54232 2011-02-10 11:50:50 -0800 [Qt] Remove the use of deprecated qFindChildren() 2011-02-10 14:15:32 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ademar ademar commit-queue kling laszlo.gombos oldest_to_newest 349243 0 ademar 2011-02-10 11:50:50 -0800 QtWebKit uses deprecated qFindChildren(), when the proper method would be ::findChildren() This change was applied to all Qt sources (including qt/src/3rdparty/webkit there), so we should probably do the same on QtWebKit. Patch is on the way. 349274 1 82025 ademar 2011-02-10 12:32:53 -0800 Created attachment 82025 patch 349373 2 82025 commit-queue 2011-02-10 14:15:27 -0800 Comment on attachment 82025 patch Clearing flags on attachment: 82025 Committed r78268: <http://trac.webkit.org/changeset/78268> 349374 3 commit-queue 2011-02-10 14:15:32 -0800 All reviewed patches have been landed. Closing bug. 82025 2011-02-10 12:32:53 -0800 2011-02-10 14:15:27 -0800 patch 0001-Remove-the-use-of-deprecated-qFindChildren.patch text/plain 3916 ademar RnJvbSA3YTVmMmRkNGE2ODdiNzlkYThmMzBkMDZjZmVhYzNiM2Y2MzAwYWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAxMCBGZWIgMjAxMSAxNjo0NTo1NSAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIFJlbW92ZSB0aGUgdXNlIG9mIGRlcHJlY2F0ZWQgcUZpbmRDaGlsZHJlbigp CgpUaGlzIHdhcyBhcHBsaWVkIG9uIHRoZSBRdCByZXBvc2l0b3J5IGFuZCBhZmZlY3RzIFF0V2Vi S2l0IHRoZXJlLgooMTM4MzNiZWI2NDEyODljNDVmYWVkMzM3ODQ4ZDM3MjgwMTk1YWFkYykKClRo ZSBzaWRlIGVmZmVjdCBvZiB0aGlzIGNoYW5nZSBpcyB0aGF0IHdlIHdvbid0IGJlIGFibGUgdG8g YnVpbGQKUXRXZWJLaXQgd2l0aCBNU1ZDIDYsIGFzIGl0IGRvZXNuJ3Qgc3VwcG9ydCBtZW1iZXIg dGVtcGxhdGUgZnVuY3Rpb25zCihub3Qgc3VyZSBpZiB0aGF0J3MgcG9zc2libGUgdG9kYXkgYW55 d2F5KS4KCk9yaWdpbmFsIHBhdGNoIGZyb20gT2xpdmllciBHb2ZmYXJ0IDxvbGl2aWVyLmdvZmZh cnRAbm9raWEuY29tPiwgd2l0aApyZXZpZXcgcmVwb3J0ZWQgYXMgYmVpbmcgZnJvbSB0aGUgbWFp bGluZyBsaXN0LgoKVGhlIGNoYW5nZXMgYXJlIHJlc3VsdCBvZiB0aGUgZm9sbG93aW5nIGNvbW1h bmRzOgoKICAgIGdpdCBncmVwIC1PInNlZCAtaSAncy9xRlwoaW5kQ2hpbGRyKmUqbio8W14+XSo+ XCkodGhpcywqICovZlxcMSgvJyIgcUZpbmRDaGlsZAogICAgZ2l0IGdyZXAgLU8ic2VkIC1pICdz L3FGXChpbmRDaGlsZHIqZSpuKjxbXj5dKj5cKSgmXChbXlwoKSxdKlwpLCogKi9cXDIuZlxcMSgv JyIgcUZpbmRDaGlsZAogICAgZ2l0IGdyZXAgLU8ic2VkIC1pICdzL3FGXChpbmRDaGlsZHIqZSpu KjxbXj5dKj5cKShcKFteXCgpLF0qKClcKSwqICovXFwyLT5mXFwxKC8nIiBxRmluZENoaWxkCiAg ICBnaXQgZ3JlcCAtTyJzZWQgLWkgJ3MvcUZcKGluZENoaWxkciplKm4qPFtePl0qPlwpKFwoW15c KCksXSpcKTpcKFteXCgpLF0qXCksKiAqLyhcXDI6XFwzKS0+ZlxcMSgvJyIgcUZpbmRDaGlsZAog ICAgZ2l0IGdyZXAgLU8ic2VkIC1pICdzL3FGXChpbmRDaGlsZHIqZSpuKjxbXj5dKj5cKShcKFte XCgpLF0qXCksKiAqL1xcMi0+ZlxcMSgvJyIgcUZpbmRDaGlsZAotLS0KIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyOCArKysrKysrKysrKysr KysrKysrKwogLi4uL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5jcHAgICAg ICAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNlODdhY2EuLjc0ZDYxOWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIs NiArMiwzNCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAg ICAgIFtRdF0gUmVtb3ZlIHRoZSB1c2Ugb2YgZGVwcmVjYXRlZCBxRmluZENoaWxkcmVuKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MjMyCisKKyAg ICAgICAgVGhpcyB3YXMgYXBwbGllZCBvbiB0aGUgUXQgcmVwb3NpdG9yeSBhbmQgYWZmZWN0cyBR dFdlYktpdCB0aGVyZS4KKyAgICAgICAgKDEzODMzYmViNjQxMjg5YzQ1ZmFlZDMzNzg0OGQzNzI4 MDE5NWFhZGMpCisKKyAgICAgICAgVGhlIHNpZGUgZWZmZWN0IG9mIHRoaXMgY2hhbmdlIGlzIHRo YXQgd2Ugd29uJ3QgYmUgYWJsZSB0byBidWlsZAorICAgICAgICBRdFdlYktpdCB3aXRoIE1TVkMg NiwgYXMgaXQgZG9lc24ndCBzdXBwb3J0IG1lbWJlciB0ZW1wbGF0ZSBmdW5jdGlvbnMKKyAgICAg ICAgKG5vdCBzdXJlIGlmIHRoYXQncyBwb3NzaWJsZSB0b2RheSBhbnl3YXkpLgorCisgICAgICAg IE9yaWdpbmFsIHBhdGNoIGZyb20gT2xpdmllciBHb2ZmYXJ0IDxvbGl2aWVyLmdvZmZhcnRAbm9r aWEuY29tPiwgd2l0aAorICAgICAgICByZXZpZXcgcmVwb3J0ZWQgYXMgYmVpbmcgZnJvbSB0aGUg bWFpbGluZyBsaXN0LgorCisgICAgICAgIFRoZSBjaGFuZ2VzIGFyZSByZXN1bHQgb2YgdGhlIGZv bGxvd2luZyBjb21tYW5kczoKKworICAgICAgICAgICAgZ2l0IGdyZXAgLU8ic2VkIC1pICdzL3FG XChpbmRDaGlsZHIqZSpuKjxbXj5dKj5cKSh0aGlzLCogKi9mXFwxKC8nIiBxRmluZENoaWxkCisg ICAgICAgICAgICBnaXQgZ3JlcCAtTyJzZWQgLWkgJ3MvcUZcKGluZENoaWxkciplKm4qPFtePl0q PlwpKCZcKFteXCgpLF0qXCksKiAqL1xcMi5mXFwxKC8nIiBxRmluZENoaWxkCisgICAgICAgICAg ICBnaXQgZ3JlcCAtTyJzZWQgLWkgJ3MvcUZcKGluZENoaWxkciplKm4qPFtePl0qPlwpKFwoW15c KCksXSooKVwpLCogKi9cXDItPmZcXDEoLyciIHFGaW5kQ2hpbGQKKyAgICAgICAgICAgIGdpdCBn cmVwIC1PInNlZCAtaSAncy9xRlwoaW5kQ2hpbGRyKmUqbio8W14+XSo+XCkoXChbXlwoKSxdKlwp OlwoW15cKCksXSpcKSwqICovKFxcMjpcXDMpLT5mXFwxKC8nIiBxRmluZENoaWxkCisgICAgICAg ICAgICBnaXQgZ3JlcCAtTyJzZWQgLWkgJ3MvcUZcKGluZENoaWxkciplKm4qPFtePl0qPlwpKFwo W15cKCksXSpcKSwqICovXFwyLT5mXFwxKC8nIiBxRmluZENoaWxkCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVQaG9ub24uY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9uOjpNZWRpYVBsYXllclByaXZhdGVQaG9u b24pOgorCisyMDExLTAyLTEwICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAgPGFkZW1hci5yZWlz QG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK ICAgICAgICAgW1F0XSBSZW1vdmUgdGhlIHVzZSBvZiBkZXByZWNhdGVkIHFWYXJpYW50KgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQyMjkKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQ cml2YXRlUGhvbm9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01l ZGlhUGxheWVyUHJpdmF0ZVBob25vbi5jcHAKaW5kZXggYjg4MTAzNi4uZmFiNGRiMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2 YXRlUGhvbm9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9N ZWRpYVBsYXllclByaXZhdGVQaG9ub24uY3BwCkBAIC0xMDIsNyArMTAyLDcgQEAgTWVkaWFQbGF5 ZXJQcml2YXRlUGhvbm9uOjpNZWRpYVBsYXllclByaXZhdGVQaG9ub24oTWVkaWFQbGF5ZXIqIHBs YXllcikKIAogICAgIC8vIE1ha2Ugc3VyZSB3ZSBnZXQgdXBkYXRlcyBmb3IgZWFjaCBmcmFtZQog ICAgIG1fdmlkZW9XaWRnZXQtPmluc3RhbGxFdmVudEZpbHRlcih0aGlzKTsKLSAgICBmb3JlYWNo IChRV2lkZ2V0KiB3aWRnZXQsIHFGaW5kQ2hpbGRyZW48UVdpZGdldCo+KG1fdmlkZW9XaWRnZXQp KQorICAgIGZvcmVhY2ggKFFXaWRnZXQqIHdpZGdldCwgbV92aWRlb1dpZGdldC0+ZmluZENoaWxk cmVuPFFXaWRnZXQqPigpKQogICAgICAgICB3aWRnZXQtPmluc3RhbGxFdmVudEZpbHRlcih0aGlz KTsKIAogICAgIGNvbm5lY3QobV9tZWRpYU9iamVjdCwgU0lHTkFMKHN0YXRlQ2hhbmdlZChQaG9u b246OlN0YXRlLFBob25vbjo6U3RhdGUpKSwKLS0gCjEuNy4zLjQKCg==