54216 2011-02-10 09:15:03 -0800 [V8] Don't crash on exception getting event handler function 2011-02-10 22:57:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ager ager oldest_to_newest 349120 0 ager 2011-02-10 09:15:03 -0800 [V8] Don't crash on exception getting event handler function 349123 1 81991 ager 2011-02-10 09:19:20 -0800 Created attachment 81991 Patch 349266 2 81991 antonm 2011-02-10 12:23:32 -0800 Comment on attachment 81991 Patch LGTM, although those empty handle checks are somewhat sketchy. Still a common practice 81991 2011-02-10 09:19:20 -0800 2011-02-10 13:55:19 -0800 Patch bug-54216-20110210181918.patch text/plain 4379 ager SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MjMyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMTAgIE1hZHMgQWdl ciAgPGFnZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtWOF0gRG9uJ3QgY3Jhc2ggb24gZXhjZXB0aW9uIGdldHRpbmcgZXZl bnQgaGFuZGxlciBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTQyMTYKKworICAgICAgICBDaGVjayBmb3IgZXhjZXB0aW9ucyB3aGVuIGF0 dGVtcHRpbmcgdG8gZ2V0IHRoZSBoYW5kbGVFdmVudCBwcm9wZXJ0eQorICAgICAgICBvZiBhbiBl dmVudC1oYW5kbGVyIG9iamVjdC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9leGNlcHRpb24t Z2V0dGluZy1ldmVudC1oYW5kbGVyLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RXZl bnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOEV2ZW50TGlzdGVuZXI6OmdldExp c3RlbmVyRnVuY3Rpb24pOgorCiAyMDExLTAyLTEwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzgy MTkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEV2ZW50TGlzdGVuZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RXZlbnRMaXN0ZW5l ci5jcHAJKHJldmlzaW9uIDc4MjIxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhF dmVudExpc3RlbmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOSBAQCB2ODo6TG9j YWw8djg6OkZ1bmN0aW9uPiBWOEV2ZW50TGlzdGVuZXI6CiAKICAgICBpZiAobGlzdGVuZXItPklz T2JqZWN0KCkpIHsKICAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gcHJvcGVydHkgPSBsaXN0 ZW5lci0+R2V0KHY4OjpTdHJpbmc6Ok5ld1N5bWJvbCgiaGFuZGxlRXZlbnQiKSk7Ci0gICAgICAg IGlmIChwcm9wZXJ0eS0+SXNGdW5jdGlvbigpKQorICAgICAgICAvLyBDaGVjayB0aGF0IG5vIGV4 Y2VwdGlvbnMgd2VyZSB0aHJvd24gd2hlbiBnZXR0aW5nIHRoZQorICAgICAgICAvLyBoYW5kbGVF dmVudCBwcm9wZXJ0eSBhbmQgdGhhdCB0aGUgdmFsdWUgaXMgYSBmdW5jdGlvbi4KKyAgICAgICAg aWYgKCFwcm9wZXJ0eS5Jc0VtcHR5KCkgJiYgcHJvcGVydHktPklzRnVuY3Rpb24oKSkKICAgICAg ICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6OkZ1bmN0aW9uPjo6Q2FzdChwcm9wZXJ0eSk7CiAg ICAgfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODIzMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTAyLTEwICBNYWRzIEFnZXIg IDxhZ2VyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbVjhdIERvbid0IGNyYXNoIG9uIGV4Y2VwdGlvbiBnZXR0aW5nIGV2ZW50 IGhhbmRsZXIgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0MjE2CisKKyAgICAgICAgQWRkIGNyYXNoIHJlZ3Jlc3Npb24gdGVzdCB3aXRo IGN1c3RvbSBjaHJvbWl1bSBleHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBmYXN0L2RvbS9leGNl cHRpb24tZ2V0dGluZy1ldmVudC1oYW5kbGVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9kb20vZXhjZXB0aW9uLWdldHRpbmctZXZlbnQtaGFuZGxlci5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2RvbS9leGNlcHRpb24tZ2V0dGluZy1l dmVudC1oYW5kbGVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTEtMDItMDkgIE1hcnRpbiBS b2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1 c3Rhdm8gTm9yb25oYSBTaWx2YS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2V4Y2VwdGlv bi1nZXR0aW5nLWV2ZW50LWhhbmRsZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZG9tL2V4Y2VwdGlvbi1nZXR0aW5nLWV2ZW50LWhhbmRsZXItZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vZXhjZXB0aW9uLWdldHRp bmctZXZlbnQtaGFuZGxlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBA QAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDA6IDQyCitUaGlzIHRlc3QgY2hlY2tzIHRoYXQgYW4g ZXhjZXB0aW9uIHRocm93biB3aGVuIGdldHRpbmcgdGhlIGhhbmRsZUV2ZW50IHByb3BlcnR5IG9m IGFuIGV2ZW50IGxpc3RlbmVyIGRvZXMgbm90IGNyYXNoLgorCitQQVNTOiBZb3UgZGlkbid0IGNy YXNoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZXhjZXB0aW9uLWdldHRpbmctZXZlbnQt aGFuZGxlci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2V4Y2VwdGlv bi1nZXR0aW5nLWV2ZW50LWhhbmRsZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvZG9tL2V4Y2VwdGlvbi1nZXR0aW5nLWV2ZW50LWhhbmRsZXIuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwyMiBAQAorPGh0bWw+Cis8Ym9keSBvbmxvYWQ9ImxvYWRlZCgpIj4KKzxw PlRoaXMgdGVzdCBjaGVja3MgdGhhdCBhbiBleGNlcHRpb24gdGhyb3duIHdoZW4gZ2V0dGluZyB0 aGUKK2hhbmRsZUV2ZW50IHByb3BlcnR5IG9mIGFuIGV2ZW50IGxpc3RlbmVyIGRvZXMgbm90IGNy YXNoLjwvcD4KKzxocj4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworZnVuY3Rpb24gbG9h ZGVkKCkgeworICAgIHZhciBvID0ge307CisgICAgby5fX2RlZmluZUdldHRlcl9fKCJoYW5kbGVF dmVudCIsIGZ1bmN0aW9uKCkgeyB0aHJvdyA0MjsgfSk7CisgICAgdmFyIGRpdiA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJkaXYiKTsKKyAgICBkaXYub25rZXlkb3duID0gbzsKKyAgICB2YXIg ZXZlbnQgPSBkb2N1bWVudC5jcmVhdGVFdmVudCgiS2V5Ym9hcmRFdmVudCIpOworICAgIGV2ZW50 LmluaXRLZXlib2FyZEV2ZW50KCJrZXlkb3duIiwgdHJ1ZSwgdHJ1ZSwgbnVsbCwgIkVudGVyIiwg IiIpOworICAgIGRpdi5kaXNwYXRjaEV2ZW50KGV2ZW50KTsKK30KKzwvc2NyaXB0PgorPGRpdiBp ZD0iZGl2Ij5QQVNTOiBZb3UgZGlkbid0IGNyYXNoLjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vZXhjZXB0aW9uLWdl dHRpbmctZXZlbnQtaGFuZGxlci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vZXhjZXB0aW9uLWdldHRpbmctZXZlbnQtaGFu ZGxlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9mYXN0L2RvbS9leGNlcHRpb24tZ2V0dGluZy1ldmVudC1oYW5kbGVyLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUg MTI6IFVuY2F1Z2h0IDQyCitUaGlzIHRlc3QgY2hlY2tzIHRoYXQgYW4gZXhjZXB0aW9uIHRocm93 biB3aGVuIGdldHRpbmcgdGhlIGhhbmRsZUV2ZW50IHByb3BlcnR5IG9mIGFuIGV2ZW50IGxpc3Rl bmVyIGRvZXMgbm90IGNyYXNoLgorCitQQVNTOiBZb3UgZGlkbid0IGNyYXNoLgo=