54208 2011-02-10 07:31:41 -0800 Double-clicking locations of assertions/logs in Visual Studio's Output Window does nothing 2011-02-10 11:27:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aroben aroben ap darin oldest_to_newest 349053 0 aroben 2011-02-10 07:31:41 -0800 Double-clicking locations of assertions/logs in Visual Studio's Output Window does nothing 349055 1 81979 aroben 2011-02-10 07:32:57 -0800 Created attachment 81979 Patch 349116 2 81979 ap 2011-02-10 09:12:39 -0800 Comment on attachment 81979 Patch What is the reason for having two printf_stderr_common formats? Could you change the existing one and keep it at two code paths instead of three? If three are needed, a comment is probably in order. 349132 3 aroben 2011-02-10 09:38:32 -0800 (In reply to comment #2) > (From update of attachment 81979 [details]) > What is the reason for having two printf_stderr_common formats? Could you change the existing one and keep it at two code paths instead of three? > > If three are needed, a comment is probably in order. I was just trying to be conservative and not change the format for non-Windows platforms. But I can easily change it for all platforms if you thinks that's better. 349153 4 ap 2011-02-10 10:05:56 -0800 I don't know. Maybe change it, and thus make whoever cares about the old format complain and actually add a comment explaining why this format was chosen? You could also check svn history and talk to the author. 349165 5 aroben 2011-02-10 10:25:17 -0800 (In reply to comment #4) > I don't know. Maybe change it, and thus make whoever cares about the old format complain and actually add a comment explaining why this format was chosen? You could also check svn history and talk to the author. Here are the changes to the format I can find: <http://trac.webkit.org/changeset/1271#file3> Ken Kocienda added stderr output on assertions with the "file:line function" format. <http://trac.webkit.org/changeset/1339#file3> Ken Kocienda added the "=======" lines and uppercased "assertion failure" <http://trac.webkit.org/changeset/1403#file12> Darin Adler added the parentheses around the location. <http://trac.webkit.org/changeset/16782#file1> Darin Adler removed the "=======" lines and added the call to _CrtDbgReport, which uses its own format. Seems likely we can just change it and see who (if anyone) complains. 349217 6 aroben 2011-02-10 11:27:39 -0800 Committed r78250: <http://trac.webkit.org/changeset/78250> 81979 2011-02-10 07:32:57 -0800 2011-02-10 09:12:39 -0800 Patch bug-54208-20110210103256.patch text/plain 1938 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogNzgyMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDli N2U2OGQyYmIwMzQ5ZDI1Y2U4ZDhkY2E4NDAwN2Q0Njg0N2FiNzguLjcwMjc3YTg5OWQyNzhmZjk5 NDM4MzEzYzU1ZmI2NzkzOGNjZmNjNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDExLTAyLTEwICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwor ICAgICAgICBQcmludCBsb2NhdGlvbnMgb2YgYXNzZXJ0aW9ucyBhbmQgbG9ncyB0aGUgc2FtZSB3 YXkgY2wuZXhlIHByaW50cyBsb2NhdGlvbnMgb2YgZXJyb3JzCisKKyAgICAgICAgV2l0aCB0aGlz IGNoYW5nZSwgZG91YmxlLWNsaWNraW5nIG9uZSBvZiB0aGVzZSBsb2NhdGlvbnMgaW4gVmlzdWFs IFN0dWRpbydzIE91dHB1dCBXaW5kb3cKKyAgICAgICAgd2lsbCBmb2N1cyB0aGF0IGxpbmUgb2Yg Y29kZSBpbiB0aGUgZWRpdG9yLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9i LzU0MjA4PiBEb3VibGUtY2xpY2tpbmcgbG9jYXRpb25zIG9mIGFzc2VydGlvbnMvbG9ncyBpbiBW aXN1YWwKKyAgICAgICAgU3R1ZGlvJ3MgT3V0cHV0IFdpbmRvdyBkb2VzIG5vdGhpbmcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRp b25zLmNwcDoKKyAgICAgICAgKHByaW50Q2FsbFNpdGUpOiBVc2UgT1MoV0lORE9XUykgaW5zdGVh ZCBvZiB0aGUgbWVhbmluZ2xlc3MgT1MoV0lOKS4gV2hlbiB3ZSBhcmVuJ3QgdXNpbmcKKyAgICAg ICAgdGhlIGRlYnVnIENSVCAoYW5kIHRodXMgY2FuJ3QgY2FsbCBfQ3J0RGJnUmVwb3J0KSwgcHJp bnQgdGhlIGZpbGUgYW5kIGxpbmUgbnVtYmVyIHVzaW5nIHRoZQorICAgICAgICBzYW1lIGZvcm1h dCB0aGF0IGNsLmV4ZSB1c2VzIHdoZW4gaXQgcHJpbnRzIGNvbXBpbGVyIGVycm9ycy4KKwogMjAx MS0wMi0xMCAgUGV0ZXIgVmFyZ2EgIDxwdmFyZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3Nl cnRpb25zLmNwcAppbmRleCA5OWM3NGI1NjgyZjdmZDIzYTY0MzFkYWJkOTZhNDQ5MWRiODcxNDE2 Li5jOWM0ZTg1Y2FhNmVjYzE4MGI0NzdmOTg3MTJkYzU5ZjdmODA2MzBiIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTE3MSw5ICsxNzEsMTMgQEAgc3RhdGlj IHZvaWQgcHJpbnRmX3N0ZGVycl9jb21tb24oY29uc3QgY2hhciogZm9ybWF0LCAuLi4pCiAKIHN0 YXRpYyB2b2lkIHByaW50Q2FsbFNpdGUoY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0 IGNoYXIqIGZ1bmN0aW9uKQogewotI2lmIE9TKFdJTikgJiYgIU9TKFdJTkNFKSAmJiBkZWZpbmVk IF9ERUJVRworI2lmIE9TKFdJTkRPV1MpICYmICFPUyhXSU5DRSkKKyNpZmRlZiBfREVCVUcKICAg ICBfQ3J0RGJnUmVwb3J0KF9DUlRfV0FSTiwgZmlsZSwgbGluZSwgTlVMTCwgIiVzXG4iLCBmdW5j dGlvbik7CiAjZWxzZQorICAgIHByaW50Zl9zdGRlcnJfY29tbW9uKCIlcyglZCkgOiAlc1xuIiwg ZmlsZSwgbGluZSwgZnVuY3Rpb24pOworI2VuZGlmCisjZWxzZQogICAgIHByaW50Zl9zdGRlcnJf Y29tbW9uKCIoJXM6JWQgJXMpXG4iLCBmaWxlLCBsaW5lLCBmdW5jdGlvbik7CiAjZW5kaWYKIH0K