54200 2011-02-10 05:57:30 -0800 check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt 2011-02-10 06:15:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan zoltan oldest_to_newest 348998 0 zoltan 2011-02-10 05:57:30 -0800 check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt 349000 1 81964 zoltan 2011-02-10 05:58:50 -0800 Created attachment 81964 proposed patch 349005 2 81964 kling 2011-02-10 06:01:11 -0800 Comment on attachment 81964 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81964&action=review > Tools/Scripts/webkitpy/style/checker_unittest.py:256 > + assertCheck("Tools/MiniBrowser/qt/UrlLoader.cpp", > + "build/include") > + assertNoCheck("Tools/MiniBrowser/qt/UrlLoader.cpp", > + "build/include") Ahrrm... 349007 3 81965 zoltan 2011-02-10 06:04:54 -0800 Created attachment 81965 proposed patch 349009 4 81965 kling 2011-02-10 06:08:02 -0800 Comment on attachment 81965 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81965&action=review r=me > Tools/Scripts/webkitpy/style/checker_unittest.py:254 > + assertCheck("random_path.cpp", > + "build/include") We're already testing this on line 213. You can leave it out. 349017 5 zoltan 2011-02-10 06:15:52 -0800 Thnx, done! Committed r78215. http://trac.webkit.org/changeset/78215 81964 2011-02-10 05:58:50 -0800 2011-02-10 06:04:54 -0800 proposed patch checker.patch text/plain 1964 zoltan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZGFh YTY3Li4yYTE3ZjRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTAgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IEFkZCAtYnVpbGQvaW5jbHVkZSBleGVtcHRpb24g Zm9yIFRvb2xzL01pbmlCcm93c2VyL3F0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NDIwMAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91 bml0dGVzdC5weToKKwogMjAxMS0wMi0xMCAgUGV0ZXIgVmFyZ2EgIDxwdmFyZ2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggMWQwZjRlMS4uMjNiOWFiMyAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTQwLDYgKzE0MCw5IEBAIF9Q QVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKICAgICAgICJTb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0 aXZlLyIsCiAgICAgICAiU291cmNlL1dlYktpdC9xdC9leGFtcGxlcy8iXSwKICAgICAgWyItcmVh ZGFiaWxpdHkvbmFtaW5nIl0pLAorICAgICAoWyMgUXQncyBNaW5pQnJvd3NlciBoYXMgbm8gY29u ZmlnLmgKKyAgICAgICAiVG9vbHMvTWluaUJyb3dzZXIvcXQiXSwKKyAgICAgIFsiLWJ1aWxkL2lu Y2x1ZGUiXSksCiAgICAgKFsjIFRoZSBHVEsrIEFQSXMgdXNlIEdUSysgbmFtaW5nIHN0eWxlLCB3 aGljaCBpbmNsdWRlcwogICAgICAgIyBsb3dlci1jYXNlZCwgdW5kZXJzY29yZS1zZXBhcmF0ZWQg dmFsdWVzLgogICAgICAgIyBBbHNvLCBHVEsrIGFsbG93cyB0aGUgdXNlIG9mIE5VTEwuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkKaW5kZXgg MzFkNTlhZi4uMDZkYTQzZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcl91bml0dGVzdC5weQpAQCAtMjUwLDYgKzI1MCwxMSBAQCBjbGFzcyBHbG9iYWxWYXJp YWJsZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygiU291 cmNlL1dlYktpdC9xdC9leGFtcGxlcy9wbGF0Zm9ybXBsdWdpbi9XZWJQbHVnaW4uY3BwIiwKICAg ICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikKIAorICAgICAgICBhc3Nl cnRDaGVjaygiVG9vbHMvTWluaUJyb3dzZXIvcXQvVXJsTG9hZGVyLmNwcCIsCisgICAgICAgICAg ICAgICAgICAgICJidWlsZC9pbmNsdWRlIikKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygiVG9vbHMv TWluaUJyb3dzZXIvcXQvVXJsTG9hZGVyLmNwcCIsCisgICAgICAgICAgICAgICAgICAgICJidWls ZC9pbmNsdWRlIikKKwogICAgICAgICBhc3NlcnROb0NoZWNrKCJTb3VyY2UvV2ViQ29yZS9Gb3J3 YXJkaW5nSGVhZGVycy9kZWJ1Z2dlci9EZWJ1Z2dlci5oIiwKICAgICAgICAgICAgICAgICAgICAg ICAiYnVpbGQvaGVhZGVyX2d1YXJkIikKIAo= 81965 2011-02-10 06:04:54 -0800 2011-02-10 06:08:02 -0800 proposed patch checker.patch text/plain 1945 zoltan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZGFh YTY3Li4yYTE3ZjRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTAgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IEFkZCAtYnVpbGQvaW5jbHVkZSBleGVtcHRpb24g Zm9yIFRvb2xzL01pbmlCcm93c2VyL3F0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NDIwMAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91 bml0dGVzdC5weToKKwogMjAxMS0wMi0xMCAgUGV0ZXIgVmFyZ2EgIDxwdmFyZ2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggMWQwZjRlMS4uMjNiOWFiMyAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTQwLDYgKzE0MCw5IEBAIF9Q QVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKICAgICAgICJTb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0 aXZlLyIsCiAgICAgICAiU291cmNlL1dlYktpdC9xdC9leGFtcGxlcy8iXSwKICAgICAgWyItcmVh ZGFiaWxpdHkvbmFtaW5nIl0pLAorICAgICAoWyMgUXQncyBNaW5pQnJvd3NlciBoYXMgbm8gY29u ZmlnLmgKKyAgICAgICAiVG9vbHMvTWluaUJyb3dzZXIvcXQiXSwKKyAgICAgIFsiLWJ1aWxkL2lu Y2x1ZGUiXSksCiAgICAgKFsjIFRoZSBHVEsrIEFQSXMgdXNlIEdUSysgbmFtaW5nIHN0eWxlLCB3 aGljaCBpbmNsdWRlcwogICAgICAgIyBsb3dlci1jYXNlZCwgdW5kZXJzY29yZS1zZXBhcmF0ZWQg dmFsdWVzLgogICAgICAgIyBBbHNvLCBHVEsrIGFsbG93cyB0aGUgdXNlIG9mIE5VTEwuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkKaW5kZXgg MzFkNTlhZi4uOWE4YjE2MSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcl91bml0dGVzdC5weQpAQCAtMjUwLDYgKzI1MCwxMSBAQCBjbGFzcyBHbG9iYWxWYXJp YWJsZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygiU291 cmNlL1dlYktpdC9xdC9leGFtcGxlcy9wbGF0Zm9ybXBsdWdpbi9XZWJQbHVnaW4uY3BwIiwKICAg ICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikKIAorICAgICAgICBhc3Nl cnRDaGVjaygicmFuZG9tX3BhdGguY3BwIiwKKyAgICAgICAgICAgICAgICAgICAgImJ1aWxkL2lu Y2x1ZGUiKQorICAgICAgICBhc3NlcnROb0NoZWNrKCJUb29scy9NaW5pQnJvd3Nlci9xdC9VcmxM b2FkZXIuY3BwIiwKKyAgICAgICAgICAgICAgICAgICAgImJ1aWxkL2luY2x1ZGUiKQorCiAgICAg ICAgIGFzc2VydE5vQ2hlY2soIlNvdXJjZS9XZWJDb3JlL0ZvcndhcmRpbmdIZWFkZXJzL2RlYnVn Z2VyL0RlYnVnZ2VyLmgiLAogICAgICAgICAgICAgICAgICAgICAgICJidWlsZC9oZWFkZXJfZ3Vh cmQiKQogCg==