54190 2011-02-10 03:56:23 -0800 Fix ignore return warning in OSRandomSource.cpp 2011-02-10 05:05:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 54167 P2 Normal --- 1 pvarga webkit-unassigned abecsi commit-queue ossy oldest_to_newest 348924 0 pvarga 2011-02-10 03:56:23 -0800 I got this warning with gcc-4.4.5: cc1plus: warnings being treated as errors ../../../Source/JavaScriptCore/wtf/OSRandomSource.cpp: In function 'void WTF::randomValuesFromOS(unsigned char*, size_t)': ../../../Source/JavaScriptCore/wtf/OSRandomSource.cpp:53: error: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result 348931 1 81948 pvarga 2011-02-10 04:10:06 -0800 Created attachment 81948 proposed patch 348934 2 81948 ossy 2011-02-10 04:21:59 -0800 Comment on attachment 81948 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81948&action=review > Source/JavaScriptCore/wtf/OSRandomSource.cpp:54 > if (fd < 0) > CRASH(); // We need /dev/urandom for this API to work... > > - read(fd, buffer, length); > - close(fd); > + if (read(fd, buffer, length)) > + close(fd); read returns 0 at the end of file and -1 on errors. The return value should be length. If an error occures, we should crash instead of using uninitialized buffer. if (read(fd, buffer, length) == length) close(fd); else CRASH(); 348941 3 81950 pvarga 2011-02-10 04:28:50 -0800 Created attachment 81950 proposed patch v2 348961 4 81950 commit-queue 2011-02-10 04:53:55 -0800 Comment on attachment 81950 proposed patch v2 Rejecting attachment 81950 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: ts/svn-apply', u'--reviewer', u'Csaba Osztrogon\xe1c',..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/wtf/OSRandomSource.cpp Hunk #1 FAILED at 50. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/OSRandomSource.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Csaba Osztrogon\xe1c',..." exit_code: 1 Full output: http://queues.webkit.org/results/7886288 348962 5 ossy 2011-02-10 04:56:57 -0800 CQ can't apply your patch because of http://trac.webkit.org/changeset/78195 Could you land it manually? 348965 6 ossy 2011-02-10 05:05:42 -0800 *** This bug has been marked as a duplicate of bug 54167 *** 81948 2011-02-10 04:10:06 -0800 2011-02-10 04:28:50 -0800 proposed patch 0001-fix-warning-OSRandomSource.patch text/plain 1527 pvarga RnJvbSAyOWQyMTYyZWFmMmUyMDZkNzc0MDM5OTc4YjhlNWY5YTA1NDZjNDQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQHdlYmtpdC5vcmc+CkRhdGU6 IFRodSwgMTAgRmViIDIwMTEgMDQ6MDM6NTQgLTA4MDAKU3ViamVjdDogW1BBVENIXSBmaXggd2Fy bmluZyBPU1JhbmRvbVNvdXJjZQoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9PU1JhbmRvbVNvdXJjZS5jcHAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZjY3Yzg3Li4xMzU2NWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBA QAorMjAxMS0wMi0xMCAgUGV0ZXIgVmFyZ2EgIDxwdmFyZ2FAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaWdub3JlIHJldHVy biB3YXJuaW5nIGluIE9TUmFuZG9tU291cmNlLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxOTAKKworICAgICAgICAqIHd0Zi9PU1JhbmRvbVNv dXJjZS5jcHA6CisgICAgICAgIChXVEY6OnJhbmRvbVZhbHVlc0Zyb21PUyk6CisKIDIwMTEtMDIt MDkgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9PU1JhbmRv bVNvdXJjZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNw cAppbmRleCA0M2FkYTQ2Li4yY2I5OTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL09TUmFuZG9tU291cmNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L09TUmFuZG9tU291cmNlLmNwcApAQCAtNTAsOCArNTAsOCBAQCB2b2lkIHJhbmRvbVZhbHVlc0Zy b21PUyh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCiAgICAgaWYgKGZkIDwg MCkKICAgICAgICAgQ1JBU0goKTsgLy8gV2UgbmVlZCAvZGV2L3VyYW5kb20gZm9yIHRoaXMgQVBJ IHRvIHdvcmsuLi4KIAotICAgIHJlYWQoZmQsIGJ1ZmZlciwgbGVuZ3RoKTsKLSAgICBjbG9zZShm ZCk7CisgICAgaWYgKHJlYWQoZmQsIGJ1ZmZlciwgbGVuZ3RoKSkKKyAgICAgICAgY2xvc2UoZmQp OwogI2VsaWYgQ09NUElMRVIoTVNWQykKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxlbmd0 aDsgaSsrKSB7CiAgICAgICAgIHVpbnQzMl90IGJpdHM7Ci0tIAoxLjcuNAoK 81950 2011-02-10 04:28:50 -0800 2011-02-10 05:05:57 -0800 proposed patch v2 0001-fix-warning-OSRandomSource-v2.patch text/plain 1571 pvarga RnJvbSAxYzVkZDZlYjE4NmUzOTA4Y2QwOTg4NjAxMDM5MDExZDRjMzllZmI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQHdlYmtpdC5vcmc+CkRhdGU6 IFRodSwgMTAgRmViIDIwMTEgMDQ6Mjc6MjcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBmaXggd2Fy bmluZyBPU1JhbmRvbVNvdXJjZSB2MgoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9PU1JhbmRvbVNvdXJjZS5jcHAgfCAgICA2ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmlu ZGV4IDJmNjdjODcuLjEzNTY1YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDExLTAyLTEwICBQZXRlciBWYXJnYSAgPHB2YXJnYUB3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBpZ25vcmUg cmV0dXJuIHdhcm5pbmcgaW4gT1NSYW5kb21Tb3VyY2UuY3BwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDE5MAorCisgICAgICAgICogd3RmL09TUmFu ZG9tU291cmNlLmNwcDoKKyAgICAgICAgKFdURjo6cmFuZG9tVmFsdWVzRnJvbU9TKToKKwogMjAx MS0wMi0wOSAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09T UmFuZG9tU291cmNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT1NSYW5kb21Tb3Vy Y2UuY3BwCmluZGV4IDQzYWRhNDYuLjRjOWE2OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvT1NSYW5kb21Tb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvT1NSYW5kb21Tb3VyY2UuY3BwCkBAIC01MCw4ICs1MCwxMCBAQCB2b2lkIHJhbmRvbVZh bHVlc0Zyb21PUyh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCiAgICAgaWYg KGZkIDwgMCkKICAgICAgICAgQ1JBU0goKTsgLy8gV2UgbmVlZCAvZGV2L3VyYW5kb20gZm9yIHRo aXMgQVBJIHRvIHdvcmsuLi4KIAotICAgIHJlYWQoZmQsIGJ1ZmZlciwgbGVuZ3RoKTsKLSAgICBj bG9zZShmZCk7CisgICAgaWYgKHJlYWQoZmQsIGJ1ZmZlciwgbGVuZ3RoKSA9PSBsZW5ndGgpCisg ICAgICAgIGNsb3NlKGZkKTsKKyAgICBlbHNlCisgICAgICAgIENSQVNIKCk7CiAjZWxpZiBDT01Q SUxFUihNU1ZDKQogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspIHsKICAg ICAgICAgdWludDMyX3QgYml0czsKLS0gCjEuNy40Cgo=