54185 2011-02-10 02:15:58 -0800 [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test 2011-02-10 02:45:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 53146 1 mario webkit-unassigned mrobinson xan.lopez oldest_to_newest 348887 0 mario 2011-02-10 02:15:58 -0800 The (to be) attached patch is needed to ensure the accessibility controller gets reset to a consistent value before running every test. This is now required after having fixed bug 54116. 348889 1 81939 mario 2011-02-10 02:19:09 -0800 Created attachment 81939 Patch proposal Simple patch to fix this 348893 2 81939 xan.lopez 2011-02-10 02:28:29 -0800 Comment on attachment 81939 Patch proposal This makes sense to me (EWS seems unhappy about the patch though). 348895 3 mario 2011-02-10 02:30:53 -0800 (In reply to comment #2) > (From update of attachment 81939 [details]) > This makes sense to me (EWS seems unhappy about the patch though). Oops, that's probably because I wrote that patch on my local branch instead of doing it on top of HEAD. Will fix that when committing. Thanks for the review 348904 4 mario 2011-02-10 02:45:17 -0800 Committed r78184: <http://trac.webkit.org/changeset/78184> 81939 2011-02-10 02:19:09 -0800 2011-02-10 02:28:29 -0800 Patch proposal 0001-2011-02-10-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2063 mario RnJvbSA4OTlhNWM0NjRkMTMwMWM1YWJkNDc3MzI3ZDY4ZTg5NTQxMjFlOTg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDEwIEZlYiAyMDExIDExOjE4OjExICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0wMi0xMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBSZXNl dCBHVEsnIERSVCdzIEFjY2Vzc2liaWxpdHlDb250cm9sbGVyIHRvIGNvbnNpc3RlbnQgdmFsdWUg YmVmb3JlIGV2ZXJ5IHRlc3QKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTQxODUKCiAgICAgICAgRW5zdXJlIEFjY2Vzc2liaWxpdHlDb250cm9sbGVyOjpy ZXNldFRvQ29uc2lzdGVudFN0YXRlKCkgaXMgYWx3YXlzCiAgICAgICAgY2FsbGVkIGJlZm9yZSBy dW5uaW5nIGV2ZXJ5IGxheW91dCB0ZXN0LgoKICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHA6CiAgICAgICAgKHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1 ZXMpOiBDYWxsCiAgICAgICAgQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXI6OnJlc2V0VG9Db25zaXN0 ZW50U3RhdGUoKQotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEwICsrKysrKysrKysKIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVy VHJlZS5jcHAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAw IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA2YzJjNWRmLi5iNmJmZmUwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMDItMTAgIE1hcmlv IFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFJlc2V0IEdUSycgRFJUJ3MgQWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIgdG8gY29uc2lzdGVudCB2YWx1ZSBiZWZvcmUgZXZlcnkgdGVz dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxODUK KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAg ICAgIChyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKToKKworMjAxMS0wMi0xMCAgTWFy aW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKICAgICAgICAgUmV2aWV3 ZWQgYnkgQ2hyaXMgRmxlaXphY2guCiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgaW4gRFJU IHRvIGxvZyAiYWNjZXNzaWJpbGl0eSBldmVudHMiCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCAwNDQyMDQ0Li4xNzk2MWRiIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTQ0NSw2ICs0NDUsOSBAQCBz dGF0aWMgdm9pZCByZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICBzZXRsb2Nh bGUoTENfQUxMLCAiIik7CiAKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldExpbmtz SW5jbHVkZWRJbkZvY3VzQ2hhaW4odHJ1ZSk7CisKKyAgICBpZiAoYXhDb250cm9sbGVyKQorICAg ICAgICBheENvbnRyb2xsZXItPnJlc2V0VG9Db25zaXN0ZW50U3RhdGUoKTsKIH0KIAogc3RhdGlj IGJvb2wgdXNlTG9uZ1J1bm5pbmdTZXJ2ZXJNb2RlKGludCBhcmdjLCBjaGFyICphcmd2W10pCi0t IAoxLjcuMy41Cgo=