54168 2011-02-09 22:29:05 -0800 Move WTF_USE_CFNETWORK to Platform.h 2011-02-15 15:02:25 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 51836 1 psolanki psolanki ddkilzer psolanki oldest_to_newest 348815 0 psolanki 2011-02-09 22:29:05 -0800 WTF_USE_CFNETWORK is defined in WebCore/config.h. It should be defined in Platform.h which will make it easier to have #if USE(CFNETWORK) blocks in WebKit. 348819 1 81925 psolanki 2011-02-09 22:38:08 -0800 Created attachment 81925 Patch Patch attached. Though I will wait for the Windows EWS to build it before checking it in. 351565 2 81925 ddkilzer 2011-02-15 14:13:58 -0800 Comment on attachment 81925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81925&action=review r=me with the fix to provide a default for WTF_USE_CFNETWORK. > Source/JavaScriptCore/wtf/Platform.h:684 > +#define WTF_USE_CFNETWORK 1 You need to add a section closer to the end of Platform.h that provides a default: #if !defined(WTF_USE_CFNETWORK) #define WTF_USE_CFNETWORK 0 #endif You might want to move it close to this line just for proximity's sake: /* Set up a define for a common error that is intended to cause a build error -- thus the space after Error. */ #define WTF_PLATFORM_CFNETWORK Error USE_macro_should_be_used_with_CFNETWORK 351579 3 82520 psolanki 2011-02-15 14:35:04 -0800 Created attachment 82520 Patch 351581 4 81925 darin 2011-02-15 14:35:42 -0800 Comment on attachment 81925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81925&action=review >> Source/JavaScriptCore/wtf/Platform.h:684 >> +#define WTF_USE_CFNETWORK 1 > > You need to add a section closer to the end of Platform.h that provides a default: > > #if !defined(WTF_USE_CFNETWORK) > #define WTF_USE_CFNETWORK 0 > #endif > > You might want to move it close to this line just for proximity's sake: > > /* Set up a define for a common error that is intended to cause a build error -- thus the space after Error. */ > #define WTF_PLATFORM_CFNETWORK Error USE_macro_should_be_used_with_CFNETWORK I don’t think that’s right about needing a default. The USE macro checks for a symbol that’s not defined, so why would we need to define it as 0? 351582 5 82520 darin 2011-02-15 14:36:09 -0800 Comment on attachment 82520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82520&action=review > Source/JavaScriptCore/wtf/Platform.h:1136 > +#if !defined(WTF_USE_CFNETWORK) > +#define WTF_USE_CFNETWORK 0 > +#endif I know Dave Kilzer told you this is needed, but I don’t think it is. 351587 6 ddkilzer 2011-02-15 14:38:41 -0800 (In reply to comment #5) > (From update of attachment 82520 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82520&action=review > > > Source/JavaScriptCore/wtf/Platform.h:1136 > > +#if !defined(WTF_USE_CFNETWORK) > > +#define WTF_USE_CFNETWORK 0 > > +#endif > > I know Dave Kilzer told you this is needed, but I don’t think it is. I see, we only need this when the default is to enable. Okay. 351626 7 psolanki 2011-02-15 15:02:25 -0800 Committed r78622: <http://trac.webkit.org/changeset/78622> 81925 2011-02-09 22:38:08 -0800 2011-02-15 14:35:42 -0800 Patch 54168.patch text/plain 2123 psolanki ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRhMDE5NTUuLjhiMWE1NTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTAyLTA5ICBQcmF0aWsgU29sYW5r aSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNb3ZlIFdURl9VU0VfQ0ZORVRXT1JLIHRvIFBsYXRmb3JtLmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MTY4CisKKyAg ICAgICAgRGVmaW5lIFdURl9VU0VfQ0ZORVRXT1JLIGZvciBXaW5kb3dzIGJ1aWxkcy4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDExLTAyLTA5ICBHYXZpbiBCYXJyYWNsb3VnaCAg PGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vpbmln LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDY0NDRkZmIuLmU0NjVhZGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTY4MSw2ICs2ODEsNyBAQAog CiAjaWYgUExBVEZPUk0oV0lOKSAmJiAhT1MoV0lOQ0UpCiAjZGVmaW5lIFdURl9QTEFURk9STV9D RiAxCisjZGVmaW5lIFdURl9VU0VfQ0ZORVRXT1JLIDEKICNkZWZpbmUgV1RGX1VTRV9QVEhSRUFE UyAwCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU0ZDIyNjIuLmFhNjdiMTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAxMS0wMi0wOSAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTW92ZSBXVEZfVVNFX0NGTkVUV09SSyB0byBQbGF0Zm9ybS5oCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDE2OAorCisgICAgICAgICogY29uZmln Lmg6IFJlbW92ZSBXVEZfVVNFX0NGTkVUV09SSworCiAyMDExLTAyLTA5ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJu c3RlaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jb25maWcuaCBiL1NvdXJjZS9XZWJD b3JlL2NvbmZpZy5oCmluZGV4IDRkNWM4ZmEuLjRiZGNlMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2NvbmZpZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2NvbmZpZy5oCkBAIC0xNDksNyAr MTQ5LDYgQEAKICNpZiBkZWZpbmVkKFdJTl9DQUlSTykKICN1bmRlZiBXVEZfUExBVEZPUk1fQ0cK ICNkZWZpbmUgV1RGX1BMQVRGT1JNX0NBSVJPIDEKLSN1bmRlZiBXVEZfVVNFX0NGTkVUV09SSwog I2RlZmluZSBXVEZfVVNFX0NVUkwgMQogI2lmbmRlZiBfV0lOU09DS0FQSV8KICNkZWZpbmUgX1dJ TlNPQ0tBUElfIC8vIFByZXZlbnQgaW5jbHVzaW9uIG9mIHdpbnNvY2suaCBpbiB3aW5kb3dzLmgK QEAgLTE1Nyw3ICsxNTYsNiBAQAogI2VsaWYgIU9TKFdJTkNFKQogI2RlZmluZSBXVEZfUExBVEZP Uk1fQ0cgMQogI3VuZGVmIFdURl9QTEFURk9STV9DQUlSTwotI2RlZmluZSBXVEZfVVNFX0NGTkVU V09SSyAxCiAjdW5kZWYgV1RGX1VTRV9DVVJMCiAjZW5kaWYKICNlbmRpZgpAQCAtMTg5LDggKzE4 Nyw2IEBACiAjZGVmaW5lIFdURl9VU0VfVjggMQogI2VuZGlmCiAKLSN1bmRlZiBXVEZfVVNFX0NG TkVUV09SSwotCiAjZW5kaWYgLyogUExBVEZPUk0oQ0hST01JVU0pICovCiAKICNpZiAhZGVmaW5l ZChXVEZfVVNFX1Y4KQo= 82520 2011-02-15 14:35:04 -0800 2011-02-15 14:36:09 -0800 Patch bug-54168-20110215143503.patch text/plain 2944 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogNzg2MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBi MzYwNzBkYmIyNjQ4MWRkMzU4M2NmYjU5YmZhZGFlMTRkNzNmNWMuLmU5YTQ2OTQ2M2JhNDNlMzU2 ZmI4MjYwMmVhMDAwZDFmMTc2YTVkNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTAyLTE1ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNv bT4KKworICAgICAgICBNb3ZlIFdURl9VU0VfQ0ZORVRXT1JLIHRvIFBsYXRmb3JtLmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MTY4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0u aDogRGVmaW5lIFdURl9VU0VfQ0ZORVRXT1JLIGZvciBXaW5kb3dzIGJ1aWxkcy4KKwogMjAxMS0w Mi0xNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9QbGF0Zm9ybS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4 IDE5M2I3NmRkODBiOTJjY2JlOGM4ZmRiNWY2ZWNjZmM1MDlmMzlmNjUuLjg0ZTVjMGJhZjI0OWNk NDcxOTI4MjJjZTY5NGNiZjRmYTY1ODhjY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm b3JtLmgKQEAgLTY4Niw2ICs2ODYsMTAgQEAKICNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAwCiAj ZW5kaWYKIAorI2lmIFBMQVRGT1JNKFdJTikgJiYgIU9TKFdJTkNFKSAmJiAhUExBVEZPUk0oQ0hS T01JVU0pICYmICFkZWZpbmVkKFdJTl9DQUlSTykKKyNkZWZpbmUgV1RGX1VTRV9DRk5FVFdPUksg MQorI2VuZGlmCisKICNpZiBQTEFURk9STShXSU4pICYmICFPUyhXSU5DRSkgJiYgIVBMQVRGT1JN KENIUk9NSVVNKSAmJiAhUExBVEZPUk0oUVQpCiAjZGVmaW5lIEVOQUJMRV9XRUJfQVJDSElWRSAx CiAjZW5kaWYKQEAgLTExMjcsNiArMTEzMSwxMCBAQAogLyogU2V0IHVwIGEgZGVmaW5lIGZvciBh IGNvbW1vbiBlcnJvciB0aGF0IGlzIGludGVuZGVkIHRvIGNhdXNlIGEgYnVpbGQgZXJyb3IgLS0g dGh1cyB0aGUgc3BhY2UgYWZ0ZXIgRXJyb3IuICovCiAjZGVmaW5lIFdURl9QTEFURk9STV9DRk5F VFdPUksgRXJyb3IgVVNFX21hY3JvX3Nob3VsZF9iZV91c2VkX3dpdGhfQ0ZORVRXT1JLCiAKKyNp ZiAhZGVmaW5lZChXVEZfVVNFX0NGTkVUV09SSykKKyNkZWZpbmUgV1RGX1VTRV9DRk5FVFdPUksg MAorI2VuZGlmCisKICNkZWZpbmUgRU5BQkxFX0pTQ19aT01CSUVTIDAKIAogLyogRklYTUU6IEV2 ZW50dWFsbHkgd2Ugc2hvdWxkIGVuYWJsZSB0aGlzIGZvciBhbGwgcGxhdGZvcm1zIGFuZCBnZXQg cmlkIG9mIHRoZSBkZWZpbmUuICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThiYmI2MTMxZjliZDBhYzUyZDI3 YmMwY2U1NzA2Y2U5YmM0N2MzNi4uMDQ1ODk0ODM4ZDE0NWQwN2M5OWU3M2RmNmE3YWEzOGFhOGNh NTRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTAyLTE1ICBQcmF0aWsgU29s YW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIFdURl9VU0VfQ0ZORVRX T1JLIHRvIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0MTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBjb25maWcuaDogUmVtb3ZlIFdURl9VU0VfQ0ZORVRXT1JLCisKIDIwMTEtMDIt MTUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NvbmZpZy5o IGIvU291cmNlL1dlYkNvcmUvY29uZmlnLmgKaW5kZXggYTNjMGU1MDg0YTNlYWU2OGRhNGJjOTFi MGY2ZWY4ZTMyZDViZTFkNC4uOTcyZDVlMTUzNmZhM2MxZGMyNjYzOGQ4MzllYzk0YmU5ZGEyOThk NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY29uZmlnLmgKKysrIGIvU291cmNlL1dlYkNv cmUvY29uZmlnLmgKQEAgLTE0OSw3ICsxNDksNiBAQAogI2lmIGRlZmluZWQoV0lOX0NBSVJPKQog I3VuZGVmIFdURl9QTEFURk9STV9DRwogI2RlZmluZSBXVEZfUExBVEZPUk1fQ0FJUk8gMQotI3Vu ZGVmIFdURl9VU0VfQ0ZORVRXT1JLCiAjZGVmaW5lIFdURl9VU0VfQ1VSTCAxCiAjaWZuZGVmIF9X SU5TT0NLQVBJXwogI2RlZmluZSBfV0lOU09DS0FQSV8gLy8gUHJldmVudCBpbmNsdXNpb24gb2Yg d2luc29jay5oIGluIHdpbmRvd3MuaApAQCAtMTU3LDcgKzE1Niw2IEBACiAjZWxpZiAhT1MoV0lO Q0UpCiAjZGVmaW5lIFdURl9QTEFURk9STV9DRyAxCiAjdW5kZWYgV1RGX1BMQVRGT1JNX0NBSVJP Ci0jZGVmaW5lIFdURl9VU0VfQ0ZORVRXT1JLIDEKICN1bmRlZiBXVEZfVVNFX0NVUkwKICNlbmRp ZgogI2VuZGlmCkBAIC0xOTMsOCArMTkxLDYgQEAKICNkZWZpbmUgV1RGX1VTRV9WOCAxCiAjZW5k aWYKIAotI3VuZGVmIFdURl9VU0VfQ0ZORVRXT1JLCi0KICNlbmRpZiAvKiBQTEFURk9STShDSFJP TUlVTSkgKi8KIAogI2lmICFkZWZpbmVkKFdURl9VU0VfVjgpCg==