54148 2011-02-09 15:05:16 -0800 REGRESSION (WebKit2): Opening two print dialogs causes havoc 2011-02-09 16:25:27 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 ap ap oldest_to_newest 348615 0 ap 2011-02-09 15:05:16 -0800 If you try to open two print dialogs at once (in separate windows, of course), they start blinking and updating like mad. Steps to reproduce: open two WebKit2 windows with about:blank, press Cmd+P in both. This is a WebKit2 regression caused by the way we force an asynchronous update of print preview (dispatching a print panel notification). 348618 1 ap 2011-02-09 15:06:19 -0800 <rdar://problem/8973887> 348654 2 81884 ap 2011-02-09 15:33:58 -0800 Created attachment 81884 proposed patch 348690 3 ap 2011-02-09 16:25:27 -0800 Committed <http://trac.webkit.org/changeset/78161>. 81884 2011-02-09 15:33:58 -0800 2011-02-09 15:49:56 -0800 proposed patch TwoPrintDialogs.txt text/plain 6524 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MTQ2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDItMDkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0MTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTczODg3PiBSRUdSRVNTSU9OIChX ZWJLaXQyKTogT3BlbmluZyB0d28gcHJpbnQgZGlhbG9ncyBjYXVzZXMgaGF2b2MKKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLUHJpbnRpbmdWaWV3Lmg6IE1vdmVkIF9pc0ZvcmNpbmdQ cmV2aWV3VXBkYXRlIGludG8gYSBzdGF0aWMgdmFyaWFibGUsCisgICAgICAgIGJlY2F1c2UgZGlz cGF0Y2hpbmcgYSBub3RpZmljYXRpb24gYWZmZWN0cyBhbGwgV0tQcmludGluZ1ZpZXdzIGF0IG9u Y2UuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tQcmludGluZ1ZpZXcubW06CisgICAg ICAgICgtW1dLUHJpbnRpbmdWaWV3IF91cGRhdGVQcmV2aWV3XSk6IFVwZGF0ZWQgZm9yIG5ldyB2 YXJpYWJsZSBuYW1lLgorICAgICAgICAoLVtXS1ByaW50aW5nVmlldyBrbm93c1BhZ2VSYW5nZTpd KTogRG9uJ3QgYnJlYWsgaWYgdGhlIG1ldGhvZCBpcyBjYWxsZWQgdHdpY2UgaW4gYSByb3cKKyAg ICAgICAgKHdlIGFscmVhZHkgaGFkIHRoaXMgbG9naWMgd2hlbiBwcmludGluZyBmcm9tIHNlcGFy YXRlIHRocmVhZCwgYnV0IG5vdCBmb3IgcHJldmlldykuCisgICAgICAgICgtW1dLUHJpbnRpbmdW aWV3IGRyYXdSZWN0Ol0pOiBDaGFuZ2VkIGFsbCBMT0cgbWVzc2FnZXMgdG8gaGF2ZSB2aWV3IG9i amVjdCBhZGRyZXNzIGZvcgorICAgICAgICBlYXNpZXIgbWF0Y2hpbmcuCisgICAgICAgICgtW1dL UHJpbnRpbmdWaWV3IHJlY3RGb3JQYWdlOl0pOiBEaXR0by4KKyAgICAgICAgKC1bV0tQcmludGlu Z1ZpZXcgYmVnaW5Eb2N1bWVudF0pOiBEaXR0by4KKyAgICAgICAgKC1bV0tQcmludGluZ1ZpZXcg ZW5kRG9jdW1lbnRdKTogRGl0dG8uCisKIDIwMTEtMDItMDkgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLUHJpbnRpbmdWaWV3LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tQcmludGluZ1ZpZXcu aAkocmV2aXNpb24gNzc5NjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ByaW50aW5nVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw3ICs0OCw2IEBAIEBpbnRlcmZh Y2UgV0tQcmludGluZ1ZpZXcgOiBOU1ZpZXcgewogICAgIEhhc2hNYXA8dWludDY0X3QsIFdlYkNv cmU6OkludFJlY3Q+IF9leHBlY3RlZFByZXZpZXdDYWxsYmFja3M7CiAgICAgdWludDY0X3QgX2xh dGVzdEV4cGVjdGVkUHJldmlld0NhbGxiYWNrOwogICAgIHVpbnQ2NF90IF9leHBlY3RlZFByaW50 Q2FsbGJhY2s7Ci0gICAgQk9PTCBfaXNGb3JjaW5nUHJldmlld1VwZGF0ZTsKIAogICAgIEJPT0wg X2lzUHJpbnRpbmdGcm9tU2Vjb25kYXJ5VGhyZWFkOwogICAgIE11dGV4IF9wcmludGluZ0NhbGxi YWNrTXV0ZXg7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ByaW50 aW5nVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9XS1ByaW50aW5nVmlldy5tbQkocmV2aXNpb24gNzc5NjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ByaW50aW5nVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzks NiArMzksOCBAQCBOU1N0cmluZyAqIGNvbnN0IFdlYktpdE9yaWdpbmFsQm90dG9tUHJpCiAKIE5T U3RyaW5nICogY29uc3QgTlNQcmludEluZm9EaWRDaGFuZ2VOb3RpZmljYXRpb24gPSBAIk5TUHJp bnRJbmZvRGlkQ2hhbmdlIjsKIAorc3RhdGljIEJPT0wgaXNGb3JjaW5nUHJldmlld1VwZGF0ZTsK KwogQGltcGxlbWVudGF0aW9uIFdLUHJpbnRpbmdWaWV3CiAKIC0gKGlkKWluaXRXaXRoRnJhbWVQ cm94eTooV2ViRnJhbWVQcm94eSopZnJhbWUKQEAgLTEyNyw5ICsxMjksMTAgQEAgLSAoQk9PTClf aXNQcmludGluZ1ByZXZpZXcKIC0gKHZvaWQpX3VwZGF0ZVByZXZpZXcKIHsKICAgICAvLyA8cmRh cjovL3Byb2JsZW0vODkwMDkyMz4gUGxlYXNlIGFkZCBhbiBBUEkgdG8gZm9yY2UgcHJpbnQgcHJl dmlldyB1cGRhdGUuCi0gICAgX2lzRm9yY2luZ1ByZXZpZXdVcGRhdGUgPSBZRVM7CisgICAgQVNT RVJUKCFpc0ZvcmNpbmdQcmV2aWV3VXBkYXRlKTsKKyAgICBpc0ZvcmNpbmdQcmV2aWV3VXBkYXRl ID0gWUVTOwogICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcG9zdE5v dGlmaWNhdGlvbk5hbWU6TlNQcmludEluZm9EaWRDaGFuZ2VOb3RpZmljYXRpb24gb2JqZWN0Om5p bF07Ci0gICAgX2lzRm9yY2luZ1ByZXZpZXdVcGRhdGUgPSBOTzsKKyAgICBpc0ZvcmNpbmdQcmV2 aWV3VXBkYXRlID0gTk87CiB9CiAKIC0gKEJPT0wpX2hhc1BhZ2VSZWN0cwpAQCAtMzE5LDcgKzMy Miw3IEBAIHN0YXRpYyB2b2lkIHByZXBhcmVEYXRhRm9yUHJpbnRpbmdPblNlY28KIAogLSAoQk9P TClrbm93c1BhZ2VSYW5nZTooTlNSYW5nZVBvaW50ZXIpcmFuZ2UKIHsKLSAgICBMT0coVmlldywg Ii1bV0tQcmludGluZ1ZpZXcga25vd3NQYWdlUmFuZ2U6XSwgJXMsICVzIiwgW3NlbGYgX2hhc1Bh Z2VSZWN0c10gPyAicHJpbnQgZGF0YSBpcyBhdmFpbGFibGUiIDogInByaW50IGRhdGEgaXMgbm90 IGF2YWlsYWJsZSB5ZXQiLCBpc01haW5UaHJlYWQoKSA/ICJvbiBtYWluIHRocmVhZCIgOiAib24g c2Vjb25kYXJ5IHRocmVhZCIpOworICAgIExPRyhWaWV3LCAiLVtXS1ByaW50aW5nVmlldyAlcCBr bm93c1BhZ2VSYW5nZTpdLCAlcywgJXMiLCBzZWxmLCBbc2VsZiBfaGFzUGFnZVJlY3RzXSA/ICJw cmludCBkYXRhIGlzIGF2YWlsYWJsZSIgOiAicHJpbnQgZGF0YSBpcyBub3QgYXZhaWxhYmxlIHll dCIsIGlzTWFpblRocmVhZCgpID8gIm9uIG1haW4gdGhyZWFkIiA6ICJvbiBzZWNvbmRhcnkgdGhy ZWFkIik7CiAgICAgQVNTRVJUKF9wcmludE9wZXJhdGlvbiA9PSBbTlNQcmludE9wZXJhdGlvbiBj dXJyZW50T3BlcmF0aW9uXSk7CiAKICAgICAvLyBBc3N1bWluZyB0aGF0IG9uY2Ugd2Ugc3dpdGNo IHRvIHByaW50aW5nIGZyb20gYSBzZWNvbmRhcnkgdGhyZWFkLCB3ZSBkb24ndCBnbyBiYWNrLgpA QCAtMzQyLDcgKzM0NSw5IEBAIC0gKEJPT0wpa25vd3NQYWdlUmFuZ2U6KE5TUmFuZ2VQb2ludGVy KXIKICAgICB9IGVsc2UgewogICAgICAgICBBU1NFUlQoW3NlbGYgX2lzUHJpbnRpbmdQcmV2aWV3 XSk7CiAKLSAgICAgICAgW3NlbGYgX2Fza1BhZ2VUb0NvbXB1dGVQYWdlUmVjdHNdOworICAgICAg ICAvLyBJZiBhIHJlcXVlc3QgZm9yIHBhZ2VzIGhhc24ndCBhbHJlYWR5IGJlZW4gbWFkZSwgbWFr ZSBpdCBub3cuCisgICAgICAgIGlmICghX2V4cGVjdGVkQ29tcHV0ZWRQYWdlc0NhbGxiYWNrKQor ICAgICAgICAgICAgW3NlbGYgX2Fza1BhZ2VUb0NvbXB1dGVQYWdlUmVjdHNdOwogCiAgICAgICAg ICpyYW5nZSA9IE5TTWFrZVJhbmdlKDEsIE5TSW50ZWdlck1heCk7CiAgICAgfQpAQCAtNDM0LDcg KzQzOSw3IEBAIC0gKHZvaWQpX2RyYXdQcmV2aWV3OihOU1JlY3QpbnNSZWN0CiAKIC0gKHZvaWQp ZHJhd1JlY3Q6KE5TUmVjdCluc1JlY3QKIHsKLSAgICBMT0coVmlldywgIldLUHJpbnRpbmdWaWV3 IHByaW50aW5nIHJlY3QgeDolZywgeTolZywgd2lkdGg6JWcsIGhlaWdodDolZyVzIiwgbnNSZWN0 Lm9yaWdpbi54LCBuc1JlY3Qub3JpZ2luLnksIG5zUmVjdC5zaXplLndpZHRoLCBuc1JlY3Quc2l6 ZS5oZWlnaHQsIFtzZWxmIF9pc1ByaW50aW5nUHJldmlld10gPyAiIGZvciBwcmV2aWV3IiA6ICIi KTsKKyAgICBMT0coVmlldywgIldLUHJpbnRpbmdWaWV3ICVwIHByaW50aW5nIHJlY3QgeDolZywg eTolZywgd2lkdGg6JWcsIGhlaWdodDolZyVzIiwgc2VsZiwgbnNSZWN0Lm9yaWdpbi54LCBuc1Jl Y3Qub3JpZ2luLnksIG5zUmVjdC5zaXplLndpZHRoLCBuc1JlY3Quc2l6ZS5oZWlnaHQsIFtzZWxm IF9pc1ByaW50aW5nUHJldmlld10gPyAiIGZvciBwcmV2aWV3IiA6ICIiKTsKIAogICAgIEFTU0VS VChfcHJpbnRPcGVyYXRpb24gPT0gW05TUHJpbnRPcGVyYXRpb24gY3VycmVudE9wZXJhdGlvbl0p OwogCkBAIC01MTgsNyArNTIzLDcgQEAgLSAoTlNSZWN0KXJlY3RGb3JQYWdlOihOU0ludGVnZXIp cGFnZQogewogICAgIEFTU0VSVChfcHJpbnRPcGVyYXRpb24gPT0gW05TUHJpbnRPcGVyYXRpb24g Y3VycmVudE9wZXJhdGlvbl0pOwogICAgIGlmICghW3NlbGYgX2hhc1BhZ2VSZWN0c10pIHsKLSAg ICAgICAgTE9HKFZpZXcsICItW1dLUHJpbnRpbmdWaWV3IHJlY3RGb3JQYWdlOiVkXSAtIGRhdGEg aXMgbm90IHlldCBhdmFpbGFibGUiLCAoaW50KXBhZ2UpOworICAgICAgICBMT0coVmlldywgIi1b V0tQcmludGluZ1ZpZXcgJXAgcmVjdEZvclBhZ2U6JWRdIC0gZGF0YSBpcyBub3QgeWV0IGF2YWls YWJsZSIsIHNlbGYsIChpbnQpcGFnZSk7CiAgICAgICAgIC8vIFdlIG11c3QgYmUgc3RpbGwgY2Fs Y3VsYXRpbmcgdGhlIHBhZ2UgcmFuZ2UuCiAgICAgICAgIEFTU0VSVChfZXhwZWN0ZWRDb21wdXRl ZFBhZ2VzQ2FsbGJhY2spOwogICAgICAgICByZXR1cm4gTlNNYWtlUmVjdCgwLCAwLCAxLCAxKTsK QEAgLTUyNiw3ICs1MzEsNyBAQCAtIChOU1JlY3QpcmVjdEZvclBhZ2U6KE5TSW50ZWdlcilwYWdl CiAKICAgICBJbnRSZWN0IHJlY3QgPSBfcHJpbnRpbmdQYWdlUmVjdHNbcGFnZSAtIDFdOwogICAg IHJlY3Quc2NhbGUoX3RvdGFsU2NhbGVGYWN0b3JGb3JQcmludGluZyk7Ci0gICAgTE9HKFZpZXcs ICItW1dLUHJpbnRpbmdWaWV3IHJlY3RGb3JQYWdlOiVkXSAtPiB4ICVkLCB5ICVkLCB3aWR0aCAl ZCwgaGVpZ2h0ICVkIiwgKGludClwYWdlLCByZWN0LngoKSwgcmVjdC55KCksIHJlY3Qud2lkdGgo KSwgcmVjdC5oZWlnaHQoKSk7CisgICAgTE9HKFZpZXcsICItW1dLUHJpbnRpbmdWaWV3ICVwIHJl Y3RGb3JQYWdlOiVkXSAtPiB4ICVkLCB5ICVkLCB3aWR0aCAlZCwgaGVpZ2h0ICVkIiwgc2VsZiwg KGludClwYWdlLCByZWN0LngoKSwgcmVjdC55KCksIHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQo KSk7CiAgICAgcmV0dXJuIHJlY3Q7CiB9CiAKQEAgLTU0MiwxMCArNTQ3LDEwIEBAIC0gKHZvaWQp YmVnaW5Eb2N1bWVudAogICAgIEFTU0VSVChfcHJpbnRPcGVyYXRpb24gPT0gW05TUHJpbnRPcGVy YXRpb24gY3VycmVudE9wZXJhdGlvbl0pOwogCiAgICAgLy8gRm9yY2luZyBwcmV2aWV3IHVwZGF0 ZSBnZXRzIHVzIGhlcmUsIGJ1dCBwYWdlIHNldHVwIGhhc24ndCBhY3R1YWxseSBjaGFuZ2VkLgot ICAgIGlmIChfaXNGb3JjaW5nUHJldmlld1VwZGF0ZSkKKyAgICBpZiAoaXNGb3JjaW5nUHJldmll d1VwZGF0ZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTE9HKFZpZXcsICItW1dLUHJpbnRpbmdW aWV3IGJlZ2luRG9jdW1lbnRdIik7CisgICAgTE9HKFZpZXcsICItW1dLUHJpbnRpbmdWaWV3ICVw IGJlZ2luRG9jdW1lbnRdIiwgc2VsZik7CiAKICAgICBbc3VwZXIgYmVnaW5Eb2N1bWVudF07CiAK QEAgLTU1NywxMCArNTYyLDEwIEBAIC0gKHZvaWQpZW5kRG9jdW1lbnQKICAgICBBU1NFUlQoX3By aW50T3BlcmF0aW9uID09IFtOU1ByaW50T3BlcmF0aW9uIGN1cnJlbnRPcGVyYXRpb25dKTsKIAog ICAgIC8vIEZvcmNpbmcgcHJldmlldyB1cGRhdGUgZ2V0cyB1cyBoZXJlLCBidXQgcGFnZSBzZXR1 cCBoYXNuJ3QgYWN0dWFsbHkgY2hhbmdlZC4KLSAgICBpZiAoX2lzRm9yY2luZ1ByZXZpZXdVcGRh dGUpCisgICAgaWYgKGlzRm9yY2luZ1ByZXZpZXdVcGRhdGUpCiAgICAgICAgIHJldHVybjsKIAot ICAgIExPRyhWaWV3LCAiLVtXS1ByaW50aW5nVmlldyBlbmREb2N1bWVudF0gLSBjbGVhcmluZyBj YWNoZWQgZGF0YSIpOworICAgIExPRyhWaWV3LCAiLVtXS1ByaW50aW5nVmlldyAlcCBlbmREb2N1 bWVudF0gLSBjbGVhcmluZyBjYWNoZWQgZGF0YSIsIHNlbGYpOwogCiAgICAgLy8gQm90aCBleGlz dGluZyBkYXRhIGFuZCBwZW5kaW5nIHJlc3BvbnNlcyBhcmUgbm93IG9ic29sZXRlLgogICAgIF9w cmludGluZ1BhZ2VSZWN0cy5jbGVhcigpOwo=