54129 2011-02-09 12:02:55 -0800 A tiny bit of encapsulation for MarkedBlock: made its heap data member private 2011-02-09 12:59:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren abarth eric gustavo webkit.review.bot xan.lopez oldest_to_newest 348434 0 ggaren 2011-02-09 12:02:55 -0800 A tiny bit of encapsulation for MarkedBlock: made its heap data member private 348437 1 81847 ggaren 2011-02-09 12:04:02 -0800 Created attachment 81847 Patch 348438 2 81847 sam 2011-02-09 12:06:42 -0800 Comment on attachment 81847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81847&action=review > Source/JavaScriptCore/runtime/MarkedBlock.h:62 > + Heap* heap(); Please make const. 348445 3 ggaren 2011-02-09 12:09:50 -0800 Committed r78105: <http://trac.webkit.org/changeset/78105> 348457 4 webkit.review.bot 2011-02-09 12:18:28 -0800 http://trac.webkit.org/changeset/78105 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Windows 32-bit Release, and EFL Linux Release (Build) 348481 5 gustavo 2011-02-09 12:59:04 -0800 Attachment 81847 did not build on gtk: Build output: http://queues.webkit.org/results/7874026 81847 2011-02-09 12:04:02 -0800 2011-02-09 12:06:42 -0800 Patch bug-54129-20110209120401.patch text/plain 3694 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzgxMDEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDItMDkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIHRpbnkgYml0IG9mIGVu Y2Fwc3VsYXRpb24gZm9yIE1hcmtlZEJsb2NrOiBtYWRlIGl0cyBoZWFwIGRhdGEgbWVtYmVyIHBy aXZhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 MTI5CisKKyAgICAgICAgKiBydW50aW1lL01hcmtlZEJsb2NrLmg6CisgICAgICAgIChKU0M6Ok1h cmtlZEJsb2NrOjppc0NlbGxBbGlnbmVkKToKKyAgICAgICAgKEpTQzo6TWFya2VkQmxvY2s6Ok1h cmtlZEJsb2NrKToKKyAgICAgICAgKEpTQzo6TWFya2VkQmxvY2s6OmhlYXApOiBNYWRlIHRoZSBo ZWFwIGRhdGEgbWVtYmVyIHByaXZhdGUsIGFuZCBwcm92aWRlZAorICAgICAgICBhIGNvbnN0cnVj dG9yIGFuZCBhbiBhY2Nlc3Nvci4KKworICAgICAgICAqIHJ1bnRpbWUvTWFya2VkU3BhY2UuY3Bw OgorICAgICAgICAoSlNDOjpNYXJrZWRTcGFjZTo6YWxsb2NhdGVCbG9jayk6CisgICAgICAgICog cnVudGltZS9NYXJrZWRTcGFjZS5oOgorICAgICAgICAoSlNDOjpNYXJrZWRTcGFjZTo6aGVhcCk6 IFVzZSB0aGUgY29uc3RydWN0b3IgYW5kIGFjY2Vzc29yLgorCiAyMDExLTAyLTA5ICBQZXRlciBW YXJnYSAgPHB2YXJnYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJh cnJhY2xvdWdoLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya2VkQmxv Y2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRC bG9jay5oCShyZXZpc2lvbiA3Nzk3NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L01hcmtlZEJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTU3LDYgKzU3LDkgQEAgbmFtZXNwYWNl IEpTQyB7CiAgICAgcHVibGljOgogICAgICAgICBzdGF0aWMgYm9vbCBpc0NlbGxBbGlnbmVkKGNv bnN0IHZvaWQqKTsKICAgICAgICAgc3RhdGljIE1hcmtlZEJsb2NrKiBibG9ja0Zvcihjb25zdCB2 b2lkKik7CisgICAgICAgIAorICAgICAgICBNYXJrZWRCbG9jayhIZWFwKik7CisgICAgICAgIEhl YXAqIGhlYXAoKTsKIAogICAgICAgICBzaXplX3QgY2VsbE51bWJlcihjb25zdCB2b2lkKik7CiAg ICAgICAgIGJvb2wgaXNNYXJrZWQoY29uc3Qgdm9pZCopOwpAQCAtNjUsNyArNjgsOSBAQCBuYW1l c3BhY2UgSlNDIHsKIAogICAgICAgICBGaXhlZEFycmF5PENvbGxlY3RvckNlbGwsIENFTExTX1BF Ul9CTE9DSz4gY2VsbHM7CiAgICAgICAgIFdURjo6Qml0bWFwPEJJVFNfUEVSX0JMT0NLPiBtYXJr ZWQ7Ci0gICAgICAgIEhlYXAqIGhlYXA7CisKKyAgICBwcml2YXRlOgorICAgICAgICBIZWFwKiBt X2hlYXA7CiAgICAgfTsKIAogICAgIHN0cnVjdCBIZWFwQ29uc3RhbnRzIHsKQEAgLTc1LDEwICs4 MCwyNSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdHlwZWRlZiBNYXJrZWRCbG9jayBCbG9j azsKICAgICB9OwogCisgICAgaW5saW5lIGJvb2wgTWFya2VkQmxvY2s6OmlzQ2VsbEFsaWduZWQo Y29uc3Qgdm9pZCogcCkKKyAgICB7CisgICAgICAgIHJldHVybiAhKChpbnRwdHJfdCkocCkgJiBD RUxMX01BU0spOworICAgIH0KKwogICAgIGlubGluZSBNYXJrZWRCbG9jayogTWFya2VkQmxvY2s6 OmJsb2NrRm9yKGNvbnN0IHZvaWQqIHApCiAgICAgewogICAgICAgICByZXR1cm4gcmVpbnRlcnBy ZXRfY2FzdDxNYXJrZWRCbG9jayo+KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihwKSAmIEJM T0NLX01BU0spOwogICAgIH0KKyAgICAKKyAgICBpbmxpbmUgTWFya2VkQmxvY2s6Ok1hcmtlZEJs b2NrKEhlYXAqIGhlYXApCisgICAgICAgIDogbV9oZWFwKGhlYXApCisgICAgeworICAgIH0KKyAg ICAKKyAgICBpbmxpbmUgSGVhcCogTWFya2VkQmxvY2s6OmhlYXAoKQorICAgIHsKKyAgICAgICAg cmV0dXJuIG1faGVhcDsKKyAgICB9CiAKICAgICBpbmxpbmUgc2l6ZV90IE1hcmtlZEJsb2NrOjpj ZWxsTnVtYmVyKGNvbnN0IHZvaWQqIGNlbGwpCiAgICAgewpAQCAtMTAwLDExICsxMjAsNiBAQCBu YW1lc3BhY2UgSlNDIHsKICAgICAgICAgbWFya2VkLnNldChjZWxsTnVtYmVyKGNlbGwpKTsKICAg ICB9CiAKLSAgICBpbmxpbmUgYm9vbCBNYXJrZWRCbG9jazo6aXNDZWxsQWxpZ25lZChjb25zdCB2 b2lkKiBwKQotICAgIHsKLSAgICAgICAgcmV0dXJuICEoKGludHB0cl90KShwKSAmIENFTExfTUFT Syk7Ci0gICAgfQotCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlmIC8vIE1hcmtlZFNwYWNl X2gKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNwYWNlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRTcGFjZS5j cHAJKHJldmlzaW9uIDc4MDE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFy a2VkU3BhY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIE5FVkVSX0lOTElO RSBNYXJrZWRCbG9jayogTWFya2VkU3BhY2U6OmEKIAogICAgIC8vIEluaXRpYWxpemUgYmxvY2su CiAKLSAgICBibG9jay0+aGVhcCA9ICZnbG9iYWxEYXRhKCktPmhlYXA7CisgICAgbmV3IChibG9j aykgTWFya2VkQmxvY2soJmdsb2JhbERhdGEoKS0+aGVhcCk7CiAgICAgY2xlYXJNYXJrQml0cyhi bG9jayk7CiAKICAgICBTdHJ1Y3R1cmUqIGR1bW15TWFya2FibGVDZWxsU3RydWN0dXJlID0gZ2xv YmFsRGF0YSgpLT5kdW1teU1hcmthYmxlQ2VsbFN0cnVjdHVyZS5nZXQoKTsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNwYWNlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya2VkU3BhY2UuaAkocmV2aXNpb24gNzgwMTcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRTcGFjZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0xMDYsNyArMTA2LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBpbmxpbmUg SGVhcCogTWFya2VkU3BhY2U6OmhlYXAoSlNDZWxsKiBjZWxsKQogICAgIHsKLSAgICAgICAgcmV0 dXJuIE1hcmtlZEJsb2NrOjpibG9ja0ZvcihjZWxsKS0+aGVhcDsKKyAgICAgICAgcmV0dXJuIE1h cmtlZEJsb2NrOjpibG9ja0ZvcihjZWxsKS0+aGVhcCgpOwogICAgIH0KIAogICAgIGlubGluZSBi b29sIE1hcmtlZFNwYWNlOjppc01hcmtlZChjb25zdCBKU0NlbGwqIGNlbGwpCg==