54125 2011-02-09 11:33:06 -0800 WebAutoFillClient::didAcceptAutocompleteSuggestion is deprecated and needs removing 2011-02-09 14:53:39 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 dhollowa webkit-unassigned commit-queue fishd oldest_to_newest 348411 0 dhollowa 2011-02-09 11:33:06 -0800 The method WebAutoFillClient::didAcceptAutocompleteSuggestion has been deprecated and replaced by the more general WebAutoFillClient::didAcceptAutoFillSuggestion. It should be removed. See: WebKit/Source/WebKit/chromium/public/WebAutoFillClient.h 348415 1 81843 dhollowa 2011-02-09 11:38:32 -0800 Created attachment 81843 Patch 348602 2 81843 commit-queue 2011-02-09 14:53:34 -0800 Comment on attachment 81843 Patch Clearing flags on attachment: 81843 Committed r78144: <http://trac.webkit.org/changeset/78144> 348603 3 commit-queue 2011-02-09 14:53:39 -0800 All reviewed patches have been landed. Closing bug. 81843 2011-02-09 11:38:32 -0800 2011-02-09 14:53:34 -0800 Patch bug-54125-20110209113831.patch text/plain 3716 dhollowa U3VidmVyc2lvbiBSZXZpc2lvbjogNzgwNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MGI2OTQ4MDRjYjgyOTBjZTVmNjQxNmM2MmI3N2YwYWQ0MDYyMTU5Ny4uMTRjMzNkZDk0ZWRmZWRk ZjNlYjhhNDkyZTI0OWJhNzMwNTcyYTdmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMi0wOSAgRGF2aWQgSG9sbG93YXkgIDxkaG9sbG93YUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlcyBkZXByZWNhdGVkIGludGVyZmFjZSBXZWJBdXRvRmlsbENsaWVudDo6ZGlkQWNj ZXB0QXV0b2NvbXBsZXRlU3VnZ2VzdGlvbigpLiAgVGhpcyBpbnRlcmZhY2UgaGFzIGJlZW4gcmVw bGFjZWQgYnkgdGhlIG1vcmUgZ2VuZXJhbCBXZWJBdXRvRmlsbENsaWVudDo6ZGlkQWNjZXB0QXV0 b0ZpbGxTdWdnZXN0aW9uKCkgbWV0aG9kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTQxMjUKKworICAgICAgICAqIHB1YmxpYy9XZWJBdXRvRmlsbENs aWVudC5oOgorICAgICAgICAqIHNyYy9FZGl0b3JDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKiBz cmMvRWRpdG9yQ2xpZW50SW1wbC5oOgorCiAyMDExLTAyLTA5ICBNT1JJVEEgSGFqaW1lICA8bW9y cml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNoaW5pY2hpcm8gSGFtYWpp LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQXV0b0ZpbGxD bGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkF1dG9GaWxsQ2xpZW50 LmgKaW5kZXggNGU3M2JlMDcyYmIwZDFmNzE1MDc0YTNlYTM0NTlhNDE3OGI0MjkzYy4uNjNiMzlh ODZlZTU1YjYwZjY2NDZhMjA0ODQ5ZjhkMmQwMWZjZmQ5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQXV0b0ZpbGxDbGllbnQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBdXRvRmlsbENsaWVudC5oCkBAIC03MCwxMSArNzAsNiBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZUF1dG9jb21wbGV0ZVN1Z2dlc3Rpb24o Y29uc3QgV2ViU3RyaW5nJiBuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpIHsgfQogCi0gICAgLy8gSW5mb3Jt cyB0aGUgYnJvd3NlciB0aGF0IHRoZSB1c2VyIGhhcyBzZWxlY3RlZCBhbiBhdXRvY29tcGxldGUg KHBhc3N3b3JkCi0gICAgLy8gb3IgZmllbGQpIHN1Z2dlc3Rpb24gZnJvbSB0aGUgZHJvcC1kb3du LiAgVGhlIGlucHV0IGVsZW1lbnQgdGV4dCBoYXMKLSAgICAvLyBhbHJlYWR5IGJlZW4gc2V0IHRv IHRoZSBzZWxlY3RlZCBzdWdnZXN0aW9uLgotICAgIHZpcnR1YWwgdm9pZCBkaWRBY2NlcHRBdXRv Y29tcGxldGVTdWdnZXN0aW9uKGNvbnN0IFdlYklucHV0RWxlbWVudCYpIHsgfQotCiAgICAgLy8g VGhlc2UgbWV0aG9kcyBhcmUgY2FsbGVkIHdoZW4gdGhlIHVzZXJzIGVkaXRzIGEgdGV4dC1maWVs ZC4KICAgICB2aXJ0dWFsIHZvaWQgdGV4dEZpZWxkRGlkQmVnaW5FZGl0aW5nKGNvbnN0IFdlYklu cHV0RWxlbWVudCYpIHsgfQogICAgIHZpcnR1YWwgdm9pZCB0ZXh0RmllbGREaWRFbmRFZGl0aW5n KGNvbnN0IFdlYklucHV0RWxlbWVudCYpIHsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcAppbmRleCBiMzAxNjg4ODdhMzcxNDUyNDhmNTM2ZmYy ZjYxN2U4MmU0ZWUxOTNhLi4zZGMzYTZhYTg1ZTY0Y2IwN2YzMmFjZjNiZjIxOGMzMDU1MDUzMTQ3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNw cApAQCAtODAyLDE4ICs4MDIsNiBAQCB2b2lkIEVkaXRvckNsaWVudEltcGw6OmNhbmNlbFBlbmRp bmdBdXRvZmlsbCgpCiAgICAgbV9hdXRvZmlsbFRpbWVyLnN0b3AoKTsKIH0KIAotdm9pZCBFZGl0 b3JDbGllbnRJbXBsOjpvbkF1dG9jb21wbGV0ZVN1Z2dlc3Rpb25BY2NlcHRlZChIVE1MSW5wdXRF bGVtZW50KiB0ZXh0RmllbGQpCi17Ci0gICAgaWYgKG1fd2ViVmlldy0+YXV0b0ZpbGxDbGllbnQo KSkKLSAgICAgICAgbV93ZWJWaWV3LT5hdXRvRmlsbENsaWVudCgpLT5kaWRBY2NlcHRBdXRvY29t cGxldGVTdWdnZXN0aW9uKFdlYklucHV0RWxlbWVudCh0ZXh0RmllbGQpKTsKLQotICAgIFdlYkZy YW1lSW1wbCogd2ViZnJhbWUgPSBXZWJGcmFtZUltcGw6OmZyb21GcmFtZSh0ZXh0RmllbGQtPmRv Y3VtZW50KCktPmZyYW1lKCkpOwotICAgIGlmICghd2ViZnJhbWUpCi0gICAgICAgIHJldHVybjsK LQotICAgIHdlYmZyYW1lLT5ub3RpZml5UGFzc3dvcmRMaXN0ZW5lck9mQXV0b2NvbXBsZXRlKFdl YklucHV0RWxlbWVudCh0ZXh0RmllbGQpKTsKLX0KLQogYm9vbCBFZGl0b3JDbGllbnRJbXBsOjpk b1RleHRGaWVsZENvbW1hbmRGcm9tRXZlbnQoRWxlbWVudCogZWxlbWVudCwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEtleWJvYXJkRXZlbnQqIGV2 ZW50KQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xp ZW50SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5o CmluZGV4IGZmMWNiNGQyNmI2NjNiYTc2NzU4ZmE2NjBhZTQ4ZjUxYzllMTNjMDQuLjhjNDBmM2Mw ZDU1OWFmMjhlMDAyMzFjOTU2MjAyNTYwNWE3YTMwMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmgKQEAgLTEyMSwxMiArMTIxLDYgQEAgcHVibGlj OgogICAgIC8vIG90aGVyd2lzZS4KICAgICB2aXJ0dWFsIGJvb2wgc2hvd0Zvcm1BdXRvZmlsbEZv ck5vZGUoV2ViQ29yZTo6Tm9kZSopOwogCi0gICAgLy8gTm90aWZpY2F0aW9uIHRoYXQgdGhlIHRl eHQgY2hhbmdlZCBkdWUgdG8gYWNjZXB0YW5jZSBvZiBhIHN1Z2dlc3Rpb24KLSAgICAvLyBwcm92 aWRlZCBieSBhbiBBdXRvY29tcGxldGUgcG9wdXAuICBIYXZpbmcgYSBzZXBhcmF0ZSBjYWxsYmFj ayBpbiB0aGlzCi0gICAgLy8gY2FzZSBpcyBhIHNpbXBsZSB3YXkgdG8gYnJlYWsgdGhlIGN5Y2xl IHRoYXQgd291bGQgb3RoZXJ3aXNlIG9jY3VyIGlmCi0gICAgLy8gdGV4dERpZENoYW5nZUluVGV4 dEZpZWxkIHdhcyBjYWxsZWQuCi0gICAgdmlydHVhbCB2b2lkIG9uQXV0b2NvbXBsZXRlU3VnZ2Vz dGlvbkFjY2VwdGVkKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQqKTsKLQogcHJpdmF0ZToKICAg ICB2b2lkIG1vZGlmeVNlbGVjdGlvbihXZWJDb3JlOjpGcmFtZSosIFdlYkNvcmU6OktleWJvYXJk RXZlbnQqKTsKIAo=