54118 2011-02-09 10:23:04 -0800 XMLHttpRequest::abort() doesn't clear response data 2011-02-15 11:10:32 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P4 Minor --- 0 jarred webkit-unassigned ap commit-queue darin oldest_to_newest 348350 0 jarred 2011-02-09 10:23:04 -0800 In the case of ArrayBuffer responses, abort() will not clear the binary buffer. So it just wastes space. Subsequent open() calls (which must come before send(), since abort() resets the state to UNSENT) will clear the buffer properly, but that's not necessarily going to happen. So this is just more memory efficient. clearResponse() can replace the code in abort(), because it's accomplishing the same thing, it's neater, and it's one function to maintain; an omission like the above can be better avoided. 348354 1 81831 jarred 2011-02-09 10:26:52 -0800 Created attachment 81831 Proposed patch 348360 2 81831 darin 2011-02-09 10:30:42 -0800 Comment on attachment 81831 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81831&action=review > Source/WebCore/ChangeLog:6 > + XMLHttpRequest::abort() should call clearResponse() > + https://bugs.webkit.org/show_bug.cgi?id=54118 This change log entry is not sufficient. It doesn’t state why this is a good change. As you do in your bug, but more briefly, you need to state the benefit of the change: Less memory used after an abort(), presumably. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) We can’t land a patch with a line like this. You need to change this line into an explanation of why it’s OK to make this change without adding any new tests. 348361 3 jarred 2011-02-09 10:31:26 -0800 I honestly dont' know what I was thinking, I totally meant to type a description in the changelog. One sec... 348367 4 81833 jarred 2011-02-09 10:38:07 -0800 Created attachment 81833 Proposed patch 348368 5 81834 jarred 2011-02-09 10:39:50 -0800 Created attachment 81834 Proposed patch 348380 6 81834 darin 2011-02-09 10:49:31 -0800 Comment on attachment 81834 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81834&action=review > Source/WebCore/ChangeLog:16 > + abort() is not properly clearing ArrayBuffer binary buffered data. This > + change will remove the cleanup code from abort() and instead call > + clearResponse() to do the cleanup, which not only does the original abort() > + cleanup, but also covers the binary response buffer as well. Future cleanup > + omissions can be avoided by only having to maintain clearResponse(). > + > + Clearing the data on abort() is more memory efficient. By not clearing > + this data, it will remain in memory until the XHR object is cleaned up or > + until a subsequent call to open(). This comment is too long. It would be better to say something like this: Calling clearResponse frees more memory at abort time. No new tests because there is no observable effect except for less memory used. The longer paragraph is something people probably won’t read. 348381 7 jarred 2011-02-09 10:50:26 -0800 Ok fair enough, I'll change it for another review. Thanks Darin. 348384 8 81836 jarred 2011-02-09 10:53:18 -0800 Created attachment 81836 Proposed patch 348600 9 81836 ap 2011-02-09 14:53:05 -0800 Comment on attachment 81836 Proposed patch One hidden change here is that m_response is now cleared. This has observable consequences - for example, XMLHttpRequest.status is lost after aborting. How did you verify that this is OK? 348619 10 jarred 2011-02-09 15:07:33 -0800 You are right, that behavior is changed. But the current behavior of status is against the W3 standard as it is. Resetting the ResourceResponse is the appropriate action, because status should return 0 when the error flag is true, which abort sets. See http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#the-abort-method and http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#the-status-attribute. We are actually fixing two things at once here... 348640 11 81836 ap 2011-02-09 15:22:32 -0800 Comment on attachment 81836 Proposed patch Thanks, that's convincing. I only picked one example, for a case where I could quickly tell that there is a behavior change. Can you go over uses of m_response in the file and check that it is always expected to have null response after abort()? > We are actually fixing two things at once here... I think that this needs a regression test then. Please add one (setting r- to that effect). It would be nice to know if the test passes in both IE and Firefox. 348664 12 jarred 2011-02-09 15:45:48 -0800 Yes I agree, thanks. I'll create tests and see how other browsers behave, and I'll survey the code affected code thoroughly. 348667 13 darin 2011-02-09 15:47:30 -0800 (In reply to comment #9) > One hidden change here is that m_response is now cleared. This has observable consequences - for example, XMLHttpRequest.status is lost after aborting. I tried to review the class to see what effects clearing m_response would have. Somehow I missed that XMLHttpRequest.status effect. 348713 14 jarred 2011-02-09 17:08:50 -0800 Ok, I am convinced that clearing the response is the right (i.e. safe) thing to do here. I was debating on whether to revise this patch and create a clearResponseBuffers() function that was used in both clearResponse() and abort(). However, anytime a response error occurs (abort, network, generic, timeout), all of the response attributes/getters (status, statusText, headers, etc.) are not meant to be accessible according to W3. Therefore, clearing the response "shouldn't matter" if we were compliant. I would even further do checks on m_state and m_error in status/statusText, but it's technically not necessary since we do proper checks on the response variables; in other words, clearing the response nets the same effect as checking m_state/m_error in status/statusText. Firefox allows access to status, statusText, and all headers even after an abort. Opera throws DOM exceptions when accessing any of these fields after a response error/abort. Haven't tested IE yet. WebKit will allow access to status and statusText, but throw INVALID_STATE exceptions if trying to retrieve headers. WebKit is completely inconsistent, and out of the 3 tested browsers, the only inconsistent one. W3 says that an abort will both 1) set error flag to true, and 2) change the state to UNSENT. It also says that for status, statusText, and the header getter functions, that if the error flag is true or the status is < HEADERS_RECEIVED, that these response attributes/getters should return 0/""/null values. We don't follow the standard on status and statusText, and we throw an INVALID_STATE exception on the header getters. We should make ourselves consistent across the board; but that is a separate issue and we can open another bug for that discussion. With that said, this patch will get us "one step closer" to the W3 standard by making status and statusText behave according to spec. We can talk about the header getters and whether an exception is the right thing to do in another conversation. The spec I'll create the regression test(s) and report my findings in IE 6 & 8. 348730 15 ap 2011-02-09 17:22:08 -0800 If the spec doesn't match at least one of IE or Firefox, the spec just needs to be fixed. We should also fix our inconsistencies, of course. Depending on how much historical baggage we uncover, this choices may not be easy to make. Hopefully, sites don't use XMLHttpRequest.abort() all that much. 348735 16 jarred 2011-02-09 17:33:24 -0800 Yes that's true. If they do abort(), they apparently don't care about accessing statuses in Opera. If IE follows the Firefox approach then we have a hard decision to make. If IE is like Opera, then Firefox is the odd man out and we're golden. In my experience, I rarely abort; and when I do, I've never been interested in just the status code. But that's just me :) If I wanted the status code, I would just wait for readyState to be 2 and then get the code, and if later I wanted to abort, fine...I have the status code captured already. Meh. 348773 17 jarred 2011-02-09 19:10:22 -0800 Ok, so IE acts like Opera. It throws exceptions. 348776 18 81913 jarred 2011-02-09 19:33:53 -0800 Created attachment 81913 Proposed patch A different patch that doesn't change behavior and stays true to this bug. Will open a new bug regarding behavior (i.e. internal inconsistencies). 348840 19 81913 ap 2011-02-10 00:06:20 -0800 Comment on attachment 81913 Proposed patch Thanks for testing! I'd be fine with following the spec then, and just going with your original patch here (plus a regression test). The new function name is not so great, because it's not just buffers that are cleared. I'm going to say r+ with hope that this function will go away very soon. 348847 20 jarred 2011-02-10 00:18:07 -0800 (In reply to comment #19) > (From update of attachment 81913 [details]) > Thanks for testing! I'd be fine with following the spec then, and just going with your original patch here (plus a regression test). > > The new function name is not so great, because it's not just buffers that are cleared. I'm going to say r+ with hope that this function will go away very soon. See https://bugs.webkit.org/show_bug.cgi?id=54162 We could set this bug as depending upon 54162, and use the original patch (proper regression tests are in 54162). Let me know what you think. 351027 21 81913 jarred 2011-02-14 18:00:26 -0800 Comment on attachment 81913 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81913&action=review Well, might as well get it committed :) > Source/WebCore/xml/XMLHttpRequest.cpp:687 > + clearResponseBuffers(); they are all pretty much buffers (hold response data/binary), with the exception of m_createdDocument being a flag. 351338 22 81913 darin 2011-02-15 09:15:57 -0800 Comment on attachment 81913 Proposed patch I agree with Alexey about the fact that the name isn’t great. 351414 23 81913 commit-queue 2011-02-15 11:10:26 -0800 Comment on attachment 81913 Proposed patch Clearing flags on attachment: 81913 Committed r78591: <http://trac.webkit.org/changeset/78591> 351415 24 commit-queue 2011-02-15 11:10:32 -0800 All reviewed patches have been landed. Closing bug. 81831 2011-02-09 10:26:52 -0800 2011-02-09 10:38:07 -0800 Proposed patch clearResponse.patch text/plain 1121 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGM1M2E1Li40OTU0YjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMDkgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFhNTEh0dHBSZXF1 ZXN0OjphYm9ydCgpIHNob3VsZCBjYWxsIGNsZWFyUmVzcG9uc2UoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxMTgKKworICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6YWJvcnQpOgorCiAyMDExLTAyLTA5ICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVl c3QuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCBhNTQ4 ZWJjLi5jMmFkMjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVl c3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTY4 NCwxMiArNjg0LDcgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6YWJvcnQoKQogCiAgICAgaW50ZXJu YWxBYm9ydCgpOwogCi0gICAgbV9yZXNwb25zZUJ1aWxkZXIuY2xlYXIoKTsKLSAgICBtX2NyZWF0 ZWREb2N1bWVudCA9IGZhbHNlOwotICAgIG1fcmVzcG9uc2VYTUwgPSAwOwotI2lmIEVOQUJMRShY SFJfUkVTUE9OU0VfQkxPQikKLSAgICBtX3Jlc3BvbnNlQmxvYiA9IDA7Ci0jZW5kaWYKKyAgICBj bGVhclJlc3BvbnNlKCk7CiAKICAgICAvLyBDbGVhciBoZWFkZXJzIGFzIHJlcXVpcmVkIGJ5IHRo ZSBzcGVjCiAgICAgbV9yZXF1ZXN0SGVhZGVycy5jbGVhcigpOwo= 81833 2011-02-09 10:38:07 -0800 2011-02-09 10:39:50 -0800 Proposed patch clearResponse.patch text/plain 1717 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGM1M2E1Li43ZmUxZTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDItMDkgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFhNTEh0dHBSZXF1 ZXN0OjphYm9ydCgpIHNob3VsZCBjYWxsIGNsZWFyUmVzcG9uc2UoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxMTgKKworICAgICAgICBhYm9ydCgp IGlzIG5vdCBwcm9wZXJseSBjbGVhcmluZyBBcnJheUJ1ZmZlciBiaW5hcnkgYnVmZmVyZWQgZGF0 YS4gVGhpcworICAgICAgICBjaGFuZ2Ugd2lsbCByZW1vdmUgdGhlIGNsZWFudXAgY29kZSBmcm9t IGFib3J0KCkgYW5kIGluc3RlYWQgY2FsbAorICAgICAgICBjbGVhclJlc3BvbnNlKCkgdG8gZG8g dGhlIGNsZWFudXAsIHdoaWNoIG5vdCBkb2VzIHRoZSBvcmlnaW5hbCBhYm9ydCgpCisgICAgICAg IGNsZWFudXAsIGJ1dCBhbHNvIGNvdmVycyB0aGUgYmluYXJ5IHJlc3BvbnNlIGJ1ZmZlciBhcyB3 ZWxsLiBGdXR1cmUgY2xlYW51cAorICAgICAgICBvbWlzc2lvbnMgY2FuIGJlIGF2b2lkZWQgYnkg b25seSBoYXZpbmcgdG8gbWFpbnRhaW4gY2xlYXJSZXNwb25zZSgpLgorICAgICAgICAKKyAgICAg ICAgQ2xlYXJpbmcgdGhlIGRhdGEgb24gYWJvcnQoKSBpcyBtb3JlIG1lbW9yeSBlZmZpY2llbnQu ICBCeSBub3QgY2xlYXJpbmcKKyAgICAgICAgdGhpcyBkYXRhLCBpdCB3aWxsIHJlbWFpbiBpbiBt ZW1vcnkgdW50aWwgdGhlIFhIUiBvYmplY3QgaXMgY2xlYW5lZCB1cCBvcgorICAgICAgICB1bnRp bCBhIHN1YnNlcXVlbnQgY2FsbCB0byBvcGVuKCkuCisgICAgICAgIAorCisgICAgICAgICogeG1s L1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0Ojph Ym9ydCk6CisKIDIwMTEtMDItMDkgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M SHR0cFJlcXVlc3QuY3BwCmluZGV4IGE1NDhlYmMuLmMyYWQyNzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUveG1s L1hNTEh0dHBSZXF1ZXN0LmNwcApAQCAtNjg0LDEyICs2ODQsNyBAQCB2b2lkIFhNTEh0dHBSZXF1 ZXN0OjphYm9ydCgpCiAKICAgICBpbnRlcm5hbEFib3J0KCk7CiAKLSAgICBtX3Jlc3BvbnNlQnVp bGRlci5jbGVhcigpOwotICAgIG1fY3JlYXRlZERvY3VtZW50ID0gZmFsc2U7Ci0gICAgbV9yZXNw b25zZVhNTCA9IDA7Ci0jaWYgRU5BQkxFKFhIUl9SRVNQT05TRV9CTE9CKQotICAgIG1fcmVzcG9u c2VCbG9iID0gMDsKLSNlbmRpZgorICAgIGNsZWFyUmVzcG9uc2UoKTsKIAogICAgIC8vIENsZWFy IGhlYWRlcnMgYXMgcmVxdWlyZWQgYnkgdGhlIHNwZWMKICAgICBtX3JlcXVlc3RIZWFkZXJzLmNs ZWFyKCk7Cg== 81834 2011-02-09 10:39:50 -0800 2011-02-09 10:53:18 -0800 Proposed patch clearResponse.patch text/plain 1722 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGM1M2E1Li5kODkzZmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDItMDkgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFhNTEh0dHBSZXF1 ZXN0OjphYm9ydCgpIHNob3VsZCBjYWxsIGNsZWFyUmVzcG9uc2UoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxMTgKKworICAgICAgICBhYm9ydCgp IGlzIG5vdCBwcm9wZXJseSBjbGVhcmluZyBBcnJheUJ1ZmZlciBiaW5hcnkgYnVmZmVyZWQgZGF0 YS4gVGhpcworICAgICAgICBjaGFuZ2Ugd2lsbCByZW1vdmUgdGhlIGNsZWFudXAgY29kZSBmcm9t IGFib3J0KCkgYW5kIGluc3RlYWQgY2FsbAorICAgICAgICBjbGVhclJlc3BvbnNlKCkgdG8gZG8g dGhlIGNsZWFudXAsIHdoaWNoIG5vdCBvbmx5IGRvZXMgdGhlIG9yaWdpbmFsIGFib3J0KCkKKyAg ICAgICAgY2xlYW51cCwgYnV0IGFsc28gY292ZXJzIHRoZSBiaW5hcnkgcmVzcG9uc2UgYnVmZmVy IGFzIHdlbGwuIEZ1dHVyZSBjbGVhbnVwCisgICAgICAgIG9taXNzaW9ucyBjYW4gYmUgYXZvaWRl ZCBieSBvbmx5IGhhdmluZyB0byBtYWludGFpbiBjbGVhclJlc3BvbnNlKCkuCisgICAgICAgIAor ICAgICAgICBDbGVhcmluZyB0aGUgZGF0YSBvbiBhYm9ydCgpIGlzIG1vcmUgbWVtb3J5IGVmZmlj aWVudC4gIEJ5IG5vdCBjbGVhcmluZworICAgICAgICB0aGlzIGRhdGEsIGl0IHdpbGwgcmVtYWlu IGluIG1lbW9yeSB1bnRpbCB0aGUgWEhSIG9iamVjdCBpcyBjbGVhbmVkIHVwIG9yCisgICAgICAg IHVudGlsIGEgc3Vic2VxdWVudCBjYWxsIHRvIG9wZW4oKS4KKyAgICAgICAgCisKKyAgICAgICAg KiB4bWwvWE1MSHR0cFJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVl c3Q6OmFib3J0KToKKwogMjAxMS0wMi0wOSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YTUxIdHRwUmVxdWVzdC5jcHAKaW5kZXggYTU0OGViYy4uYzJhZDI3MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCkBAIC02ODQsMTIgKzY4NCw3IEBAIHZvaWQgWE1MSHR0 cFJlcXVlc3Q6OmFib3J0KCkKIAogICAgIGludGVybmFsQWJvcnQoKTsKIAotICAgIG1fcmVzcG9u c2VCdWlsZGVyLmNsZWFyKCk7Ci0gICAgbV9jcmVhdGVkRG9jdW1lbnQgPSBmYWxzZTsKLSAgICBt X3Jlc3BvbnNlWE1MID0gMDsKLSNpZiBFTkFCTEUoWEhSX1JFU1BPTlNFX0JMT0IpCi0gICAgbV9y ZXNwb25zZUJsb2IgPSAwOwotI2VuZGlmCisgICAgY2xlYXJSZXNwb25zZSgpOwogCiAgICAgLy8g Q2xlYXIgaGVhZGVycyBhcyByZXF1aXJlZCBieSB0aGUgc3BlYwogICAgIG1fcmVxdWVzdEhlYWRl cnMuY2xlYXIoKTsK 81836 2011-02-09 10:53:18 -0800 2011-02-09 19:33:53 -0800 Proposed patch clearResponse.patch text/plain 1245 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGM1M2E1Li4xMmVkZmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDItMDkgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFhNTEh0dHBSZXF1 ZXN0OjphYm9ydCgpIHNob3VsZCBjYWxsIGNsZWFyUmVzcG9uc2UoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxMTgKKworICAgICAgICBDYWxsaW5n IGNsZWFyUmVzcG9uc2UgZnJlZXMgbW9yZSBtZW1vcnkgYXQgYWJvcnQgdGltZS4KKworICAgICAg ICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBvYnNlcnZhYmxlIGVmZmVjdCBleGNl cHQgZm9yIGxlc3MgbWVtb3J5IHVzZWQuCisKKyAgICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3Qu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmFib3J0KToKKwogMjAxMS0w Mi0wOSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hN TEh0dHBSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAK aW5kZXggYTU0OGViYy4uYzJhZDI3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hN TEh0dHBSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3Qu Y3BwCkBAIC02ODQsMTIgKzY4NCw3IEBAIHZvaWQgWE1MSHR0cFJlcXVlc3Q6OmFib3J0KCkKIAog ICAgIGludGVybmFsQWJvcnQoKTsKIAotICAgIG1fcmVzcG9uc2VCdWlsZGVyLmNsZWFyKCk7Ci0g ICAgbV9jcmVhdGVkRG9jdW1lbnQgPSBmYWxzZTsKLSAgICBtX3Jlc3BvbnNlWE1MID0gMDsKLSNp ZiBFTkFCTEUoWEhSX1JFU1BPTlNFX0JMT0IpCi0gICAgbV9yZXNwb25zZUJsb2IgPSAwOwotI2Vu ZGlmCisgICAgY2xlYXJSZXNwb25zZSgpOwogCiAgICAgLy8gQ2xlYXIgaGVhZGVycyBhcyByZXF1 aXJlZCBieSB0aGUgc3BlYwogICAgIG1fcmVxdWVzdEhlYWRlcnMuY2xlYXIoKTsK 81913 2011-02-09 19:33:53 -0800 2011-02-15 11:10:26 -0800 Proposed patch clearResponse.patch text/plain 2000 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZDZlMDM5Li5lNGE3MjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDItMDkgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5jaGEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFhNTEh0dHBSZXF1 ZXN0OjphYm9ydCgpIGRvZXNuJ3QgY2xlYXIgcmVzcG9uc2UgZGF0YQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxMTgKKworICAgICAgICBQcm9wZXJs eSBjbGVhciBhbGwgYnVmZmVyIGRhdGEgb24gYWJvcnQsIHNvIG5vIG1lbW9yeSBoYW5ncyBhcm91 bmQgdW5uZWNlc3NhcmlseS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBp cyBubyBvYnNlcnZhYmxlIGVmZmVjdCBleGNlcHQgZm9yIGxlc3MgbWVtb3J5IHVzZWQuCisKKyAg ICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0 cFJlcXVlc3Q6OmFib3J0KToKKwogMjAxMS0wMi0wOSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNv cmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCBhNTQ4ZWJjLi4wNDc2YmI0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTY4NCwxMiArNjg0LDcgQEAgdm9pZCBY TUxIdHRwUmVxdWVzdDo6YWJvcnQoKQogCiAgICAgaW50ZXJuYWxBYm9ydCgpOwogCi0gICAgbV9y ZXNwb25zZUJ1aWxkZXIuY2xlYXIoKTsKLSAgICBtX2NyZWF0ZWREb2N1bWVudCA9IGZhbHNlOwot ICAgIG1fcmVzcG9uc2VYTUwgPSAwOwotI2lmIEVOQUJMRShYSFJfUkVTUE9OU0VfQkxPQikKLSAg ICBtX3Jlc3BvbnNlQmxvYiA9IDA7Ci0jZW5kaWYKKyAgICBjbGVhclJlc3BvbnNlQnVmZmVycygp OwogCiAgICAgLy8gQ2xlYXIgaGVhZGVycyBhcyByZXF1aXJlZCBieSB0aGUgc3BlYwogICAgIG1f cmVxdWVzdEhlYWRlcnMuY2xlYXIoKTsKQEAgLTczMyw2ICs3MjgsMTEgQEAgdm9pZCBYTUxIdHRw UmVxdWVzdDo6aW50ZXJuYWxBYm9ydCgpCiB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpjbGVhclJlc3Bv bnNlKCkKIHsKICAgICBtX3Jlc3BvbnNlID0gUmVzb3VyY2VSZXNwb25zZSgpOworICAgIGNsZWFy UmVzcG9uc2VCdWZmZXJzKCk7Cit9CisKK3ZvaWQgWE1MSHR0cFJlcXVlc3Q6OmNsZWFyUmVzcG9u c2VCdWZmZXJzKCkKK3sKICAgICBtX3Jlc3BvbnNlQnVpbGRlci5jbGVhcigpOwogICAgIG1fY3Jl YXRlZERvY3VtZW50ID0gZmFsc2U7CiAgICAgbV9yZXNwb25zZVhNTCA9IDA7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YTUxIdHRwUmVxdWVzdC5oCmluZGV4IDM4NGE4NDYuLjFmMDc4YTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YTUxIdHRwUmVxdWVzdC5oCkBAIC0xNzMsNiArMTczLDcgQEAgcHJpdmF0ZToKICAgICB2b2lk IGRyb3BQcm90ZWN0aW9uKCk7CiAgICAgdm9pZCBpbnRlcm5hbEFib3J0KCk7CiAgICAgdm9pZCBj bGVhclJlc3BvbnNlKCk7CisgICAgdm9pZCBjbGVhclJlc3BvbnNlQnVmZmVycygpOwogICAgIHZv aWQgY2xlYXJSZXF1ZXN0KCk7CiAKICAgICB2b2lkIGNyZWF0ZVJlcXVlc3QoRXhjZXB0aW9uQ29k ZSYpOwo=