54107 2011-02-09 08:15:41 -0800 Remove explicit disable ENABLE_ASSEMBLER_WX_EXCLUSIVE on non-iOS ports 2011-02-13 02:20:08 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 1 dbates dbates abarth barraclough eric ggaren webkit.review.bot oldest_to_newest 348248 0 dbates 2011-02-09 08:15:41 -0800 By the definition of ENABLE() (http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/Platform.h?rev=78042#L55), it is unnecessary to explicitly disable ENABLE_ASSEMBLER_WX_EXCLUSIVE on non-iOS ports. 348251 1 81816 dbates 2011-02-09 08:30:33 -0800 Created attachment 81816 Patch 350068 2 81816 ggaren 2011-02-11 14:58:58 -0800 Comment on attachment 81816 Patch r=me 350203 3 81816 dbates 2011-02-11 18:42:48 -0800 Comment on attachment 81816 Patch Clearing flags on attachment: 81816 Committed r78402: <http://trac.webkit.org/changeset/78402> 350204 4 dbates 2011-02-11 18:42:54 -0800 All reviewed patches have been landed. Closing bug. 350373 5 webkit.review.bot 2011-02-13 02:20:08 -0800 http://trac.webkit.org/changeset/78402 might have broken SnowLeopard Intel Release (WebKit2 Tests) The following tests are not passing: fast/loader/empty-embed-src-attribute.html 81816 2011-02-09 08:30:33 -0800 2011-02-11 18:42:48 -0800 Patch bug-54107-20110209082741.patch text/plain 1236 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzgwNTUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDItMDkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBleHBsaWNpdCBkaXNh YmxlIEVOQUJMRV9BU1NFTUJMRVJfV1hfRVhDTFVTSVZFIG9uIG5vbi1pT1MgcG9ydHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MTA3CisgICAgICAg IAorICAgICAgICBJdCBpcyB1bm5lY2Vzc2FyeSB0byBleHBsaWNpdGx5IGRpc2FibGUgRU5BQkxF X0FTU0VNQkxFUl9XWF9FWENMVVNJVkUKKyAgICAgICAgYnkgdGhlIGRlZmluaXRpb24gb2YgRU5B QkxFKCkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxMS0wMi0wOSAgUGV0ZXIg VmFyZ2EgIDxwdmFyZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBC YXJyYWNsb3VnaC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlz aW9uIDc4MDU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMDUwLDggKzEwNTAsNiBAQAogICAgc2VjdXJpdHkgYnV0IGN1cnJlY3Rs eSBjb21lcyBhdCBhIHNpZ25pZmljYW50IHBlcmZvcm1hbmNlIGNvc3QuICovCiAjaWYgUExBVEZP Uk0oSU9TKQogI2RlZmluZSBFTkFCTEVfQVNTRU1CTEVSX1dYX0VYQ0xVU0lWRSAxCi0jZWxzZQot I2RlZmluZSBFTkFCTEVfQVNTRU1CTEVSX1dYX0VYQ0xVU0lWRSAwCiAjZW5kaWYKIAogLyogUGlj ayB3aGljaCBhbGxvY2F0b3IgdG8gdXNlOyB3ZSBvbmx5IG5lZWQgYW4gZXhlY3V0YWJsZSBhbGxv Y2F0b3IgaWYgdGhlIGFzc2VtYmxlciBpcyBjb21waWxlZCBpbi4K