54092 2011-02-09 05:12:38 -0800 Extra separator after Select All in context menu 2011-04-26 16:57:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 christian webkit-unassigned commit-queue oldest_to_newest 348165 0 christian 2011-02-09 05:12:38 -0800 There is an extra separator after Select All in the context menu. 348172 1 81794 christian 2011-02-09 05:53:57 -0800 Created attachment 81794 Move spelling option menu separator to non-GTK+port guards The separator comes from the spelling option menu which the GTK+ port doesn't show. So the separator needs to be moved into non-GTK+ port guards. 350673 2 81794 gustavo 2011-02-14 08:33:40 -0800 Comment on attachment 81794 Move spelling option menu separator to non-GTK+port guards View in context: https://bugs.webkit.org/attachment.cgi?id=81794&action=review > Source/WebCore/page/ContextMenuController.cpp:894 > #ifndef BUILDING_ON_TIGER > #if !PLATFORM(GTK) > + appendItem(*separatorItem(), m_contextMenu.get()); This looks right ot me, but we're also affecting Mac here. Although it does look like it would work as intended for them as well, better check with someone from mac land. 383467 3 81794 bfulgham 2011-04-11 13:49:49 -0700 Comment on attachment 81794 Move spelling option menu separator to non-GTK+port guards View in context: https://bugs.webkit.org/attachment.cgi?id=81794&action=review >> Source/WebCore/page/ContextMenuController.cpp:894 >> + appendItem(*separatorItem(), m_contextMenu.get()); > > This looks right ot me, but we're also affecting Mac here. Although it does look like it would work as intended for them as well, better check with someone from mac land. This may not do the right thing for Tiger builds. The append will only happen for more recent OS versions, but perhaps no one cares anymore? 392823 4 81794 eric 2011-04-26 15:29:50 -0700 Comment on attachment 81794 Move spelling option menu separator to non-GTK+port guards Looks fine. If this doesn't break anything in the CQ, it's fine. Please let the cq land it to be sure. 393095 5 81794 commit-queue 2011-04-26 16:57:48 -0700 Comment on attachment 81794 Move spelling option menu separator to non-GTK+port guards Clearing flags on attachment: 81794 Committed r84983: <http://trac.webkit.org/changeset/84983> 393096 6 commit-queue 2011-04-26 16:57:51 -0700 All reviewed patches have been landed. Closing bug. 81794 2011-02-09 05:53:57 -0800 2011-04-26 16:57:48 -0700 Move spelling option menu separator to non-GTK+port guards 0001-Extra-separator-after-Select-All-in-context-menu.diff text/plain 1876 christian RnJvbSA4ZGQxMWUzYzcwNzU5OThjMjMyYzY5YThlY2U1N2VhZWQ0ZjJjNmJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRHl3YW4gPGNocmlzdGlhbkB0d290b2FzdHMu ZGU+CkRhdGU6IFdlZCwgOSBGZWIgMjAxMSAxNDo1MjoyMSArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IEV4dHJhIHNlcGFyYXRvciBhZnRlciBTZWxlY3QgQWxsIGluIGNvbnRleHQgbWVudQogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MDkyCgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwOiBNb3ZlIHNlcGFy YXRvciB0byBub24tR1RLKwogICAgcG9ydCBndWFyZHMgc2luY2UgaXQgaXMgZm9yIHRoZSBzcGVs bGluZyBvcHRpb25zIG1lbnUKICAgIHdoaWNoIHRoZSBHVEsrIHBvcnQgZG9lc24ndCB1c2UuCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IGU5MDEyNjcuLmJlZmVmNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxMS0wMi0wOSAgQ2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQGxhbmVkby5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXh0cmEgc2Vw YXJhdG9yIGFmdGVyIFNlbGVjdCBBbGwgaW4gY29udGV4dCBtZW51CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDA5MgorCisgICAgICAgICogcGFnZS9D b250ZXh0TWVudUNvbnRyb2xsZXIuY3BwOiBNb3ZlIHNlcGFyYXRvciB0byBub24tR1RLKworICAg ICAgICAgICAgcG9ydCBndWFyZHMgc2luY2UgaXQgaXMgZm9yIHRoZSBzcGVsbGluZyBvcHRpb25z IG1lbnUKKyAgICAgICAgICAgIHdoaWNoIHRoZSBHVEsrIHBvcnQgZG9lc24ndCB1c2UuCisKIDIw MTEtMDItMDkgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRN ZW51Q29udHJvbGxlci5jcHAKaW5kZXggMzZhYzg5ZC4uZTM2NWM5ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmNwcApAQCAtODg5LDkgKzg4OSw5IEBA IHZvaWQgQ29udGV4dE1lbnVDb250cm9sbGVyOjpwb3B1bGF0ZSgpCiAjZW5kaWYKIAogICAgICAg ICBpZiAoIWluUGFzc3dvcmRGaWVsZCkgewotICAgICAgICAgICAgYXBwZW5kSXRlbSgqc2VwYXJh dG9ySXRlbSgpLCBtX2NvbnRleHRNZW51LmdldCgpKTsKICNpZm5kZWYgQlVJTERJTkdfT05fVElH RVIKICNpZiAhUExBVEZPUk0oR1RLKQorICAgICAgICAgICAgYXBwZW5kSXRlbSgqc2VwYXJhdG9y SXRlbSgpLCBtX2NvbnRleHRNZW51LmdldCgpKTsKICAgICAgICAgICAgIENvbnRleHRNZW51SXRl bSBTcGVsbGluZ0FuZEdyYW1tYXJNZW51SXRlbShTdWJtZW51VHlwZSwgQ29udGV4dE1lbnVJdGVt VGFnU3BlbGxpbmdNZW51LCAKICAgICAgICAgICAgICAgICBjb250ZXh0TWVudUl0ZW1UYWdTcGVs bGluZ01lbnUoKSk7CiAgICAgICAgICAgICBjcmVhdGVBbmRBcHBlbmRTcGVsbGluZ0FuZEdyYW1t YXJTdWJNZW51KFNwZWxsaW5nQW5kR3JhbW1hck1lbnVJdGVtKTsKLS0gCjEuNy4zLjUKCg==