5409 2005-10-17 23:23:49 -0700 slice() testcase doesn't pass 2005-11-05 21:55:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Other Linux RESOLVED FIXED P2 Normal --- 1 staikos ggaren oldest_to_newest 22198 0 staikos 2005-10-17 23:23:49 -0700 String slice() testcases are not passing. attached KJS patch fixes it. It should be fairly easy to merge by hand. 22199 1 4394 staikos 2005-10-17 23:24:17 -0700 Created attachment 4394 patch to fix slice() in KJS 22200 2 4394 mjs 2005-10-17 23:31:53 -0700 Comment on attachment 4394 patch to fix slice() in KJS George and I discussed how it would be safer against extreme values ot use toInteger and leave things as double until after the range check, but I think it's still an improvement to merge this fix from KJS. 22220 3 4394 darin 2005-10-18 09:55:30 -0700 Comment on attachment 4394 patch to fix slice() in KJS The standard is clear on this point: toUInt32 is incorrect, toInteger is correct. But that's a bug that can be fixed separately. 22868 4 ggaren 2005-10-24 19:42:41 -0700 Filed a new bug to track using toInteger: 5490. 22870 5 4466 ggaren 2005-10-24 20:13:14 -0700 Created attachment 4466 Revised Patch Psych. Decided to fix it myself here. Also fixed the end == undefined case. 22912 6 4466 darin 2005-10-25 08:16:52 -0700 Comment on attachment 4466 Revised Patch There are a few examples here of braces for single lines. That doesn't match our coding style. Also, I prefer just doing a return to setting the value of String. Finally, I'd like test cases for what you fixed here. But it looks good to me, so review+ anyway. 23768 7 ggaren 2005-11-05 21:55:32 -0800 I removed the single braces and added a layout test for the cases not covered by the mozilla test suite before landing. I felt iffy about returning immediately rather than setting result, though. Setting result is the idiom for StringProtoFuncImp::callAsFunction. If we don't like that idiom, I think we should file a separate bug and change all cases of it in the function, rather than creating an idiosyncracy for this one case. 4394 2005-10-17 23:24:17 -0700 2005-10-24 20:13:14 -0700 patch to fix slice() in KJS slice.patch text/plain 1225 staikos SW5kZXg6IHN0cmluZ19vYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN0cmluZ19vYmplY3QuY3Bw CShyZXZpc2lvbiA0Njk3MDIpCisrKyBzdHJpbmdfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDA1LDIwICs0MDUsMjMgQEAKICAgICB7CiAgICAgICAgIC8vIFRoZSBhcmcgcHJvY2Vzc2lu ZyBpcyB2ZXJ5IG11Y2ggbGlrZSBBcnJheVByb3RvRnVuYzo6U2xpY2UKICAgICAgICAgaW50IGJl Z2luID0gYXJnc1swXS50b1VJbnQzMihleGVjKTsKLSAgICAgICAgaWYgKGJlZ2luIDwgMCkKLSAg ICAgICAgICBiZWdpbiA9IG1heEludChiZWdpbiArIGxlbiwgMCk7Ci0gICAgICAgIGVsc2UKLSAg ICAgICAgICBiZWdpbiA9IG1pbkludChiZWdpbiwgbGVuKTsKICAgICAgICAgaW50IGVuZCA9IGxl bjsKICAgICAgICAgaWYgKGFyZ3NbMV0udHlwZSgpICE9IFVuZGVmaW5lZFR5cGUpIHsKICAgICAg ICAgICBlbmQgPSBhcmdzWzFdLnRvSW50ZWdlcihleGVjKTsKLSAgICAgICAgICBpZiAoZW5kIDwg MCkKLSAgICAgICAgICAgIGVuZCA9IG1heEludChsZW4gKyBlbmQsIDApOwotICAgICAgICAgIGVs c2UKLSAgICAgICAgICAgIGVuZCA9IG1pbkludChlbmQsIGxlbik7CiAgICAgICAgIH0KLSAgICAg ICAgLy9wcmludGYoICJTbGljaW5nIGZyb20gJWQgdG8gJWQgXG4iLCBiZWdpbiwgZW5kICk7Ci0g ICAgICAgIHJlc3VsdCA9IFN0cmluZyhzLnN1YnN0cihiZWdpbiwgZW5kLWJlZ2luKSk7CisgICAg ICAgIGludCBmcm9tID0gYmVnaW4gPCAwID8gbGVuICsgYmVnaW4gOiBiZWdpbjsKKyAgICAgICAg aW50IHRvID0gZW5kIDwgMCA/IGxlbiArIGVuZCA6IGVuZDsKKyAgICAgICAgaWYgKHRvID4gZnJv bSAmJiB0byA+IDAgJiYgZnJvbSA8IGxlbikgeworICAgICAgICAgIGlmIChmcm9tIDwgMCkgewor ICAgICAgICAgICAgZnJvbSA9IDA7CisgICAgICAgICAgfQorICAgICAgICAgIGlmICh0byA+IGxl bikgeworICAgICAgICAgICAgdG8gPSBsZW47CisgICAgICAgICAgfQorICAgICAgICAgIHJlc3Vs dCA9IFN0cmluZyhzLnN1YnN0cihmcm9tLCB0byAtIGZyb20pKTsKKyAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICByZXN1bHQgPSBTdHJpbmcoIiIpOworICAgICAgICB9CiAgICAgICAgIGJyZWFr OwogICAgIH0KICAgICBjYXNlIFNwbGl0OiB7Cg== 4466 2005-10-24 20:13:14 -0700 2005-10-25 08:16:52 -0700 Revised Patch patch.txt text/plain 1963 ggaren SW5kZXg6IGtqcy9zdHJpbmdfb2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvSmF2YVNjcmlwdENvcmUva2pzL3N0cmluZ19vYmplY3QuY3BwLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjQ5CmRpZmYgLXAgLXUgLXIxLjQ5IGtqcy9zdHJpbmdfb2JqZWN0LmNwcAotLS0ga2pz L3N0cmluZ19vYmplY3QuY3BwCTExIE9jdCAyMDA1IDIwOjQzOjQ5IC0wMDAwCTEuNDkKKysrIGtq cy9zdHJpbmdfb2JqZWN0LmNwcAkyNSBPY3QgMjAwNSAwMzoxMzowMyAtMDAwMApAQCAtNTEwLDMx ICs1MTAsMjMgQEAgVmFsdWVJbXAgKlN0cmluZ1Byb3RvRnVuY0ltcDo6Y2FsbEFzRnVuYwogICAg IGJyZWFrOwogICBjYXNlIFNsaWNlOgogICAgIHsKLSAgICAgICAgLy8gVGhlIGFyZyBwcm9jZXNz aW5nIGlzIHZlcnkgbXVjaCBsaWtlIEFycmF5UHJvdG9GdW5jOjpTbGljZQotICAgICAgICBkb3Vi bGUgYmVnaW4gPSBhcmdzWzBdLT50b0ludGVnZXIoZXhlYyk7Ci0gICAgICAgIGlmIChiZWdpbiA+ PSAwKSB7IC8vIGZhbHNlIGZvciBOYU4KLSAgICAgICAgICBpZiAoYmVnaW4gPiBsZW4pCi0gICAg ICAgICAgICBiZWdpbiA9IGxlbjsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICBiZWdpbiAr PSBsZW47Ci0gICAgICAgICAgaWYgKCEoYmVnaW4gPj0gMCkpIC8vIHRydWUgZm9yIE5hTgotICAg ICAgICAgICAgYmVnaW4gPSAwOworICAgICAgLy8gVGhlIGFyZyBwcm9jZXNzaW5nIGlzIHZlcnkg bXVjaCBsaWtlIEFycmF5UHJvdG9GdW5jOjpTbGljZQorICAgICAgZG91YmxlIHN0YXJ0ID0gYTAt PnRvSW50ZWdlcihleGVjKTsKKyAgICAgIGRvdWJsZSBlbmQgPSBhMS0+aXNVbmRlZmluZWQoKSA/ IGxlbiA6IGExLT50b0ludGVnZXIoZXhlYyk7CisgICAgICBkb3VibGUgZnJvbSA9IHN0YXJ0IDwg MCA/IGxlbiArIHN0YXJ0IDogc3RhcnQ7CisgICAgICBkb3VibGUgdG8gPSBlbmQgPCAwID8gbGVu ICsgZW5kIDogZW5kOworICAgICAgaWYgKHRvID4gZnJvbSAmJiB0byA+IDAgJiYgZnJvbSA8IGxl bikgeworICAgICAgICBpZiAoZnJvbSA8IDApIHsKKyAgICAgICAgICBmcm9tID0gMDsKICAgICAg ICAgfQotICAgICAgICBkb3VibGUgZW5kID0gbGVuOwotICAgICAgICBpZiAoIWFyZ3NbMV0tPmlz VW5kZWZpbmVkKCkpIHsKLSAgICAgICAgICBlbmQgPSBhcmdzWzFdLT50b0ludGVnZXIoZXhlYyk7 Ci0gICAgICAgICAgaWYgKGVuZCA+PSAwKSB7IC8vIGZhbHNlIGZvciBOYU4KLSAgICAgICAgICAg IGlmIChlbmQgPiBsZW4pCi0gICAgICAgICAgICAgIGVuZCA9IGxlbjsKLSAgICAgICAgICB9IGVs c2UgewotICAgICAgICAgICAgZW5kICs9IGxlbjsKLSAgICAgICAgICAgIGlmICghKGVuZCA+PSAw KSkgLy8gdHJ1ZSBmb3IgTmFOCi0gICAgICAgICAgICAgIGVuZCA9IDA7Ci0gICAgICAgICAgfQor ICAgICAgICBpZiAodG8gPiBsZW4pIHsKKyAgICAgICAgICB0byA9IGxlbjsKICAgICAgICAgfQot ICAgICAgICAvL3ByaW50ZiggIlNsaWNpbmcgZnJvbSAlZCB0byAlZCBcbiIsIGJlZ2luLCBlbmQg KTsKLSAgICAgICAgcmVzdWx0ID0gU3RyaW5nKHMuc3Vic3RyKHN0YXRpY19jYXN0PGludD4oYmVn aW4pLCBzdGF0aWNfY2FzdDxpbnQ+KGVuZC1iZWdpbikpKTsKLSAgICAgICAgYnJlYWs7CisgICAg ICAgIHJlc3VsdCA9IFN0cmluZyhzLnN1YnN0cihzdGF0aWNfY2FzdDxpbnQ+KGZyb20pLCBzdGF0 aWNfY2FzdDxpbnQ+KHRvIC0gZnJvbSkpKTsKKyAgICAgIH0gZWxzZSB7CisgICAgICAgIHJlc3Vs dCA9IFN0cmluZygiIik7CisgICAgICB9CisgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBT cGxpdDogewogICAgIE9iamVjdEltcCAqY29uc3RydWN0b3IgPSBleGVjLT5sZXhpY2FsSW50ZXJw cmV0ZXIoKS0+YnVpbHRpbkFycmF5KCk7Cg==