54059 2011-02-08 21:18:20 -0800 Crash when going back/forward when back/forward list is in a bad state. 2011-02-08 21:40:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 347939 0 mjs 2011-02-08 21:18:20 -0800 Crash when going back/forward when back/forward list is in a bad state. 347942 1 81742 mjs 2011-02-08 21:20:38 -0800 Created attachment 81742 Patch 347948 2 81742 mrowe 2011-02-08 21:26:11 -0800 Comment on attachment 81742 Patch Local variables for m_backForwardList->forwardItem() and m_backForwardList->backItem() could make this clearer since each of those is called four times within the function. 347954 3 81743 mjs 2011-02-08 21:36:29 -0800 Created attachment 81743 Patch 347957 4 mjs 2011-02-08 21:40:20 -0800 Committed r78015: <http://trac.webkit.org/changeset/78015> 81742 2011-02-08 21:20:38 -0800 2011-02-08 21:36:26 -0800 Patch bug-54059-20110208212036.patch text/plain 1727 mjs SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MDEzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDggIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDcmFzaCB3aGVuIGdvaW5nIGJhY2svZm9yd2FyZCB3aGVuIGJh Y2svZm9yd2FyZCBsaXN0IGlzIGluIGEgYmFkIHN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQwNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzg5NzUyNDQ+CisgICAgICAgIAorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmdvRm9yd2FyZCk6IEFkZCBhIG51bGwg Y2hlY2suCisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Z29CYWNrKTogZGl0dG8KKwog MjAxMS0wMi0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gNzc5MTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDA4LDcgKzQwOCw4 IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpnb0ZvcndhcmQoKQogICAgIGlmIChpc1ZhbGlkKCkgJiYg IWNhbkdvRm9yd2FyZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBzZXRQZW5kaW5nQVBJUmVx dWVzdFVSTChtX2JhY2tGb3J3YXJkTGlzdC0+Zm9yd2FyZEl0ZW0oKS0+dXJsKCkpOworICAgIGlm IChtX2JhY2tGb3J3YXJkTGlzdC0+Zm9yd2FyZEl0ZW0oKSkKKyAgICAgICAgc2V0UGVuZGluZ0FQ SVJlcXVlc3RVUkwobV9iYWNrRm9yd2FyZExpc3QtPmZvcndhcmRJdGVtKCktPnVybCgpKTsKIAog ICAgIGlmICghaXNWYWxpZCgpKSB7CiAgICAgICAgIHJlYXR0YWNoVG9XZWJQcm9jZXNzV2l0aEl0 ZW0obV9iYWNrRm9yd2FyZExpc3QtPmZvcndhcmRJdGVtKCkpOwpAQCAtNDI4LDcgKzQyOSw4IEBA IHZvaWQgV2ViUGFnZVByb3h5Ojpnb0JhY2soKQogICAgIGlmIChpc1ZhbGlkKCkgJiYgIWNhbkdv QmFjaygpKQogICAgICAgICByZXR1cm47CiAKLSAgICBzZXRQZW5kaW5nQVBJUmVxdWVzdFVSTCht X2JhY2tGb3J3YXJkTGlzdC0+YmFja0l0ZW0oKS0+dXJsKCkpOworICAgIGlmIChtX2JhY2tGb3J3 YXJkTGlzdC0+YmFja0l0ZW0oKSkKKyAgICAgICAgc2V0UGVuZGluZ0FQSVJlcXVlc3RVUkwobV9i YWNrRm9yd2FyZExpc3QtPmJhY2tJdGVtKCktPnVybCgpKTsKIAogICAgIGlmICghaXNWYWxpZCgp KSB7CiAgICAgICAgIHJlYXR0YWNoVG9XZWJQcm9jZXNzV2l0aEl0ZW0obV9iYWNrRm9yd2FyZExp c3QtPmJhY2tJdGVtKCkpOwo= 81743 2011-02-08 21:36:29 -0800 2011-02-08 21:38:52 -0800 Patch bug-54059-20110208213628.patch text/plain 2407 mjs SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MDEzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDggIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDcmFzaCB3aGVuIGdvaW5nIGJhY2svZm9yd2FyZCB3aGVuIGJh Y2svZm9yd2FyZCBsaXN0IGlzIGluIGEgYmFkIHN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQwNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzg5NzUyNDQ+CisgICAgICAgIAorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmdvRm9yd2FyZCk6IEFkZCBhIG51bGwg Y2hlY2suCisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Z29CYWNrKTogZGl0dG8KKwog MjAxMS0wMi0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gNzc5MTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDA4LDE0ICs0MDgs MTYgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmdvRm9yd2FyZCgpCiAgICAgaWYgKGlzVmFsaWQoKSAm JiAhY2FuR29Gb3J3YXJkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHNldFBlbmRpbmdBUElS ZXF1ZXN0VVJMKG1fYmFja0ZvcndhcmRMaXN0LT5mb3J3YXJkSXRlbSgpLT51cmwoKSk7CisgICAg V2ViQmFja0ZvcndhcmRMaXN0SXRlbSogZm9yd2FyZEl0ZW0gPSBtX2JhY2tGb3J3YXJkTGlzdC0+ Zm9yd2FyZEl0ZW0oKTsKKyAgICBpZiAoZm9yd2FyZEl0ZW0pCisgICAgICAgIHNldFBlbmRpbmdB UElSZXF1ZXN0VVJMKGZvcndhcmRJdGVtLT51cmwoKSk7CiAKICAgICBpZiAoIWlzVmFsaWQoKSkg ewotICAgICAgICByZWF0dGFjaFRvV2ViUHJvY2Vzc1dpdGhJdGVtKG1fYmFja0ZvcndhcmRMaXN0 LT5mb3J3YXJkSXRlbSgpKTsKKyAgICAgICAgcmVhdHRhY2hUb1dlYlByb2Nlc3NXaXRoSXRlbShm b3J3YXJkSXRlbSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBwcm9jZXNzKCktPnNl bmQoTWVzc2FnZXM6OldlYlBhZ2U6OkdvRm9yd2FyZChtX2JhY2tGb3J3YXJkTGlzdC0+Zm9yd2Fy ZEl0ZW0oKS0+aXRlbUlEKCkpLCBtX3BhZ2VJRCk7CisgICAgcHJvY2VzcygpLT5zZW5kKE1lc3Nh Z2VzOjpXZWJQYWdlOjpHb0ZvcndhcmQoZm9yd2FyZEl0ZW0tPml0ZW1JRCgpKSwgbV9wYWdlSUQp OwogfQogCiBib29sIFdlYlBhZ2VQcm94eTo6Y2FuR29Gb3J3YXJkKCkgY29uc3QKQEAgLTQyOCwx NCArNDMwLDE2IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpnb0JhY2soKQogICAgIGlmIChpc1ZhbGlk KCkgJiYgIWNhbkdvQmFjaygpKQogICAgICAgICByZXR1cm47CiAKLSAgICBzZXRQZW5kaW5nQVBJ UmVxdWVzdFVSTChtX2JhY2tGb3J3YXJkTGlzdC0+YmFja0l0ZW0oKS0+dXJsKCkpOworICAgIFdl YkJhY2tGb3J3YXJkTGlzdEl0ZW0qIGJhY2tJdGVtID0gbV9iYWNrRm9yd2FyZExpc3QtPmJhY2tJ dGVtKCk7CisgICAgaWYgKGJhY2tJdGVtKQorICAgICAgICBzZXRQZW5kaW5nQVBJUmVxdWVzdFVS TChiYWNrSXRlbS0+dXJsKCkpOwogCiAgICAgaWYgKCFpc1ZhbGlkKCkpIHsKLSAgICAgICAgcmVh dHRhY2hUb1dlYlByb2Nlc3NXaXRoSXRlbShtX2JhY2tGb3J3YXJkTGlzdC0+YmFja0l0ZW0oKSk7 CisgICAgICAgIHJlYXR0YWNoVG9XZWJQcm9jZXNzV2l0aEl0ZW0oYmFja0l0ZW0pOwogICAgICAg ICByZXR1cm47CiAgICAgfQogCi0gICAgcHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdl OjpHb0JhY2sobV9iYWNrRm9yd2FyZExpc3QtPmJhY2tJdGVtKCktPml0ZW1JRCgpKSwgbV9wYWdl SUQpOworICAgIHByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6R29CYWNrKGJhY2tJ dGVtLT5pdGVtSUQoKSksIG1fcGFnZUlEKTsKIH0KIAogYm9vbCBXZWJQYWdlUHJveHk6OmNhbkdv QmFjaygpIGNvbnN0Cg==