54057 2011-02-08 20:46:50 -0800 [GTK] Build break with 2.18.3 2011-02-11 00:26:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned commit-queue mrobinson oldest_to_newest 347930 0 ryuan.choi 2011-02-08 20:46:50 -0800 I got below error message and I realized that GTK+2.18.3 doesn't have gtk_range_get_min_slider_size. But configure.ac indicate GTK_REQUIRED_VERSION as 2.10. Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp: In member function ‘void WebCore::ScrollbarThemeGtk::updateThemeProperties()’: Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:62:74: error: ‘gtk_range_get_min_slider_size’ was not declared in this scope CXX Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-WidgetGtk.lo CXX Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-WidgetRenderingContext.lo CXX Source/WebCore/platform/image-decoders/bmp/libwebkitgtk_1_0_la-BMPImageDecoder.lo CXX Source/WebCore/platform/image-decoders/bmp/libwebkitgtk_1_0_la-BMPImageReader.lo CXX Source/WebCore/platform/image-decoders/cairo/libwebkitgtk_1_0_la-ImageDecoderCairo.lo make[1]: *** [Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-ScrollbarThemeGtk2.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/workspace/gtk_webkit' make: *** [all] Error 2 349524 1 82075 ryuan.choi 2011-02-10 17:16:43 -0800 Created attachment 82075 Patch 349538 2 82075 mrobinson 2011-02-10 17:46:19 -0800 Comment on attachment 82075 Patch I believe you can just include GtkVersioning.h in the RenderThemeGtk2.cpp. 349546 3 82081 ryuan.choi 2011-02-10 17:55:50 -0800 Created attachment 82081 Patch 349674 4 82081 commit-queue 2011-02-11 00:26:15 -0800 Comment on attachment 82081 Patch Clearing flags on attachment: 82081 Committed r78320: <http://trac.webkit.org/changeset/78320> 349675 5 commit-queue 2011-02-11 00:26:20 -0800 All reviewed patches have been landed. Closing bug. 82075 2011-02-10 17:16:43 -0800 2011-02-10 17:55:44 -0800 Patch bug-54057-20110211101644.patch text/plain 983 ryuan.choi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc4Mjg1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDIt MTAgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEJ1aWxkIGJyZWFrIHdpdGgg Mi4xOC4zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NDA1NworCisgICAgICAgIEJ1bXBlZCB0aGUgR1RLKyByZXF1aXJlZCB2ZXJzaW9uIHRvIDIuMjAg Zm9yIGd0a19yYW5nZV9nZXRfbWluX3NsaWRlcl9zaXplLgorCisgICAgICAgICogY29uZmlndXJl LmFjOgorCiAyMDExLTAyLTEwICBQZXRlciBWYXJnYSAgPHB2YXJnYUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KSW5kZXg6IGNvbmZpZ3VyZS5h Ywo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUuYWMJKHJldmlzaW9uIDc4Mjg1KQorKysgY29uZmln dXJlLmFjCSh3b3JraW5nIGNvcHkpCkBAIC0xOTAsNyArMTkwLDcgQEAgQUNfQVJHX1dJVEgoW2d0 a10sCiBBQ19NU0dfUkVTVUxUKFskd2l0aF9ndGtdKQogCiBjYXNlICIkd2l0aF9ndGsiIGluCi0g ICAgIDIuMCkgR1RLX1JFUVVJUkVEX1ZFUlNJT049Mi4xMAorICAgICAyLjApIEdUS19SRVFVSVJF RF9WRVJTSU9OPTIuMjAKICAgICAgICAgICBHVEtfQVBJX1ZFUlNJT049Mi4wCiAgICAgICAgICAg V0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OPTEKICAgICAgICAgICBXRUJLSVRHVEtfQVBJX01J Tk9SX1ZFUlNJT049MAo= 82081 2011-02-10 17:55:50 -0800 2011-02-11 00:26:15 -0800 Patch bug-54057-20110211105551.patch text/plain 978 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4Mjk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMTAgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4LgorCisgICAgICAgIFtHVEtdIEJ1aWxkIGJyZWFrIHdpdGggMi4xOC4zCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDA1NworCisgICAgICAgICog cGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrMi5jcHA6IEluY2x1ZGUgR3RrVmVyc2lvbmlu Zy5oCisKIDIwMTEtMDItMTAgIENvc21pbiBUcnV0YSAgPGN0cnV0YUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsyLmNwcAkocmV2aXNpb24gNzgy ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogCiAjaWZkZWYgR1RLX0FQSV9WRVJT SU9OXzIKIAorI2luY2x1ZGUgIkd0a1ZlcnNpb25pbmcuaCIKICNpbmNsdWRlICJQbGF0Zm9ybU1v dXNlRXZlbnQuaCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZUd0ay5oIgogI2luY2x1ZGUgIlNjcm9s bFZpZXcuaCIK