54017 2011-02-08 09:54:02 -0800 drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER 2011-02-08 11:34:50 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo abarth cmarrin enne eric kbr webkit.review.bot oldest_to_newest 347469 0 zmo 2011-02-08 09:54:02 -0800 WebGL spec says: " If count is greater than zero, then a non-null WebGLBuffer must be bound to the ELEMENT_ARRAY_BUFFER binding point or an INVALID_OPERATION error will be generated." We should avoid sending down the call to underlying GL if no buffer is bound to the ELEMENT_ARRAY_BUFFER. 347491 1 81658 zmo 2011-02-08 10:24:37 -0800 Created attachment 81658 Patch 347493 2 81658 kbr 2011-02-08 10:28:36 -0800 Comment on attachment 81658 Patch Looks good. 347509 3 zmo 2011-02-08 10:50:44 -0800 Landed in http://trac.webkit.org/changeset/77956 347565 4 webkit.review.bot 2011-02-08 11:34:50 -0800 http://trac.webkit.org/changeset/77956 might have broken Qt Linux Release The following tests are not passing: http/tests/websocket/tests/workers/close-in-onmessage-crash.html 81658 2011-02-08 10:24:37 -0800 2011-02-08 10:28:36 -0800 Patch bug-54017-20110208102436.patch text/plain 3737 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3OTUyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMDggIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBkcmF3RWxlbWVudHMgc2hvdWxkIGNoZWNrIGlmIGEgYnVmZmVyIGlzIGJv dW5kIHRvIEVMRU1FTlRfQVJSQVlfQlVGRkVSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NDAxNworCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29u dGV4dDo6ZHJhd0VsZW1lbnRzKToKKwogMjAxMS0wMi0wOCAgWGlhb21laSBKaSAgPHhqaUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 LmNwcAkocmV2aXNpb24gNzc5MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDk0LDYgKzE0OTQsMTEg QEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmRyYXdFbGVtZW50cwogICAgIGlmICghY291 bnQpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmICghbV9ib3VuZEVsZW1lbnRBcnJheUJ1ZmZl cikgeworICAgICAgICBtX2NvbnRleHQtPnN5bnRoZXNpemVHTEVycm9yKEdyYXBoaWNzQ29udGV4 dDNEOjpJTlZBTElEX09QRVJBVElPTik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBp bnQgbnVtRWxlbWVudHMgPSAwOwogICAgIGlmICghaXNFcnJvckdlbmVyYXRlZE9uT3V0T2ZCb3Vu ZHNBY2Nlc3NlcygpKSB7CiAgICAgICAgIC8vIEVuc3VyZSB3ZSBoYXZlIGEgdmFsaWQgcmVuZGVy aW5nIHN0YXRlCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3Nzk1MikKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTAyLTA4ICBaaGVueWFv IE1vICA8em1vQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgZHJhd0VsZW1lbnRzIHNob3VsZCBjaGVjayBpZiBhIGJ1ZmZlciBpcyBi b3VuZCB0byBFTEVNRU5UX0FSUkFZX0JVRkZFUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQwMTcKKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmds L2RyYXctZWxlbWVudHMtb3V0LW9mLWJvdW5kcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFz dC9jYW52YXMvd2ViZ2wvZHJhdy1lbGVtZW50cy1vdXQtb2YtYm91bmRzLmh0bWw6CisKIDIwMTEt MDItMDggIFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9k cmF3LWVsZW1lbnRzLW91dC1vZi1ib3VuZHMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2RyYXctZWxlbWVudHMtb3V0LW9mLWJvdW5kcy1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDc3OTUwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv d2ViZ2wvZHJhdy1lbGVtZW50cy1vdXQtb2YtYm91bmRzLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtNTIsNiArNTIsNyBAQCBQQVNTIGNvbnRleHQuZHJhd0VsZW1lbnRzKGNvbnRleHQu VFJJQU5HCiBQQVNTIGNvbnRleHQuZHJhd0VsZW1lbnRzKGNvbnRleHQuVFJJQU5HTEVTLCA2LCBj b250ZXh0LlVOU0lHTkVEX1NIT1JULCAwKSBnZW5lcmF0ZWQgZXhwZWN0ZWQgR0wgZXJyb3I6IE5P X0VSUk9SLgogUEFTUyBjb250ZXh0LmRyYXdFbGVtZW50cyhjb250ZXh0LlRSSUFOR0xFUywgNiwg Y29udGV4dC5VTlNJR05FRF9TSE9SVCwgMSkgZ2VuZXJhdGVkIGV4cGVjdGVkIEdMIGVycm9yOiBJ TlZBTElEX09QRVJBVElPTi4KIFBBU1MgY29udGV4dC5kcmF3RWxlbWVudHMoY29udGV4dC5UUklB TkdMRVMsIDYsIGNvbnRleHQuVU5TSUdORURfU0hPUlQsIDIpIGdlbmVyYXRlZCBleHBlY3RlZCBH TCBlcnJvcjogTk9fRVJST1IuCitQQVNTIGNvbnRleHQuZHJhd0VsZW1lbnRzKGNvbnRleHQuVFJJ QU5HTEVTLCA2LCBjb250ZXh0LlVOU0lHTkVEX1NIT1JULCAwKSBnZW5lcmF0ZWQgZXhwZWN0ZWQg R0wgZXJyb3I6IElOVkFMSURfT1BFUkFUSU9OLgogCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCiAKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2RyYXctZWxlbWVu dHMtb3V0LW9mLWJvdW5kcy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2Fu dmFzL3dlYmdsL2RyYXctZWxlbWVudHMtb3V0LW9mLWJvdW5kcy5odG1sCShyZXZpc2lvbiA3Nzk1 MCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2RyYXctZWxlbWVudHMtb3V0LW9m LWJvdW5kcy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsNiArMTI1LDEwIEBAIHNob3VsZEdl bmVyYXRlR0xFcnJvcihjb250ZXh0LCBjb250ZXh0Lk4KIHNob3VsZEdlbmVyYXRlR0xFcnJvcihj b250ZXh0LCBjb250ZXh0LklOVkFMSURfT1BFUkFUSU9OLCAiY29udGV4dC5kcmF3RWxlbWVudHMo Y29udGV4dC5UUklBTkdMRVMsIDYsIGNvbnRleHQuVU5TSUdORURfU0hPUlQsIDEpIik7CiBzaG91 bGRHZW5lcmF0ZUdMRXJyb3IoY29udGV4dCwgY29udGV4dC5OT19FUlJPUiwgImNvbnRleHQuZHJh d0VsZW1lbnRzKGNvbnRleHQuVFJJQU5HTEVTLCA2LCBjb250ZXh0LlVOU0lHTkVEX1NIT1JULCAy KSIpOwogCisvLyBpbnZhbGlkIG9wZXJhdGlvbiBpZiBubyBidWZmZXIgaXMgYm91bmQgdG8gRUxF TUVOVF9BUlJBWV9CVUZGRVIKK2NvbnRleHQuYmluZEJ1ZmZlcihjb250ZXh0LkVMRU1FTlRfQVJS QVlfQlVGRkVSLCBudWxsKTsKK3Nob3VsZEdlbmVyYXRlR0xFcnJvcihjb250ZXh0LCBjb250ZXh0 LklOVkFMSURfT1BFUkFUSU9OLCAiY29udGV4dC5kcmF3RWxlbWVudHMoY29udGV4dC5UUklBTkdM RVMsIDYsIGNvbnRleHQuVU5TSUdORURfU0hPUlQsIDApIik7CisKIGRlYnVnKCIiKQogc3VjY2Vz c2Z1bGx5UGFyc2VkID0gdHJ1ZTsKIDwvc2NyaXB0Pgo=