54010 2011-02-08 09:05:08 -0800 Web Inspector: script formatter should not create a worker for each script. 2011-02-09 02:12:34 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 347426 0 podivilov 2011-02-08 09:05:08 -0800 Reusing a worker results in a much better performance when formatting multiple scripts inlined in html. 347427 1 81644 podivilov 2011-02-08 09:06:01 -0800 Created attachment 81644 Patch. 348017 2 81644 yurys 2011-02-08 23:46:07 -0800 Comment on attachment 81644 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=81644&action=review > Source/WebCore/inspector/front-end/ScriptFormatter.js:133 > + this._lastTask = task; I'd rather use and array with its push/shift methods 348082 3 podivilov 2011-02-09 02:12:34 -0800 Committed r78034: <http://trac.webkit.org/changeset/78034> 81644 2011-02-08 09:06:01 -0800 2011-02-08 23:46:07 -0800 Patch. patch text/plain 2608 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZDcwZDdmLi5jZjE2NWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDItMDggIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3Rvcjogc2NyaXB0IGZvcm1hdHRlciBzaG91bGQgbm90IGNyZWF0ZSBhIHdvcmtlciBmb3Ig ZWFjaCBzY3JpcHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01NDAxMAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRGb3JtYXR0 ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0Rm9ybWF0dGVyKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5TY3JpcHRGb3JtYXR0ZXIucHJvdG90eXBlLl9mb3JtYXRTY3JpcHQpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdEZvcm1hdHRlci5wcm90b3R5cGUuX2hhbmRsZU1l c3NhZ2UpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdEZvcm1hdHRlci5wcm90b3R5cGUu X2hhbmRsZUVycm9yKToKKwogMjAxMS0wMi0wNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIExlb3BhcmQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRGb3JtYXR0ZXIuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdEZvcm1hdHRlci5qcwpp bmRleCA3MmZmZTM3Li43NjEzZGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdEZvcm1hdHRlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NjcmlwdEZvcm1hdHRlci5qcwpAQCAtMzAsNiArMzAsMTEgQEAKIAog V2ViSW5zcGVjdG9yLlNjcmlwdEZvcm1hdHRlciA9IGZ1bmN0aW9uKCkKIHsKKyAgICB0aGlzLl93 b3JrZXIgPSBuZXcgV29ya2VyKCJTY3JpcHRGb3JtYXR0ZXJXb3JrZXIuanMiKTsKKyAgICB0aGlz Ll93b3JrZXIub25tZXNzYWdlID0gdGhpcy5faGFuZGxlTWVzc2FnZS5iaW5kKHRoaXMpOworICAg IHRoaXMuX3dvcmtlci5vbmVycm9yID0gdGhpcy5faGFuZGxlRXJyb3IuYmluZCh0aGlzKTsKKyAg ICB0aGlzLl9maXJzdFRhc2sgPSBudWxsOworICAgIHRoaXMuX2xhc3RUYXNrID0gbnVsbDsKIH0K IAogV2ViSW5zcGVjdG9yLlNjcmlwdEZvcm1hdHRlci5wcm90b3R5cGUgPSB7CkBAIC0xMjAsMTIg KzEyNSwyOCBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0Rm9ybWF0dGVyLnByb3RvdHlwZSA9IHsKIAog ICAgIF9mb3JtYXRTY3JpcHQ6IGZ1bmN0aW9uKHNvdXJjZSwgY2FsbGJhY2spCiAgICAgewotICAg ICAgICB2YXIgd29ya2VyID0gbmV3IFdvcmtlcigiU2NyaXB0Rm9ybWF0dGVyV29ya2VyLmpzIik7 Ci0gICAgICAgIGZ1bmN0aW9uIG1lc3NhZ2VIYW5kbGVyKGV2ZW50KQotICAgICAgICB7Ci0gICAg ICAgICAgICBjYWxsYmFjayhldmVudC5kYXRhLmZvcm1hdHRlZFNvdXJjZSwgZXZlbnQuZGF0YS5t YXBwaW5nKTsKLSAgICAgICAgfQotICAgICAgICB3b3JrZXIub25tZXNzYWdlID0gbWVzc2FnZUhh bmRsZXIuYmluZCh0aGlzKTsKLSAgICAgICAgd29ya2VyLnBvc3RNZXNzYWdlKHNvdXJjZSk7Cisg ICAgICAgIHZhciB0YXNrID0geyBzb3VyY2U6IHNvdXJjZSwgY2FsbGJhY2s6IGNhbGxiYWNrIH07 CisgICAgICAgIGlmICghdGhpcy5maXJzdFRhc2spCisgICAgICAgICAgICB0aGlzLl9maXJzdFRh c2sgPSB0YXNrOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlzLl9sYXN0VGFzay5uZXh0 ID0gdGFzazsKKyAgICAgICAgdGhpcy5fbGFzdFRhc2sgPSB0YXNrOworICAgICAgICB0aGlzLl93 b3JrZXIucG9zdE1lc3NhZ2Uoc291cmNlKTsKKyAgICB9LAorCisgICAgX2hhbmRsZU1lc3NhZ2U6 IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgdmFyIHRhc2sgPSB0aGlzLl9maXJzdFRh c2s7CisgICAgICAgIHRoaXMuX2ZpcnN0VGFzayA9IHRoaXMuX2ZpcnN0VGFzay5uZXh0OworICAg ICAgICB0YXNrLmNhbGxiYWNrKGV2ZW50LmRhdGEuZm9ybWF0dGVkU291cmNlLCBldmVudC5kYXRh Lm1hcHBpbmcpOworICAgIH0sCisKKyAgICBfaGFuZGxlRXJyb3I6IGZ1bmN0aW9uKGV2ZW50KQor ICAgIHsKKyAgICAgICAgY29uc29sZS53YXJuKCJFcnJvciBpbiBzY3JpcHQgZm9ybWF0dGVyIHdv cmtlcjoiLCBldmVudCk7CisgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCkKKyAgICAgICAg dmFyIHRhc2sgPSB0aGlzLl9maXJzdFRhc2s7CisgICAgICAgIHRoaXMuX2ZpcnN0VGFzayA9IHRo aXMuX2ZpcnN0VGFzay5uZXh0OworICAgICAgICB0YXNrLmNhbGxiYWNrKHRhc2suc291cmNlLCB7 IG9yaWdpbmFsOiBbXSwgZm9ybWF0dGVkOiBbXSB9KTsKICAgICB9CiB9Cg==