54009 2011-02-08 08:56:11 -0800 [WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards but not defined in DrawingAreaProxy.h 2011-02-08 23:22:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 52805 1 alex webkit-unassigned andersca mrobinson oldest_to_newest 347422 0 alex 2011-02-08 08:56:11 -0800 After r77546 LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards: diff --git a/Source/WebKit2/UIProcess/DrawingAreaProxy.h b/Source/WebKit2/UIProcess/DrawingAreaProxy.h index 1639668..0e3b555 100644 --- a/Source/WebKit2/UIProcess/DrawingAreaProxy.h +++ b/Source/WebKit2/UIProcess/DrawingAreaProxy.h @@ -97,7 +97,7 @@ private: // CoreIPC message handlers. // FIXME: These should be pure virtual. virtual void update(uint64_t sequenceNumber, const UpdateInfo&) { } - virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&) { } + virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&, const LayerTreeContext&) { } #if USE(ACCELERATED_COMPOSITING) virtual void enterAcceleratedCompositingMode(uint64_t sequenceNumber, const LayerTreeContext&) { } virtual void exitAcceleratedCompositingMode(uint64_t sequenceNumber) { } But it is forward declared inside the guards in the same file. 347424 1 81643 alex 2011-02-08 09:03:35 -0800 Created attachment 81643 Proposed patch 348003 2 alex 2011-02-08 23:22:41 -0800 Landed http://trac.webkit.org/changeset/78021 81643 2011-02-08 09:03:35 -0800 2011-02-08 09:04:31 -0800 Proposed patch fwd_decl_layertreecontext.patch text/plain 1809 alex Y29tbWl0IDEwZWYxNjA3MTEwMTQ5MjgyYzk1MjI4NjIxNGUwYjZjMTA0YTc5ZDkKQXV0aG9yOiBB bGVqYW5kcm8gRy4gQ2FzdHJvIDxhbGV4QGlnYWxpYS5jb20+CkRhdGU6ICAgVHVlIEZlYiA4IDE3 OjU4OjMxIDIwMTEgKzAxMDAKCiAgICAyMDExLTAyLTA4ICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8 YWxleEBpZ2FsaWEuY29tPgogICAgCiAgICAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgogICAgCiAgICAgICAgICAgIFtXSzJdIExheWVyVHJlZUNvbnRleHQgaXMgdXNlZCBvdXRz aWRlIHRoZSBBQ0NFTEVSQVRFRF9DT01QT1NJVElORwogICAgICAgICAgICBndWFyZHMgYnV0IG5v dCBkZWZpbmVkIGluIERyYXdpbmdBcmVhUHJveHkuaAogICAgICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQwMDkKICAgIAogICAgICAgICAgICBSZW1vdmVk IHRoZSBndWFyZHMgaW4gdGhlIGZvcndhcmQgZGVjbGFyYXRpb24sIHRoaXMgd2lsbCBmYWlsIGlm CiAgICAgICAgICAgIHRoZSBjbGFzcyBpcyBmaW5hbGx5IHVzZWQgaW4gdGhlIGZ1bmN0aW9uLCBi dXQgaXQgd29ya3MgZm9yIHRoZQogICAgICAgICAgICBtb21lbnQuCiAgICAKICAgICAgICAgICAg KiBVSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oOgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhODM4Zjc3Li45 NGE5ZTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMDggIEFsZWphbmRy byBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1dLMl0gTGF5ZXJUcmVlQ29udGV4dCBpcyB1c2VkIG91 dHNpZGUgdGhlIEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HCisgICAgICAgIGd1YXJkcyBidXQgbm90 IGRlZmluZWQgaW4gRHJhd2luZ0FyZWFQcm94eS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDAwOQorCisgICAgICAgIFJlbW92ZWQgdGhlIGd1YXJk cyBpbiB0aGUgZm9yd2FyZCBkZWNsYXJhdGlvbiwgdGhpcyB3aWxsIGZhaWwgaWYKKyAgICAgICAg dGhlIGNsYXNzIGlzIGZpbmFsbHkgdXNlZCBpbiB0aGUgZnVuY3Rpb24sIGJ1dCBpdCB3b3JrcyBm b3IgdGhlCisgICAgICAgIG1vbWVudC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJl YVByb3h5Lmg6CisKIDIwMTEtMDItMDggIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgKaW5kZXggMTZmZGZkYi4uMDQyZWJkNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oCkBAIC0zNSwxMCArMzUs NyBAQCBjbGFzcyBRUGFpbnRlcjsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLSNpZiBVU0UoQUND RUxFUkFURURfQ09NUE9TSVRJTkcpCiBjbGFzcyBMYXllclRyZWVDb250ZXh0OwotI2VuZGlmCi0K IGNsYXNzIFVwZGF0ZUluZm87CiBjbGFzcyBXZWJQYWdlUHJveHk7CiAK