54005 2011-02-08 08:03:43 -0800 ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web Process crashes 2011-02-08 08:59:13 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jberlin jberlin abarth aroben eric jberlin webkit.review.bot oldest_to_newest 347388 0 jberlin 2011-02-08 08:03:43 -0800 In ConnectionWin's Connection::writeEventHandler(), the error returned from ::GetLastError is ERROR_BROKEN_PIPE. This is pretty logical, since the Web Process just crashed. We should handle this case by calling connectionDidClose() and returning. 347393 1 jberlin 2011-02-08 08:06:25 -0800 <rdar://problem/8971458> 347394 2 81637 jberlin 2011-02-08 08:08:01 -0800 Created attachment 81637 Patch 347402 3 81637 jberlin 2011-02-08 08:35:12 -0800 Comment on attachment 81637 Patch Committed in r77942 http://trac.webkit.org/changeset/77942 347423 4 webkit.review.bot 2011-02-08 08:59:13 -0800 http://trac.webkit.org/changeset/77942 might have broken Qt Linux Release The following tests are not passing: http/tests/websocket/tests/workers/close-in-onmessage-crash.html 81637 2011-02-08 08:08:01 -0800 2011-02-08 08:35:12 -0800 Patch fixAssertionWhenWebProcessCrashes54005.patch text/plain 1358 jberlin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3OTM3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDggIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBU1NFUlRJT04gRkFJTFVSRTogQVNTRVJUX05PVF9SRUFDSEVE KCkgaW4gQ29ubmVjdGlvbjo6d3JpdGVFdmVudEhhbmRsZXIoKSBhZnRlciB0aGUgV2ViCisgICAg ICAgIFByb2Nlc3MgY3Jhc2hlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU0MDA1CisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL3dpbi9Db25u ZWN0aW9uV2luLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OkNvbm5lY3Rpb246OndyaXRlRXZlbnRI YW5kbGVyKToKKyAgICAgICAgSGFuZGxlIEVSUk9SX0JST0tFTl9QSVBFIGJ5IGNhbGxpbmcgY29u bmVjdGlvbkRpZENsb3NlKCkgYW5kIHJldHVybmluZyBlYXJseS4KKwogMjAxMS0wMi0wOCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjc3ODY2LgpJbmRleDogU291cmNlL1dlYktpdDIvUGxhdGZvcm0v Q29yZUlQQy93aW4vQ29ubmVjdGlvbldpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy93aW4vQ29ubmVjdGlvbldpbi5jcHAJKHJldmlzaW9uIDc3OTI3 KQorKysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy93aW4vQ29ubmVjdGlvbldpbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI0Myw2ICsyNDMsMTAgQEAgdm9pZCBDb25uZWN0aW9uOjp3 cml0ZUV2ZW50SGFuZGxlcigpCiAgICAgICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGZpZ3Vy ZSBvdXQgd2h5IHdlJ3JlIGdldHRpbmcgdGhpcyBlcnJvci4KICAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgfQorICAgICAgICBpZiAoZXJyb3IgPT0gRVJST1JfQlJPS0VOX1BJUEUpIHsKKyAg ICAgICAgICAgIGNvbm5lY3Rpb25EaWRDbG9zZSgpOworICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICB9CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KIAo=