54000 2011-02-08 07:10:16 -0800 [Qt] Crash on application exit after constructing and destroying a QWebView twice 2011-02-14 10:52:28 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Normal --- 1 kari.salminen menard benjamin commit-queue menard webkit.review.bot oldest_to_newest 347345 0 81632 kari.salminen 2011-02-08 07:10:16 -0800 Created attachment 81632 Test case for the bug How to reproduce the crash (Tested on Qt 4.7.0/Windows XP/MSVC9/Qt Creator 2.0.1): - Create a QApplication - Loop this twice: - Create a QWindow and and a QWebView - Set the QWebView as the QWindow's central widget - Load an URL (e.g. http://www.google.com/) to the QWebView and show it - Execute the QApplication - User interaction: Close the window by clicking on the X - Exit the program - Voila! Crash (Not always, but sometimes). I've included a webtest.zip containing a webtest.pro and main.cpp that contains the test case. The test case does not crash every time on my computer though, only sometimes (I don't think my computer's hardware e.g. memory, is faulty because the computer is usually very stable). Also I noticed that on second showing of the Google page not all looked the same (If there was moving graphics there on the first run, the second run all was static i.e. not moving). The real use case behind this bug is using a relogin system in our commercial software that creates the main window completely from scratch when logging out and relogging in (We don't shut down the application in between logging out and relogging in). --- Stack trace from Qt Creator 2.0.1 with MSVC debugger: --- Exception at 0x0, code: 0xc0000005: read access violation at: 0x0, flags=0x0 Level Function File Line Address 0 GetModuleFileNameA kernel32 0 0x0 1 WebCore::SharedTimerQt::~SharedTimerQt SharedTimerQt.cpp 74 0x109ec8f1 2 WebCore::SharedTimerQt::`scalar deleting destructor' QtWebKitd4 0 0x109ecdcf 3 WebCore::SharedTimerQt::destroy SharedTimerQt.cpp 78 0x109ec94a 4 WebCore::SharedTimerQt::qt_metacall SharedTimerQt.moc 74 0x109ecc88 5 QMetaObject::metacall qmetaobject.cpp 238 0x671ca551 6 QMetaObject::activate qobject.cpp 3272 0x671e1dc6 7 QCoreApplication::aboutToQuit moc_qcoreapplication.cpp 131 0x67263049 8 QCoreApplication::exec qcoreapplication.cpp 1015 0x671c103d 9 QApplication::exec qapplication.cpp 3673 0x6506e458 10 main main.cpp 17 0x401189 11 WinMain qtmain_win.cpp 131 0x4023ca 12 __tmainCRTStartup crtexe.c 578 0x4018a8 13 WinMainCRTStartup crtexe.c 403 0x40160f 14 RegisterWaitForInputIdle kernel32 0 0x7c816fe7 C:\Qt\4.7.0\src\3rdparty\webkit\WebCore\platform\qt\SharedTimerQt.cpp: SharedTimerQt::~SharedTimerQt() { if (m_timer.isActive()) (m_timerFunction)(); } // <------ debugger points here at level 1 (Points to assembly code on level 0) According to https://svn.webkit.org/wiki/QtWebKitRelease20 QtWebKit that comes with Qt 4.7.0, which I'm using, was branches off WebKit trunk from SVN r56441 ("AppleWebKit/533.3") and thus I chose 528+ as the version number. I chose to report this here instead than in the Qt's bug tracker because of Henry Haverinen's comment on 25/May/10 12:24 PM at http://bugreports.qt.nokia.com/browse/QTWEBKIT-189 hoping that this is the correct place for this bug. 348328 1 81824 benjamin 2011-02-09 09:47:42 -0800 Created attachment 81824 Test case that builds 348330 2 benjamin 2011-02-09 09:50:30 -0800 Crash: I set as P1. I can reproduce everytime with trunk on Linux. Backtrace: #0 0x0000000000000000 in ?? () #1 0x00007ffff703522c in WebCore::SharedTimerQt::~SharedTimerQt() () from /home/ikipou/dev/webkit/qtwebkit/WebKitBuild/Release/lib/libQtWebKit.so.4 #2 0x00007ffff7035289 in WebCore::SharedTimerQt::~SharedTimerQt() () from /home/ikipou/dev/webkit/qtwebkit/WebKitBuild/Release/lib/libQtWebKit.so.4 #3 0x00007ffff7035147 in WebCore::SharedTimerQt::qt_metacall(QMetaObject::Call, int, void**) () from /home/ikipou/dev/webkit/qtwebkit/WebKitBuild/Release/lib/libQtWebKit.so.4 #4 0x00007ffff514bfaf in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /home/ikipou/dev/qt-oslo-staging-2_release_64/lib/libQtCore.so.4 #5 0x00007ffff513a5a3 in QCoreApplication::exec() () from /home/ikipou/dev/qt-oslo-staging-2_release_64/lib/libQtCore.so.4 #6 0x0000000000400e18 in main () 349320 3 82035 qi.2.zhang 2011-02-10 13:26:25 -0800 Created attachment 82035 patch Patch. 349322 4 82035 benjamin 2011-02-10 13:28:46 -0800 Comment on attachment 82035 patch This really needs an autotest. 350620 5 82310 menard 2011-02-14 06:06:32 -0800 Created attachment 82310 Patch with test case 350622 6 webkit.review.bot 2011-02-14 06:09:02 -0800 Attachment 82310 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2824: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 350626 7 82310 kling 2011-02-14 06:11:25 -0800 Comment on attachment 82310 Patch with test case View in context: https://bugs.webkit.org/attachment.cgi?id=82310&action=review > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2823 > + for (int i = 0; i < 2; ++i) Coding style, { on this line. > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2831 > + webView->load(QUrl(QLatin1String("http://www.google.com/"))); > + mainWindow.show(); > + connect(webView, SIGNAL(loadFinished(bool)), &mainWindow, SLOT(close())); > + QApplication::instance()->exec(); We can't rely on external websites in our autotests. 350628 8 82311 menard 2011-02-14 06:19:45 -0800 Created attachment 82311 Patch v2 with comments taken into accounts... 350631 9 82311 tonikitoo 2011-02-14 06:25:13 -0800 Comment on attachment 82311 Patch v2 with comments taken into accounts... View in context: https://bugs.webkit.org/attachment.cgi?id=82311&action=review LGTM > Source/WebCore/ChangeLog:8 > + Check the value is valid before use it. Nit: "Check IF.." 350763 10 commit-queue 2011-02-14 10:50:50 -0800 The commit-queue encountered the following flaky tests while processing attachment 82311: fast/history/history-subframe-with-name.html bug 51039 (author: mihaip@chromium.org) The commit-queue is continuing to process your patch. 350764 11 82311 commit-queue 2011-02-14 10:52:23 -0800 Comment on attachment 82311 Patch v2 with comments taken into accounts... Clearing flags on attachment: 82311 Committed r78490: <http://trac.webkit.org/changeset/78490> 350765 12 commit-queue 2011-02-14 10:52:28 -0800 All reviewed patches have been landed. Closing bug. 81632 2011-02-08 07:10:16 -0800 2011-02-08 07:10:16 -0800 Test case for the bug webtest.zip application/octet-stream 535 kari.salminen UEsDBBQAAAAIAEiDSD4OOtHm/QAAANoBAAAIAAAAbWFpbi5jcHB1UM1KxDAQvgfyDsMKkuxqqx7t uiAevOihiPYgHmIa28E0KTG7EcR3N7WlG5QdAjN8fzPkCI3U21rBuvS3W8zL677XKIVHazaU/KPv BZoKTW3DH7ZSr+/o8zL2J1QDS8nOYg1ddDA0HoRr5AnIVjhYxnn3/MIp+aIEYqVrQfQ9G8WDjBeU jKI36+A3CeEKzorY1nAR22rFR8EQNlVyKHTzWCSC6dAlhHGImUaFGWfHextPfHs0+1D+RhnvhK6w bpRnU1Iqn6DTjbaiZuWj06y8Ex7N+YN3aBq2aL3vL/M8hJA11jZaZdJ2+YLzQ1tbG1jKxe/K1KeS M/hNSXw/UEsDBBQAAAAIAE92SD6YepOURgAAAE4AAAALAAAAd2VidGVzdC5wcm8LDFHQtlVIzi9K VUgvzVQoT03Kzizh5QpxDHJ3DVGwBQmUpBaDRFx9A3wcQ1yBYokFBbxcwf6hQc6uwSDduYmZeXrJ IEEAUEsBAhQAFAAAAAgASINIPg460eb9AAAA2gEAAAgAAAAAAAAAAAAgAAAAAAAAAG1haW4uY3Bw UEsBAhQAFAAAAAgAT3ZIPph6k5RGAAAATgAAAAsAAAAAAAAAAAAgAAAAIwEAAHdlYnRlc3QucHJv UEsFBgAAAAACAAIAbwAAAJIBAAAAAA== 81824 2011-02-09 09:47:42 -0800 2011-02-10 13:34:53 -0800 Test case that builds main.cpp text/plain 436 benjamin I2luY2x1ZGUgPFF0R3VpPg0KI2luY2x1ZGUgPFF0V2ViS2l0Pg0KDQppbnQgbWFpbihpbnQgYXJn YywgY2hhciAqYXJndltdKQ0Kew0KICAgIFFBcHBsaWNhdGlvbiBhcHAoYXJnYywgYXJndik7DQoN CiAgICBmb3IgKGludCBpID0gMDsgaSA8IDI7IGkrKykNCiAgICB7DQogICAgICAgIFFNYWluV2lu ZG93IG1haW5XaW5kb3c7DQogICAgICAgIFFXZWJWaWV3KiB3ZWJWaWV3ID0gbmV3IFFXZWJWaWV3 KCZtYWluV2luZG93KTsNCiAgICAgICAgbWFpbldpbmRvdy5zZXRDZW50cmFsV2lkZ2V0KHdlYlZp ZXcpOw0KICAgICAgICB3ZWJWaWV3LT5sb2FkKFFVcmwoUUxhdGluMVN0cmluZygiaHR0cDovL3d3 dy5nb29nbGUuY29tLyIpKSk7DQogICAgICAgIG1haW5XaW5kb3cuc2hvdygpOw0KICAgICAgICBh cHAuZXhlYygpOw0KICAgIH0NCiAgICByZXR1cm4gMDsNCn0NCg== 82035 2011-02-10 13:26:25 -0800 2011-02-14 06:06:32 -0800 patch bug54000.patch text/plain 1316 qi.2.zhang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MjYzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTAgIFFpIFpoYW5n ICA8cWkuMi56aGFuZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBDcmFzaCBvbiBhcHBsaWNhdGlvbiBleGl0IGFmdGVyIGNv bnN0cnVjdGluZyBhbmQgZGVzdHJveWluZyBhIFFXZWJWaWV3IHR3aWNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDAwMAorCisgICAgICAgIENoZWNr IHRoZSB2YWx1ZSBpcyB2YWxpZCBiZWZvcmUgdXNlIGl0LgorICAgICAgICBObyBjaGFuZ2Ugb2Yg ZnVuY3Rpb25hbGl0eSwgc28gbm8gbmV3IHRlc3QgY2FzZXMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9xdC9TaGFyZWRUaW1lclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZFRpbWVyUXQ6 On5TaGFyZWRUaW1lclF0KToKKwogMjAxMS0wMi0xMCAgQWRlbWFyIGRlIFNvdXphIFJlaXMgSnIg IDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJl YXMgS2xpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1l clF0LmNwcAkocmV2aXNpb24gNzgyNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9T aGFyZWRUaW1lclF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjgsOCArNjgsMTEgQEAgU2hhcmVk VGltZXJRdDo6U2hhcmVkVGltZXJRdCgpCiAKIFNoYXJlZFRpbWVyUXQ6On5TaGFyZWRUaW1lclF0 KCkKIHsKLSAgICBpZiAobV90aW1lci5pc0FjdGl2ZSgpKQotICAgICAgICAobV90aW1lckZ1bmN0 aW9uKSgpOworICAgIGlmIChtX3RpbWVyLmlzQWN0aXZlKCkpIHsKKyAgICAgICAgaWYgKG1fdGlt ZXJGdW5jdGlvbikKKyAgICAgICAgICAgIChtX3RpbWVyRnVuY3Rpb24pKCk7CisgICAgICAgIG1f dGltZXJGdW5jdGlvbiA9IDA7CisgICAgfQogfQogCiB2b2lkIFNoYXJlZFRpbWVyUXQ6OmRlc3Ry b3koKQo= 82310 2011-02-14 06:06:32 -0800 2011-02-14 06:19:45 -0800 Patch with test case patch.diff text/plain 3278 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTMzMTNiLi4xMzhiYTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMTEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENy YXNoIG9uIGFwcGxpY2F0aW9uIGV4aXQgYWZ0ZXIgY29uc3RydWN0aW5nIGFuZCBkZXN0cm95aW5n IGEgUVdlYlZpZXcgdHdpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0MDAwCisKKyAgICAgICAgQ2hlY2sgdGhlIHZhbHVlIGlzIHZhbGlkIGJlZm9y ZSB1c2UgaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNoYXJlZFRpbWVyUXQ6On5TaGFyZWRUaW1lclF0KToKKwogMjAxMS0w Mi0xMSAgSmFubmUgS29za2luZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vcXQvU2hhcmVkVGltZXJRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9TaGFyZWRUaW1lclF0LmNwcAppbmRleCA4YTZiZDgxLi41MDc1Mzk1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNwcApAQCAtNjgsOCArNjgsMTIg QEAgU2hhcmVkVGltZXJRdDo6U2hhcmVkVGltZXJRdCgpCiAKIFNoYXJlZFRpbWVyUXQ6On5TaGFy ZWRUaW1lclF0KCkKIHsKLSAgICBpZiAobV90aW1lci5pc0FjdGl2ZSgpKQotICAgICAgICAobV90 aW1lckZ1bmN0aW9uKSgpOworICAgIGlmIChtX3RpbWVyLmlzQWN0aXZlKCkpIHsKKyAgICAgICAg aWYgKG1fdGltZXJGdW5jdGlvbikgeworICAgICAgICAgICAgKG1fdGltZXJGdW5jdGlvbikoKTsK KyAgICAgICAgICAgIG1fdGltZXJGdW5jdGlvbiA9IDA7CisgICAgICAgIH0KKyAgICB9CiB9CiAK IHZvaWQgU2hhcmVkVGltZXJRdDo6ZGVzdHJveSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDRiMzQ0ZTku LjhlNmRmZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTEgIEFs ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENyYXNoIG9uIGFwcGxpY2F0aW9u IGV4aXQgYWZ0ZXIgY29uc3RydWN0aW5nIGFuZCBkZXN0cm95aW5nIGEgUVdlYlZpZXcgdHdpY2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MDAwCisK KyAgICAgICAgVGVzdCBjYXNlIHRvIGNvdmVyIHRoZSBjcmFzaC4KKworICAgICAgICAqIHRlc3Rz L3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OmRlbGV0 ZVFXZWJWaWV3VHdpY2UpOgorCiAyMDExLTAyLTEwICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAg PGFkZW1hci5yZWlzQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVh cyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJw YWdlLmNwcAppbmRleCBjOWM0MDlkLi5hN2VmMWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9x dC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5j bHVkZSA8UUdyYXBoaWNzV2lkZ2V0PgogI2luY2x1ZGUgPFFMaW5lRWRpdD4KICNpbmNsdWRlIDxR TG9jYWxlPgorI2luY2x1ZGUgPFFNYWluV2luZG93PgogI2luY2x1ZGUgPFFNZW51PgogI2luY2x1 ZGUgPFFQdXNoQnV0dG9uPgogI2luY2x1ZGUgPFFTdHlsZT4KQEAgLTEzNiw2ICsxMzcsNyBAQCBw cml2YXRlIHNsb3RzOgogICAgIHZvaWQgbmV0d29ya0FjY2Vzc01hbmFnZXJPbkRpZmZlcmVudFRo cmVhZCgpOwogICAgIHZvaWQgbmF2aWdhdG9yQ29va2llRW5hYmxlZCgpOwogICAgIHZvaWQgbmF2 aWdhdG9yQ29va2llRW5hYmxlZEZvck5ldHdvcmtBY2Nlc3NNYW5hZ2VyT25EaWZmZXJlbnRUaHJl YWQoKTsKKyAgICB2b2lkIGRlbGV0ZVFXZWJWaWV3VHdpY2UoKTsKIAogI2lmZGVmIFFfT1NfTUFD CiAgICAgdm9pZCBtYWNDb3B5VW5pY29kZVRvQ2xpcGJvYXJkKCk7CkBAIC0yODE1LDUgKzI4MTcs MjAgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmNvbnRleHRNZW51Q29weSgpCiAgICAgaW50IGluZGV4 ID0gbGlzdC5pbmRleE9mKHZpZXcucGFnZSgpLT5hY3Rpb24oUVdlYlBhZ2U6OkNvcHkpKTsKICAg ICBRVkVSSUZZKGluZGV4ICE9IC0xKTsKIH0KKwordm9pZCB0c3RfUVdlYlBhZ2U6OmRlbGV0ZVFX ZWJWaWV3VHdpY2UoKQoreworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgMjsgKytpKQorICAgIHsK KyAgICAgICAgUU1haW5XaW5kb3cgbWFpbldpbmRvdzsKKyAgICAgICAgUVdlYlZpZXcqIHdlYlZp ZXcgPSBuZXcgUVdlYlZpZXcoJm1haW5XaW5kb3cpOworICAgICAgICBtYWluV2luZG93LnNldENl bnRyYWxXaWRnZXQod2ViVmlldyk7CisgICAgICAgIHdlYlZpZXctPmxvYWQoUVVybChRTGF0aW4x U3RyaW5nKCJodHRwOi8vd3d3Lmdvb2dsZS5jb20vIikpKTsKKyAgICAgICAgbWFpbldpbmRvdy5z aG93KCk7CisgICAgICAgIGNvbm5lY3Qod2ViVmlldywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29s KSksICZtYWluV2luZG93LCBTTE9UKGNsb3NlKCkpKTsKKyAgICAgICAgUUFwcGxpY2F0aW9uOjpp bnN0YW5jZSgpLT5leGVjKCk7CisgICAgfQorfQorCiBRVEVTVF9NQUlOKHRzdF9RV2ViUGFnZSkK ICNpbmNsdWRlICJ0c3RfcXdlYnBhZ2UubW9jIgo= 82311 2011-02-14 06:19:45 -0800 2011-02-14 10:52:23 -0800 Patch v2 with comments taken into accounts... patch.diff text/plain 3265 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTMzMTNiLi4xMzhiYTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMTEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENy YXNoIG9uIGFwcGxpY2F0aW9uIGV4aXQgYWZ0ZXIgY29uc3RydWN0aW5nIGFuZCBkZXN0cm95aW5n IGEgUVdlYlZpZXcgdHdpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0MDAwCisKKyAgICAgICAgQ2hlY2sgdGhlIHZhbHVlIGlzIHZhbGlkIGJlZm9y ZSB1c2UgaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNoYXJlZFRpbWVyUXQ6On5TaGFyZWRUaW1lclF0KToKKwogMjAxMS0w Mi0xMSAgSmFubmUgS29za2luZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vcXQvU2hhcmVkVGltZXJRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9TaGFyZWRUaW1lclF0LmNwcAppbmRleCA4YTZiZDgxLi41MDc1Mzk1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNwcApAQCAtNjgsOCArNjgsMTIg QEAgU2hhcmVkVGltZXJRdDo6U2hhcmVkVGltZXJRdCgpCiAKIFNoYXJlZFRpbWVyUXQ6On5TaGFy ZWRUaW1lclF0KCkKIHsKLSAgICBpZiAobV90aW1lci5pc0FjdGl2ZSgpKQotICAgICAgICAobV90 aW1lckZ1bmN0aW9uKSgpOworICAgIGlmIChtX3RpbWVyLmlzQWN0aXZlKCkpIHsKKyAgICAgICAg aWYgKG1fdGltZXJGdW5jdGlvbikgeworICAgICAgICAgICAgKG1fdGltZXJGdW5jdGlvbikoKTsK KyAgICAgICAgICAgIG1fdGltZXJGdW5jdGlvbiA9IDA7CisgICAgICAgIH0KKyAgICB9CiB9CiAK IHZvaWQgU2hhcmVkVGltZXJRdDo6ZGVzdHJveSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDRiMzQ0ZTku LjhlNmRmZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTEgIEFs ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENyYXNoIG9uIGFwcGxpY2F0aW9u IGV4aXQgYWZ0ZXIgY29uc3RydWN0aW5nIGFuZCBkZXN0cm95aW5nIGEgUVdlYlZpZXcgdHdpY2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MDAwCisK KyAgICAgICAgVGVzdCBjYXNlIHRvIGNvdmVyIHRoZSBjcmFzaC4KKworICAgICAgICAqIHRlc3Rz L3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OmRlbGV0 ZVFXZWJWaWV3VHdpY2UpOgorCiAyMDExLTAyLTEwICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAg PGFkZW1hci5yZWlzQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVh cyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJw YWdlLmNwcAppbmRleCBjOWM0MDlkLi4yZGE4ZTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9x dC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5j bHVkZSA8UUdyYXBoaWNzV2lkZ2V0PgogI2luY2x1ZGUgPFFMaW5lRWRpdD4KICNpbmNsdWRlIDxR TG9jYWxlPgorI2luY2x1ZGUgPFFNYWluV2luZG93PgogI2luY2x1ZGUgPFFNZW51PgogI2luY2x1 ZGUgPFFQdXNoQnV0dG9uPgogI2luY2x1ZGUgPFFTdHlsZT4KQEAgLTEzNiw2ICsxMzcsNyBAQCBw cml2YXRlIHNsb3RzOgogICAgIHZvaWQgbmV0d29ya0FjY2Vzc01hbmFnZXJPbkRpZmZlcmVudFRo cmVhZCgpOwogICAgIHZvaWQgbmF2aWdhdG9yQ29va2llRW5hYmxlZCgpOwogICAgIHZvaWQgbmF2 aWdhdG9yQ29va2llRW5hYmxlZEZvck5ldHdvcmtBY2Nlc3NNYW5hZ2VyT25EaWZmZXJlbnRUaHJl YWQoKTsKKyAgICB2b2lkIGRlbGV0ZVFXZWJWaWV3VHdpY2UoKTsKIAogI2lmZGVmIFFfT1NfTUFD CiAgICAgdm9pZCBtYWNDb3B5VW5pY29kZVRvQ2xpcGJvYXJkKCk7CkBAIC0yODE1LDUgKzI4MTcs MTkgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmNvbnRleHRNZW51Q29weSgpCiAgICAgaW50IGluZGV4 ID0gbGlzdC5pbmRleE9mKHZpZXcucGFnZSgpLT5hY3Rpb24oUVdlYlBhZ2U6OkNvcHkpKTsKICAg ICBRVkVSSUZZKGluZGV4ICE9IC0xKTsKIH0KKwordm9pZCB0c3RfUVdlYlBhZ2U6OmRlbGV0ZVFX ZWJWaWV3VHdpY2UoKQoreworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgMjsgKytpKSB7CisgICAg ICAgIFFNYWluV2luZG93IG1haW5XaW5kb3c7CisgICAgICAgIFFXZWJWaWV3KiB3ZWJWaWV3ID0g bmV3IFFXZWJWaWV3KCZtYWluV2luZG93KTsKKyAgICAgICAgbWFpbldpbmRvdy5zZXRDZW50cmFs V2lkZ2V0KHdlYlZpZXcpOworICAgICAgICB3ZWJWaWV3LT5sb2FkKFFVcmwoInFyYzovLy9yZXNv dXJjZXMvZnJhbWVfYS5odG1sIikpOworICAgICAgICBtYWluV2luZG93LnNob3coKTsKKyAgICAg ICAgY29ubmVjdCh3ZWJWaWV3LCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSwgJm1haW5XaW5k b3csIFNMT1QoY2xvc2UoKSkpOworICAgICAgICBRQXBwbGljYXRpb246Omluc3RhbmNlKCktPmV4 ZWMoKTsKKyAgICB9Cit9CisKIFFURVNUX01BSU4odHN0X1FXZWJQYWdlKQogI2luY2x1ZGUgInRz dF9xd2VicGFnZS5tb2MiCg==