53969 2011-02-07 18:50:47 -0800 Removed some dead code from Heap 2011-02-07 22:05:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren abarth eric rniwa sam webkit.review.bot oldest_to_newest 347006 0 ggaren 2011-02-07 18:50:47 -0800 xed Ch 347007 1 81564 ggaren 2011-02-07 18:53:07 -0800 Created attachment 81564 Patch 347012 2 sam 2011-02-07 19:04:55 -0800 (In reply to comment #0) > xed Ch LOL 347018 3 ggaren 2011-02-07 19:09:07 -0800 Committed r77881: <http://trac.webkit.org/changeset/77881> 347022 4 rniwa 2011-02-07 19:34:55 -0800 Committed r77883: <http://trac.webkit.org/changeset/77883> 347097 5 webkit.review.bot 2011-02-07 22:05:37 -0800 http://trac.webkit.org/changeset/77881 might have broken GTK Linux 32-bit Release 81564 2011-02-07 18:53:07 -0800 2011-02-07 19:04:43 -0800 Patch bug-53969-20110207185304.patch text/plain 3396 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzc4ODApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTEtMDItMDcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHNvbWUgZGVh ZCBjb2RlIGZyb20gSGVhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTM5NjkKKyAgICAgICAgCisgICAgICAgIFN1blNwaWRlciByZXBvcnRzIG5vIGNo YW5nZS4KKworICAgICAgICAqIHJ1bnRpbWUvTWFya2VkU3BhY2UuY3BwOgorICAgICAgICAoSlND OjpNYXJrZWRTcGFjZTo6c2hyaW5rKToKKyAgICAgICAgKEpTQzo6TWFya2VkU3BhY2U6OnN3ZWVw KToKKyAgICAgICAgKiBydW50aW1lL01hcmtlZFNwYWNlLmg6IFJlbW92ZWQgcmVzaXplQmxvY2tz LCBhbmQgZ3Jvd0Jsb2NrcywgYW5kCisgICAgICAgIHJlbmFtZWQgc2hyaW5rQmxvY2tzIHRvIHNo cmluaywgbWFraW5nIGl0IHVuY29uZGl0aW9uYWxseSBzaHJpbmsgYXMKKyAgICAgICAgbXVjaCBh cyBwb3NzaWJsZS4KKwogMjAxMS0wMi0wNyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya2VkU3BhY2UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNwYWNlLmNwcAkocmV2aXNpb24gNzc4Nzcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRTcGFjZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1MSwzNyArMTUxLDEzIEBAIHZvaWQqIE1hcmtlZFNwYWNlOjphbGxvY2F0 ZShzaXplX3QgcykKICAgICByZXR1cm4gMDsKIH0KIAotdm9pZCBNYXJrZWRTcGFjZTo6cmVzaXpl QmxvY2tzKCkKK3ZvaWQgTWFya2VkU3BhY2U6OnNocmluaygpCiB7Ci0gICAgc2l6ZV90IHVzZWRD ZWxsQ291bnQgPSBtYXJrZWRDZWxscygpOwotICAgIHNpemVfdCBtaW5DZWxsQ291bnQgPSB1c2Vk Q2VsbENvdW50ICsgbWF4KEFMTE9DQVRJT05TX1BFUl9DT0xMRUNUSU9OLCB1c2VkQ2VsbENvdW50 KTsKLSAgICBzaXplX3QgbWluQmxvY2tDb3VudCA9IChtaW5DZWxsQ291bnQgKyBIZWFwQ29uc3Rh bnRzOjpjZWxsc1BlckJsb2NrIC0gMSkgLyBIZWFwQ29uc3RhbnRzOjpjZWxsc1BlckJsb2NrOwot Ci0gICAgc2l6ZV90IG1heENlbGxDb3VudCA9IDEuMjVmICogbWluQ2VsbENvdW50OwotICAgIHNp emVfdCBtYXhCbG9ja0NvdW50ID0gKG1heENlbGxDb3VudCArIEhlYXBDb25zdGFudHM6OmNlbGxz UGVyQmxvY2sgLSAxKSAvIEhlYXBDb25zdGFudHM6OmNlbGxzUGVyQmxvY2s7Ci0KLSAgICBpZiAo bV9oZWFwLnVzZWRCbG9ja3MgPCBtaW5CbG9ja0NvdW50KQotICAgICAgICBncm93QmxvY2tzKG1p bkJsb2NrQ291bnQpOwotICAgIGVsc2UgaWYgKG1faGVhcC51c2VkQmxvY2tzID4gbWF4QmxvY2tD b3VudCkKLSAgICAgICAgc2hyaW5rQmxvY2tzKG1heEJsb2NrQ291bnQpOwotfQotCi12b2lkIE1h cmtlZFNwYWNlOjpncm93QmxvY2tzKHNpemVfdCBuZWVkZWRCbG9ja3MpCi17Ci0gICAgQVNTRVJU KG1faGVhcC51c2VkQmxvY2tzIDwgbmVlZGVkQmxvY2tzKTsKLSAgICB3aGlsZSAobV9oZWFwLnVz ZWRCbG9ja3MgPCBuZWVkZWRCbG9ja3MpCi0gICAgICAgIGFsbG9jYXRlQmxvY2soKTsKLX0KLQot dm9pZCBNYXJrZWRTcGFjZTo6c2hyaW5rQmxvY2tzKHNpemVfdCBuZWVkZWRCbG9ja3MpCi17Ci0g ICAgQVNTRVJUKG1faGVhcC51c2VkQmxvY2tzID4gbmVlZGVkQmxvY2tzKTsKLSAgICAKICAgICAv LyBDbGVhciB0aGUgYWx3YXlzLW9uIGxhc3QgYml0LCBzbyBpc0VtcHR5KCkgaXNuJ3QgZm9vbGVk IGJ5IGl0LgogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9oZWFwLnVzZWRCbG9ja3M7ICsr aSkKICAgICAgICAgbV9oZWFwLmNvbGxlY3RvckJsb2NrKGkpLT5tYXJrZWQuY2xlYXIoSGVhcENv bnN0YW50czo6Y2VsbHNQZXJCbG9jayAtIDEpOwogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkg IT0gbV9oZWFwLnVzZWRCbG9ja3MgJiYgbV9oZWFwLnVzZWRCbG9ja3MgIT0gbmVlZGVkQmxvY2tz OyApIHsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSAhPSBtX2hlYXAudXNlZEJsb2NrcyAmJiBt X2hlYXAudXNlZEJsb2NrcyA+IDE7ICkgeyAvLyBXZSBhc3N1bWUgYXQgbGVhc3Qgb25lIGJsb2Nr IGV4aXN0cyBhdCBhbGwgdGltZXMuCiAgICAgICAgIGlmIChtX2hlYXAuY29sbGVjdG9yQmxvY2so aSktPm1hcmtlZC5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgIGZyZWVCbG9jayhpKTsKICAgICAg ICAgfSBlbHNlCkBAIC0yNzIsOCArMjQ4LDcgQEAgdm9pZCBNYXJrZWRTcGFjZTo6c3dlZXAoKQog I2VuZGlmCiAgICAgfQogICAgIAotICAgIGlmIChtX2hlYXAudXNlZEJsb2NrcyA+IDEpCi0gICAg ICAgIHNocmlua0Jsb2NrcygxKTsKKyAgICBzaHJpbmsoKTsKIH0KIAogc2l6ZV90IE1hcmtlZFNw YWNlOjpvYmplY3RDb3VudCgpIGNvbnN0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9NYXJrZWRTcGFjZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL01hcmtlZFNwYWNlLmgJKHJldmlzaW9uIDc3ODUyKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTWFya2VkU3BhY2UuaAkod29ya2luZyBjb3B5KQpAQCAtOTYsOSArOTYs NyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICBORVZFUl9JTkxJTkUgTWFya2VkQmxvY2sq IGFsbG9jYXRlQmxvY2soKTsKICAgICAgICAgTkVWRVJfSU5MSU5FIHZvaWQgZnJlZUJsb2NrKHNp emVfdCk7Ci0gICAgICAgIHZvaWQgcmVzaXplQmxvY2tzKCk7Ci0gICAgICAgIHZvaWQgZ3Jvd0Js b2NrcyhzaXplX3QgbmVlZGVkQmxvY2tzKTsKLSAgICAgICAgdm9pZCBzaHJpbmtCbG9ja3Moc2l6 ZV90IG5lZWRlZEJsb2Nrcyk7CisgICAgICAgIHZvaWQgc2hyaW5rKCk7CiAKICAgICAgICAgdm9p ZCBjbGVhck1hcmtCaXRzKE1hcmtlZEJsb2NrKik7CiAK