53962 2011-02-07 16:41:13 -0800 [GTK] EventSender.keyDown does not support non-array modifier arguments 2012-09-17 16:08:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned ap eric oldest_to_newest 346942 0 mrobinson 2011-02-07 16:41:13 -0800 This can be seem by the failure of fast/forms/legend-access-key.html which uses "altKey" as the modifier argument. 346992 1 81560 mrobinson 2011-02-07 18:03:13 -0800 Created attachment 81560 Patch 347175 2 81560 eric 2011-02-07 23:43:12 -0800 Comment on attachment 81560 Patch Very nice. Nice use of a helper function. 347378 3 81560 mrobinson 2011-02-08 07:57:28 -0800 Comment on attachment 81560 Patch Clearing flags on attachment: 81560 Committed r77936: <http://trac.webkit.org/changeset/77936> 347379 4 mrobinson 2011-02-08 07:57:31 -0800 All reviewed patches have been landed. Closing bug. 722345 5 ap 2012-09-17 15:59:22 -0700 This looks wrong. This is just a mistake in a single test. Eric, you reviewed this. How did you decide that this change was OK? 722356 6 eric 2012-09-17 16:08:45 -0700 Donno. I mean, the option seems reasonable to me. Checking if the arg is a string vs. array seems like a totally reasonable API convenience. But if you feel strongly, I'm sure it can be removed. 81560 2011-02-07 18:03:13 -0800 2011-02-08 07:57:28 -0800 Patch bug-53962-20110207180318.patch text/plain 5447 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmYjBmYTgxNzhkNjk3Nzk4ODZhMjQ3NGI0ZjUyNjUzZjkzY2JhMTUyLi5lYWRkNDI4 MTk3NTY4NzYzNTgyNzgzOGFjZDNhYmNmYTg2MzliMmE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTEtMDItMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEV2ZW50 U2VuZGVyLmtleURvd24gZG9lcyBub3Qgc3VwcG9ydCBub24tYXJyYXkgbW9kaWZpZXIgYXJndW1l bnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzk2 MgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFVuc2tpcCBhIHRlc3Qgd2hpY2gg aXMgbm93IHBhc3NpbmcuCisKKzIwMTEtMDItMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgorCiAgICAgICAgIENsYXNzaWZ5IHRlc3RzIGZhaWxpbmcgaW4gdGhlIGZh c3QgZGlyZWN0b3J5IG9uIEdUSysuIEFkZCByZXN1bHRzIGZvcgogICAgICAgICB0ZXN0cyB0aGF0 IGp1c3QgbmVlZCBwbGF0Zm9ybSBleHBlY3RhdGlvbnMuCiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBw ZWQKaW5kZXggMDMxMzdkMzk5YWE4ODdiOTFhMTY3MWE3ZWM1ZTFlNmU1ZGY3YTc5ZS4uYTRkYzE2 MzY0MjljNzNmNmRiNTBiY2ZhOGI5OGI4YmQzZjdkOGYzMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Nr aXBwZWQKQEAgLTEzMywxMCArMTMzLDYgQEAgZmFzdC9lbmNvZGluZy9tYWlsdG8tYWx3YXlzLXV0 Zi04Lmh0bWwKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzOTYw IAogZmFzdC9ldmVudHMvcG9wdXAtYmxvY2tpbmctY2xpY2staW4taWZyYW1lLmh0bWwKIAotIyBF dmVudFNlbmRlci5rZXlEb3duIGRvZXMgbm90IHN1cHBvcnQgbm9uLWFycmF5IG1vZGlmaWVyIGFy Z3VtZW50cy4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzOTYy IAotZmFzdC9mb3Jtcy9sZWdlbmQtYWNjZXNzLWtleS5odG1sCi0KICMgTG9va3MgbGlrZSBhIGJ1 ZyBpbiB0aGUgTGF5b3V0VGVzdENvbnRyb2xsZXIgZ2xvYmFsIGhpc3Rvcnkgc3VwcG9ydCBkdWUg dG8gbWlzc2luZyBBUEkuCiBmYXN0L2hpc3Rvcnkvd2luZG93LW9wZW4uaHRtbAogCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmE5YWNhYTk2NWVh ZjQwMDI4ZWZkODM3YTA0OWU5NjkyZDJkMWQ0YS4uYzM2YTY3NDZkZDdkMmU4OWRiOTA2Y2JkYmMz ZjNkNjkxYzM3YzBmYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTAyLTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxt cm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbR1RLXSBFdmVudFNlbmRlci5rZXlEb3duIGRvZXMgbm90IHN1cHBvcnQg bm9uLWFycmF5IG1vZGlmaWVyIGFyZ3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM5NjIKKworICAgICAgICBTdXBwb3J0IGhhbmRsaW5nIGVp dGhlciBhbiBhcnJheSBvciBhIHN0cmluZyBmb3IgdGhlIG1vZGlmaWVyIGFyZ3VtZW50CisgICAg ICAgIHRvIEV2ZW50U2VuZGVyLmtleURvd24uCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9n dGsvRXZlbnRTZW5kZXIuY3BwOgorICAgICAgICAoZ2RrTW9kaWZpZXJGcm9tSlNWYWx1ZSk6IEFk ZGVkIHRoaXMgaGVscGVyIHdoaWNoIGZhY3RvcnMgb3V0IHRoZQorICAgICAgICBzdHJpbmcgY29t cGFyaXNvbiBiaXRzLgorICAgICAgICAoZ2RrTW9kaWZlcnNGcm9tSlNWYWx1ZSk6IFRlc3QgdXAg ZnJvbnQgd2hldGhlciB0aGUgdmFsdWUgaXMgYSBzdHJpbmcsCisgICAgICAgIHRvIGhhbmRsZSBp dCBzcGVjaWFsbHkuCisKIDIwMTEtMDItMDcgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJv cmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKaW5kZXggOTIzYTRiYTExNTYwYzdlMGNi ZDY2MmMzNjk4Yzg2NTI0NTUyNjk0YS4uMTBlMTI5Y2I1YThlMjhhOTJkNWUwNzAwODIxOWM2MjU1 MGIxMmM3OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVy LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCkBAIC0y NDAsMzMgKzI0MCw0MiBAQCBzdGF0aWMgdm9pZCB1cGRhdGVDbGlja0NvdW50KGludCBidXR0b24p CiAgICAgICAgIGNsaWNrQ291bnQrKzsKIH0KIAorc3RhdGljIGd1aW50IGdka01vZGlmaWVyRnJv bUpTVmFsdWUoSlNDb250ZXh0UmVmIGNvbnRleHQsIGNvbnN0IEpTVmFsdWVSZWYgdmFsdWUpCit7 CisgICAgSlNTdHJpbmdSZWYgc3RyaW5nID0gSlNWYWx1ZVRvU3RyaW5nQ29weShjb250ZXh0LCB2 YWx1ZSwgMCk7CisgICAgZ3VpbnQgZ2RrTW9kaWZpZXIgPSAwOworICAgIGlmIChKU1N0cmluZ0lz RXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgImN0cmxLZXkiKQorICAgICAgICB8fCBKU1N0cmlu Z0lzRXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgImFkZFNlbGVjdGlvbktleSIpKQorICAgICAg ICBnZGtNb2RpZmllciA9IEdES19DT05UUk9MX01BU0s7CisgICAgZWxzZSBpZiAoSlNTdHJpbmdJ c0VxdWFsVG9VVEY4Q1N0cmluZyhzdHJpbmcsICJzaGlmdEtleSIpCisgICAgICAgICAgICAgfHwg SlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhzdHJpbmcsICJyYW5nZVNlbGVjdGlvbktleSIp KQorICAgICAgICBnZGtNb2RpZmllciA9IEdES19TSElGVF9NQVNLOworICAgIGVsc2UgaWYgKEpT U3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAiYWx0S2V5IikpCisgICAgICAgIGdk a01vZGlmaWVyID0gR0RLX01PRDFfTUFTSzsKKyAgICAKKyAgICAvLyBDdXJyZW50bHkgdGhlIG1l dGFLZXkgYXMgZGVmaW5lZCBpbiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9Nb3VzZUV2ZW50R3RrLmNw cAorICAgIC8vIGlzIEdES19NT0QyX01BU0suIFRoaXMgY29kZSBtdXN0IGJlIGtlcHQgaW4gc3lu YyB3aXRoIHRoYXQgZmlsZS4KKyAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3Ry aW5nKHN0cmluZywgIm1ldGFLZXkiKSkKKyAgICAgICAgZ2RrTW9kaWZpZXIgPSBHREtfTU9EMl9N QVNLOworICAgIAorICAgIEpTU3RyaW5nUmVsZWFzZShzdHJpbmcpOworICAgIHJldHVybiBnZGtN b2RpZmllcjsKK30KKwogc3RhdGljIGd1aW50IGdka01vZGlmZXJzRnJvbUpTVmFsdWUoSlNDb250 ZXh0UmVmIGNvbnRleHQsIGNvbnN0IEpTVmFsdWVSZWYgbW9kaWZpZXJzKQogeworICAgIC8vIFRo ZSB2YWx1ZSBtYXkgZWl0aGVyIGJlIGEgc3RyaW5nIHdpdGggYSBzaW5nbGUgbW9kaWZpZXIgb3Ig YW4gYXJyYXkgb2YgbW9kaWZpZXJzLgorICAgIGlmIChKU1ZhbHVlSXNTdHJpbmcoY29udGV4dCwg bW9kaWZpZXJzKSkKKyAgICAgICAgcmV0dXJuIGdka01vZGlmaWVyRnJvbUpTVmFsdWUoY29udGV4 dCwgbW9kaWZpZXJzKTsKKwogICAgIEpTT2JqZWN0UmVmIG1vZGlmaWVyc0FycmF5ID0gSlNWYWx1 ZVRvT2JqZWN0KGNvbnRleHQsIG1vZGlmaWVycywgMCk7CiAgICAgaWYgKCFtb2RpZmllcnNBcnJh eSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBndWludCBnZGtNb2RpZmllcnMgPSAwOwogICAg IGludCBtb2RpZmllcnNDb3VudCA9IEpTVmFsdWVUb051bWJlcihjb250ZXh0LCBKU09iamVjdEdl dFByb3BlcnR5KGNvbnRleHQsIG1vZGlmaWVyc0FycmF5LCBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4 Q1N0cmluZygibGVuZ3RoIiksIDApLCAwKTsKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IG1vZGlm aWVyc0NvdW50OyArK2kpIHsKLSAgICAgICAgSlNWYWx1ZVJlZiB2YWx1ZSA9IEpTT2JqZWN0R2V0 UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIG1vZGlmaWVyc0FycmF5LCBpLCAwKTsKLSAgICAgICAg SlNTdHJpbmdSZWYgc3RyaW5nID0gSlNWYWx1ZVRvU3RyaW5nQ29weShjb250ZXh0LCB2YWx1ZSwg MCk7Ci0gICAgICAgIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgImN0 cmxLZXkiKQotICAgICAgICAgICAgfHwgSlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhzdHJp bmcsICJhZGRTZWxlY3Rpb25LZXkiKSkKLSAgICAgICAgICAgIGdka01vZGlmaWVycyB8PSBHREtf Q09OVFJPTF9NQVNLOwotICAgICAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3Ry aW5nKHN0cmluZywgInNoaWZ0S2V5IikKLSAgICAgICAgICAgICAgICAgfHwgSlNTdHJpbmdJc0Vx dWFsVG9VVEY4Q1N0cmluZyhzdHJpbmcsICJyYW5nZVNlbGVjdGlvbktleSIpKQotICAgICAgICAg ICAgZ2RrTW9kaWZpZXJzIHw9IEdES19TSElGVF9NQVNLOwotICAgICAgICBlbHNlIGlmIChKU1N0 cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgImFsdEtleSIpKQotICAgICAgICAgICAg Z2RrTW9kaWZpZXJzIHw9IEdES19NT0QxX01BU0s7Ci0KLSAgICAgICAgLy8gQ3VycmVudGx5IHRo ZSBtZXRhS2V5IGFzIGRlZmluZWQgaW4gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTW91c2VFdmVudEd0 ay5jcHAKLSAgICAgICAgLy8gaXMgR0RLX01PRDJfTUFTSy4gVGhpcyBjb2RlIG11c3QgYmUga2Vw dCBpbiBzeW5jIHdpdGggdGhhdCBmaWxlLgotICAgICAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1 YWxUb1VURjhDU3RyaW5nKHN0cmluZywgIm1ldGFLZXkiKSkKLSAgICAgICAgICAgIGdka01vZGlm aWVycyB8PSBHREtfTU9EMl9NQVNLOwotCi0gICAgICAgIEpTU3RyaW5nUmVsZWFzZShzdHJpbmcp OwotICAgIH0KKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG1vZGlmaWVyc0NvdW50OyArK2kpCisg ICAgICAgIGdka01vZGlmaWVycyB8PSBnZGtNb2RpZmllckZyb21KU1ZhbHVlKGNvbnRleHQsIEpT T2JqZWN0R2V0UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIG1vZGlmaWVyc0FycmF5LCBpLCAwKSk7 CiAgICAgcmV0dXJuIGdka01vZGlmaWVyczsKIH0KIAo=