53950 2011-02-07 14:57:06 -0800 USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in Platform.h instead 2011-06-18 12:37:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bdakin bdakin abarth bdakin darin eric mihaip mjs webkit.review.bot oldest_to_newest 346837 0 bdakin 2011-02-07 14:57:06 -0800 Title says it all. 346838 1 81530 bdakin 2011-02-07 14:57:35 -0800 Created attachment 81530 Patch 346848 2 81530 eric 2011-02-07 15:05:53 -0800 Comment on attachment 81530 Patch I'm not sure if this should be ENABLE or USE, but OK. 346861 3 mjs 2011-02-07 15:12:17 -0800 I suggest USE() instead of ENABLE() 346997 4 webkit.review.bot 2011-02-07 18:11:31 -0800 http://trac.webkit.org/changeset/77871 might have broken Leopard Intel Release (Build) 81530 2011-02-07 14:57:35 -0800 2011-02-07 15:05:53 -0800 Patch for-review.txt text/plain 6551 bdakin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzc4NDcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAK KzIwMTEtMDItMDcgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTW92ZSAjZGVmaW5l IG9mIFdLX1NDUk9MTEJBUl9QQUlOVEVSIHRvIFBsYXRmb3JtLmgKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDoKKwogMjAxMS0wMi0wNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA3Nzg0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNjA3LDYgKzYwNyw3IEBACiAj aWYgIWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xF T1BBUkQpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKICNkZWZpbmUgRU5B QkxFX0dFU1RVUkVfRVZFTlRTIDEKICNkZWZpbmUgRU5BQkxFX1JVQkJFUl9CQU5ESU5HIDEKKyNk ZWZpbmUgRU5BQkxFX1dLX1NDUk9MTEJBUl9QQUlOVEVSIDEKICNlbmRpZgogI2lmICFkZWZpbmVk KEVOQUJMRV9KQVZBX0JSSURHRSkKICNkZWZpbmUgRU5BQkxFX0pBVkFfQlJJREdFIDEKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDc3ODQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMDcgIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVzZSBob3QgbmV3IEVOQUJMRShXS19TQ1JPTExCQVJfUEFJTlRFUikgZnJvbSBQ bGF0Zm9ybS5oIHJhdGhlcgorICAgICAgICB0aGFuIHRoZSBzaWxseSwgb2xkIGluLWZpbGUgI2Rl ZmluZS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbToKKyAg ICAgICAgKCtbU2Nyb2xsYmFyUHJlZnNPYnNlcnZlciBhcHBlYXJhbmNlUHJlZnNDaGFuZ2VkOl0p OgorICAgICAgICAoV2ViQ29yZTo6dXBkYXRlQXJyb3dQbGFjZW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OnJlZ2lzdGVyU2Nyb2xsYmFyKToKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjpzY3JvbGxiYXJUaGlja25lc3MpOgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OnVzZXNPdmVybGF5U2Nyb2xsYmFycyk6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZU1hYzo6aGFzVGh1bWIpOgorICAgICAgICAoV2Vi Q29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6Om1pbmltdW1UaHVtYkxlbmd0aCk6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxiYXJUaGVtZU1hYzo6cGFpbnQpOgorCiAyMDExLTAyLTA3ICBMdWNhcyBG b3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH ZW9mZnJleSBHYXJlbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxi YXJUaGVtZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv U2Nyb2xsYmFyVGhlbWVNYWMubW0JKHJldmlzaW9uIDc3ODQxKQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNiwx MCArMzYsNiBAQAogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KICNpbmNsdWRlIDx3dGYv VW51c2VkUGFyYW0uaD4KIAotI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKSAmJiAhZGVm aW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9TTk9XX0xF T1BBUkQpCi0jZGVmaW5lIFVTRV9XS19TQ1JPTExCQVJfUEFJTlRFUgotI2VuZGlmCi0KIC8vIEZJ WE1FOiBUaGVyZSBhcmUgcmVwYWludGluZyBwcm9ibGVtcyBkdWUgdG8gQXF1YSBzY3JvbGwgYmFy IGJ1dHRvbnMnIHZpc3VhbCBvdmVyZmxvdy4KIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsKQEAgLTQ3 LDcgKzQzLDcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAotI2lmIGRlZmluZWQoVVNFX1dLX1NDUk9MTEJBUl9QQUlOVEVSKQorI2lmIEVOQUJMRShX S19TQ1JPTExCQVJfUEFJTlRFUikKIHR5cGVkZWYgSGFzaE1hcDxTY3JvbGxiYXIqLCBSZXRhaW5Q dHI8V0tTY3JvbGxiYXJQYWludGVyUmVmPiA+IFNjcm9sbGJhclBhaW50ZXJNYXA7CiAjZWxzZQog dHlwZWRlZiBIYXNoU2V0PFNjcm9sbGJhcio+IFNjcm9sbGJhclBhaW50ZXJNYXA7CkBAIC04Myw3 ICs3OSw3IEBAICsgKHZvaWQpYXBwZWFyYW5jZVByZWZzQ2hhbmdlZDooTlNOb3RpZmkKICAgICAg ICAgcmV0dXJuOwogICAgIFNjcm9sbGJhclBhaW50ZXJNYXA6Oml0ZXJhdG9yIGVuZCA9IHNjcm9s bGJhck1hcCgpLT5lbmQoKTsKICAgICBmb3IgKFNjcm9sbGJhclBhaW50ZXJNYXA6Oml0ZXJhdG9y IGl0ID0gc2Nyb2xsYmFyTWFwKCktPmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewotI2lmIGRl ZmluZWQoVVNFX1dLX1NDUk9MTEJBUl9QQUlOVEVSKQorI2lmIEVOQUJMRShXS19TQ1JPTExCQVJf UEFJTlRFUikKICAgICAgICAgaXQtPmZpcnN0LT5zdHlsZUNoYW5nZWQoKTsKICAgICAgICAgaXQt PmZpcnN0LT5pbnZhbGlkYXRlKCk7CiAjZWxzZQpAQCAtMTIxLDcgKzExNyw3IEBAIHN0YXRpYyBp bnQgY1JlYWxCdXR0b25MZW5ndGhbXSA9IHsgMjgsIDIKIHN0YXRpYyBpbnQgY0J1dHRvbkhpdElu c2V0W10gPSB7IDMsIDIgfTsKIC8vIGNSZWFsQnV0dG9uTGVuZ3RoIC0gY0J1dHRvbkluc2V0CiBz dGF0aWMgaW50IGNCdXR0b25MZW5ndGhbXSA9IHsgMTQsIDEwIH07Ci0jaWYgIWRlZmluZWQoVVNF X1dLX1NDUk9MTEJBUl9QQUlOVEVSKQorI2lmICFFTkFCTEUoV0tfU0NST0xMQkFSX1BBSU5URVIp CiBzdGF0aWMgaW50IGNTY3JvbGxiYXJUaGlja25lc3NbXSA9IHsgMTUsIDExIH07CiBzdGF0aWMg aW50IGNCdXR0b25JbnNldFtdID0geyAxNCwgMTEgfTsKIHN0YXRpYyBpbnQgY1RodW1iTWluTGVu Z3RoW10gPSB7IDI2LCAyMCB9OwpAQCAtMTM0LDcgKzEzMCw3IEBAIHN0YXRpYyBmbG9hdCBnSW5p dGlhbEJ1dHRvbkRlbGF5ID0gMC41ZjsKIHN0YXRpYyBmbG9hdCBnQXV0b3Njcm9sbEJ1dHRvbkRl bGF5ID0gMC4wNWY7CiBzdGF0aWMgYm9vbCBnSnVtcE9uVHJhY2tDbGljayA9IGZhbHNlOwogCi0j aWYgZGVmaW5lZChVU0VfV0tfU0NST0xMQkFSX1BBSU5URVIpCisjaWYgRU5BQkxFKFdLX1NDUk9M TEJBUl9QQUlOVEVSKQogc3RhdGljIFNjcm9sbGJhckJ1dHRvbnNQbGFjZW1lbnQgZ0J1dHRvblBs YWNlbWVudCA9IFNjcm9sbGJhckJ1dHRvbnNOb25lOwogI2Vsc2UKIHN0YXRpYyBTY3JvbGxiYXJC dXR0b25zUGxhY2VtZW50IGdCdXR0b25QbGFjZW1lbnQgPSBTY3JvbGxiYXJCdXR0b25zRG91Ymxl RW5kOwpAQCAtMTUwLDcgKzE0Niw3IEBAIHN0YXRpYyB2b2lkIHVwZGF0ZUFycm93UGxhY2VtZW50 KCkKICAgICBlbHNlIGlmIChbYnV0dG9uUGxhY2VtZW50IGlzRXF1YWxUb1N0cmluZzpAIkRvdWJs ZUJvdGgiXSkKICAgICAgICAgZ0J1dHRvblBsYWNlbWVudCA9IFNjcm9sbGJhckJ1dHRvbnNEb3Vi bGVCb3RoOwogICAgIGVsc2UgewotI2lmIGRlZmluZWQoVVNFX1dLX1NDUk9MTEJBUl9QQUlOVEVS KQorI2lmIEVOQUJMRShXS19TQ1JPTExCQVJfUEFJTlRFUikKICAgICAgICAgZ0J1dHRvblBsYWNl bWVudCA9IFNjcm9sbGJhckJ1dHRvbnNOb25lOwogI2Vsc2UKICAgICAgICAgZ0J1dHRvblBsYWNl bWVudCA9IFNjcm9sbGJhckJ1dHRvbnNEb3VibGVFbmQ7CkBAIC0xNjAsNyArMTU2LDcgQEAgc3Rh dGljIHZvaWQgdXBkYXRlQXJyb3dQbGFjZW1lbnQoKQogCiB2b2lkIFNjcm9sbGJhclRoZW1lTWFj OjpyZWdpc3RlclNjcm9sbGJhcihTY3JvbGxiYXIqIHNjcm9sbGJhcikKIHsKLSNpZiBkZWZpbmVk KFVTRV9XS19TQ1JPTExCQVJfUEFJTlRFUikKKyNpZiBFTkFCTEUoV0tfU0NST0xMQkFSX1BBSU5U RVIpCiAgICAgYm9vbCBpc0hvcml6b250YWwgPSBzY3JvbGxiYXItPm9yaWVudGF0aW9uKCkgPT0g SG9yaXpvbnRhbFNjcm9sbGJhcjsKICAgICBXS1Njcm9sbGJhclBhaW50ZXJSZWYgc2Nyb2xsYmFy UGFpbnRlciA9IHdrTWFrZVNjcm9sbGJhclBhaW50ZXIoc2Nyb2xsYmFyLT5jb250cm9sU2l6ZSgp LCBpc0hvcml6b250YWwpOwogICAgIHNjcm9sbGJhck1hcCgpLT5hZGQoc2Nyb2xsYmFyLCBzY3Jv bGxiYXJQYWludGVyKTsKQEAgLTIxMyw3ICsyMDksNyBAQCB2b2lkIFNjcm9sbGJhclRoZW1lTWFj OjpwcmVmZXJlbmNlc0NoYW5nCiAKIGludCBTY3JvbGxiYXJUaGVtZU1hYzo6c2Nyb2xsYmFyVGhp Y2tuZXNzKFNjcm9sbGJhckNvbnRyb2xTaXplIGNvbnRyb2xTaXplKQogewotI2lmIGRlZmluZWQo VVNFX1dLX1NDUk9MTEJBUl9QQUlOVEVSKQorI2lmIEVOQUJMRShXS19TQ1JPTExCQVJfUEFJTlRF UikKICAgICByZXR1cm4gd2tTY3JvbGxiYXJUaGlja25lc3MoY29udHJvbFNpemUpOwogI2Vsc2UK ICAgICByZXR1cm4gY1Njcm9sbGJhclRoaWNrbmVzc1tjb250cm9sU2l6ZV07CkBAIC0yMjIsNyAr MjE4LDcgQEAgaW50IFNjcm9sbGJhclRoZW1lTWFjOjpzY3JvbGxiYXJUaGlja25lcwogCiBib29s IFNjcm9sbGJhclRoZW1lTWFjOjp1c2VzT3ZlcmxheVNjcm9sbGJhcnMoKSBjb25zdAogewotI2lm IGRlZmluZWQoVVNFX1dLX1NDUk9MTEJBUl9QQUlOVEVSKQorI2lmIEVOQUJMRShXS19TQ1JPTExC QVJfUEFJTlRFUikKICAgICByZXR1cm4gd2tTY3JvbGxiYXJQYWludGVyVXNlc092ZXJsYXlTY3Jv bGxlcnMoKTsKICNlbHNlCiAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMjU1LDcgKzI1MSw3IEBAIGJv b2wgU2Nyb2xsYmFyVGhlbWVNYWM6Omhhc0J1dHRvbnMoU2Nyb2wKIGJvb2wgU2Nyb2xsYmFyVGhl bWVNYWM6Omhhc1RodW1iKFNjcm9sbGJhciogc2Nyb2xsYmFyKQogewogICAgIGludCBtaW5MZW5n dGhGb3JUaHVtYjsKLSNpZiBkZWZpbmVkKFVTRV9XS19TQ1JPTExCQVJfUEFJTlRFUikKKyNpZiBF TkFCTEUoV0tfU0NST0xMQkFSX1BBSU5URVIpCiAgICAgbWluTGVuZ3RoRm9yVGh1bWIgPSB3a1Nj cm9sbGJhck1pbmltdW1Ub3RhbExlbmd0aE5lZWRlZEZvclRodW1iKHNjcm9sbGJhck1hcCgpLT5n ZXQoc2Nyb2xsYmFyKS5nZXQoKSk7CiAjZWxzZQogICAgIG1pbkxlbmd0aEZvclRodW1iID0gMiAq IGNCdXR0b25JbnNldFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCldICsgY1RodW1iTWluTGVuZ3Ro W3Njcm9sbGJhci0+Y29udHJvbFNpemUoKV0gKyAxOwpAQCAtMzk2LDcgKzM5Miw3IEBAIEludFJl Y3QgU2Nyb2xsYmFyVGhlbWVNYWM6OnRyYWNrUmVjdChTY3IKIAogaW50IFNjcm9sbGJhclRoZW1l TWFjOjptaW5pbXVtVGh1bWJMZW5ndGgoU2Nyb2xsYmFyKiBzY3JvbGxiYXIpCiB7Ci0jaWYgZGVm aW5lZChVU0VfV0tfU0NST0xMQkFSX1BBSU5URVIpCisjaWYgRU5BQkxFKFdLX1NDUk9MTEJBUl9Q QUlOVEVSKQogICAgIHJldHVybiB3a1Njcm9sbGJhck1pbmltdW1UaHVtYkxlbmd0aChzY3JvbGxi YXJNYXAoKS0+Z2V0KHNjcm9sbGJhcikuZ2V0KCkpOwogI2Vsc2UKICAgICByZXR1cm4gY1RodW1i TWluTGVuZ3RoW3Njcm9sbGJhci0+Y29udHJvbFNpemUoKV07CkBAIC00MzIsNyArNDI4LDcgQEAg c3RhdGljIGludCBzY3JvbGxiYXJQYXJ0VG9ISVByZXNzZWRTdGF0ZQogCiBib29sIFNjcm9sbGJh clRoZW1lTWFjOjpwYWludChTY3JvbGxiYXIqIHNjcm9sbGJhciwgR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0LCBjb25zdCBJbnRSZWN0JiBkYW1hZ2VSZWN0KQogewotI2lmIGRlZmluZWQoVVNFX1dL X1NDUk9MTEJBUl9QQUlOVEVSKQorI2lmIEVOQUJMRShXS19TQ1JPTExCQVJfUEFJTlRFUikKICAg ICBmbG9hdCB2YWx1ZSA9IDAuMGY7CiAgICAgZmxvYXQgdG90YWxTaXplID0gMC4wZjsKIAo=