53949 2011-02-07 14:56:34 -0800 ImageDecoder.h hardcodes RGBA byteorder on Skia 2011-02-08 09:17:09 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned abarth commit-queue eric pkasting oldest_to_newest 346836 0 gwright 2011-02-07 14:56:34 -0800 At the moment the setRGBA function in ImageDecoder.h hard codes the colour byte order: *dest = (a << 24 | r << 16 | g << 8 | b); In Skia's case this should use Skia's helper function SkPackARGB32. 346839 1 81531 gwright 2011-02-07 15:00:13 -0800 Created attachment 81531 Use SkPackARGB32 in Skia's case Patch to use SkPackARGB32 in Skia's case. 346850 2 eric 2011-02-07 15:07:11 -0800 I'm confused why this needs to be in a shared file. 346855 3 pkasting 2011-02-07 15:09:41 -0800 This looks OK to me. (In reply to comment #2) > I'm confused why this needs to be in a shared file. It needs to be inlined into all the decoders. 346914 4 81531 abarth 2011-02-07 16:00:12 -0800 Comment on attachment 81531 Use SkPackARGB32 in Skia's case This change is fine, but it illustrates some of the design problems with this class. 347366 5 81531 paroga 2011-02-08 07:44:15 -0800 Comment on attachment 81531 Use SkPackARGB32 in Skia's case cq+ as requested by gw280 on IRC 347437 6 commit-queue 2011-02-08 09:15:52 -0800 The commit-queue encountered the following flaky tests while processing attachment 81531: http/tests/websocket/tests/error-detect.html bug 54012 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 347438 7 81531 commit-queue 2011-02-08 09:17:04 -0800 Comment on attachment 81531 Use SkPackARGB32 in Skia's case Clearing flags on attachment: 81531 Committed r77946: <http://trac.webkit.org/changeset/77946> 347439 8 commit-queue 2011-02-08 09:17:09 -0800 All reviewed patches have been landed. Closing bug. 81531 2011-02-07 15:00:13 -0800 2011-02-08 09:17:04 -0800 Use SkPackARGB32 in Skia's case colourorder.patch text/plain 1876 gwright Y29tbWl0IGMxNmM4ZDlmMWZkZDZlYmMwNmJhN2QwZGJlMjUxNjUzNDMwMTRiY2EKQXV0aG9yOiBH ZW9yZ2UgV3JpZ2h0IDxnd3JpZ2h0QHJpbS5jb20+CkRhdGU6ICAgTW9uIEZlYiA3IDE3OjQ5OjUz IDIwMTEgLTA1MDAKCiAgICAyMDExLTAyLTA3ICBHZW9yZ2UgV3JpZ2h0ICA8Z3dyaWdodEByaW0u Y29tPgogICAgCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUzOTQ5CiAgICAKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAg ICAgIEVuc3VyZSB0aGF0IHdlIHBhY2sgdGhlIGNvbG91ciBieXRlIG9yZGVyIGNvcnJlY3RseSBm b3IgU2tpYSB1c2luZwogICAgICAgIFNraWEncyBTa1BhY2tBUkdCMzIgZnVuY3Rpb24uCiAgICAK ICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oOgogICAgICAg IChXZWJDb3JlOjpJbWFnZUZyYW1lOjpzZXRSR0JBKToKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMzZDE4MS4u NmQ2NTgyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAyLTA3ICBHZW9yZ2Ug V3JpZ2h0ICA8Z3dyaWdodEByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01Mzk0OQorCisgICAgICAgIEVuc3VyZSB0aGF0IHdlIHBhY2sgdGhlIGNvbG91ciBieXRlIG9y ZGVyIGNvcnJlY3RseSBmb3IgU2tpYSB1c2luZworICAgICAgICBTa2lhJ3MgU2tQYWNrQVJHQjMy IGZ1bmN0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNv ZGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUZyYW1lOjpzZXRSR0JBKToKKwogMjAxMS0w Mi0wNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBidWlsZC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdl RGVjb2Rlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VE ZWNvZGVyLmgKaW5kZXggYzU5NGJjOS4uOGE3ZjRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmgKQEAgLTM5LDYgKzM5 LDcgQEAKIAogI2lmIFBMQVRGT1JNKFNLSUEpCiAjaW5jbHVkZSAiTmF0aXZlSW1hZ2VTa2lhLmgi CisjaW5jbHVkZSAiU2tDb2xvclByaXYuaCIKICNlbGlmIFBMQVRGT1JNKFFUKQogI2luY2x1ZGUg PFFQaXhtYXA+CiAjaW5jbHVkZSA8UUltYWdlPgpAQCAtMTc0LDcgKzE3NSwxMSBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgICAgICAgICAgICAgICAgIGcgPSBzdGF0aWNfY2FzdDx1bnNpZ25l ZD4oZyAqIGFscGhhUGVyY2VudCk7CiAgICAgICAgICAgICAgICAgICAgIGIgPSBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4oYiAqIGFscGhhUGVyY2VudCk7CiAgICAgICAgICAgICAgICAgfQorI2lmIFBM QVRGT1JNKFNLSUEpCisgICAgICAgICAgICAgICAgKmRlc3QgPSBTa1BhY2tBUkdCMzIoYSwgciwg ZywgYik7CisjZWxzZQogICAgICAgICAgICAgICAgICpkZXN0ID0gKGEgPDwgMjQgfCByIDw8IDE2 IHwgZyA8PCA4IHwgYik7CisjZW5kaWYKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCg==