<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>53942</bug_id>
          
          <creation_ts>2011-02-07 14:26:22 -0800</creation_ts>
          <short_desc>[Chromium] Select popup box does not align with select button when appearance is not &quot;menulist&quot;.</short_desc>
          <delta_ts>2011-02-07 23:07:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="xiyuan">xiyuan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>346792</commentid>
    <comment_count>0</comment_count>
      <attachid>81520</attachid>
    <who name="xiyuan">xiyuan</who>
    <bug_when>2011-02-07 14:26:22 -0800</bug_when>
    <thetext>Created attachment 81520
Test case.

When a select element&apos;s appearance is not &quot;menulist&quot;, we use the css padding to calculdate popup width (since https://bugs.webkit.org/show_bug.cgi?id=33235). And this caused the popup box is wider than the select button when appearance is not menulist. And use has no way to fix this via css padding.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346813</commentid>
    <comment_count>1</comment_count>
      <attachid>81523</attachid>
    <who name="xiyuan">xiyuan</who>
    <bug_when>2011-02-07 14:42:22 -0800</bug_when>
    <thetext>Created attachment 81523
Proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346819</commentid>
    <comment_count>2</comment_count>
      <attachid>81525</attachid>
    <who name="xiyuan">xiyuan</who>
    <bug_when>2011-02-07 14:45:15 -0800</bug_when>
    <thetext>Created attachment 81525
Fix typo in manual test name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346917</commentid>
    <comment_count>3</comment_count>
      <attachid>81525</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-02-07 16:06:54 -0800</bug_when>
    <thetext>Comment on attachment 81525
Fix typo in manual test name.

View in context: https://bugs.webkit.org/attachment.cgi?id=81525&amp;action=review

just some small nits

&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1272
&gt; +const int minEndOfLinePadding = 2;

static?  Also, should this be at the top of the file with the other constants?  The other constants are named incorrectly (k prefix), but we can fix that later.

&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1275
&gt; +    bool rightAligned = m_popupClient-&gt;menuStyle().textDirection() == RTL;

Nit: rightAligned -&gt; isRightAligned</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346919</commentid>
    <comment_count>4</comment_count>
      <attachid>81525</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-02-07 16:07:30 -0800</bug_when>
    <thetext>Comment on attachment 81525
Fix typo in manual test name.

View in context: https://bugs.webkit.org/attachment.cgi?id=81525&amp;action=review

&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1349
&gt; +        // Use minEndOfLinePadding when there is a scrollbar.

Why does a scrollbar cause us to need 2 extra pixels?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346939</commentid>
    <comment_count>5</comment_count>
      <attachid>81525</attachid>
    <who name="xiyuan">xiyuan</who>
    <bug_when>2011-02-07 16:36:01 -0800</bug_when>
    <thetext>Comment on attachment 81525
Fix typo in manual test name.

View in context: https://bugs.webkit.org/attachment.cgi?id=81525&amp;action=review

&gt;&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1272

&gt; 
&gt; static?  Also, should this be at the top of the file with the other constants?  The other constants are named incorrectly (k prefix), but we can fix that later.

Done.

&gt;&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1275

&gt; 
&gt; Nit: rightAligned -&gt; isRightAligned

Done

&gt;&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1349
&gt;&gt; +        // Use minEndOfLinePadding when there is a scrollbar.
&gt; 
&gt; Why does a scrollbar cause us to need 2 extra pixels?

Updated the comment to make it more clear.

It&apos;s not that we need the 2 extra pixels. We replace the lineEndPaddingWidth space with the minimum 2 pixel space when there is a scrollbar. In this way, scrollbar will stay as much as possible inside the line end padding space. User could use a big enough &quot;padding-right&quot; (&gt;= scrollbarWidth + 2px) to make the popup listbox align with the select button.

This is because https://bugs.webkit.org/show_bug.cgi?id=33235 makes popup respect the &quot;padding-right&quot;. It works well when there is no scrollbar. But when popup has a scrollbar, the popup is always wider than the select button no matter what padding-right value you use. You can see that from the test case page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346940</commentid>
    <comment_count>6</comment_count>
      <attachid>81550</attachid>
    <who name="xiyuan">xiyuan</who>
    <bug_when>2011-02-07 16:36:52 -0800</bug_when>
    <thetext>Created attachment 81550
Address tony&apos;s comments @3,4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>346943</commentid>
    <comment_count>7</comment_count>
      <attachid>81550</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-02-07 16:41:25 -0800</bug_when>
    <thetext>Comment on attachment 81550
Address tony&apos;s comments @3,4

View in context: https://bugs.webkit.org/attachment.cgi?id=81550&amp;action=review

&gt; Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1353
&gt; +        // Use kMinEndOfLinePadding when there is a scrollbar so that we use
&gt; +        // as much as (lineEndPaddingWidth - kMinEndOfLinePadding) padding
&gt; +        // space for scrollbar and allow user to use CSS padding to make the
&gt; +        // popup listbox align with the select element.
&gt; +        paddingWidth = paddingWidth - lineEndPaddingWidth + kMinEndOfLinePadding;

This comment is much more useful.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>347137</commentid>
    <comment_count>8</comment_count>
      <attachid>81550</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-02-07 23:07:18 -0800</bug_when>
    <thetext>Comment on attachment 81550
Address tony&apos;s comments @3,4

Clearing flags on attachment: 81550

Committed r77907: &lt;http://trac.webkit.org/changeset/77907&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>347139</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-02-07 23:07:24 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>81520</attachid>
            <date>2011-02-07 14:26:22 -0800</date>
            <delta_ts>2011-02-07 14:26:22 -0800</delta_ts>
            <desc>Test case.</desc>
            <filename>select_webkit_appearance_off_popup_alighment.html</filename>
            <type>text/html</type>
            <size>2131</size>
            <attacher name="xiyuan">xiyuan</attacher>
            
              <data encoding="base64">PGh0bWw+Cgo8Ym9keT4KICA8cD5NYW51YWwgdGVzdCBmb3IgcG9wdXAgYWxpZ25tZW50IG9mIHNl
bGVjdCB3aXRoIG5vIGFwcGVyYW5jZS48L3A+CgogIDxwPkFsbCBwb3B1cCBib3hlcyBzaG91bGQg
YWxsIGFsaWduIHdpdGggc2VsZWN0IGVsZW1lbnQgb24gYm90aCBsZWZ0IGFuZCByaWdodCBzaWRl
LjwvcD4KCiAgTm8gc2Nyb2xsYmFyIGluIHBvcHVwOjxicj4KICAKICBMVFI6IDxzZWxlY3Qgc2l6
ZT0iMSIgc3R5bGU9Ii13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsgcGFkZGluZy1yaWdodDogMjBw
eDsiPgogICAgPG9wdGlvbj5JdGVtIDE8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAyPC9vcHRp
b24+CiAgICA8b3B0aW9uPkl0ZW0gMzwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDQ8L29wdGlv
bj4KICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CiAgPC9zZWxlY3Q+CgogIFJUTDogPHNlbGVj
dCBzaXplPSIxIiBkaXI9InJ0bCIgc3R5bGU9Ii13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsgcGFk
ZGluZy1sZWZ0OiAyMHB4OyI+CiAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgogICAgPG9wdGlv
bj5JdGVtIDI8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAzPC9vcHRpb24+CiAgICA8b3B0aW9u
Pkl0ZW0gNDwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDU8L29wdGlvbj4KICA8L3NlbGVjdD4K
CiAgPGJyPgoKICBQb3B1cCBoYXMgc2Nyb2xsYmFyOjxicj4KICBMVFI6IDxzZWxlY3Qgc2l6ZT0i
MSIgc3R5bGU9Ii13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsgcGFkZGluZy1yaWdodDogMjBweDsi
PgogICAgPG9wdGlvbj5JdGVtIDE8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAyPC9vcHRpb24+
CiAgICA8b3B0aW9uPkl0ZW0gMzwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDQ8L29wdGlvbj4K
ICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gNjwvb3B0aW9uPgog
ICAgPG9wdGlvbj5JdGVtIDc8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSA4PC9vcHRpb24+CiAg
ICA8b3B0aW9uPkl0ZW0gOTwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDEwPC9vcHRpb24+CiAg
ICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAxMjwvb3B0aW9uPgog
ICAgPG9wdGlvbj5JdGVtIDEzPC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gMTQ8L29wdGlvbj4K
ICAgIDxvcHRpb24+SXRlbSAxNTwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDE2PC9vcHRpb24+
CiAgICA8b3B0aW9uPkl0ZW0gMTc8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAxODwvb3B0aW9u
PgogICAgPG9wdGlvbj5JdGVtIDE5PC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gMjA8L29wdGlv
bj4KICAgIDxvcHRpb24+SXRlbSAyMTwvb3B0aW9uPgogIDwvc2VsZWN0PgoKICBSVEw6IDxzZWxl
Y3Qgc2l6ZT0iMSIgZGlyPSJydEwiIHN0eWxlPSItd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7IHBh
ZGRpbmctbGVmdDogMjBweDsiPgogICAgPG9wdGlvbj5JdGVtIDE8L29wdGlvbj4KICAgIDxvcHRp
b24+SXRlbSAyPC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gMzwvb3B0aW9uPgogICAgPG9wdGlv
bj5JdGVtIDQ8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CiAgICA8b3B0aW9u
Pkl0ZW0gNjwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDc8L29wdGlvbj4KICAgIDxvcHRpb24+
SXRlbSA4PC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gOTwvb3B0aW9uPgogICAgPG9wdGlvbj5J
dGVtIDEwPC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KICAgIDxvcHRpb24+
SXRlbSAxMjwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDEzPC9vcHRpb24+CiAgICA8b3B0aW9u
Pkl0ZW0gMTQ8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAxNTwvb3B0aW9uPgogICAgPG9wdGlv
bj5JdGVtIDE2PC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gMTc8L29wdGlvbj4KICAgIDxvcHRp
b24+SXRlbSAxODwvb3B0aW9uPgogICAgPG9wdGlvbj5JdGVtIDE5PC9vcHRpb24+CiAgICA8b3B0
aW9uPkl0ZW0gMjA8L29wdGlvbj4KICAgIDxvcHRpb24+SXRlbSAyMTwvb3B0aW9uPgogIDwvc2Vs
ZWN0PgoKPC9ib2R5Pgo8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>81523</attachid>
            <date>2011-02-07 14:42:22 -0800</date>
            <delta_ts>2011-02-07 14:45:15 -0800</delta_ts>
            <desc>Proposed patch.</desc>
            <filename>webkit_53942.patch</filename>
            <type>text/plain</type>
            <size>5276</size>
            <attacher name="xiyuan">xiyuan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3ODQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDcgIFhpeXVhbiBY
aWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU2VsZWN0IHBvcHVwIGJveCBkb2VzIG5vdCBh
bGlnbiB3aXRoIHNlbGVjdCBidXR0b24gd2hlbiBhcHBlYXJhbmNlIGlzIG5vdCAibWVudWxpc3Qi
LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM5NDIK
KworICAgICAgICBBZGRlZCBtYW51YWwgdGVzdCBzZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2Zm
X3BvcHVwX2FsaWdobWVudC5odG1sLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdF93
ZWJraXRfYXBwZWFyYW5jZV9vZmZfcG9wdXBfYWxpZ2htZW50Lmh0bWw6IEFkZGVkLgorICAgICAg
ICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OlBvcHVwTGlzdEJveDo6bGF5b3V0KToKKwogMjAxMS0wMi0wNyAgTHVjYXMgRm9yc2No
bGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZy
ZXkgR2FyZW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0X3dlYmtp
dF9hcHBlYXJhbmNlX29mZl9wb3B1cF9hbGlnaG1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0X3dlYmtpdF9hcHBlYXJhbmNlX29mZl9wb3B1
cF9hbGlnaG1lbnQuaHRtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJDb3JlL21hbnVhbC10
ZXN0cy9zZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2ZmX3BvcHVwX2FsaWdobWVudC5odG1sCShy
ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDc4IEBACis8aHRtbD4KKworPGJvZHk+CisgIDxwPk1hbnVh
bCB0ZXN0IGZvciBwb3B1cCBhbGlnbm1lbnQgb2Ygc2VsZWN0IHdpdGggbm8gYXBwZXJhbmNlLjwv
cD4KKworICA8cD5BbGwgcG9wdXAgYm94ZXMgc2hvdWxkIGFsbCBhbGlnbiB3aXRoIHNlbGVjdCBl
bGVtZW50IG9uIGJvdGggbGVmdCBhbmQgcmlnaHQgc2lkZS48L3A+CisKKyAgTm8gc2Nyb2xsYmFy
IGluIHBvcHVwOjxicj4KKyAgCisgIExUUjogPHNlbGVjdCBzaXplPSIxIiBzdHlsZT0iLXdlYmtp
dC1hcHBlYXJhbmNlOiBub25lOyI+CisgICAgPG9wdGlvbj5JdGVtIDE8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMjwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSAzPC9vcHRpb24+CisgICAg
PG9wdGlvbj5JdGVtIDQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNTwvb3B0aW9uPgorICA8
L3NlbGVjdD4KKworICBSVEw6IDxzZWxlY3Qgc2l6ZT0iMSIgZGlyPSJydGwiIHN0eWxlPSItd2Vi
a2l0LWFwcGVhcmFuY2U6IG5vbmU7Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAg
IDxvcHRpb24+SXRlbSAyPC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAg
ICA8b3B0aW9uPkl0ZW0gNDwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+Cisg
IDwvc2VsZWN0PgorCisgIDxicj4KKworICBQb3B1cCBoYXMgc2Nyb2xsYmFyOjxicj4KKyAgTFRS
OiA8c2VsZWN0IHNpemU9IjEiIHN0eWxlPSItd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7IHBhZGRp
bmctcmlnaHQ6IDIwcHg7Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAgIDxvcHRp
b24+SXRlbSAyPC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAgICA8b3B0
aW9uPkl0ZW0gNDwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CisgICAgPG9w
dGlvbj5JdGVtIDY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNzwvb3B0aW9uPgorICAgIDxv
cHRpb24+SXRlbSA4PC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDk8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMTA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KKyAg
ICA8b3B0aW9uPkl0ZW0gMTI8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTM8L29wdGlvbj4K
KyAgICA8b3B0aW9uPkl0ZW0gMTQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTU8L29wdGlv
bj4KKyAgICA8b3B0aW9uPkl0ZW0gMTY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTc8L29w
dGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTg8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTk8
L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMjA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0g
MjE8L29wdGlvbj4KKyAgPC9zZWxlY3Q+CisKKyAgUlRMOiA8c2VsZWN0IHNpemU9IjEiIGRpcj0i
cnRMIiBzdHlsZT0iLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOyBwYWRkaW5nLWxlZnQ6IDIwcHg7
Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSAyPC9vcHRp
b24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNDwvb3B0
aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDY8L29w
dGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNzwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA4PC9v
cHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDk8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTA8
L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0g
MTI8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTM8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0
ZW0gMTQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTU8L29wdGlvbj4KKyAgICA8b3B0aW9u
Pkl0ZW0gMTY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTc8L29wdGlvbj4KKyAgICA8b3B0
aW9uPkl0ZW0gMTg8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTk8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMjA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMjE8L29wdGlvbj4KKyAg
PC9zZWxlY3Q+CisKKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IFNvdXJj
ZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2ZmX3BvcHVw
X2FsaWdobWVudC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK
SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1
cE1lbnVDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDc3ODQ1KQorKysgU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x
MjY5LDExICsxMjY5LDE1IEBAIHZvaWQgUG9wdXBMaXN0Qm94Ojp1cGRhdGVGcm9tRWxlbWVudCgp
CiAgICAgbGF5b3V0KCk7CiB9CiAKK2NvbnN0IGludCBtaW5FbmRPZkxpbmVQYWRkaW5nID0gMjsK
IHZvaWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogeworICAgIGJvb2wgcmlnaHRBbGlnbmVkID0g
bV9wb3B1cENsaWVudC0+bWVudVN0eWxlKCkudGV4dERpcmVjdGlvbigpID09IFJUTDsKKyAgICAK
ICAgICAvLyBTaXplIG91ciBjaGlsZCBpdGVtcy4KICAgICBpbnQgYmFzZVdpZHRoID0gMDsKICAg
ICBpbnQgcGFkZGluZ1dpZHRoID0gMDsKKyAgICBpbnQgbGluZUVuZFBhZGRpbmdXaWR0aCA9IDA7
CiAgICAgaW50IHkgPSAwOwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtSXRlbXMoKTsgKytp
KSB7CiAgICAgICAgIC8vIFBsYWNlIHRoZSBpdGVtIHZlcnRpY2FsbHkuCkBAIC0xMzA2LDYgKzEz
MTAsOCBAQCB2b2lkIFBvcHVwTGlzdEJveDo6bGF5b3V0KCkKICAgICAgICAgLy8gRklYTUU6IGh0
dHA6Ly9iLzEyMTA0ODEgV2Ugc2hvdWxkIGdldCB0aGUgcGFkZGluZyBvZiBpbmRpdmlkdWFsIG9w
dGlvbiBlbGVtZW50cy4KICAgICAgICAgcGFkZGluZ1dpZHRoID0gbWF4KHBhZGRpbmdXaWR0aCwK
ICAgICAgICAgICAgIG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdMZWZ0KCkgKyBtX3BvcHVw
Q2xpZW50LT5jbGllbnRQYWRkaW5nUmlnaHQoKSk7CisgICAgICAgIGxpbmVFbmRQYWRkaW5nV2lk
dGggPSBtYXgobGluZUVuZFBhZGRpbmdXaWR0aCwKKyAgICAgICAgICAgIHJpZ2h0QWxpZ25lZCA/
IG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdMZWZ0KCkgOiBtX3BvcHVwQ2xpZW50LT5jbGll
bnRQYWRkaW5nUmlnaHQoKSk7CiAgICAgfQogCiAgICAgLy8gQ2FsY3VsYXRlIHNjcm9sbCBiYXIg
d2lkdGguCkBAIC0xMzM3LDkgKzEzNDMsMTMgQEAgdm9pZCBQb3B1cExpc3RCb3g6OmxheW91dCgp
CiAKICAgICAvLyBTZXQgb3VyIHdpZGdldCBhbmQgc2Nyb2xsYWJsZSBjb250ZW50cyBzaXplcy4K
ICAgICBpbnQgc2Nyb2xsYmFyV2lkdGggPSAwOwotICAgIGlmIChtX3Zpc2libGVSb3dzIDwgbnVt
SXRlbXMoKSkKKyAgICBpZiAobV92aXNpYmxlUm93cyA8IG51bUl0ZW1zKCkpIHsKICAgICAgICAg
c2Nyb2xsYmFyV2lkdGggPSBTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKS0+c2Nyb2xsYmFy
VGhpY2tuZXNzKCk7CiAKKyAgICAgICAgLy8gVXNlIG1pbkVuZE9mTGluZVBhZGRpbmcgd2hlbiB0
aGVyZSBpcyBhIHNjcm9sbGJhci4KKyAgICAgICAgcGFkZGluZ1dpZHRoID0gcGFkZGluZ1dpZHRo
IC0gbGluZUVuZFBhZGRpbmdXaWR0aCArIG1pbkVuZE9mTGluZVBhZGRpbmc7CisgICAgfQorCiAg
ICAgaW50IHdpbmRvd1dpZHRoOwogICAgIGludCBjb250ZW50V2lkdGg7CiAgICAgaWYgKG1fc2V0
dGluZ3MucmVzdHJpY3RXaWR0aE9mTGlzdEJveCkgewo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>81525</attachid>
            <date>2011-02-07 14:45:15 -0800</date>
            <delta_ts>2011-02-07 16:36:52 -0800</delta_ts>
            <desc>Fix typo in manual test name.</desc>
            <filename>webkit_53942.patch</filename>
            <type>text/plain</type>
            <size>5276</size>
            <attacher name="xiyuan">xiyuan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3ODQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDcgIFhpeXVhbiBY
aWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU2VsZWN0IHBvcHVwIGJveCBkb2VzIG5vdCBh
bGlnbiB3aXRoIHNlbGVjdCBidXR0b24gd2hlbiBhcHBlYXJhbmNlIGlzIG5vdCAibWVudWxpc3Qi
LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM5NDIK
KworICAgICAgICBBZGRlZCBtYW51YWwgdGVzdCBzZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2Zm
X3BvcHVwX2FsaWdubWVudC5odG1sLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdF93
ZWJraXRfYXBwZWFyYW5jZV9vZmZfcG9wdXBfYWxpZ25tZW50Lmh0bWw6IEFkZGVkLgorICAgICAg
ICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OlBvcHVwTGlzdEJveDo6bGF5b3V0KToKKwogMjAxMS0wMi0wNyAgTHVjYXMgRm9yc2No
bGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZy
ZXkgR2FyZW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0X3dlYmtp
dF9hcHBlYXJhbmNlX29mZl9wb3B1cF9hbGlnbm1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0X3dlYmtpdF9hcHBlYXJhbmNlX29mZl9wb3B1
cF9hbGlnbm1lbnQuaHRtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJDb3JlL21hbnVhbC10
ZXN0cy9zZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2ZmX3BvcHVwX2FsaWdubWVudC5odG1sCShy
ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDc4IEBACis8aHRtbD4KKworPGJvZHk+CisgIDxwPk1hbnVh
bCB0ZXN0IGZvciBwb3B1cCBhbGlnbm1lbnQgb2Ygc2VsZWN0IHdpdGggbm8gYXBwZXJhbmNlLjwv
cD4KKworICA8cD5BbGwgcG9wdXAgYm94ZXMgc2hvdWxkIGFsbCBhbGlnbiB3aXRoIHNlbGVjdCBl
bGVtZW50IG9uIGJvdGggbGVmdCBhbmQgcmlnaHQgc2lkZS48L3A+CisKKyAgTm8gc2Nyb2xsYmFy
IGluIHBvcHVwOjxicj4KKyAgCisgIExUUjogPHNlbGVjdCBzaXplPSIxIiBzdHlsZT0iLXdlYmtp
dC1hcHBlYXJhbmNlOiBub25lOyI+CisgICAgPG9wdGlvbj5JdGVtIDE8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMjwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSAzPC9vcHRpb24+CisgICAg
PG9wdGlvbj5JdGVtIDQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNTwvb3B0aW9uPgorICA8
L3NlbGVjdD4KKworICBSVEw6IDxzZWxlY3Qgc2l6ZT0iMSIgZGlyPSJydGwiIHN0eWxlPSItd2Vi
a2l0LWFwcGVhcmFuY2U6IG5vbmU7Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAg
IDxvcHRpb24+SXRlbSAyPC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAg
ICA8b3B0aW9uPkl0ZW0gNDwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+Cisg
IDwvc2VsZWN0PgorCisgIDxicj4KKworICBQb3B1cCBoYXMgc2Nyb2xsYmFyOjxicj4KKyAgTFRS
OiA8c2VsZWN0IHNpemU9IjEiIHN0eWxlPSItd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7IHBhZGRp
bmctcmlnaHQ6IDIwcHg7Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAgIDxvcHRp
b24+SXRlbSAyPC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAgICA8b3B0
aW9uPkl0ZW0gNDwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CisgICAgPG9w
dGlvbj5JdGVtIDY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNzwvb3B0aW9uPgorICAgIDxv
cHRpb24+SXRlbSA4PC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDk8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMTA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KKyAg
ICA8b3B0aW9uPkl0ZW0gMTI8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTM8L29wdGlvbj4K
KyAgICA8b3B0aW9uPkl0ZW0gMTQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTU8L29wdGlv
bj4KKyAgICA8b3B0aW9uPkl0ZW0gMTY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTc8L29w
dGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTg8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTk8
L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMjA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0g
MjE8L29wdGlvbj4KKyAgPC9zZWxlY3Q+CisKKyAgUlRMOiA8c2VsZWN0IHNpemU9IjEiIGRpcj0i
cnRMIiBzdHlsZT0iLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOyBwYWRkaW5nLWxlZnQ6IDIwcHg7
Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSAyPC9vcHRp
b24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNDwvb3B0
aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDY8L29w
dGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNzwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA4PC9v
cHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDk8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTA8
L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0g
MTI8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTM8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0
ZW0gMTQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTU8L29wdGlvbj4KKyAgICA8b3B0aW9u
Pkl0ZW0gMTY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTc8L29wdGlvbj4KKyAgICA8b3B0
aW9uPkl0ZW0gMTg8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTk8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMjA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMjE8L29wdGlvbj4KKyAg
PC9zZWxlY3Q+CisKKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IFNvdXJj
ZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2ZmX3BvcHVw
X2FsaWdubWVudC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK
SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1
cE1lbnVDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDc3ODQ1KQorKysgU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x
MjY5LDExICsxMjY5LDE1IEBAIHZvaWQgUG9wdXBMaXN0Qm94Ojp1cGRhdGVGcm9tRWxlbWVudCgp
CiAgICAgbGF5b3V0KCk7CiB9CiAKK2NvbnN0IGludCBtaW5FbmRPZkxpbmVQYWRkaW5nID0gMjsK
IHZvaWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogeworICAgIGJvb2wgcmlnaHRBbGlnbmVkID0g
bV9wb3B1cENsaWVudC0+bWVudVN0eWxlKCkudGV4dERpcmVjdGlvbigpID09IFJUTDsKKyAgICAK
ICAgICAvLyBTaXplIG91ciBjaGlsZCBpdGVtcy4KICAgICBpbnQgYmFzZVdpZHRoID0gMDsKICAg
ICBpbnQgcGFkZGluZ1dpZHRoID0gMDsKKyAgICBpbnQgbGluZUVuZFBhZGRpbmdXaWR0aCA9IDA7
CiAgICAgaW50IHkgPSAwOwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtSXRlbXMoKTsgKytp
KSB7CiAgICAgICAgIC8vIFBsYWNlIHRoZSBpdGVtIHZlcnRpY2FsbHkuCkBAIC0xMzA2LDYgKzEz
MTAsOCBAQCB2b2lkIFBvcHVwTGlzdEJveDo6bGF5b3V0KCkKICAgICAgICAgLy8gRklYTUU6IGh0
dHA6Ly9iLzEyMTA0ODEgV2Ugc2hvdWxkIGdldCB0aGUgcGFkZGluZyBvZiBpbmRpdmlkdWFsIG9w
dGlvbiBlbGVtZW50cy4KICAgICAgICAgcGFkZGluZ1dpZHRoID0gbWF4KHBhZGRpbmdXaWR0aCwK
ICAgICAgICAgICAgIG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdMZWZ0KCkgKyBtX3BvcHVw
Q2xpZW50LT5jbGllbnRQYWRkaW5nUmlnaHQoKSk7CisgICAgICAgIGxpbmVFbmRQYWRkaW5nV2lk
dGggPSBtYXgobGluZUVuZFBhZGRpbmdXaWR0aCwKKyAgICAgICAgICAgIHJpZ2h0QWxpZ25lZCA/
IG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdMZWZ0KCkgOiBtX3BvcHVwQ2xpZW50LT5jbGll
bnRQYWRkaW5nUmlnaHQoKSk7CiAgICAgfQogCiAgICAgLy8gQ2FsY3VsYXRlIHNjcm9sbCBiYXIg
d2lkdGguCkBAIC0xMzM3LDkgKzEzNDMsMTMgQEAgdm9pZCBQb3B1cExpc3RCb3g6OmxheW91dCgp
CiAKICAgICAvLyBTZXQgb3VyIHdpZGdldCBhbmQgc2Nyb2xsYWJsZSBjb250ZW50cyBzaXplcy4K
ICAgICBpbnQgc2Nyb2xsYmFyV2lkdGggPSAwOwotICAgIGlmIChtX3Zpc2libGVSb3dzIDwgbnVt
SXRlbXMoKSkKKyAgICBpZiAobV92aXNpYmxlUm93cyA8IG51bUl0ZW1zKCkpIHsKICAgICAgICAg
c2Nyb2xsYmFyV2lkdGggPSBTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKS0+c2Nyb2xsYmFy
VGhpY2tuZXNzKCk7CiAKKyAgICAgICAgLy8gVXNlIG1pbkVuZE9mTGluZVBhZGRpbmcgd2hlbiB0
aGVyZSBpcyBhIHNjcm9sbGJhci4KKyAgICAgICAgcGFkZGluZ1dpZHRoID0gcGFkZGluZ1dpZHRo
IC0gbGluZUVuZFBhZGRpbmdXaWR0aCArIG1pbkVuZE9mTGluZVBhZGRpbmc7CisgICAgfQorCiAg
ICAgaW50IHdpbmRvd1dpZHRoOwogICAgIGludCBjb250ZW50V2lkdGg7CiAgICAgaWYgKG1fc2V0
dGluZ3MucmVzdHJpY3RXaWR0aE9mTGlzdEJveCkgewo=
</data>
<flag name="review"
          id="73119"
          type_id="1"
          status="-"
          setter="tony"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>81550</attachid>
            <date>2011-02-07 16:36:52 -0800</date>
            <delta_ts>2011-02-07 23:07:18 -0800</delta_ts>
            <desc>Address tony&apos;s comments @3,4</desc>
            <filename>webkit_53942.patch</filename>
            <type>text/plain</type>
            <size>5771</size>
            <attacher name="xiyuan">xiyuan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3ODQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDcgIFhpeXVhbiBY
aWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU2VsZWN0IHBvcHVwIGJveCBkb2VzIG5vdCBh
bGlnbiB3aXRoIHNlbGVjdCBidXR0b24gd2hlbiBhcHBlYXJhbmNlIGlzIG5vdCAibWVudWxpc3Qi
LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM5NDIK
KworICAgICAgICBBZGRlZCBtYW51YWwgdGVzdCBzZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2Zm
X3BvcHVwX2FsaWdubWVudC5odG1sLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdF93
ZWJraXRfYXBwZWFyYW5jZV9vZmZfcG9wdXBfYWxpZ25tZW50Lmh0bWw6IEFkZGVkLgorICAgICAg
ICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OlBvcHVwTGlzdEJveDo6bGF5b3V0KToKKwogMjAxMS0wMi0wNyAgTHVjYXMgRm9yc2No
bGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZy
ZXkgR2FyZW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0X3dlYmtp
dF9hcHBlYXJhbmNlX29mZl9wb3B1cF9hbGlnbm1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0X3dlYmtpdF9hcHBlYXJhbmNlX29mZl9wb3B1
cF9hbGlnbm1lbnQuaHRtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJDb3JlL21hbnVhbC10
ZXN0cy9zZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2ZmX3BvcHVwX2FsaWdubWVudC5odG1sCShy
ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDc4IEBACis8aHRtbD4KKworPGJvZHk+CisgIDxwPk1hbnVh
bCB0ZXN0IGZvciBwb3B1cCBhbGlnbm1lbnQgb2Ygc2VsZWN0IHdpdGggbm8gYXBwZXJhbmNlLjwv
cD4KKworICA8cD5BbGwgcG9wdXAgYm94ZXMgc2hvdWxkIGFsbCBhbGlnbiB3aXRoIHNlbGVjdCBl
bGVtZW50IG9uIGJvdGggbGVmdCBhbmQgcmlnaHQgc2lkZS48L3A+CisKKyAgTm8gc2Nyb2xsYmFy
IGluIHBvcHVwOjxicj4KKyAgCisgIExUUjogPHNlbGVjdCBzaXplPSIxIiBzdHlsZT0iLXdlYmtp
dC1hcHBlYXJhbmNlOiBub25lOyI+CisgICAgPG9wdGlvbj5JdGVtIDE8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMjwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSAzPC9vcHRpb24+CisgICAg
PG9wdGlvbj5JdGVtIDQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNTwvb3B0aW9uPgorICA8
L3NlbGVjdD4KKworICBSVEw6IDxzZWxlY3Qgc2l6ZT0iMSIgZGlyPSJydGwiIHN0eWxlPSItd2Vi
a2l0LWFwcGVhcmFuY2U6IG5vbmU7Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAg
IDxvcHRpb24+SXRlbSAyPC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAg
ICA8b3B0aW9uPkl0ZW0gNDwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+Cisg
IDwvc2VsZWN0PgorCisgIDxicj4KKworICBQb3B1cCBoYXMgc2Nyb2xsYmFyOjxicj4KKyAgTFRS
OiA8c2VsZWN0IHNpemU9IjEiIHN0eWxlPSItd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7IHBhZGRp
bmctcmlnaHQ6IDIwcHg7Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAgIDxvcHRp
b24+SXRlbSAyPC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAgICA8b3B0
aW9uPkl0ZW0gNDwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CisgICAgPG9w
dGlvbj5JdGVtIDY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNzwvb3B0aW9uPgorICAgIDxv
cHRpb24+SXRlbSA4PC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDk8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMTA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KKyAg
ICA8b3B0aW9uPkl0ZW0gMTI8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTM8L29wdGlvbj4K
KyAgICA8b3B0aW9uPkl0ZW0gMTQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTU8L29wdGlv
bj4KKyAgICA8b3B0aW9uPkl0ZW0gMTY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTc8L29w
dGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTg8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTk8
L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMjA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0g
MjE8L29wdGlvbj4KKyAgPC9zZWxlY3Q+CisKKyAgUlRMOiA8c2VsZWN0IHNpemU9IjEiIGRpcj0i
cnRMIiBzdHlsZT0iLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOyBwYWRkaW5nLWxlZnQ6IDIwcHg7
Ij4KKyAgICA8b3B0aW9uPkl0ZW0gMTwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSAyPC9vcHRp
b24+CisgICAgPG9wdGlvbj5JdGVtIDM8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNDwvb3B0
aW9uPgorICAgIDxvcHRpb24+SXRlbSA1PC9vcHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDY8L29w
dGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gNzwvb3B0aW9uPgorICAgIDxvcHRpb24+SXRlbSA4PC9v
cHRpb24+CisgICAgPG9wdGlvbj5JdGVtIDk8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTA8
L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTE8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0g
MTI8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTM8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0
ZW0gMTQ8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTU8L29wdGlvbj4KKyAgICA8b3B0aW9u
Pkl0ZW0gMTY8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTc8L29wdGlvbj4KKyAgICA8b3B0
aW9uPkl0ZW0gMTg8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMTk8L29wdGlvbj4KKyAgICA8
b3B0aW9uPkl0ZW0gMjA8L29wdGlvbj4KKyAgICA8b3B0aW9uPkl0ZW0gMjE8L29wdGlvbj4KKyAg
PC9zZWxlY3Q+CisKKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IFNvdXJj
ZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3Rfd2Via2l0X2FwcGVhcmFuY2Vfb2ZmX3BvcHVw
X2FsaWdubWVudC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK
SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1
cE1lbnVDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDc3ODQ1KQorKysgU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03
Myw2ICs3Myw3IEBAIHN0YXRpYyBjb25zdCBpbnQga01heEhlaWdodCA9IDUwMDsKIHN0YXRpYyBj
b25zdCBpbnQga0JvcmRlclNpemUgPSAxOwogc3RhdGljIGNvbnN0IGludCBrVGV4dFRvTGFiZWxQ
YWRkaW5nID0gMTA7CiBzdGF0aWMgY29uc3QgaW50IGtMYWJlbFRvSWNvblBhZGRpbmcgPSA1Owor
c3RhdGljIGNvbnN0IGludCBrTWluRW5kT2ZMaW5lUGFkZGluZyA9IDI7CiBzdGF0aWMgY29uc3Qg
VGltZVN0YW1wIGtUeXBlQWhlYWRUaW1lb3V0TXMgPSAxMDAwOwogCiAvLyBUaGUgc2V0dGluZ3Mg
dXNlZCBmb3IgdGhlIGRyb3AgZG93biBtZW51LgpAQCAtMTI3MSw5ICsxMjcyLDEyIEBAIHZvaWQg
UG9wdXBMaXN0Qm94Ojp1cGRhdGVGcm9tRWxlbWVudCgpCiAKIHZvaWQgUG9wdXBMaXN0Qm94Ojps
YXlvdXQoKQogeworICAgIGJvb2wgaXNSaWdodEFsaWduZWQgPSBtX3BvcHVwQ2xpZW50LT5tZW51
U3R5bGUoKS50ZXh0RGlyZWN0aW9uKCkgPT0gUlRMOworICAgIAogICAgIC8vIFNpemUgb3VyIGNo
aWxkIGl0ZW1zLgogICAgIGludCBiYXNlV2lkdGggPSAwOwogICAgIGludCBwYWRkaW5nV2lkdGgg
PSAwOworICAgIGludCBsaW5lRW5kUGFkZGluZ1dpZHRoID0gMDsKICAgICBpbnQgeSA9IDA7CiAg
ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1JdGVtcygpOyArK2kpIHsKICAgICAgICAgLy8gUGxh
Y2UgdGhlIGl0ZW0gdmVydGljYWxseS4KQEAgLTEzMDYsNiArMTMxMCw4IEBAIHZvaWQgUG9wdXBM
aXN0Qm94OjpsYXlvdXQoKQogICAgICAgICAvLyBGSVhNRTogaHR0cDovL2IvMTIxMDQ4MSBXZSBz
aG91bGQgZ2V0IHRoZSBwYWRkaW5nIG9mIGluZGl2aWR1YWwgb3B0aW9uIGVsZW1lbnRzLgogICAg
ICAgICBwYWRkaW5nV2lkdGggPSBtYXgocGFkZGluZ1dpZHRoLAogICAgICAgICAgICAgbV9wb3B1
cENsaWVudC0+Y2xpZW50UGFkZGluZ0xlZnQoKSArIG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRp
bmdSaWdodCgpKTsKKyAgICAgICAgbGluZUVuZFBhZGRpbmdXaWR0aCA9IG1heChsaW5lRW5kUGFk
ZGluZ1dpZHRoLAorICAgICAgICAgICAgaXNSaWdodEFsaWduZWQgPyBtX3BvcHVwQ2xpZW50LT5j
bGllbnRQYWRkaW5nTGVmdCgpIDogbV9wb3B1cENsaWVudC0+Y2xpZW50UGFkZGluZ1JpZ2h0KCkp
OwogICAgIH0KIAogICAgIC8vIENhbGN1bGF0ZSBzY3JvbGwgYmFyIHdpZHRoLgpAQCAtMTMzNyw5
ICsxMzQzLDE2IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogCiAgICAgLy8gU2V0IG91
ciB3aWRnZXQgYW5kIHNjcm9sbGFibGUgY29udGVudHMgc2l6ZXMuCiAgICAgaW50IHNjcm9sbGJh
cldpZHRoID0gMDsKLSAgICBpZiAobV92aXNpYmxlUm93cyA8IG51bUl0ZW1zKCkpCisgICAgaWYg
KG1fdmlzaWJsZVJvd3MgPCBudW1JdGVtcygpKSB7CiAgICAgICAgIHNjcm9sbGJhcldpZHRoID0g
U2Nyb2xsYmFyVGhlbWU6Om5hdGl2ZVRoZW1lKCktPnNjcm9sbGJhclRoaWNrbmVzcygpOwogCisg
ICAgICAgIC8vIFVzZSBrTWluRW5kT2ZMaW5lUGFkZGluZyB3aGVuIHRoZXJlIGlzIGEgc2Nyb2xs
YmFyIHNvIHRoYXQgd2UgdXNlCisgICAgICAgIC8vIGFzIG11Y2ggYXMgKGxpbmVFbmRQYWRkaW5n
V2lkdGggLSBrTWluRW5kT2ZMaW5lUGFkZGluZykgcGFkZGluZworICAgICAgICAvLyBzcGFjZSBm
b3Igc2Nyb2xsYmFyIGFuZCBhbGxvdyB1c2VyIHRvIHVzZSBDU1MgcGFkZGluZyB0byBtYWtlIHRo
ZQorICAgICAgICAvLyBwb3B1cCBsaXN0Ym94IGFsaWduIHdpdGggdGhlIHNlbGVjdCBlbGVtZW50
LgorICAgICAgICBwYWRkaW5nV2lkdGggPSBwYWRkaW5nV2lkdGggLSBsaW5lRW5kUGFkZGluZ1dp
ZHRoICsga01pbkVuZE9mTGluZVBhZGRpbmc7CisgICAgfQorCiAgICAgaW50IHdpbmRvd1dpZHRo
OwogICAgIGludCBjb250ZW50V2lkdGg7CiAgICAgaWYgKG1fc2V0dGluZ3MucmVzdHJpY3RXaWR0
aE9mTGlzdEJveCkgewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>