53929 2011-02-07 10:47:57 -0800 check-style should not complain about code in icu directories 2016-12-15 19:36:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin dbates ap commit-queue dbates ddkilzer glenn mmaxfield oldest_to_newest 346672 0 darin 2011-02-07 10:47:57 -0800 check-style should not complain about pasted ICU code in UnicodeMacrosFromICU.h; those are using the ICU style 1260489 1 dbates 2016-12-15 19:18:59 -0800 (In reply to comment #0) > check-style should not complain about pasted ICU code in > UnicodeMacrosFromICU.h; those are using the ICU style UnicodeMacrosFromICU.h was removed in the patch for bug #128106, <https://trac.webkit.org/changeset/163315>. Having said that we still have imported ICU headers, say in Source/WebCore/icu, and check-webkit-style should not warn about style issues in such files. 1260490 2 dbates 2016-12-15 19:20:35 -0800 For completeness, this issue caught my eye because of the deluge of style issues reported on each iteration of the patch for bug #160629 (attachment 297271), which imports more ICU headers. 1260494 3 297287 dbates 2016-12-15 19:24:54 -0800 Created attachment 297287 Patch 1260496 4 297287 joepeck 2016-12-15 19:30:45 -0800 Comment on attachment 297287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297287&action=review > Tools/Scripts/webkitpy/style/checker.py:327 > + ] Style: Indentation of this seems weird. Should this have 4 spaces like the block below this? 1260498 5 dbates 2016-12-15 19:35:09 -0800 (In reply to comment #4) > Comment on attachment 297287 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297287&action=review > > > Tools/Scripts/webkitpy/style/checker.py:327 > > + ] > > Style: Indentation of this seems weird. Should this have 4 spaces like the > block below this? Wow, style bot failure. Will fix. 1260499 6 dbates 2016-12-15 19:36:37 -0800 Committed r209902: <http://trac.webkit.org/changeset/209902> 297287 2016-12-15 19:24:54 -0800 2016-12-15 19:29:52 -0800 Patch bug-53929-20161215192401.patch text/plain 1938 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5Nzg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjk2NzJjMjkzNzhmMDZmYmMxMDA4M2Q0YzZmNGViZWM3 ZTYyZjdkYi4uODVkNzU5NjViMDU3NmQzYzIyZDg3NDgzMTI0MDUwZjE1MjExZjEwNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE2LTEyLTE1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBjaGVjay1zdHlsZSBzaG91bGQgbm90IGNvbXBsYWluIGFib3V0IGNvZGUgaW4gaWN1IGRp cmVjdG9yaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MzkyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNraXAgc3R5bGUgY2hlY2tpbmcgb2YgaW1wb3J0ZWQgSUNVIGhlYWRlcnMgdG8gYXZvaWQgYSBk ZWx1Z2Ugb2Ygc3R5bGUgaXNzdWVzCisgICAgICAgIGFzIHRoZXkgZG8gbm90IGNvbmZvcm0gdG8g dGhlIFdlYktpdCBDb2RlIFN0eWxlIGd1aWRlbGluZS4gV2Ugd2FudCB0byBwcmVzZXJ2ZQorICAg ICAgICB0aGUgZm9ybWF0dGluZyBvZiB0aGVzZSBoZWFkZXJzIHNvIGFzIHRvIG1ha2UgaXQgc3Ry YWlnaHRmb3J3YXJkIHRvIG1lcmdlCisgICAgICAgIGNoYW5nZXMgdG8gdGhlbSwgaWYgbmVjZXNz YXJ5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorCiAy MDE2LTEyLTEzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgRml4IENNYWtlIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2VyLnB5CmluZGV4IGUyZmE0ZmQzYTk3YTZjN2ZkMmI4Nzg0M2MyNTJmYzJlYjE5N2Q4NjcuLjJi ZTM1NGZiYWMzMzU1ZWRlMmFlODc0YWEyNDc5OGY5MmNhNjI4YmYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKQEAgLTMxNSw4ICszMTUsMTYgQEAgX1NLSVBQRURfRklM RVNfV0lUSF9XQVJOSU5HID0gWwogIyB3aXRoIEZpbGVUeXBlLk5PTkUgYXJlIGF1dG9tYXRpY2Fs bHkgc2tpcHBlZCB3aXRob3V0IHdhcm5pbmcuCiBfU0tJUFBFRF9GSUxFU19XSVRIT1VUX1dBUk5J TkcgPSBbCiAgICAgIkxheW91dFRlc3RzIiArIG9zLnBhdGguc2VwLAorCiAgICAgIyBGaWxlcyBn ZW5lcmF0ZWQgYnkgdGhlIGJpbmRpbmdzIHNjcmlwdCBzaG91bGQgbm90IGJlIGNoZWNrZWQgZm9y IHN0eWxlLgotICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYkNvcmUnLCAnYmluZGluZ3Mn LCAnc2NyaXB0cycsICd0ZXN0JyldCisgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViQ29y ZScsICdiaW5kaW5ncycsICdzY3JpcHRzJywgJ3Rlc3QnKSwKKworICAgICMgSUNVIGhlYWRlcnMg YXMgdGhleSBhcmUgaW1wb3J0ZWQuCisgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnSmF2YVNj cmlwdENvcmUnLCAnaWN1JyksCisgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViQ29yZScs ICdpY3UnKSwKKyAgICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJLaXQnLCAnbWFjJywgJ2lj dScpLAorICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dURicsICdpY3UnKSwKKyAgXQogCiAj IEV4dGVuc2lvbnMgb2YgZmlsZXMgd2hpY2ggYXJlIGFsbG93ZWQgdG8gY29udGFpbiBjYXJyaWFn ZSByZXR1cm5zLgogX0NBUlJJQUdFX1JFVFVSTl9BTExPV0VEX0ZJTEVfRVhURU5TSU9OUyA9IFsK