53910 2011-02-07 01:29:42 -0800 Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells 2011-02-15 06:41:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo apavlov apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 346513 0 loislo 2011-02-07 01:29:42 -0800 1) open http://build.chromium.org/p/chromium/console 2) do inspect element on a WebKit bot's status bot expected: box is highlighted, text description is attached to the highlight frame. actual: text description shown ~100px lower 350574 1 82300 apavlov 2011-02-14 03:20:53 -0800 Created attachment 82300 [PATCH] Suggested fix 350713 2 82300 commit-queue 2011-02-14 09:43:05 -0800 Comment on attachment 82300 [PATCH] Suggested fix Rejecting attachment 82300 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'build-..." exit_code: 2 Last 500 characters of output: launch-safari', '--exit-after-n..." exit_code: 1 ............................................................................................................................................... inspector ...................................................................... inspector/styles-iframe.html -> failed Exiting early after 1 failures. 12662 tests run. 327.54s total testing time 12661 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 8 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7907646 351221 3 apavlov 2011-02-15 06:41:36 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorAgent.cpp Committed r78553 82300 2011-02-14 03:20:53 -0800 2011-02-14 09:43:05 -0800 [PATCH] Suggested fix highlightpos.patch text/plain 2305 apavlov Y29tbWl0IGRmNGUxOWNkNTk3Mjc3MmU4NjNhZGJlMWJkY2U5MWVmYzZhNDJiNWEKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gRmViIDE0 IDE0OjEzOjI1IDIwMTEgKzAzMDAKCiAgICBGaXhUb29sdGlwUG9zaXRpb25JbklmcmFtZQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCAwNDBjYmUzLi5hZmY4MzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDItMTQgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBoaWdobGlnaHRlciB3b3JrcyBpbmNvcnJlY3QgYXQgYnVpbGQuY2hyb21pdW0ub3JnIFdl YktpdCBjZWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTM5MTAKKworICAgICAgICBVc2UgZW5jbG9zaW5nQm91bmRpbmdCb3ggZm9yIHRoZSBhYnNv bHV0ZSBtYXJnaW4gcXVhZCBhcyB0aGUgcmVmZXJlbmNlIGJveCBmb3IgYSB0b29sdGlwLgorCisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckFnZW50OjpkcmF3Tm9kZUhpZ2hsaWdodCk6CisKIDIwMTEtMDItMTMgIEFudHRp IEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBC ZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y QWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFnZW50LmNwcApp bmRleCA5NTU5MDk5Li5lMTQwYWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JBZ2VudC5jcHAKQEAgLTEwNzIsOSArMTA3Miw2IEBAIHZvaWQgSW5zcGVjdG9yQWdlbnQ6 OmRyYXdOb2RlSGlnaGxpZ2h0KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCkgY29uc3QKICAgICAg ICAgSW50UmVjdCBtYXJnaW5Cb3goYm9yZGVyQm94LngoKSAtIHJlbmRlckJveC0+bWFyZ2luTGVm dCgpLCBib3JkZXJCb3gueSgpIC0gcmVuZGVyQm94LT5tYXJnaW5Ub3AoKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgYm9yZGVyQm94LndpZHRoKCkgKyByZW5kZXJCb3gtPm1hcmdpbkxlZnQo KSArIHJlbmRlckJveC0+bWFyZ2luUmlnaHQoKSwgYm9yZGVyQm94LmhlaWdodCgpICsgcmVuZGVy Qm94LT5tYXJnaW5Ub3AoKSArIHJlbmRlckJveC0+bWFyZ2luQm90dG9tKCkpOwogCi0gICAgICAg IHRpdGxlUmVmZXJlbmNlQm94ID0gbWFyZ2luQm94OwotICAgICAgICB0aXRsZVJlZmVyZW5jZUJv eC5tb3ZlKG1haW5GcmFtZU9mZnNldCk7Ci0gICAgICAgIHRpdGxlUmVmZXJlbmNlQm94Lm1vdmUo Ym91bmRpbmdCb3gueCgpLCBib3VuZGluZ0JveC55KCkpOwogCiAgICAgICAgIEZsb2F0UXVhZCBh YnNDb250ZW50UXVhZCA9IHJlbmRlckJveC0+bG9jYWxUb0Fic29sdXRlUXVhZChGbG9hdFJlY3Qo Y29udGVudEJveCkpOwogICAgICAgICBGbG9hdFF1YWQgYWJzUGFkZGluZ1F1YWQgPSByZW5kZXJC b3gtPmxvY2FsVG9BYnNvbHV0ZVF1YWQoRmxvYXRSZWN0KHBhZGRpbmdCb3gpKTsKQEAgLTEwODYs NiArMTA4Myw4IEBAIHZvaWQgSW5zcGVjdG9yQWdlbnQ6OmRyYXdOb2RlSGlnaGxpZ2h0KEdyYXBo aWNzQ29udGV4dCYgY29udGV4dCkgY29uc3QKICAgICAgICAgYWJzQm9yZGVyUXVhZC5tb3ZlKG1h aW5GcmFtZU9mZnNldCk7CiAgICAgICAgIGFic01hcmdpblF1YWQubW92ZShtYWluRnJhbWVPZmZz ZXQpOwogCisgICAgICAgIHRpdGxlUmVmZXJlbmNlQm94ID0gYWJzTWFyZ2luUXVhZC5lbmNsb3Np bmdCb3VuZGluZ0JveCgpOworCiAgICAgICAgIGRyYXdIaWdobGlnaHRGb3JCb3goY29udGV4dCwg YWJzQ29udGVudFF1YWQsIGFic1BhZGRpbmdRdWFkLCBhYnNCb3JkZXJRdWFkLCBhYnNNYXJnaW5R dWFkKTsKICAgICB9IGVsc2UgaWYgKHJlbmRlcmVyLT5pc1JlbmRlcklubGluZSgpIHx8IGlzU1ZH UmVuZGVyZXIpIHsKICAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBzaG93IG1hcmdpbnMvcGFk ZGluZy9ib3JkZXIgZm9yIGlubGluZXMuCg==