53899 2011-02-06 18:43:14 -0800 [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer. 2011-02-18 02:45:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 morrita webkit-unassigned fishd tkent oldest_to_newest 346430 0 morrita 2011-02-06 18:43:14 -0800 In WebViewHost, there are several calls like: webkit_support::PostDelayedTask(invokeFinishLastTextCheck, static_cast<void*>(this), 0); But this is not safe when |this| object is deleted before the task callback is invoked. Pointed at Bug 51013. 348042 1 tkent 2011-02-09 00:51:41 -0800 (In reply to comment #0) > In WebViewHost, there are several calls like: > webkit_support::PostDelayedTask(invokeFinishLastTextCheck, static_cast<void*>(this), 0); > But this is not safe when |this| object is deleted before the task callback is invoked. Yes. In that case, we had better use DumpRenderTree/chromium/Taks.h instead of the bare PostDelayedTask(). 352666 2 82766 morrita 2011-02-17 01:09:26 -0800 Created attachment 82766 Patch 352672 3 82766 tkent 2011-02-17 01:17:17 -0800 Comment on attachment 82766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82766&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:419 > + postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::finishLastTextCheck), 0); "WebViewHost::" looks redundant. > Tools/DumpRenderTree/chromium/WebViewHost.cpp:662 > + postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::scheduleComposite), 0); ditto. > Tools/DumpRenderTree/chromium/WebViewHost.cpp:709 > + postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::closeWidget), 0); ditto. > Tools/DumpRenderTree/chromium/WebViewHost.h:70 > + class HostMethodTask : public MethodTask<WebViewHost> { Do we need to make this class public? > Tools/DumpRenderTree/chromium/WebViewHost.h:76 > + {} nit: We usually use "{ }" (a blank between {}). 353498 4 82938 morrita 2011-02-18 02:33:50 -0800 Created attachment 82938 Patch 353501 5 morrita 2011-02-18 02:38:18 -0800 Hi Kent-san, thank you for reviewing! I updated the patch. (In reply to comment #3) > (From update of attachment 82766 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82766&action=review > > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:419 > > + postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::finishLastTextCheck), 0); > > "WebViewHost::" looks redundant. Sure. removed. > > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:662 > > + postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::scheduleComposite), 0); > > ditto. Done. > > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:709 > > + postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::closeWidget), 0); > > ditto. Done. > > > Tools/DumpRenderTree/chromium/WebViewHost.h:70 > > + class HostMethodTask : public MethodTask<WebViewHost> { > > Do we need to make this class public? Good point. Moved to private. > > > Tools/DumpRenderTree/chromium/WebViewHost.h:76 > > + {} > > nit: We usually use "{ }" (a blank between {}). Done. 353504 6 morrita 2011-02-18 02:45:30 -0800 Committed r78984: <http://trac.webkit.org/changeset/78984> 82766 2011-02-17 01:09:26 -0800 2011-02-18 02:33:45 -0800 Patch bug-53899-20110217180924.patch text/plain 5182 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogNzg3OTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0YjNlYjRlZTRlYWE4YmJhMTRmNTNlMWMxODM2ZWM2OTdk YzA5ZTU5Li4wOGZjZDI0MGI5N2M2ODk1MWJlYWQwY2JkMGZlNDI3NWNmZWMwZTFlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDItMTYgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXVtE UlRdIHNvbWUgUG9zdERlbGF5ZWRUYXNrKCkgYWNjZXNzZXMgcG9zc2libHkgZGFuZ2xpbmcgdGhp cyBwb2ludGVyLgorICAgICAgICBodHRwOi8vd2Via2l0Lm9yZy9iLzUzODk5CisKKyAgICAgICAg UmVwbGFjZWQgc3RhdGljIGludm9jYXRpb24gd3JhcHBlcnMgd2l0aCBNZXRob2RUYXNrIG9iamVj dHMsCisgICAgICAgIHdoaWNoIGFyZSByZW1vdmVkIG9uIFdlYlZpZXdIb3N0IGRlc3RydWN0b3Iu CisgICAgICAgIAorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmNwcDoKKyAgICAgICAgKFdlYlZpZXdIb3N0OjpyZXF1ZXN0Q2hlY2tpbmdPZlRleHQpOgorICAg ICAgICAoV2ViVmlld0hvc3Q6OnNjaGVkdWxlQW5pbWF0aW9uKToKKyAgICAgICAgKFdlYlZpZXdI b3N0OjpjbG9zZVdpZGdldFNvb24pOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1dlYlZpZXdIb3N0Lmg6CisgICAgICAgIChXZWJWaWV3SG9zdDo6SG9zdE1ldGhvZFRhc2s6Okhv c3RNZXRob2RUYXNrKToKKyAgICAgICAgKFdlYlZpZXdIb3N0OjpIb3N0TWV0aG9kVGFzazo6cnVu SWZWYWxpZCk6CisgICAgICAgIChXZWJWaWV3SG9zdDo6dGFza0xpc3QpOgorCiAyMDExLTAyLTE2 ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vV2ViVmlld0hvc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2Vi Vmlld0hvc3QuY3BwCmluZGV4IGExM2JjMGM4YWIyMmRkMzM2ZDdhNGZhMjUwODI5ODM0MjI5NmQz YmEuLmRkMDZkOTZmMGViYzQ3ZWY4NDM5NzI0ZmEyZDExY2FiYjYxMTQyZDUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKQEAgLTIyOCwxMiArMjI4 LDYgQEAgc3RhdGljIHN0cmluZyB0ZXh0QWZmaW5pdHlEZXNjcmlwdGlvbihXZWJUZXh0QWZmaW5p dHkgYWZmaW5pdHkpCiAgICAgcmV0dXJuICIoVU5LTk9XTiBBRkZJTklUWSkiOwogfQogCi1zdGF0 aWMgdm9pZCBpbnZva2VGaW5pc2hMYXN0VGV4dENoZWNrKHZvaWQqIGNvbnRleHQpCi17Ci0gICAg V2ViVmlld0hvc3QqIHd2aCA9IHN0YXRpY19jYXN0PFdlYlZpZXdIb3N0Kj4oY29udGV4dCk7Ci0g ICAgd3ZoLT5maW5pc2hMYXN0VGV4dENoZWNrKCk7Ci19Ci0KIC8vIFdlYlZpZXdDbGllbnQgLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogCiBXZWJWaWV3KiBXZWJWaWV3SG9zdDo6Y3JlYXRlVmlldyhXZWJGcmFtZSosIGNvbnN0IFdl YlVSTFJlcXVlc3QmLCBjb25zdCBXZWJXaW5kb3dGZWF0dXJlcyYsIGNvbnN0IFdlYlN0cmluZyYp CkBAIC00MjIsNyArNDE2LDcgQEAgdm9pZCBXZWJWaWV3SG9zdDo6cmVxdWVzdENoZWNraW5nT2ZU ZXh0KGNvbnN0IFdlYlN0cmluZyYgdGV4dCwgV2ViVGV4dENoZWNraW5nQ28KIHsKICAgICBtX2xh c3RSZXF1ZXN0ZWRUZXh0Q2hlY2tpbmdDb21wbGV0aW9uID0gY29tcGxldGlvbjsKICAgICBtX2xh c3RSZXF1ZXN0ZWRUZXh0Q2hlY2tTdHJpbmcgPSB0ZXh0OwotICAgIHdlYmtpdF9zdXBwb3J0OjpQ b3N0RGVsYXllZFRhc2soaW52b2tlRmluaXNoTGFzdFRleHRDaGVjaywgc3RhdGljX2Nhc3Q8dm9p ZCo+KHRoaXMpLCAwKTsKKyAgICBwb3N0RGVsYXllZFRhc2sobmV3IFdlYlZpZXdIb3N0OjpIb3N0 TWV0aG9kVGFzayh0aGlzLCAmV2ViVmlld0hvc3Q6OmZpbmlzaExhc3RUZXh0Q2hlY2spLCAwKTsK IH0KIAogdm9pZCBXZWJWaWV3SG9zdDo6ZmluaXNoTGFzdFRleHRDaGVjaygpCkBAIC02NjMsMTUg KzY1Nyw5IEBAIHZvaWQgV2ViVmlld0hvc3Q6OnNjaGVkdWxlQ29tcG9zaXRlKCkKIH0KIAogI2lm IEVOQUJMRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRSkKLXN0YXRpYyB2b2lkIGludm9rZVNjaGVk dWxlQ29tcG9zaXRlKHZvaWQqIGNvbnRleHQpCi17Ci0gICAgV2ViVmlld0hvc3QqIHd2aCA9IHN0 YXRpY19jYXN0PFdlYlZpZXdIb3N0Kj4oY29udGV4dCk7Ci0gICAgd3ZoLT5zY2hlZHVsZUNvbXBv c2l0ZSgpOwotfQotCiB2b2lkIFdlYlZpZXdIb3N0OjpzY2hlZHVsZUFuaW1hdGlvbigpCiB7Ci0g ICAgd2Via2l0X3N1cHBvcnQ6OlBvc3REZWxheWVkVGFzayhpbnZva2VTY2hlZHVsZUNvbXBvc2l0 ZSwgdGhpcywgMCk7CisgICAgcG9zdERlbGF5ZWRUYXNrKG5ldyBXZWJWaWV3SG9zdDo6SG9zdE1l dGhvZFRhc2sodGhpcywgJldlYlZpZXdIb3N0OjpzY2hlZHVsZUNvbXBvc2l0ZSksIDApOwogfQog I2VuZGlmCiAKQEAgLTcxNiwxNSArNzA0LDkgQEAgdm9pZCBXZWJWaWV3SG9zdDo6Y2xvc2VXaWRn ZXQoKQogICAgIC8vIE5vIG1vcmUgY29kZSBoZXJlLCB3ZSBzaG91bGQgYmUgZGVsZXRlZCBhdCB0 aGlzIHBvaW50LgogfQogCi1zdGF0aWMgdm9pZCBpbnZva2VDbG9zZVdpZGdldCh2b2lkKiBjb250 ZXh0KQotewotICAgIFdlYlZpZXdIb3N0KiB3dmggPSBzdGF0aWNfY2FzdDxXZWJWaWV3SG9zdCo+ KGNvbnRleHQpOwotICAgIHd2aC0+Y2xvc2VXaWRnZXQoKTsKLX0KLQogdm9pZCBXZWJWaWV3SG9z dDo6Y2xvc2VXaWRnZXRTb29uKCkKIHsKLSAgICB3ZWJraXRfc3VwcG9ydDo6UG9zdERlbGF5ZWRU YXNrKGludm9rZUNsb3NlV2lkZ2V0LCBzdGF0aWNfY2FzdDx2b2lkKj4odGhpcyksIDApOworICAg IHBvc3REZWxheWVkVGFzayhuZXcgV2ViVmlld0hvc3Q6Okhvc3RNZXRob2RUYXNrKHRoaXMsICZX ZWJWaWV3SG9zdDo6Y2xvc2VXaWRnZXQpLCAwKTsKIH0KIAogdm9pZCBXZWJWaWV3SG9zdDo6ZGlk Q2hhbmdlQ3Vyc29yKGNvbnN0IFdlYkN1cnNvckluZm8mIGN1cnNvckluZm8pCmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAppbmRleCBlNmQ4MmFlODhhM2Q4ZTI2 NTNjY2FmYzg5ZTNkMjZmYjM1MWVkZTU4Li45NTA5NzJlY2UxYTg2OTNjYTkxZGY5NzczZTBmNjQy MTM3Y2ZmMWUzIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJW aWV3SG9zdC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmgKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgV2ViVmlld0hvc3RfaAogCiAjaW5jbHVkZSAi TW9ja1NwZWxsQ2hlY2suaCIKKyNpbmNsdWRlICJUYXNrLmgiCiAjaW5jbHVkZSAiVGVzdE5hdmln YXRpb25Db250cm9sbGVyLmgiCiAjaW5jbHVkZSAiV2ViQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlv bi5oIgogI2luY2x1ZGUgIldlYkN1cnNvckluZm8uaCIKQEAgLTY1LDYgKzY2LDIxIEBAIGNsYXNz IFBsYXRmb3JtQ2FudmFzOwogCiBjbGFzcyBXZWJWaWV3SG9zdCA6IHB1YmxpYyBXZWJLaXQ6Oldl YlZpZXdDbGllbnQsIHB1YmxpYyBXZWJLaXQ6OldlYkZyYW1lQ2xpZW50LCBwdWJsaWMgTmF2aWdh dGlvbkhvc3QgewogIHB1YmxpYzoKKworICAgIGNsYXNzIEhvc3RNZXRob2RUYXNrIDogcHVibGlj IE1ldGhvZFRhc2s8V2ViVmlld0hvc3Q+IHsKKyAgICBwdWJsaWM6CisgICAgICAgIHR5cGVkZWYg dm9pZCAoV2ViVmlld0hvc3Q6OipDYWxsYmFja01ldGhvZFR5cGUpKCk7CisgICAgICAgIEhvc3RN ZXRob2RUYXNrKFdlYlZpZXdIb3N0KiBvYmplY3QsIENhbGxiYWNrTWV0aG9kVHlwZSBjYWxsYmFj aykKKyAgICAgICAgICAgIDogTWV0aG9kVGFzazxXZWJWaWV3SG9zdD4ob2JqZWN0KQorICAgICAg ICAgICAgLCBtX2NhbGxiYWNrKGNhbGxiYWNrKQorICAgICAgICB7fQorCisgICAgICAgIHZpcnR1 YWwgdm9pZCBydW5JZlZhbGlkKCkgeyAobV9vYmplY3QtPiptX2NhbGxiYWNrKSgpOyB9CisKKyAg ICBwcml2YXRlOgorICAgICAgICBDYWxsYmFja01ldGhvZFR5cGUgbV9jYWxsYmFjazsKKyAgICB9 OworICAgCiAgICAgV2ViVmlld0hvc3QoVGVzdFNoZWxsKiBzaGVsbCk7CiAgICAgfldlYlZpZXdI b3N0KCk7CiAgICAgdm9pZCBzZXRXZWJXaWRnZXQoV2ViS2l0OjpXZWJXaWRnZXQqIHdpZGdldCkg eyBtX3dlYldpZGdldCA9IHdpZGdldDsgfQpAQCAtMjE2LDYgKzIzMiw5IEBAIGNsYXNzIFdlYlZp ZXdIb3N0IDogcHVibGljIFdlYktpdDo6V2ViVmlld0NsaWVudCwgcHVibGljIFdlYktpdDo6V2Vi RnJhbWVDbGllbnQsCiAgICAgLy8gR2VvbG9jYXRpb24gY2xpZW50IG1vY2tzIGZvciBMYXlvdXRU ZXN0Q29udHJvbGxlcgogICAgIFdlYktpdDo6V2ViR2VvbG9jYXRpb25DbGllbnRNb2NrKiBnZW9s b2NhdGlvbkNsaWVudE1vY2soKTsKIAorICAgIC8vIFBlbmRpbmcgdGFzayBsaXN0LCBOb3RlIHRh aHQgdGhlIG1ldGhvZCBpcyByZWZlcnJlZCBmcm9tIE1ldGhvZFRhc2sgY2xhc3MuCisgICAgVGFz a0xpc3QqIHRhc2tMaXN0KCkgeyByZXR1cm4gJm1fdGFza0xpc3Q7IH0KKwogcHJpdmF0ZToKICAg ICBMYXlvdXRUZXN0Q29udHJvbGxlciogbGF5b3V0VGVzdENvbnRyb2xsZXIoKSBjb25zdDsKIApA QCAtMzI3LDYgKzM0Niw4IEBAIHByaXZhdGU6CiAKICAgICBXZWJLaXQ6OldlYlN0cmluZyBtX2xh c3RSZXF1ZXN0ZWRUZXh0Q2hlY2tTdHJpbmc7CiAgICAgV2ViS2l0OjpXZWJUZXh0Q2hlY2tpbmdD b21wbGV0aW9uKiBtX2xhc3RSZXF1ZXN0ZWRUZXh0Q2hlY2tpbmdDb21wbGV0aW9uOworCisgICAg VGFza0xpc3QgbV90YXNrTGlzdDsKIH07CiAKICNlbmRpZiAvLyBXZWJWaWV3SG9zdF9oCg== 82938 2011-02-18 02:33:50 -0800 2011-02-18 02:37:07 -0800 Patch bug-53899-20110218193348.patch text/plain 4890 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogNzg5NzYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZGU5OWY0OTM1MzkzODY5MmVhYjQwMDc2OTAwMGZkMzJi Y2VmMDQ1Li4yZTY5NTA3YjVlNDRiOTJlMTI1ZjI4ZjQ2OTVlNzExOTJkNjE1NzM5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDItMTYgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXVtE UlRdIHNvbWUgUG9zdERlbGF5ZWRUYXNrKCkgYWNjZXNzZXMgcG9zc2libHkgZGFuZ2xpbmcgdGhp cyBwb2ludGVyLgorICAgICAgICBodHRwOi8vd2Via2l0Lm9yZy9iLzUzODk5CisKKyAgICAgICAg UmVwbGFjZWQgc3RhdGljIGludm9jYXRpb24gd3JhcHBlcnMgd2l0aCBNZXRob2RUYXNrIG9iamVj dHMsCisgICAgICAgIHdoaWNoIGFyZSByZW1vdmVkIG9uIFdlYlZpZXdIb3N0IGRlc3RydWN0b3Iu CisgICAgICAgIAorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmNwcDoKKyAgICAgICAgKFdlYlZpZXdIb3N0OjpyZXF1ZXN0Q2hlY2tpbmdPZlRleHQpOgorICAg ICAgICAoV2ViVmlld0hvc3Q6OnNjaGVkdWxlQW5pbWF0aW9uKToKKyAgICAgICAgKFdlYlZpZXdI b3N0OjpjbG9zZVdpZGdldFNvb24pOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1dlYlZpZXdIb3N0Lmg6CisgICAgICAgIChXZWJWaWV3SG9zdDo6SG9zdE1ldGhvZFRhc2s6Okhv c3RNZXRob2RUYXNrKToKKyAgICAgICAgKFdlYlZpZXdIb3N0OjpIb3N0TWV0aG9kVGFzazo6cnVu SWZWYWxpZCk6CisgICAgICAgIChXZWJWaWV3SG9zdDo6dGFza0xpc3QpOgorCiAyMDExLTAyLTA3 ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v V2ViVmlld0hvc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hv c3QuY3BwCmluZGV4IGExM2JjMGM4YWIyMmRkMzM2ZDdhNGZhMjUwODI5ODM0MjI5NmQzYmEuLjVi YTBkY2JmMTNkYWM3YTZmMWQxYmFhYTk2MTY3NzkxMTg1MTFjNWYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKQEAgLTIyOCwxMiArMjI4LDYgQEAg c3RhdGljIHN0cmluZyB0ZXh0QWZmaW5pdHlEZXNjcmlwdGlvbihXZWJUZXh0QWZmaW5pdHkgYWZm aW5pdHkpCiAgICAgcmV0dXJuICIoVU5LTk9XTiBBRkZJTklUWSkiOwogfQogCi1zdGF0aWMgdm9p ZCBpbnZva2VGaW5pc2hMYXN0VGV4dENoZWNrKHZvaWQqIGNvbnRleHQpCi17Ci0gICAgV2ViVmll d0hvc3QqIHd2aCA9IHN0YXRpY19jYXN0PFdlYlZpZXdIb3N0Kj4oY29udGV4dCk7Ci0gICAgd3Zo LT5maW5pc2hMYXN0VGV4dENoZWNrKCk7Ci19Ci0KIC8vIFdlYlZpZXdDbGllbnQgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBX ZWJWaWV3KiBXZWJWaWV3SG9zdDo6Y3JlYXRlVmlldyhXZWJGcmFtZSosIGNvbnN0IFdlYlVSTFJl cXVlc3QmLCBjb25zdCBXZWJXaW5kb3dGZWF0dXJlcyYsIGNvbnN0IFdlYlN0cmluZyYpCkBAIC00 MjIsNyArNDE2LDcgQEAgdm9pZCBXZWJWaWV3SG9zdDo6cmVxdWVzdENoZWNraW5nT2ZUZXh0KGNv bnN0IFdlYlN0cmluZyYgdGV4dCwgV2ViVGV4dENoZWNraW5nQ28KIHsKICAgICBtX2xhc3RSZXF1 ZXN0ZWRUZXh0Q2hlY2tpbmdDb21wbGV0aW9uID0gY29tcGxldGlvbjsKICAgICBtX2xhc3RSZXF1 ZXN0ZWRUZXh0Q2hlY2tTdHJpbmcgPSB0ZXh0OwotICAgIHdlYmtpdF9zdXBwb3J0OjpQb3N0RGVs YXllZFRhc2soaW52b2tlRmluaXNoTGFzdFRleHRDaGVjaywgc3RhdGljX2Nhc3Q8dm9pZCo+KHRo aXMpLCAwKTsKKyAgICBwb3N0RGVsYXllZFRhc2sobmV3IEhvc3RNZXRob2RUYXNrKHRoaXMsICZX ZWJWaWV3SG9zdDo6ZmluaXNoTGFzdFRleHRDaGVjayksIDApOwogfQogCiB2b2lkIFdlYlZpZXdI b3N0OjpmaW5pc2hMYXN0VGV4dENoZWNrKCkKQEAgLTY2MywxNSArNjU3LDkgQEAgdm9pZCBXZWJW aWV3SG9zdDo6c2NoZWR1bGVDb21wb3NpdGUoKQogfQogCiAjaWYgRU5BQkxFKFJFUVVFU1RfQU5J TUFUSU9OX0ZSQU1FKQotc3RhdGljIHZvaWQgaW52b2tlU2NoZWR1bGVDb21wb3NpdGUodm9pZCog Y29udGV4dCkKLXsKLSAgICBXZWJWaWV3SG9zdCogd3ZoID0gc3RhdGljX2Nhc3Q8V2ViVmlld0hv c3QqPihjb250ZXh0KTsKLSAgICB3dmgtPnNjaGVkdWxlQ29tcG9zaXRlKCk7Ci19Ci0KIHZvaWQg V2ViVmlld0hvc3Q6OnNjaGVkdWxlQW5pbWF0aW9uKCkKIHsKLSAgICB3ZWJraXRfc3VwcG9ydDo6 UG9zdERlbGF5ZWRUYXNrKGludm9rZVNjaGVkdWxlQ29tcG9zaXRlLCB0aGlzLCAwKTsKKyAgICBw b3N0RGVsYXllZFRhc2sobmV3IEhvc3RNZXRob2RUYXNrKHRoaXMsICZXZWJWaWV3SG9zdDo6c2No ZWR1bGVDb21wb3NpdGUpLCAwKTsKIH0KICNlbmRpZgogCkBAIC03MTYsMTUgKzcwNCw5IEBAIHZv aWQgV2ViVmlld0hvc3Q6OmNsb3NlV2lkZ2V0KCkKICAgICAvLyBObyBtb3JlIGNvZGUgaGVyZSwg d2Ugc2hvdWxkIGJlIGRlbGV0ZWQgYXQgdGhpcyBwb2ludC4KIH0KIAotc3RhdGljIHZvaWQgaW52 b2tlQ2xvc2VXaWRnZXQodm9pZCogY29udGV4dCkKLXsKLSAgICBXZWJWaWV3SG9zdCogd3ZoID0g c3RhdGljX2Nhc3Q8V2ViVmlld0hvc3QqPihjb250ZXh0KTsKLSAgICB3dmgtPmNsb3NlV2lkZ2V0 KCk7Ci19Ci0KIHZvaWQgV2ViVmlld0hvc3Q6OmNsb3NlV2lkZ2V0U29vbigpCiB7Ci0gICAgd2Vi a2l0X3N1cHBvcnQ6OlBvc3REZWxheWVkVGFzayhpbnZva2VDbG9zZVdpZGdldCwgc3RhdGljX2Nh c3Q8dm9pZCo+KHRoaXMpLCAwKTsKKyAgICBwb3N0RGVsYXllZFRhc2sobmV3IEhvc3RNZXRob2RU YXNrKHRoaXMsICZXZWJWaWV3SG9zdDo6Y2xvc2VXaWRnZXQpLCAwKTsKIH0KIAogdm9pZCBXZWJW aWV3SG9zdDo6ZGlkQ2hhbmdlQ3Vyc29yKGNvbnN0IFdlYkN1cnNvckluZm8mIGN1cnNvckluZm8p CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5o IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAppbmRleCBlNmQ4 MmFlODhhM2Q4ZTI2NTNjY2FmYzg5ZTNkMjZmYjM1MWVkZTU4Li40ZmMzNDAwNzQ2MGYwZTQzMmRm ZDllNzAyMTQyZTliYTY3ZTE2YzBkIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJWaWV3SG9zdC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1dlYlZpZXdIb3N0LmgKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgV2ViVmlld0hvc3RfaAog CiAjaW5jbHVkZSAiTW9ja1NwZWxsQ2hlY2suaCIKKyNpbmNsdWRlICJUYXNrLmgiCiAjaW5jbHVk ZSAiVGVzdE5hdmlnYXRpb25Db250cm9sbGVyLmgiCiAjaW5jbHVkZSAiV2ViQWNjZXNzaWJpbGl0 eU5vdGlmaWNhdGlvbi5oIgogI2luY2x1ZGUgIldlYkN1cnNvckluZm8uaCIKQEAgLTIxNiw3ICsy MTcsMjUgQEAgY2xhc3MgV2ViVmlld0hvc3QgOiBwdWJsaWMgV2ViS2l0OjpXZWJWaWV3Q2xpZW50 LCBwdWJsaWMgV2ViS2l0OjpXZWJGcmFtZUNsaWVudCwKICAgICAvLyBHZW9sb2NhdGlvbiBjbGll bnQgbW9ja3MgZm9yIExheW91dFRlc3RDb250cm9sbGVyCiAgICAgV2ViS2l0OjpXZWJHZW9sb2Nh dGlvbkNsaWVudE1vY2sqIGdlb2xvY2F0aW9uQ2xpZW50TW9jaygpOwogCisgICAgLy8gUGVuZGlu ZyB0YXNrIGxpc3QsIE5vdGUgdGFodCB0aGUgbWV0aG9kIGlzIHJlZmVycmVkIGZyb20gTWV0aG9k VGFzayBjbGFzcy4KKyAgICBUYXNrTGlzdCogdGFza0xpc3QoKSB7IHJldHVybiAmbV90YXNrTGlz dDsgfQorCiBwcml2YXRlOgorCisgICAgY2xhc3MgSG9zdE1ldGhvZFRhc2sgOiBwdWJsaWMgTWV0 aG9kVGFzazxXZWJWaWV3SG9zdD4geworICAgIHB1YmxpYzoKKyAgICAgICAgdHlwZWRlZiB2b2lk IChXZWJWaWV3SG9zdDo6KkNhbGxiYWNrTWV0aG9kVHlwZSkoKTsKKyAgICAgICAgSG9zdE1ldGhv ZFRhc2soV2ViVmlld0hvc3QqIG9iamVjdCwgQ2FsbGJhY2tNZXRob2RUeXBlIGNhbGxiYWNrKQor ICAgICAgICAgICAgOiBNZXRob2RUYXNrPFdlYlZpZXdIb3N0PihvYmplY3QpCisgICAgICAgICAg ICAsIG1fY2FsbGJhY2soY2FsbGJhY2spCisgICAgICAgIHsgfQorCisgICAgICAgIHZpcnR1YWwg dm9pZCBydW5JZlZhbGlkKCkgeyAobV9vYmplY3QtPiptX2NhbGxiYWNrKSgpOyB9CisKKyAgICBw cml2YXRlOgorICAgICAgICBDYWxsYmFja01ldGhvZFR5cGUgbV9jYWxsYmFjazsKKyAgICB9Owor CiAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIqIGxheW91dFRlc3RDb250cm9sbGVyKCkgY29uc3Q7 CiAKICAgICAvLyBDYWxsZWQgdGhlIHRpdGxlIG9mIHRoZSBwYWdlIGNoYW5nZXMuCkBAIC0zMjcs NiArMzQ2LDggQEAgcHJpdmF0ZToKIAogICAgIFdlYktpdDo6V2ViU3RyaW5nIG1fbGFzdFJlcXVl c3RlZFRleHRDaGVja1N0cmluZzsKICAgICBXZWJLaXQ6OldlYlRleHRDaGVja2luZ0NvbXBsZXRp b24qIG1fbGFzdFJlcXVlc3RlZFRleHRDaGVja2luZ0NvbXBsZXRpb247CisKKyAgICBUYXNrTGlz dCBtX3Rhc2tMaXN0OwogfTsKIAogI2VuZGlmIC8vIFdlYlZpZXdIb3N0X2gK