53886 2011-02-06 11:53:44 -0800 [EFL] Remove WebCore::currentTime() 2011-02-19 07:55:01 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi ryuan.choi tonikitoo oldest_to_newest 346362 0 paroga 2011-02-06 11:53:44 -0800 see patch 346363 1 81423 paroga 2011-02-06 11:58:01 -0800 Created attachment 81423 Patch 353263 2 ryuan.choi 2011-02-17 17:30:07 -0800 add WebKit EFL reviewers/committers to CC. It looks OK to me. 353276 3 gyuyoung.kim 2011-02-17 17:35:48 -0800 LGTM. 353359 4 81423 tonikitoo 2011-02-17 20:10:16 -0800 Comment on attachment 81423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81423&action=review > Source/WebCore/ChangeLog:8 > + There is no declaration for it and we use WTF::currentTime() everywherey. typo: everywhereY. > Source/WebCore/platform/efl/SystemTimeEfl.cpp:2 > - * Copyright (C) 2008 INdT. All rights reserved. > - * Copyright (C) 2009-2010 ProFUSION embedded systems > - * Copyright (C) 2009-2010 Samsung Electronics > + * Copyright (C) 2009 Apple Inc. All Rights Reserved. Why this? 354128 5 83069 paroga 2011-02-19 04:20:25 -0800 Created attachment 83069 Patch (In reply to comment #4) > > Source/WebCore/ChangeLog:8 > > + There is no declaration for it and we use WTF::currentTime() everywherey. > > typo: everywhereY. Fixed. > > Source/WebCore/platform/efl/SystemTimeEfl.cpp:2 > > - * Copyright (C) 2008 INdT. All rights reserved. > > - * Copyright (C) 2009-2010 ProFUSION embedded systems > > - * Copyright (C) 2009-2010 Samsung Electronics > > + * Copyright (C) 2009 Apple Inc. All Rights Reserved. > > Why this? Now it's the same file as the other SystemTime*.cpp files of the other ports. 354161 6 83069 paroga 2011-02-19 07:54:49 -0800 Comment on attachment 83069 Patch Clearing flags on attachment: 83069 Committed r79122: <http://trac.webkit.org/changeset/79122> 354162 7 paroga 2011-02-19 07:55:01 -0800 All reviewed patches have been landed. Closing bug. 81423 2011-02-06 11:58:01 -0800 2011-02-19 04:20:25 -0800 Patch bug-53886.patch text/plain 1493 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OGUzNjcyLi4wNzRkY2I2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDItMDYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gUmVt b3ZlIFdlYkNvcmU6OmN1cnJlbnRUaW1lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUzODg2CisKKyAgICAgICAgVGhlcmUgaXMgbm8gZGVjbGFyYXRp b24gZm9yIGl0IGFuZCB3ZSB1c2UgV1RGOjpjdXJyZW50VGltZSgpIGV2ZXJ5d2hlcmV5LgorCisg ICAgICAgICogcGxhdGZvcm0vZWZsL1N5c3RlbVRpbWVFZmwuY3BwOgorCisyMDExLTAyLTA2ICBQ YXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gUm9iZW4uCiAKICAgICAgICAgW1dJTl0gVXNlIFdDSEFSIGluc3RlYWQgb2YgVENI QVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TeXN0ZW1UaW1lRWZs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TeXN0ZW1UaW1lRWZsLmNwcAppbmRl eCBlYzZkNjYyLi4wMzIxOWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9l ZmwvU3lzdGVtVGltZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1N5 c3RlbVRpbWVFZmwuY3BwCkBAIC0xLDcgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAw OCBJTmRULiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICogQ29weXJpZ2h0IChDKSAyMDA5LTIwMTAg UHJvRlVTSU9OIGVtYmVkZGVkIHN5c3RlbXMKLSAqIENvcHlyaWdodCAoQykgMjAwOS0yMDEwIFNh bXN1bmcgRWxlY3Ryb25pY3MKKyAqIENvcHlyaWdodCAoQykgMjAwOSBBcHBsZSBJbmMuIEFsbCBS aWdodHMgUmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI5LDE2 ICsyNywxMCBAQAogI2luY2x1ZGUgIlN5c3RlbVRpbWUuaCIKIAogI2luY2x1ZGUgIk5vdEltcGxl bWVudGVkLmgiCi0jaW5jbHVkZSA8RWNvcmUuaD4KICNpbmNsdWRlIDxsaW1pdHM+CiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAotZG91YmxlIGN1cnJlbnRUaW1lKCkKLXsKLSAgICByZXR1cm4gZWNv cmVfdGltZV9nZXQoKTsKLX0KLQogZmxvYXQgdXNlcklkbGVUaW1lKCkKIHsKICAgICBub3RJbXBs ZW1lbnRlZCgpOwo= 83069 2011-02-19 04:20:25 -0800 2011-02-19 07:54:49 -0800 Patch bug-53886.patch text/plain 1492 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OGUzNjcyLi4wNzRkY2I2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDItMDYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gUmVt b3ZlIFdlYkNvcmU6OmN1cnJlbnRUaW1lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUzODg2CisKKyAgICAgICAgVGhlcmUgaXMgbm8gZGVjbGFyYXRp b24gZm9yIGl0IGFuZCB3ZSB1c2UgV1RGOjpjdXJyZW50VGltZSgpIGV2ZXJ5d2hlcmUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvU3lzdGVtVGltZUVmbC5jcHA6CisKKzIwMTEtMDItMDYgIFBh dHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBSb2Jlbi4KIAogICAgICAgICBbV0lOXSBVc2UgV0NIQVIgaW5zdGVhZCBvZiBUQ0hB UgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1N5c3RlbVRpbWVFZmwu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1N5c3RlbVRpbWVFZmwuY3BwCmluZGV4 IGVjNmQ2NjIuLjAzMjE5ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9TeXN0ZW1UaW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU3lz dGVtVGltZUVmbC5jcHAKQEAgLTEsNyArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA4 IElOZFQuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDktMjAxMCBQ cm9GVVNJT04gZW1iZWRkZWQgc3lzdGVtcwotICogQ29weXJpZ2h0IChDKSAyMDA5LTIwMTAgU2Ft c3VuZyBFbGVjdHJvbmljcworICogQ29weXJpZ2h0IChDKSAyMDA5IEFwcGxlIEluYy4gQWxsIFJp Z2h0cyBSZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjksMTYg KzI3LDEwIEBACiAjaW5jbHVkZSAiU3lzdGVtVGltZS5oIgogCiAjaW5jbHVkZSAiTm90SW1wbGVt ZW50ZWQuaCIKLSNpbmNsdWRlIDxFY29yZS5oPgogI2luY2x1ZGUgPGxpbWl0cz4KIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi1kb3VibGUgY3VycmVudFRpbWUoKQotewotICAgIHJldHVybiBlY29y ZV90aW1lX2dldCgpOwotfQotCiBmbG9hdCB1c2VySWRsZVRpbWUoKQogewogICAgIG5vdEltcGxl bWVudGVkKCk7Cg==