53881 2011-02-06 11:30:25 -0800 [WIN] Add missing includes and forward declarations for DownloadBundle 2011-02-08 08:50:32 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 paroga paroga aroben commit-queue oldest_to_newest 346349 0 paroga 2011-02-06 11:30:25 -0800 see patch 346350 1 81417 paroga 2011-02-06 11:32:42 -0800 Created attachment 81417 Patch 346383 2 81428 paroga 2011-02-06 14:35:13 -0800 Created attachment 81428 Patch 346571 3 81428 aroben 2011-02-07 07:38:28 -0800 Comment on attachment 81428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81428&action=review > Source/WebCore/platform/network/cf/DownloadBundle.h:31 > +typedef const struct __CFData* CFDataRef; Why is this needed? On Windows we pull in CoreFoundation.h through our prefix header. > Source/WebCore/platform/network/win/DownloadBundleWin.cpp:29 > +#include <CoreFoundation/CoreFoundation.h> Same question. > Source/WebCore/platform/network/win/DownloadBundleWin.cpp:32 > +#include <sys/stat.h> > +#include <sys/types.h> Presumably these are getting pulled in through the prefix header on Windows, too. 347419 4 81428 commit-queue 2011-02-08 08:50:28 -0800 Comment on attachment 81428 Patch Clearing flags on attachment: 81428 Committed r77944: <http://trac.webkit.org/changeset/77944> 347420 5 commit-queue 2011-02-08 08:50:32 -0800 All reviewed patches have been landed. Closing bug. 81417 2011-02-06 11:32:42 -0800 2011-02-06 14:35:13 -0800 Patch bug-53881.patch text/plain 2546 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OGUzNjcyLi5jMzZmNGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMDcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTl0gQWRk IG1pc3NpbmcgaW5jbHVkZXMgYW5kIGZvcndhcmQgZGVjbGFyYXRpb25zIGZvciBEb3dubG9hZEJ1 bmRsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM4 ODEKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvRG93bmxvYWRCdW5kbGUuaDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9Eb3dubG9hZEJ1bmRsZVdpbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEb3dubG9hZEJ1bmRsZTo6YXBwZW5kUmVzdW1lRGF0YSk6CisKIDIwMTEt MDItMDYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvY2YvRG93bmxvYWRCdW5kbGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvRG93bmxvYWRCdW5kbGUuaAppbmRleCBkMTU5Mjc3Li5hZDdkNzNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0Rvd25sb2FkQnVuZGxl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Eb3dubG9hZEJ1bmRs ZS5oCkBAIC0yNiwyMCArMjYsMTggQEAKICNpZm5kZWYgRG93bmxvYWRCdW5kbGVfaAogI2RlZmlu ZSBEb3dubG9hZEJ1bmRsZV9oCiAKLW5hbWVzcGFjZSBXVEYgewotICAgIGNsYXNzIFN0cmluZzsK LX0KKyNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogCi1uYW1lc3BhY2UgV2ViQ29yZSB7Cit0eXBl ZGVmIGNvbnN0IHN0cnVjdCBfX0NGRGF0YSAqIENGRGF0YVJlZjsKIAorbmFtZXNwYWNlIFdlYkNv cmUgewogbmFtZXNwYWNlIERvd25sb2FkQnVuZGxlIHsKIAotYm9vbCBhcHBlbmRSZXN1bWVEYXRh KENGRGF0YVJlZiByZXN1bWVEYXRhLCBjb25zdCBXVEY6OlN0cmluZyYgYnVuZGxlUGF0aCk7Ci1D RkRhdGFSZWYgZXh0cmFjdFJlc3VtZURhdGEoY29uc3QgV1RGOjpTdHJpbmcmIGJ1bmRsZVBhdGgp OwotY29uc3QgV1RGOjpTdHJpbmcmIGZpbGVFeHRlbnNpb24oKTsKLQotfQorYm9vbCBhcHBlbmRS ZXN1bWVEYXRhKENGRGF0YVJlZiByZXN1bWVEYXRhLCBjb25zdCBTdHJpbmcmIGJ1bmRsZVBhdGgp OworQ0ZEYXRhUmVmIGV4dHJhY3RSZXN1bWVEYXRhKGNvbnN0IFN0cmluZyYgYnVuZGxlUGF0aCk7 Citjb25zdCBTdHJpbmcmIGZpbGVFeHRlbnNpb24oKTsKIAotfQorfSAvLyBuYW1lc3BhY2UgRG93 bmxvYWRCdW5kbGUKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIERvd25sb2Fk QnVuZGxlX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvd2lu L0Rvd25sb2FkQnVuZGxlV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv d2luL0Rvd25sb2FkQnVuZGxlV2luLmNwcAppbmRleCA4YTA5MWRhLi5mMGYzMDI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9Eb3dubG9hZEJ1bmRsZVdp bi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vRG93bmxvYWRC dW5kbGVXaW4uY3BwCkBAIC0yNCwxNSArMjQsMTUgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmln LmgiCi0KICNpbmNsdWRlICJEb3dubG9hZEJ1bmRsZS5oIgogCisjaW5jbHVkZSA8Q29yZUZvdW5k YXRpb24vQ29yZUZvdW5kYXRpb24uaD4KICNpbmNsdWRlIDxpby5oPgorI2luY2x1ZGUgPHN5cy9z dGF0Lmg+CisjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmlu Zy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCi11c2luZyBXVEY6OlN0cmlu ZzsKLQogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBuYW1lc3BhY2UgRG93bmxvYWRCdW5kbGUgewpA QCAtNzMsNyArNzMsNyBAQCBib29sIGFwcGVuZFJlc3VtZURhdGEoQ0ZEYXRhUmVmIHJlc3VtZURh dGEsIGNvbnN0IFN0cmluZyYgYnVuZGxlUGF0aCkKICAgICBpZiAoIXJlc3VtZUJ5dGVzKQogICAg ICAgICBnb3RvIGV4aXQ7CiAKLSAgICBVSW50MzIgcmVzdW1lTGVuZ3RoID0gQ0ZEYXRhR2V0TGVu Z3RoKHJlc3VtZURhdGEpOworICAgIENGSW5kZXggcmVzdW1lTGVuZ3RoID0gQ0ZEYXRhR2V0TGVu Z3RoKHJlc3VtZURhdGEpOwogICAgIEFTU0VSVChyZXN1bWVMZW5ndGggPiAwKTsKICAgICBpZiAo cmVzdW1lTGVuZ3RoIDwgMSkKICAgICAgICAgZ290byBleGl0Owo= 81428 2011-02-06 14:35:13 -0800 2011-02-08 08:50:28 -0800 Patch bug-53881.patch text/plain 2545 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OGUzNjcyLi5jMzZmNGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMDcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTl0gQWRk IG1pc3NpbmcgaW5jbHVkZXMgYW5kIGZvcndhcmQgZGVjbGFyYXRpb25zIGZvciBEb3dubG9hZEJ1 bmRsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM4 ODEKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvRG93bmxvYWRCdW5kbGUuaDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9Eb3dubG9hZEJ1bmRsZVdpbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEb3dubG9hZEJ1bmRsZTo6YXBwZW5kUmVzdW1lRGF0YSk6CisKIDIwMTEt MDItMDYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvY2YvRG93bmxvYWRCdW5kbGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvRG93bmxvYWRCdW5kbGUuaAppbmRleCBkMTU5Mjc3Li5hZDdkNzNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0Rvd25sb2FkQnVuZGxl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Eb3dubG9hZEJ1bmRs ZS5oCkBAIC0yNiwyMCArMjYsMTggQEAKICNpZm5kZWYgRG93bmxvYWRCdW5kbGVfaAogI2RlZmlu ZSBEb3dubG9hZEJ1bmRsZV9oCiAKLW5hbWVzcGFjZSBXVEYgewotICAgIGNsYXNzIFN0cmluZzsK LX0KKyNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogCi1uYW1lc3BhY2UgV2ViQ29yZSB7Cit0eXBl ZGVmIGNvbnN0IHN0cnVjdCBfX0NGRGF0YSogQ0ZEYXRhUmVmOwogCituYW1lc3BhY2UgV2ViQ29y ZSB7CiBuYW1lc3BhY2UgRG93bmxvYWRCdW5kbGUgewogCi1ib29sIGFwcGVuZFJlc3VtZURhdGEo Q0ZEYXRhUmVmIHJlc3VtZURhdGEsIGNvbnN0IFdURjo6U3RyaW5nJiBidW5kbGVQYXRoKTsKLUNG RGF0YVJlZiBleHRyYWN0UmVzdW1lRGF0YShjb25zdCBXVEY6OlN0cmluZyYgYnVuZGxlUGF0aCk7 Ci1jb25zdCBXVEY6OlN0cmluZyYgZmlsZUV4dGVuc2lvbigpOwotCi19Citib29sIGFwcGVuZFJl c3VtZURhdGEoQ0ZEYXRhUmVmIHJlc3VtZURhdGEsIGNvbnN0IFN0cmluZyYgYnVuZGxlUGF0aCk7 CitDRkRhdGFSZWYgZXh0cmFjdFJlc3VtZURhdGEoY29uc3QgU3RyaW5nJiBidW5kbGVQYXRoKTsK K2NvbnN0IFN0cmluZyYgZmlsZUV4dGVuc2lvbigpOwogCi19Cit9IC8vIG5hbWVzcGFjZSBEb3du bG9hZEJ1bmRsZQorfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRG93bmxvYWRC dW5kbGVfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4v RG93bmxvYWRCdW5kbGVXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93 aW4vRG93bmxvYWRCdW5kbGVXaW4uY3BwCmluZGV4IDhhMDkxZGEuLmYwZjMwMjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvd2luL0Rvd25sb2FkQnVuZGxlV2lu LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9Eb3dubG9hZEJ1 bmRsZVdpbi5jcHAKQEAgLTI0LDE1ICsyNCwxNSBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcu aCIKLQogI2luY2x1ZGUgIkRvd25sb2FkQnVuZGxlLmgiCiAKKyNpbmNsdWRlIDxDb3JlRm91bmRh dGlvbi9Db3JlRm91bmRhdGlvbi5oPgogI2luY2x1ZGUgPGlvLmg+CisjaW5jbHVkZSA8c3lzL3N0 YXQuaD4KKyNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5n Lmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKLXVzaW5nIFdURjo6U3RyaW5n OwotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIG5hbWVzcGFjZSBEb3dubG9hZEJ1bmRsZSB7CkBA IC03Myw3ICs3Myw3IEBAIGJvb2wgYXBwZW5kUmVzdW1lRGF0YShDRkRhdGFSZWYgcmVzdW1lRGF0 YSwgY29uc3QgU3RyaW5nJiBidW5kbGVQYXRoKQogICAgIGlmICghcmVzdW1lQnl0ZXMpCiAgICAg ICAgIGdvdG8gZXhpdDsKIAotICAgIFVJbnQzMiByZXN1bWVMZW5ndGggPSBDRkRhdGFHZXRMZW5n dGgocmVzdW1lRGF0YSk7CisgICAgQ0ZJbmRleCByZXN1bWVMZW5ndGggPSBDRkRhdGFHZXRMZW5n dGgocmVzdW1lRGF0YSk7CiAgICAgQVNTRVJUKHJlc3VtZUxlbmd0aCA+IDApOwogICAgIGlmIChy ZXN1bWVMZW5ndGggPCAxKQogICAgICAgICBnb3RvIGV4aXQ7Cg==