53878 2011-02-06 08:36:54 -0800 Assertion failure in DrawingAreaImpl::resumePainting after window.open or when opening Web Inspector 2011-02-09 07:45:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 53805 1 aroben webkit-unassigned andersca sam oldest_to_newest 346307 0 aroben 2011-02-06 08:36:54 -0800 To reproduce: 1. Set WEBKIT2_USE_NEW_DRAWING_AREA=1 and launch your WebKit2 browser 2. Right-click on the page and choose Inspect Element You'll hit an assertion in DrawingAreaImpl::resumePainting: ASSERT(m_isPaintingSuspended); Here's the backtrace: > WebKit.dll!WebKit::DrawingAreaImpl::resumePainting() Line 222 + 0x2c bytes C++ WebKit.dll!CoreIPC::callMemberFunction<WebKit::DrawingArea,void (__thiscall WebKit::DrawingArea::*)(void)>(const CoreIPC::Arguments0 & __formal={...}, WebKit::DrawingArea * object=0x07504d38, void (void)* function=0x1000f420) Line 13 + 0xb bytes C++ WebKit.dll!CoreIPC::handleMessage<Messages::DrawingArea::ResumePainting,WebKit::DrawingArea,void (__thiscall WebKit::DrawingArea::*)(void)>(CoreIPC::ArgumentDecoder * argumentDecoder=0x070fada8, WebKit::DrawingArea * object=0x07504d38, void (void)* function=0x1000f420) Line 227 + 0x15 bytes C++ WebKit.dll!WebKit::DrawingArea::didReceiveDrawingAreaMessage(CoreIPC::Connection * __formal=0x0238e208, CoreIPC::MessageID messageID={...}, CoreIPC::ArgumentDecoder * arguments=0x070fada8) Line 49 + 0x23 bytes C++ WebKit.dll!WebKit::WebPage::didReceiveMessage(CoreIPC::Connection * connection=0x0238e208, CoreIPC::MessageID messageID={...}, CoreIPC::ArgumentDecoder * arguments=0x070fada8) Line 1662 C++ WebKit.dll!WebKit::WebProcess::didReceiveMessage(CoreIPC::Connection * connection=0x0238e208, CoreIPC::MessageID messageID={...}, CoreIPC::ArgumentDecoder * arguments=0x070fada8) Line 537 C++ WebKit.dll!CoreIPC::Connection::dispatchMessages() Line 441 + 0x31 bytes C++ WebKit.dll!MemberFunctionWorkItem0<CoreIPC::Connection>::execute() Line 76 + 0x10 bytes C++ WebKit.dll!RunLoop::performWork() Line 63 + 0x1a bytes C++ WebKit.dll!RunLoop::wndProc(HWND__ * hWnd=0x00040bec, unsigned int message=1025, unsigned int wParam=37276896, long lParam=0) Line 57 C++ WebKit.dll!RunLoop::RunLoopWndProc(HWND__ * hWnd=0x00040bec, unsigned int message=1025, unsigned int wParam=37276896, long lParam=0) Line 39 + 0x18 bytes C++ user32.dll!_InternalCallWinProc@20() + 0x28 bytes user32.dll!_UserCallWinProcCheckWow@32() + 0xb7 bytes user32.dll!_DispatchMessageWorker@8() + 0xdc bytes user32.dll!_DispatchMessageW@4() + 0xf bytes WebKit.dll!RunLoop::run() Line 73 + 0xc bytes C++ WebKit.dll!WebKit::WebProcessMain(const WebKit::CommandLine & commandLine={...}) Line 82 C++ WebKit.dll!WebKitMain(const WebKit::CommandLine & commandLine={...}) Line 48 + 0x9 bytes C++ WebKit.dll!WebKitMain(HINSTANCE__ * hInstance=0x00400000, HINSTANCE__ * hPrevInstance=0x00000000, wchar_t * lpstrCmdLine=0x0002114c, int nCmdShow=10) Line 172 + 0x9 bytes C++ WebKit2WebProcess.exe!wWinMain(HINSTANCE__ * hInstance=0x00400000, HINSTANCE__ * hPrevInstance=0x00000000, wchar_t * lpstrCmdLine=0x0002114c, int nCmdShow=10) Line 44 + 0x18 bytes C++ WebKit2WebProcess.exe!__tmainCRTStartup() Line 589 + 0x1c bytes C kernel32.dll!_BaseProcessStart@4() + 0x23 bytes 346614 1 aroben 2011-02-07 09:12:54 -0800 It looks like the sequence of events is essentially this: Web process: 1) WebInspector::createInspectorPage is called, which sends a synchronous WebInspectorProxy::CreateInspectorPage message to the UI process UI process: 2) WebInspectorProxy::createInspectorPage is called to handle the message, which ends up creating a new WebView for the page 3) WebView::WebView creates a new HWND, then calls ::ShowWindow(m_window, SW_SHOW) on it 4) The WebView receives a WM_SHOWWINDOW message, which results in a DrawingArea::ResumePainting message being sent to the web process 5) WebInspectorProxy::createInspectorPage calls WebPageProxy::creationParameters to get the parameters to send back to the web process. Since the WebView has already been shown at this point, parameters.isVisible is set to true. 5) WebInspectorProxy::createInspectorPage returns, sending the parameters back to the web process Web process: 6) WebInspectorProxy::createInspectorPage receives the synchronous message reply it's been waiting for, and creates a new, already-visible page with the WebPageCreationParameters from the UI process. 7) The new page's DrawingArea is created with painting not suspended, because the page is already visible based on the creation parameters. 8) The web process receives the DrawingArea::ResumePainting from (4), and asserts because painting is not suspended. 346616 2 aroben 2011-02-07 09:16:30 -0800 It looks like WebInspector::createInspectorPage is pretty similar to WebChromeClient::createWindow. And, in fact, window.open hits the same assertion! 346630 3 aroben 2011-02-07 09:39:31 -0800 I'm going to try passing WS_VISIBLE to ::CreateWindowExW instead of using a separate ::ShowWindow call. 346666 4 aroben 2011-02-07 10:41:28 -0800 (In reply to comment #3) > I'm going to try passing WS_VISIBLE to ::CreateWindowExW instead of using a separate ::ShowWindow call. That fixes the inspector, but not window.open. 348218 5 aroben 2011-02-09 07:23:37 -0800 <rdar://problem/8977306> 348227 6 81813 aroben 2011-02-09 07:41:12 -0800 Created attachment 81813 Hide the ugly details of WebView::m_window initialization from WebPageProxy, and make it less ugly 348232 7 aroben 2011-02-09 07:45:47 -0800 Committed r78054: <http://trac.webkit.org/changeset/78054> 81813 2011-02-09 07:41:12 -0800 2011-02-09 07:42:12 -0800 Hide the ugly details of WebView::m_window initialization from WebPageProxy, and make it less ugly bug-53878-20110209104109.patch text/plain 5396 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogNzgwNDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA2Yjk2MGUzZGJmN2JiOWQ2 YWUyMzg2MzA0YjI1YWJmMGVmNTExMzRhLi5hMjE3MjBmYmY5NjFlOGE5MjlkMzk5NTkyNTUxZWJk ODljYmRmNTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcgQEAKKzIwMTEtMDItMDkgIEFkYW0g Um9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAgIEhpZGUgdGhlIHVnbHkgZGV0YWls cyBvZiBXZWJWaWV3OjptX3dpbmRvdyBpbml0aWFsaXphdGlvbiBmcm9tIFdlYlBhZ2VQcm94eSwg YW5kIG1ha2UgaXQKKyAgICAgICAgbGVzcyB1Z2x5CisKKyAgICAgICAgV2ViVmlldzo6V2ViVmll dyB3YXMgaW5pdGlhbGx5IGNyZWF0aW5nIGEgaGlkZGVuIHdpbmRvdywgdGhlbiBzaG93aW5nIGl0 LiBJdCB3b3VsZCB0ZWxsCisgICAgICAgIFdlYlBhZ2VQcm94eSBhYm91dCB0aGUgd2luZG93IHdo aWxlIGl0IHdhcyBzdGlsbCBoaWRkZW4sIGFuZCB0aGVuIGhhdmUgdG8gaW5mb3JtCisgICAgICAg IFdlYlBhZ2VQcm94eSB0aGF0IHRoZSB3aW5kb3cgaGFkIGJlY29tZSBzaG93bi4gVGhpcyByZXN1 bHRlZCBpbiBXZWJQYWdlUHJveHkgc2VuZGluZworICAgICAgICB1bm5lY2Vzc2FyeSBtZXNzYWdl cyB0byB0aGUgd2ViIHByb2Nlc3MsIGFuZCBjb25mdXNlZCBjb2RlIHRoYXQgYXNzdW1lZCB0aGF0 IHRoZSB3aW5kb3cKKyAgICAgICAgd291bGQgYmUgaW4gdGhlIHNhbWUgc3RhdGUgYWZ0ZXIgV2Vi VmlldydzIGNvbnN0cnVjdG9yIGV4aXRlZCBhcyBpdCB3YXMgd2hlbiBXZWJQYWdlUHJveHkKKyAg ICAgICAgZmlyc3QgZm91bmQgb3V0IGFib3V0IHRoZSB3aW5kb3cuCisKKyAgICAgICAgV2Ugbm93 IGRvbid0IGhpZGUgdGhlIHdpbmRvdyB3aGVuIGNyZWF0aW5nIGl0LCB3aGljaCBzaW1wbGlmaWVz IHRoZSBjb2RlLCBhbmQgb25seSB0ZWxsCisgICAgICAgIFdlYlBhZ2VQcm94eSBhYm91dCB0aGUg d2luZG93IGFmdGVyIHdlJ3JlIGRvbmUgbW9kaWZ5aW5nIGl0LCB3aGljaCBmaXhlcyB0aGUgYnVn LgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzUzODc4PiA8cmRhcjovL3By b2JsZW0vODk3NzMwNj4gQXNzZXJ0aW9uIGZhaWx1cmUgaW4KKyAgICAgICAgRHJhd2luZ0FyZWFJ bXBsOjpyZXN1bWVQYWludGluZyBhZnRlciB3aW5kb3cub3BlbiBvciB3aGVuIG9wZW5pbmcgV2Vi IEluc3BlY3RvcgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll dzo6V2ViVmlldyk6IENoYW5nZWQgOjpDcmVhdGVXaW5kb3dFeCB0byA6OkNyZWF0ZVdpbmRvd0V4 VywgdG8gbWF0Y2ggb3RoZXIKKyAgICAgICAgV2luMzIgQVBJIGNhbGxzIGluIFdlYktpdDIuIFBh c3MgV1NfVklTSUJMRSB0byA6OkNyZWF0ZVdpbmRvd0V4VyByYXRoZXIgdGhhbiB3YWl0aW5nIHVu dGlsCisgICAgICAgIGxhdGVyIHRvIHNob3cgdGhlIHdpbmRvdy4gQWRkZWQgYW4gYXNzZXJ0aW9u IHRoYXQgbV9pc1Zpc2libGUgbWF0Y2hlcyB0aGUgd2luZG93J3MgdmlzaWJsZQorICAgICAgICBz dGF0ZS4gRG9uJ3QgZXZlbiBjcmVhdGUgb3VyIFdlYlBhZ2VQcm94eSwgb3IgdGVsbCBpdCBhYm91 dCBvdXIgd2luZG93LCB1bnRpbCB3ZSdyZSBkb25lCisgICAgICAgIGluaXRpYWxpemluZyBvdXIg d2luZG93LCBzbyB0aGF0IGl0IGRvZXNuJ3QgZ2V0IGluZm9ybWVkIGFib3V0IG91ciB3aW5kb3cn cyBpbnRlcm5hbCBzdGF0ZQorICAgICAgICBjaGFuZ2VzIHRoYXQgaGFwcGVuIGJlbmVhdGggOjpD cmVhdGVXaW5kb3dFeFcuCisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6Om9uU2l6ZUV2ZW50KTog TnVsbC1jaGVjayBtX3BhZ2Ugc2luY2Ugd2UgY2FuIHJlY2VpdmUgdGhpcyBtZXNzYWdlIGJlbmVh dGgKKyAgICAgICAgOjpDcmVhdGVXaW5kb3dFeFcuCisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6 Om9uU2hvd1dpbmRvd0V2ZW50KTogRGl0dG8uIFJlcGxhY2VkIG9uZSBGSVhNRSB3aXRoIGFub3Ro ZXIuIEFsd2F5cyBzZXQKKyAgICAgICAgaGFuZGxlZCB0byBmYWxzZSBzbyB0aGF0IDo6RGVmV2lu ZG93UHJvY1cgY2FuIGRvIGl0cyB0aGluZy4gKE1TRE4gc2F5cyB0aGlzIGlzIHdoZW4gaXQKKyAg ICAgICAgYWN0dWFsbHkgc2hvd3MvaGlkZXMgdGhlIHdpbmRvdywgdGhvdWdoIEkgY291bGRuJ3Qg ZmluZCBhbnkgY29uc2VxdWVuY2VzIG9mIG5vdCBjYWxsaW5nCisgICAgICAgIDo6RGVmV2luZG93 UHJvY1cgaGVyZS4pCisKIDIwMTEtMDItMDkgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAKaW5kZXggNzZjMjliZGI0NDFlNmU0MWJi YWE2NTkzM2M0MzJlN2EyNjFhYjA1MS4uNGNhYzQ2N2E0YjBhOGY3Nzg4NzI1ZjMzNmQ2ZDVhMGY2 MTYwNGFkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCkBAIC0y NTAsMTggKzI1MCwxOSBAQCBXZWJWaWV3OjpXZWJWaWV3KFJFQ1QgcmVjdCwgV2ViQ29udGV4dCog Y29udGV4dCwgV2ViUGFnZUdyb3VwKiBwYWdlR3JvdXAsIEhXTkQgcAogewogICAgIHJlZ2lzdGVy V2ViVmlld1dpbmRvd0NsYXNzKCk7CiAKLSAgICBtX3BhZ2UgPSBjb250ZXh0LT5jcmVhdGVXZWJQ YWdlKHRoaXMsIHBhZ2VHcm91cCk7Ci0KLSAgICBtX3dpbmRvdyA9IDo6Q3JlYXRlV2luZG93RXgo MCwga1dlYktpdDJXZWJWaWV3V2luZG93Q2xhc3NOYW1lLCAwLCBXU19DSElMRCB8IFdTX0NMSVBT SUJMSU5HUyB8IFdTX0NMSVBDSElMRFJFTiwKKyAgICBtX3dpbmRvdyA9IDo6Q3JlYXRlV2luZG93 RXhXKDAsIGtXZWJLaXQyV2ViVmlld1dpbmRvd0NsYXNzTmFtZSwgMCwgV1NfQ0hJTEQgfCBXU19D TElQU0lCTElOR1MgfCBXU19DTElQQ0hJTERSRU4gfCBXU19WSVNJQkxFLAogICAgICAgICByZWN0 LnRvcCwgcmVjdC5sZWZ0LCByZWN0LnJpZ2h0IC0gcmVjdC5sZWZ0LCByZWN0LmJvdHRvbSAtIHJl Y3QudG9wLCBwYXJlbnRXaW5kb3cgPyBwYXJlbnRXaW5kb3cgOiBIV05EX01FU1NBR0UsIDAsIGlu c3RhbmNlSGFuZGxlKCksIHRoaXMpOwogICAgIEFTU0VSVCg6OklzV2luZG93KG1fd2luZG93KSk7 CisgICAgLy8gV2Ugb25seSBjaGVjayBvdXIgd2luZG93IHN0eWxlLCBhbmQgbm90IDo6SXNXaW5k b3dWaXNpYmxlLCBiZWNhdXNlIG1faXNWaXNpYmxlIG9ubHkgdHJhY2tzCisgICAgLy8gdGhpcyB3 aW5kb3cncyB2aXNpYmlsaXR5IHN0YXR1cywgd2hpbGUgOjpJc1dpbmRvd1Zpc2libGUgdGFrZXMg b3VyIGFuY2VzdG9ycycgdmlzaWJpbGl0eQorICAgIC8vIHN0YXR1cyBpbnRvIGFjY291bnQuIDxo dHRwOi8vd2Via2l0Lm9yZy9iLzU0MTA0PgorICAgIEFTU0VSVChtX2lzVmlzaWJsZSA9PSBzdGF0 aWNfY2FzdDxib29sPig6OkdldFdpbmRvd0xvbmcobV93aW5kb3csIEdXTF9TVFlMRSkgJiBXU19W SVNJQkxFKSk7CiAKKyAgICBtX3BhZ2UgPSBjb250ZXh0LT5jcmVhdGVXZWJQYWdlKHRoaXMsIHBh Z2VHcm91cCk7CiAgICAgbV9wYWdlLT5pbml0aWFsaXplV2ViUGFnZSgpOwogCiAgICAgQ29DcmVh dGVJbnN0YW5jZShDTFNJRF9EcmFnRHJvcEhlbHBlciwgMCwgQ0xTQ1RYX0lOUFJPQ19TRVJWRVIs IElJRF9JRHJvcFRhcmdldEhlbHBlciwgKHZvaWQqKikmbV9kcm9wVGFyZ2V0SGVscGVyKTsKIAot ICAgIDo6U2hvd1dpbmRvdyhtX3dpbmRvdywgU1dfU0hPVyk7Ci0KICAgICAvLyBGSVhNRTogSW5p dGlhbGl6aW5nIHRoZSB0b29sdGlwIHdpbmRvdyBoZXJlIG1hdGNoZXMgV2ViS2l0IHdpbiwgYnV0 IHNlZW1zIGxpa2Ugc29tZXRoaW5nCiAgICAgLy8gd2UgY291bGQgZG8gb24gZGVtYW5kIHRvIHNh dmUgcmVzb3VyY2VzLgogICAgIGluaXRpYWxpemVUb29sVGlwV2luZG93KCk7CkBAIC00NjMsNyAr NDY0LDcgQEAgTFJFU1VMVCBXZWJWaWV3OjpvblNpemVFdmVudChIV05ELCBVSU5ULCBXUEFSQU0s IExQQVJBTSBsUGFyYW0sIGJvb2wmIGhhbmRsZWQpCiAgICAgaW50IHdpZHRoID0gTE9XT1JEKGxQ YXJhbSk7CiAgICAgaW50IGhlaWdodCA9IEhJV09SRChsUGFyYW0pOwogCi0gICAgaWYgKG1fcGFn ZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICBpZiAobV9wYWdlICYmIG1fcGFnZS0+ZHJhd2luZ0FyZWEo KSkKICAgICAgICAgbV9wYWdlLT5kcmF3aW5nQXJlYSgpLT5zZXRTaXplKEludFNpemUod2lkdGgs IGhlaWdodCksIEludFNpemUoKSk7CiAKICAgICBoYW5kbGVkID0gdHJ1ZTsKQEAgLTUwOSwxNCAr NTEwLDE1IEBAIExSRVNVTFQgV2ViVmlldzo6b25UaW1lckV2ZW50KEhXTkQgaFduZCwgVUlOVCwg V1BBUkFNIHdQYXJhbSwgTFBBUkFNLCBib29sJiBoYW5kCiBMUkVTVUxUIFdlYlZpZXc6Om9uU2hv d1dpbmRvd0V2ZW50KEhXTkQgaFduZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFS QU0gbFBhcmFtLCBib29sJiBoYW5kbGVkKQogewogICAgIC8vIGxQYXJhbSBpcyAwIHdoZW4gdGhl IG1lc3NhZ2UgaXMgc2VudCBiZWNhdXNlIG9mIGEgU2hvd1dpbmRvdyBjYWxsLgotICAgIC8vIEZJ WE1FOiBJcyBXTV9TSE9XV0lORE9XIHNlbnQgd2hlbiBTaG93V2luZG93IGlzIGNhbGxlZCBvbiBh biBhbmNlc3RvciBvZiBvdXIgd2luZG93PworICAgIC8vIEZJWE1FOiBTaW5jZSB3ZSBkb24ndCBn ZXQgbm90aWZpZWQgd2hlbiBhbiBhbmNlc3RvciB3aW5kb3cgaXMgaGlkZGVuIG9yIHNob3duLCB3 ZSB3aWxsIGtlZXAKKyAgICAvLyBwYWludGluZyBldmVuIHdoZW4gd2UgaGF2ZSBhIGhpZGRlbiBh bmNlc3Rvci4gPGh0dHA6Ly93ZWJraXQub3JnL2IvNTQxMDQ+CiAgICAgaWYgKCFsUGFyYW0pIHsK ICAgICAgICAgbV9pc1Zpc2libGUgPSB3UGFyYW07Ci0gICAgICAgIG1fcGFnZS0+dmlld1N0YXRl RGlkQ2hhbmdlKFdlYlBhZ2VQcm94eTo6Vmlld0lzVmlzaWJsZSk7Ci0KLSAgICAgICAgaGFuZGxl ZCA9IHRydWU7CisgICAgICAgIGlmIChtX3BhZ2UpCisgICAgICAgICAgICBtX3BhZ2UtPnZpZXdT dGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdJc1Zpc2libGUpOwogICAgIH0KIAorICAg IGhhbmRsZWQgPSBmYWxzZTsKICAgICByZXR1cm4gMDsKIH0KIAo=