53874 2011-02-06 08:07:29 -0800 [Qt] Clear page's groupName even when not in DRT 2011-02-06 10:46:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 robert robert abarth eric webkit.review.bot oldest_to_newest 346294 0 robert 2011-02-06 08:07:29 -0800 [Qt] Clear page's groupName even when not in DRT 346295 1 81405 robert 2011-02-06 08:09:00 -0800 Created attachment 81405 Patch 346309 2 81405 kling 2011-02-06 08:37:35 -0800 Comment on attachment 81405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81405&action=review r=me > Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:310 > + m_webPage->d->page->setGroupName(QString()); Use String() instead of QString() here to avoid the extra implicit conversion. 346332 3 robert 2011-02-06 10:19:30 -0800 Committed r77772: <http://trac.webkit.org/changeset/77772> 346340 4 webkit.review.bot 2011-02-06 10:46:48 -0800 http://trac.webkit.org/changeset/77772 might have broken Qt Linux Release The following tests are not passing: http/tests/websocket/tests/websocket-pending-activity.html 81405 2011-02-06 08:09:00 -0800 2011-02-06 08:37:35 -0800 Patch bug-53874-20110206160900.patch text/plain 2674 robert ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggOTU1ZTFlMWNiNmVhNWUxZmRlN2RiZTdjNzViYzFkMWZjYmZhZDk0 ZC4uMmIyNzVkZjk4ZTZjN2FjNDI5NTQ1NThkZjZjYTM3MWIwMzRjZTlkMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0wNiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBDbGVhciBwYWdlJ3MgZ3JvdXBOYW1lIGV2ZW4gd2hlbiBub3QgaW4gRFJUCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzg3NAorCisgICAg ICAgIE1hdGNoZXMgYmVoYXZpb3VyIG9mIG90aGVyIHBvcnRzLgorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xp ZW50UXQ6OmNsb3NlV2luZG93U29vbik6CisKIDIwMTEtMDItMDMgIFl1cnkgU2VtaWtoYXRza3kg IDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1h bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRR dC5jcHAKaW5kZXggNWE1MWI2M2UzMTYxYjllYWRjODk0NzFlNjE4OTIzMzY4ZmJhOGI3Ny4uMDcw NjRiMDg0NWVmZjVmNDVkNzg1NzcwZmY5NmQ3MGNhZDJhYWYyNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKQEAgLTMwNyw2ICsz MDcsNyBAQCBib29sIENocm9tZUNsaWVudFF0OjpydW5CZWZvcmVVbmxvYWRDb25maXJtUGFuZWwo Y29uc3QgU3RyaW5nJiBtZXNzYWdlLCBGcmFtZSogZgogCiB2b2lkIENocm9tZUNsaWVudFF0Ojpj bG9zZVdpbmRvd1Nvb24oKQogeworICAgIG1fd2ViUGFnZS0+ZC0+cGFnZS0+c2V0R3JvdXBOYW1l KFFTdHJpbmcoKSk7CiAgICAgbV93ZWJQYWdlLT5tYWluRnJhbWUoKS0+ZC0+ZnJhbWUtPmxvYWRl cigpLT5zdG9wQWxsTG9hZGVycygpOwogICAgIGVtaXQgbV93ZWJQYWdlLT53aW5kb3dDbG9zZVJl cXVlc3RlZCgpOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IGJlY2NiNTEyYmM2NmVlNmU3ZmMzMmQ1Nzc2ZGU5ZjA0YmYxMzBkYTUuLmE1NDg4 YjZjMDg2OTc3N2EwOTJiYzQ0NGRlOWNjM2E2MDliYjZhMmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMi0w NiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBDbGVhciBwYWdlJ3MgZ3JvdXBOYW1l IGV2ZW4gd2hlbiBub3QgaW4gRFJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01Mzg3NAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl bmRlclRyZWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6d2luZG93 Q2xvc2VSZXF1ZXN0ZWQpOgorCiAyMDExLTAyLTA2ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0Bh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdp dCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggYWM1ZDllNzRiZWJl Njg4M2ZlOGEyZTQxNGUxMjhiMzNiM2Q1OTU3Yy4uYjI3YTQyNmYwOTJmNjExMTk3ZDc3YjFkMmQx MTBiZThjZGY1MDQ5YyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl bmRlclRyZWVRdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWVRdC5jcHAKQEAgLTEwODQsOSArMTA4NCw2IEBAIHZvaWQgRHVtcFJlbmRlclRyZWU6OndpbmRv d0Nsb3NlUmVxdWVzdGVkKCkKICAgICBRV2ViUGFnZSogcGFnZSA9IHFvYmplY3RfY2FzdDxRV2Vi UGFnZSo+KHNlbmRlcigpKTsKICAgICBRT2JqZWN0KiBjb250YWluZXIgPSBwYWdlLT5wYXJlbnQo KTsKICAgICB3aW5kb3dzLnJlbW92ZUFsbChjb250YWluZXIpOwotICAgIC8vIE91ciB1c2Ugb2Yg Y29udGFpbmVyLT5kZWxldGVMYXRlcigpIG1lYW5zIHdlIG5lZWQgdG8gcmVtb3ZlIGNsb3NlZCBw YWdlcwotICAgIC8vIGZyb20gdGhlIG9yZy53ZWJraXQucXQuRHVtcFJlbmRlclRyZWUgZ3JvdXAg ZXhwbGljaXRseS4KLSAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6d2ViUGFnZVNldEdyb3Vw TmFtZShwYWdlLCAiIik7CiAgICAgY29udGFpbmVyLT5kZWxldGVMYXRlcigpOwogfQogCg==