53869 2011-02-06 05:31:42 -0800 [Qt] MiniBrowser: Clean up handling of titleChanged() signal 2011-02-06 07:19:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-unassigned oldest_to_newest 346268 0 kling 2011-02-06 05:31:42 -0800 Some minor cleanups are in order. 346269 1 81398 kling 2011-02-06 05:32:29 -0800 Created attachment 81398 Proposed patch 346279 2 81398 kling 2011-02-06 07:19:36 -0800 Comment on attachment 81398 Proposed patch Clearing flags on attachment: 81398 Committed r77767: <http://trac.webkit.org/changeset/77767> 346280 3 kling 2011-02-06 07:19:44 -0800 All reviewed patches have been landed. Closing bug. 81398 2011-02-06 05:32:29 -0800 2011-02-06 07:19:36 -0800 Proposed patch bug-53869.diff text/plain 2833 kling ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiZWNj YjUxLi44MGJjZDUxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDYgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gTWluaUJyb3dzZXI6IENsZWFuIHVwIGhhbmRsaW5nIG9mIHRpdGxlQ2hhbmdl ZCgpIHNpZ25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTM4NjkKKworICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcDoKKyAg ICAgICAgKEJyb3dzZXJWaWV3OjpCcm93c2VyVmlldyk6IFJlbW92ZSB1bm5lY2Vzc2FyeSB0aXRs ZUNoYW5nZWQoKSBoYW5kbGluZy4KKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2lu ZG93LmNwcDoKKyAgICAgICAgKEJyb3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3cpOiBDb25uZWN0 IHRpdGxlQ2hhbmdlZCgpIGRpcmVjdGx5IHRvIHNldFdpbmRvd1RpdGxlKCkuCisgICAgICAgICog TWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oOgorCiAyMDExLTAyLTA2ICBNYWNpZWogU3Rh Y2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5z dGVpbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcCBi L1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcAppbmRleCAxOGQyNjJiLi43ZDY0 MjZlIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5jcHAKKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuY3BwCkBAIC00MSw4ICs0MSw2IEBA IEJyb3dzZXJWaWV3OjpCcm93c2VyVmlldyhRR3JhcGhpY3NXS1ZpZXc6OkJhY2tpbmdTdG9yZVR5 cGUgYmFja2luZ1N0b3JlVHlwZSwgUVdLCiAgICAgc2V0RnJhbWVTaGFwZShRRnJhbWU6Ok5vRnJh bWUpOwogICAgIHNldEhvcml6b250YWxTY3JvbGxCYXJQb2xpY3koUXQ6OlNjcm9sbEJhckFsd2F5 c09mZik7CiAgICAgc2V0VmVydGljYWxTY3JvbGxCYXJQb2xpY3koUXQ6OlNjcm9sbEJhckFsd2F5 c09mZik7Ci0KLSAgICBjb25uZWN0KG1faXRlbSwgU0lHTkFMKHRpdGxlQ2hhbmdlZChRU3RyaW5n KSksIHRoaXMsIFNMT1Qoc2V0V2luZG93VGl0bGUoUVN0cmluZykpKTsKIH0KIAogdm9pZCBCcm93 c2VyVmlldzo6cmVzaXplRXZlbnQoUVJlc2l6ZUV2ZW50KiBldmVudCkKZGlmZiAtLWdpdCBhL1Rv b2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwIGIvVG9vbHMvTWluaUJyb3dzZXIv cXQvQnJvd3NlcldpbmRvdy5jcHAKaW5kZXggYWI0ZWMzNi4uYmZkN2Y5NSAxMDA2NDQKLS0tIGEv VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKKysrIGIvVG9vbHMvTWluaUJy b3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKQEAgLTUwLDcgKzUwLDcgQEAgQnJvd3NlcldpbmRv dzo6QnJvd3NlcldpbmRvdyhRV0tDb250ZXh0KiBjb250ZXh0KQogICAgIHNldEF0dHJpYnV0ZShR dDo6V0FfRGVsZXRlT25DbG9zZSk7CiAKICAgICBjb25uZWN0KG1fYnJvd3Nlci0+dmlldygpLCBT SUdOQUwobG9hZFByb2dyZXNzKGludCkpLCBTTE9UKGxvYWRQcm9ncmVzcyhpbnQpKSk7Ci0gICAg Y29ubmVjdChtX2Jyb3dzZXItPnZpZXcoKSwgU0lHTkFMKHRpdGxlQ2hhbmdlZChjb25zdCBRU3Ry aW5nJikpLCBTTE9UKHRpdGxlQ2hhbmdlZChjb25zdCBRU3RyaW5nJikpKTsKKyAgICBjb25uZWN0 KG1fYnJvd3Nlci0+dmlldygpLCBTSUdOQUwodGl0bGVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmKSks IFNMT1Qoc2V0V2luZG93VGl0bGUoY29uc3QgUVN0cmluZyYpKSk7CiAgICAgY29ubmVjdChtX2Jy b3dzZXItPnZpZXcoKSwgU0lHTkFMKHVybENoYW5nZWQoY29uc3QgUVVybCYpKSwgU0xPVCh1cmxD aGFuZ2VkKGNvbnN0IFFVcmwmKSkpOwogCiAgICAgdGhpcy0+c2V0Q2VudHJhbFdpZGdldChtX2Jy b3dzZXIpOwpAQCAtMTg2LDExICsxODYsNiBAQCB2b2lkIEJyb3dzZXJXaW5kb3c6OmxvYWRQcm9n cmVzcyhpbnQgcHJvZ3Jlc3MpCiAgICAgbV9hZGRyZXNzQmFyLT5zZXRQYWxldHRlKHBhbGxldGUp OwogfQogCi12b2lkIEJyb3dzZXJXaW5kb3c6OnRpdGxlQ2hhbmdlZChjb25zdCBRU3RyaW5nJiB0 aXRsZSkKLXsKLSAgICBzZXRXaW5kb3dUaXRsZSh0aXRsZSk7Ci19Ci0KIHZvaWQgQnJvd3Nlcldp bmRvdzo6dXJsQ2hhbmdlZChjb25zdCBRVXJsJiB1cmwpCiB7CiAgICAgbV9hZGRyZXNzQmFyLT5z ZXRUZXh0KHVybC50b1N0cmluZygpKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0 L0Jyb3dzZXJXaW5kb3cuaCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaApp bmRleCBiNDNlMWE0Li5mMGE2NDJlIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9C cm93c2VyV2luZG93LmgKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5o CkBAIC01Nyw3ICs1Nyw2IEBAIHNpZ25hbHM6CiBwcm90ZWN0ZWQgc2xvdHM6CiAgICAgdm9pZCBj aGFuZ2VMb2NhdGlvbigpOwogICAgIHZvaWQgbG9hZFByb2dyZXNzKGludCBwcm9ncmVzcyk7Ci0g ICAgdm9pZCB0aXRsZUNoYW5nZWQoY29uc3QgUVN0cmluZyYpOwogICAgIHZvaWQgdXJsQ2hhbmdl ZChjb25zdCBRVXJsJik7CiAgICAgdm9pZCBvcGVuRmlsZSgpOwogCg==