53845 2011-02-05 02:54:56 -0800 Add performance tests for URL parsing 2011-02-05 03:25:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth oldest_to_newest 346099 0 eric 2011-02-05 02:54:56 -0800 Add performance tests for URL parsing 346100 1 eric 2011-02-05 03:08:53 -0800 I'm omitting the urls file from the uploaded patch since it's too big. :( 346101 2 81352 eric 2011-02-05 03:10:14 -0800 Created attachment 81352 Patch 346102 3 eric 2011-02-05 03:13:50 -0800 Committed r77739: <http://trac.webkit.org/changeset/77739> 346103 4 eric 2011-02-05 03:22:36 -0800 Some figures: We call KURL::parse() about 2000 times when loading gmail.com (a logged in account). Since our benchmark parses apple.com 200000 times in under 400ms, it seems URL parsing is not a huge perf concern at the moment. 346104 5 eric 2011-02-05 03:23:49 -0800 Based on those numbers, we're spending about 4ms in URL parsing while loading gmail (that's a very rough estimate). 346105 6 eric 2011-02-05 03:25:07 -0800 Or using the figures from the english url corpus, a rough estimate of time spent loading gmail parsing urls would be 6.5 ms. In either case, these are not huge numbers. 81352 2011-02-05 03:10:14 -0800 2011-02-05 03:11:45 -0800 Patch bug-53845-20110205031013.patch text/plain 2540 eric ZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nIGIvUGVyZm9ybWFuY2VUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNjk5YTZhYTE1YzYxMGRkOTBjYWI2MzI4MWNmMWM3MTE0MzA3ODI5 ZC4uNjFiNjU2NDY2ODg2MzAxNzhmOTNhYjk4NmMyOGQyMjA0MWZjZTAxMiAxMDA2NDQKLS0tIGEv UGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwzMyBAQAorMjAxMS0wMi0wNSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHBlcmZvcm1hbmNlIHRlc3RzIGZvciBVUkwgcGFyc2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM4NDUKKworICAgICAgICBUaGUgZmluYWwt dXJsLWVuIFVSTCBjb3JwdXMgaXMgZnJvbToKKyAgICAgICAgaHR0cDovL2NvcnB1cy5sZWVkcy5h Yy51ay9pbnRlcm5ldC5odG1sCisKKyAgICAgICAgVGhlcmUgYXJlIGFsc28gb3RoZXIgbGFuZ3Vh Z2UgY29ycHVzZXMgd2hpY2ggd2UgbWF5IHdhbnQgdG8gdXNlIGluIHRoZSBmdXR1cmUuCisKKyAg ICAgICAgVGhlIHVzYWdlIGluc3RydWN0aW9ucyB3ZXJlIGFzIGZvbGxvd3M6CisgICAgICAgICJV UkwgbGlzdHMgYW5kIG90aGVyIHJlc291cmNlczogeW91IGNhbiBmcmVlbHkgdXNlIHRoZW0gaW4g eW91ciByZXNlYXJjaAorICAgICAgICBwcm92aWRlZCB0aGF0IHlvdSBzdXBwbHkgYSBsaW5rIHRv IHRoaXMgd2Vic2l0ZTogaHR0cDovL2NvcnB1cy5sZWVkcy5hYy51ay8uIgorICAgICAgICBEb25l LgorCisgICAgICAgICogUGFyc2VyL3NpbXBsZS11cmwuaHRtbDogQWRkZWQuCisgICAgICAgICBP biBteSBtYWNoaW5lOgorICAgICAgICAgRmlyZWZveDogMjU1bXMKKyAgICAgICAgIFRPVCBXZWJL aXQ6IDM3OG1zCisgICAgICAgICBDaHJvbWU6IDI4Nm1zCisgICAgICAgICBPcGVyYTogMjgzMG1z IChubywgdGhhdCBpcyBub3QgYSB0eXBvKQorICAgICAgICAqIFBhcnNlci91cmwtcGFyc2VyLmh0 bWw6IEFkZGVkLgorICAgICAgICAgRmlyZWZveDogMzgxbXMKKyAgICAgICAgIFRPVCBXZWJLaXQ6 IDIxNm1zCisgICAgICAgICBDaHJvbWU6IDEzMW1zCisgICAgICAgICBPcGVyYTogMTM4M21zIChh Z2Fpbiwgbm90IGEgdHlwbykKKyAgICAgICAgKiBQYXJzZXIvcmVzb3VyY2VzL2ZpbmFsLXVybC1l bjogQWRkZWQuCisKIDIwMTEtMDItMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCmRpZmYgLS1naXQgYS9QZXJmb3Jt YW5jZVRlc3RzL1BhcnNlci9zaW1wbGUtdXJsLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL1BhcnNl ci9zaW1wbGUtdXJsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDQ2OTM4M2JiMzRhNzQxNzdiYTQ3YTI2MzI2 NzJkYTgzZjY5NGM0ZQotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvUGFyc2Vy L3NpbXBsZS11cmwuaHRtbApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxib2R5 PgorPHByZSBpZD0ibG9nIj48L3ByZT4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcnVubmVyLmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQ+Cit2YXIgYW5jaG9yID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiYSIpOworc3RhcnQoMjAsIGZ1bmN0aW9uKCkgeworICAgIGZvciAodmFyIHggPSAwOyB4IDwg MjAwMDAwOyB4KyspIHsKKyAgICAgICAgYW5jaG9yLmhyZWYgPSAiaHR0cDovL3d3dy5hcHBsZS5j b20vIgorICAgIH0KK30pOworPC9zY3JpcHQ+Cis8L2JvZHk+CmRpZmYgLS1naXQgYS9QZXJmb3Jt YW5jZVRlc3RzL1BhcnNlci91cmwtcGFyc2VyLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL1BhcnNl ci91cmwtcGFyc2VyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmQ1NGUwYzAyZmVjN2IxNzY1NTMyOTMxODNi MzMzMTY0OTFlYzAxNAotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvUGFyc2Vy L3VybC1wYXJzZXIuaHRtbApAQCAtMCwwICsxLDE1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxib2R5 PgorPHByZSBpZD0ibG9nIj48L3ByZT4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcnVubmVyLmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQ+Cit2YXIgdXJscyA9IGxvYWRGaWxlKCJyZXNvdXJjZXMvZmlu YWwtdXJsLWVuIikuc3BsaXQoIlxuIik7Cit2YXIgYW5jaG9yID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiYSIpOworCitzdGFydCgyMCwgZnVuY3Rpb24oKSB7CisgICAgZm9yICh2YXIgeCA9IDA7 IHggPCB1cmxzLmxlbmd0aDsgeCsrKSB7CisgICAgICAgIGFuY2hvci5ocmVmID0gdXJsc1t4XTsK KyAgICB9Cit9KTsKKzwvc2NyaXB0PgorPC9ib2R5Pgo=