53839 2011-02-04 20:08:41 -0800 nrwt multiprocessing: remove obsolete WatchableThread class 2011-02-08 16:37:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 53838 1 dpranke dpranke eric hayato mihaip ojan tony oldest_to_newest 346032 0 dpranke 2011-02-04 20:08:41 -0800 nrwt multiprocessing: remove obsolete WatchableThread class 346034 1 81341 dpranke 2011-02-04 20:10:03 -0800 Created attachment 81341 remove WatchableThread 346082 2 81341 eric 2011-02-05 01:17:59 -0800 Comment on attachment 81341 remove WatchableThread I'm not sure why inlining this class is better. 346170 3 dpranke 2011-02-05 11:59:10 -0800 fewer lines of code, less distractions. The test code that used the WatchableThread abstraction is gone, so readers might look at this code and be puzzled by why it doesn't seem to be used anywhere. And they'd be right. If you look at the next series of patches, my goal is to move all of the real logic into single_test_runner, leaving dump_render_tree_thread.py (and worker.py) with just the communications code. 346387 4 81341 ojan 2011-02-06 14:49:38 -0800 Comment on attachment 81341 remove WatchableThread Less subclassing seems better if we don't get anything from the subclassing. 347802 5 dpranke 2011-02-08 16:37:31 -0800 Committed r77991: <http://trac.webkit.org/changeset/77991> 81341 2011-02-04 20:10:03 -0800 2011-02-06 14:49:38 -0800 remove WatchableThread bug-53839-20110204201002.patch text/plain 5033 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkZjM5 NzNlZDZhZWQ3NzFlNTAzZjNkYzMxYTc0NDU5OTczMTBjNTZmLi5hNDllZThkMDU2NzIxNWM2ODJi NTYyMWIwN2ViNzBiZTc2Y2MwMGZhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMDQgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IHJlbW92ZSBubyBsb25nZXIg bmVlZGVkIFdhdGNoYWJsZVRocmVhZAorICAgICAgICBjbGFzcy4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM4MzkKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVf dGhyZWFkLnB5OgorCiAyMDExLTAyLTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvZHVtcF9y ZW5kZXJfdHJlZV90aHJlYWQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9sYXlvdXRfcGFja2FnZS9kdW1wX3JlbmRlcl90cmVlX3RocmVhZC5weQppbmRleCAxZDFhYjk3 MTY5YTcxYzgzYWU1Y2M0NThjZTM5NWY1MGI3YzY5NzM2Li5hNzgwZGFhNGVjMTk3NWZmMzFkYjZl MGExMTNjMTNhODFiZTE2MTMzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9kdW1wX3JlbmRlcl90cmVlX3RocmVhZC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9kdW1w X3JlbmRlcl90cmVlX3RocmVhZC5weQpAQCAtMTIwLDQyICsxMjAsNyBAQCBjbGFzcyBTaW5nbGVU ZXN0VGhyZWFkKHRocmVhZGluZy5UaHJlYWQpOgogICAgICAgICByZXR1cm4gc2VsZi5fdGVzdF9y ZXN1bHQKIAogCi1jbGFzcyBXYXRjaGFibGVUaHJlYWQodGhyZWFkaW5nLlRocmVhZCk6Ci0gICAg IiIiVGhpcyBjbGFzcyBhYnN0cmFjdHMgYW4gaW50ZXJmYWNlIHVzZWQgYnkKLSAgICBydW5fd2Vi a2l0X3Rlc3RzLlRlc3RSdW5uZXIuX3dhaXRfZm9yX3RocmVhZHNfdG9fZmluaXNoIGZvciB0aHJl YWQKLSAgICBtYW5hZ2VtZW50LiIiIgotICAgIGRlZiBfX2luaXRfXyhzZWxmKToKLSAgICAgICAg dGhyZWFkaW5nLlRocmVhZC5fX2luaXRfXyhzZWxmKQotICAgICAgICBzZWxmLl9jYW5jZWxlZCA9 IEZhbHNlCi0gICAgICAgIHNlbGYuX2V4Y2VwdGlvbl9pbmZvID0gTm9uZQotICAgICAgICBzZWxm Ll9uZXh0X3RpbWVvdXQgPSBOb25lCi0gICAgICAgIHNlbGYuX3RocmVhZF9pZCA9IE5vbmUKLQot ICAgIGRlZiBjYW5jZWwoc2VsZik6Ci0gICAgICAgICIiIlNldCBhIGZsYWcgdGVsbGluZyB0aGlz IHRocmVhZCB0byBxdWl0LiIiIgotICAgICAgICBzZWxmLl9jYW5jZWxlZCA9IFRydWUKLQotICAg IGRlZiBjbGVhcl9uZXh0X3RpbWVvdXQoc2VsZik6Ci0gICAgICAgICIiIk1hcmsgYSBmbGFnIHRl bGxpbmcgdGhpcyB0aHJlYWQgdG8gc3RvcCBzZXR0aW5nIHRpbWVvdXRzLiIiIgotICAgICAgICBz ZWxmLl90aW1lb3V0ID0gMAotCi0gICAgZGVmIGV4Y2VwdGlvbl9pbmZvKHNlbGYpOgotICAgICAg ICAiIiJJZiBydW4oKSB0ZXJtaW5hdGVkIG9uIGFuIHVuY2F1Z2h0IGV4Y2VwdGlvbiwgcmV0dXJu IGl0IGhlcmUKLSAgICAgICAgKCh0eXBlLCB2YWx1ZSwgdHJhY2ViYWNrKSB0dXBsZSkuCi0gICAg ICAgIFJldHVybnMgTm9uZSBpZiBydW4oKSB0ZXJtaW5hdGVkIG5vcm1hbGx5LiBNZWFudCB0byBi ZSBjYWxsZWQgYWZ0ZXIKLSAgICAgICAgam9pbmluZyB0aGlzIHRocmVhZC4iIiIKLSAgICAgICAg cmV0dXJuIHNlbGYuX2V4Y2VwdGlvbl9pbmZvCi0KLSAgICBkZWYgaWQoc2VsZik6Ci0gICAgICAg ICIiIlJldHVybiBhIHRocmVhZCBpZGVudGlmaWVyLiIiIgotICAgICAgICByZXR1cm4gc2VsZi5f dGhyZWFkX2lkCi0KLSAgICBkZWYgbmV4dF90aW1lb3V0KHNlbGYpOgotICAgICAgICAiIiJSZXR1 cm4gdGhlIHRpbWUgdGhlIHRlc3QgaXMgc3VwcG9zZWQgdG8gZmluaXNoIGJ5LiIiIgotICAgICAg ICByZXR1cm4gc2VsZi5fbmV4dF90aW1lb3V0Ci0KLQotY2xhc3MgVGVzdFNoZWxsVGhyZWFkKFdh dGNoYWJsZVRocmVhZCk6CitjbGFzcyBUZXN0U2hlbGxUaHJlYWQodGhyZWFkaW5nLlRocmVhZCk6 CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBvcnQsIG9wdGlvbnMsIHdvcmtlcl9udW1iZXIsIHdv cmtlcl9uYW1lLAogICAgICAgICAgICAgICAgICBmaWxlbmFtZV9saXN0X3F1ZXVlLCByZXN1bHRf cXVldWUpOgogICAgICAgICAiIiJJbml0aWFsaXplIGFsbCB0aGUgbG9jYWwgc3RhdGUgZm9yIHRo aXMgRHVtcFJlbmRlclRyZWUgdGhyZWFkLgpAQCAtMTcwLDcgKzEzNSwxMSBAQCBjbGFzcyBUZXN0 U2hlbGxUaHJlYWQoV2F0Y2hhYmxlVGhyZWFkKToKICAgICAgICAgICByZXN1bHRfcXVldWU6IEEg dGhyZWFkIHNhZmUgUXVldWUgY2xhc3MgdGhhdCB3aWxsIGNvbnRhaW4KICAgICAgICAgICAgICAg c2VyaWFsaXplZCBUZXN0UmVzdWx0IG9iamVjdHMuCiAgICAgICAgICIiIgotICAgICAgICBXYXRj aGFibGVUaHJlYWQuX19pbml0X18oc2VsZikKKyAgICAgICAgdGhyZWFkaW5nLlRocmVhZC5fX2lu aXRfXyhzZWxmKQorICAgICAgICBzZWxmLl9jYW5jZWxlZCA9IEZhbHNlCisgICAgICAgIHNlbGYu X2V4Y2VwdGlvbl9pbmZvID0gTm9uZQorICAgICAgICBzZWxmLl9uZXh0X3RpbWVvdXQgPSBOb25l CisgICAgICAgIHNlbGYuX3RocmVhZF9pZCA9IE5vbmUKICAgICAgICAgc2VsZi5fcG9ydCA9IHBv cnQKICAgICAgICAgc2VsZi5fb3B0aW9ucyA9IG9wdGlvbnMKICAgICAgICAgc2VsZi5fd29ya2Vy X251bWJlciA9IHdvcmtlcl9udW1iZXIKQEAgLTIwNiw2ICsxNzUsMzIgQEAgY2xhc3MgVGVzdFNo ZWxsVGhyZWFkKFdhdGNoYWJsZVRocmVhZCk6CiAgICAgICAgICAgICBjbGFzc2VzLmFwcGVuZChp bWFnZV9kaWZmLkltYWdlRGlmZikKICAgICAgICAgcmV0dXJuIGNsYXNzZXMKIAorICAgIGRlZiBj YW5jZWwoc2VsZik6CisgICAgICAgICIiIlNldCBhIGZsYWcgdGVsbGluZyB0aGlzIHRocmVhZCB0 byBxdWl0LiIiIgorICAgICAgICBzZWxmLl9zdG9wX3NlcnZlcnNfd2l0aF9sb2NrKCkKKyAgICAg ICAgc2VsZi5fY2FuY2VsZWQgPSBUcnVlCisKKyAgICBkZWYgY2xlYXJfbmV4dF90aW1lb3V0KHNl bGYpOgorICAgICAgICAiIiJNYXJrIGEgZmxhZyB0ZWxsaW5nIHRoaXMgdGhyZWFkIHRvIHN0b3Ag c2V0dGluZyB0aW1lb3V0cy4iIiIKKyAgICAgICAgc2VsZi5fdGltZW91dCA9IDAKKworICAgIGRl ZiBleGNlcHRpb25faW5mbyhzZWxmKToKKyAgICAgICAgIiIiSWYgcnVuKCkgdGVybWluYXRlZCBv biBhbiB1bmNhdWdodCBleGNlcHRpb24sIHJldHVybiBpdCBoZXJlCisgICAgICAgICgodHlwZSwg dmFsdWUsIHRyYWNlYmFjaykgdHVwbGUpLgorICAgICAgICBSZXR1cm5zIE5vbmUgaWYgcnVuKCkg dGVybWluYXRlZCBub3JtYWxseS4gTWVhbnQgdG8gYmUgY2FsbGVkIGFmdGVyCisgICAgICAgIGpv aW5pbmcgdGhpcyB0aHJlYWQuIiIiCisgICAgICAgIHJldHVybiBzZWxmLl9leGNlcHRpb25faW5m bworCisgICAgZGVmIGlkKHNlbGYpOgorICAgICAgICAiIiJSZXR1cm4gYSB0aHJlYWQgaWRlbnRp Zmllci4iIiIKKyAgICAgICAgcmV0dXJuIHNlbGYuX3RocmVhZF9pZAorCisgICAgZGVmIG5leHRf dGltZW91dChzZWxmKToKKyAgICAgICAgIiIiUmV0dXJuIHRoZSB0aW1lIHRoZSB0ZXN0IGlzIHN1 cHBvc2VkIHRvIGZpbmlzaCBieS4iIiIKKyAgICAgICAgaWYgc2VsZi5fbmV4dF90aW1lb3V0Ogor ICAgICAgICAgICAgcmV0dXJuIHNlbGYuX25leHRfdGltZW91dCArIHNlbGYuX2h0dHBfbG9ja193 YWl0X3RpbWUoKQorICAgICAgICByZXR1cm4gc2VsZi5fbmV4dF90aW1lb3V0CisKICAgICBkZWYg Z2V0X3Rlc3RfZ3JvdXBfdGltaW5nX3N0YXRzKHNlbGYpOgogICAgICAgICAiIiJSZXR1cm5zIGEg ZGljdGlvbmFyeSBtYXBwaW5nIHRlc3QgZ3JvdXAgdG8gYSB0dXBsZSBvZgogICAgICAgICAobnVt YmVyIG9mIHRlc3RzIGluIHRoYXQgZ3JvdXAsIHRpbWUgdG8gcnVuIHRoZSB0ZXN0cykiIiIKQEAg LTI2MCwxNyArMjU1LDYgQEAgY2xhc3MgVGVzdFNoZWxsVGhyZWFkKFdhdGNoYWJsZVRocmVhZCk6 CiAgICAgICAgIGRvIG11bHRpLXRocmVhZGVkIGRlYnVnZ2luZy4iIiIKICAgICAgICAgc2VsZi5f cnVuKHRlc3RfcnVubmVyLCByZXN1bHRfc3VtbWFyeSkKIAotICAgIGRlZiBjYW5jZWwoc2VsZik6 Ci0gICAgICAgICIiIkNsZWFuIHVwIGh0dHAgbG9jayBhbmQgc2V0IGEgZmxhZyB0ZWxsaW5nIHRo aXMgdGhyZWFkIHRvIHF1aXQuIiIiCi0gICAgICAgIHNlbGYuX3N0b3Bfc2VydmVyc193aXRoX2xv Y2soKQotICAgICAgICBXYXRjaGFibGVUaHJlYWQuY2FuY2VsKHNlbGYpCi0KLSAgICBkZWYgbmV4 dF90aW1lb3V0KHNlbGYpOgotICAgICAgICAiIiJSZXR1cm4gdGhlIHRpbWUgdGhlIHRlc3QgaXMg c3VwcG9zZWQgdG8gZmluaXNoIGJ5LiIiIgotICAgICAgICBpZiBzZWxmLl9uZXh0X3RpbWVvdXQ6 Ci0gICAgICAgICAgICByZXR1cm4gc2VsZi5fbmV4dF90aW1lb3V0ICsgc2VsZi5faHR0cF9sb2Nr X3dhaXRfdGltZSgpCi0gICAgICAgIHJldHVybiBzZWxmLl9uZXh0X3RpbWVvdXQKLQogICAgIGRl ZiBfaHR0cF9sb2NrX3dhaXRfdGltZShzZWxmKToKICAgICAgICAgIiIiUmV0dXJuIHRoZSB0aW1l IHdoYXQgaHR0cCBsb2NraW5nIHRha2VzLiIiIgogICAgICAgICBpZiBzZWxmLl9odHRwX2xvY2tf d2FpdF9iZWdpbiA9PSAwOgo=