53833 2011-02-04 18:40:40 -0800 [GTK] plugins/plugin-document-back-forward.html fails 2011-02-04 20:17:48 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned abarth commit-queue eric mrobinson webkit.review.bot oldest_to_newest 345994 0 abarth 2011-02-04 18:40:40 -0800 plugins/plugin-document-back-forward.html fails after being added. The test is supposed to test our behavior when loading a plugin a second time, but the initial load doesn't seem to be working. Maybe the test plugin isn't fully implemented in GTK? Not really sure how to debug the issue. 346006 1 mrobinson 2011-02-04 19:12:57 -0800 r77706 added a new test plugin functionality, but did not add it to the Unix version of the plugin. 346011 2 81337 mrobinson 2011-02-04 19:19:27 -0800 Created attachment 81337 Patch 346022 3 webkit.review.bot 2011-02-04 19:43:29 -0800 http://trac.webkit.org/changeset/77721 might have broken GTK Linux 64-bit Debug 346024 4 81337 abarth 2011-02-04 19:46:14 -0800 Comment on attachment 81337 Patch There's a unix version of the plugin? Thanks... 346029 5 mrobinson 2011-02-04 20:03:30 -0800 (In reply to comment #4) > (From update of attachment 81337 [details]) > There's a unix version of the plugin? Thanks... No problem. Thanks for the review! 346037 6 81337 commit-queue 2011-02-04 20:17:44 -0800 Comment on attachment 81337 Patch Clearing flags on attachment: 81337 Committed r77727: <http://trac.webkit.org/changeset/77727> 346038 7 commit-queue 2011-02-04 20:17:48 -0800 All reviewed patches have been landed. Closing bug. 81337 2011-02-04 19:19:27 -0800 2011-02-04 20:17:44 -0800 Patch bug-53833-20110204191921.patch text/plain 3128 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZDYyMjNjMzYwMGM3YmZkZGEzYTUwOGE3ODhjNTA4OTgxZDc3ZDU3Li5kMmVkMDlm NWQzYzhjNDYwNmM1NmYyMmI0ODMxOGZlODQ2YjgwNGRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDItMDQgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHBsdWdp bnMvcGx1Z2luLWRvY3VtZW50LWJhY2stZm9yd2FyZC5odG1sIGZhaWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzgzMworCisgICAgICAgICogcGxh dGZvcm0vZ3RrL1NraXBwZWQ6IFVuc2tpcCB0ZXN0IHdoaWNoIGlzIG5vdyBwYXNzaW5nLgorCiAy MDExLTAyLTA0ICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IGU0 M2NkMmU2YjJiMmJhMzVlZjE5Yzc0ZDdiNDMzZjA2NWUzNTFjMzAuLmE3ZDk3YmVjYzZiYzNiYWU3 NDU1NmE0ODU5MzBhMDVmZjFmMjRkYTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC00 NzExLDcgKzQ3MTEsMyBAQCBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy91cmwtd2l0aC1jcmVk ZW50aWFsLmh0bWwKIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL3VybC13aXRoLWVtcHR5LXF1 ZXJ5Lmh0bWwKIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL3NpbXBsZS5odG1sCiBodHRwL3Rl c3RzL3dlYnNvY2tldC90ZXN0cy9jcm9zcy1vcmlnaW4uaHRtbAotCi0jIFRoZSBwbHVnaW4gZG9l c24ndCBzZWVtIHRvIGxvYWQgYXQgYWxsLi4uICBOb3Qgc3VyZSB3aGF0J3MgZ29pbmcgb24uCi0j IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzgzMwotcGx1Z2lucy9w bHVnaW4tZG9jdW1lbnQtYmFjay1mb3J3YXJkLmh0bWwKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5n ZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMDYzNDQ5ODRiNmU1YWNkZDc4NWMxNjg1YjZi ZTgwNzA1MzA5Mzg2Li44MDk1YzI1YWU3M2ExYWRiOTBkNzc2MDQzZTJkZmNhMTlhMzc5MjA4IDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDItMDQgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtH VEtdIHBsdWdpbnMvcGx1Z2luLWRvY3VtZW50LWJhY2stZm9yd2FyZC5odG1sIGZhaWxzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzgzMworCisgICAg ICAgIEFkZCB0aGUgbmV3ICJhbGVydCBvbiBsb2FkIiBmdW5jdGlvbmFsaXR5IGZvciB0aGUgVW5p eCB2ZXJzaW9uIG9mIHRoZQorICAgICAgICB0ZXN0IHBsdWdpbi4gVGhpcyBmdW5jdGlvbmFsaXR5 IHdhcyBvcmlnaW5hbGx5IGludHJvZHVjZWQgaW4gcjc3NzA2LgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcDoK KyAgICAgICAgKHdlYmtpdF90ZXN0X3BsdWdpbl9uZXdfaW5zdGFuY2UpOiBBZGQgbmV3IHBsdWdp biBmdWN0aW9uYWxpdHkuCisKIDIwMTEtMDItMDQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBs dWdpbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRzY2FwZVBsdWdpbi9U ZXN0TmV0c2NhcGVQbHVnaW4uY3BwCmluZGV4IDJmNzI4OGE2MGMyMjYzYTk1NjNiYjRmMzI2MWE2 ZDM2ZmEzZWUxZDMuLjQ5MzZlZmQxNjEzNGEzZTJiNzFmODg3ZWMzMjgzYTYxYjI5NDY4ODkgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rl c3ROZXRzY2FwZVBsdWdpbi5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvdW5peC9UZXN0 TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcApAQCAtNzksNiArNzksOSBAQCB3 ZWJraXRfdGVzdF9wbHVnaW5fbmV3X2luc3RhbmNlKE5QTUlNRVR5cGUgbWltZXR5cGUsCiAgICAg ICAgICAgICBlbHNlIGlmIChzdHJjYXNlY21wKGFyZ25baV0sICJzcmMiKSA9PSAwICYmCiAgICAg ICAgICAgICAgICAgICAgICBzdHJjYXNlY21wKGFyZ3ZbaV0sICJkYXRhOmFwcGxpY2F0aW9uL3gt d2Via2l0LXRlc3QtbmV0c2NhcGUscmV0dXJuZXJyb3Jmcm9tbmV3c3RyZWFtIikgPT0gMCkKICAg ICAgICAgICAgICAgICBvYmotPnJldHVybkVycm9yRnJvbU5ld1N0cmVhbSA9IFRSVUU7CisgICAg ICAgICAgICBlbHNlIGlmICghc3RyY2FzZWNtcChhcmduW2ldLCAic3JjIikKKyAgICAgICAgICAg ICAgICAgICAgICYmICFzdHJjYXNlY21wKGFyZ3ZbaV0sICJkYXRhOmFwcGxpY2F0aW9uL3gtd2Vi a2l0LXRlc3QtbmV0c2NhcGUsYWxlcnR3aGVubG9hZGVkIikpCisgICAgICAgICAgICAgICAgZXhl Y3V0ZVNjcmlwdChvYmosICJhbGVydCgnUGx1Z2luIExvYWRlZCEnKSIpOwogICAgICAgICAgICAg ZWxzZSBpZiAoc3RyY2FzZWNtcChhcmduW2ldLCAibG9nZmlyc3RzZXR3aW5kb3ciKSA9PSAwKQog ICAgICAgICAgICAgICAgIG9iai0+bG9nU2V0V2luZG93ID0gVFJVRTsKICAgICAgICAgICAgIGVs c2UgaWYgKHN0cmNhc2VjbXAoYXJnbltpXSwgInRlc3RucHJ1bnRpbWUiKSA9PSAwKQo=