53818 2011-02-04 15:07:53 -0800 MediaPlayerPrivateQTKit should use the Application Cache during load. 2011-03-25 18:13:24 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED <none> InRadar, PlatformOnly P2 Normal --- 53784 1 jer.noble jer.noble abarth beidson eric.carlson eric webkit.review.bot oldest_to_newest 345835 0 jer.noble 2011-02-04 15:07:53 -0800 Once https://bugs.webkit.org/show_bug.cgi?id=53784 lands, the MediaPlayerPrivateQTKit should query the Application Cache for resources during load. 372462 1 jer.noble 2011-03-23 15:02:09 -0700 <rdar://problem/9178011> 372489 2 86709 jer.noble 2011-03-23 15:24:58 -0700 Created attachment 86709 Patch 372585 3 86709 mjs 2011-03-23 18:02:25 -0700 Comment on attachment 86709 Patch r=me 372665 4 webkit.review.bot 2011-03-23 21:45:04 -0700 Attachment 86709 did not build on mac: Build output: http://queues.webkit.org/results/8235196 372666 5 jer.noble 2011-03-23 21:46:50 -0700 The build failure is due to the dependant patch from Bug #53784 not being applied first. 372675 6 86709 eric.carlson 2011-03-23 22:38:11 -0700 Comment on attachment 86709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86709&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:319 > + NSMutableDictionary *movieAttributes = [NSMutableDictionary dictionaryWithObjectsAndKeys: > + [NSNumber numberWithBool:m_player->preservesPitch()], QTMovieRateChangesPreservePitchAttribute, > + [NSNumber numberWithBool:YES], QTMoviePreventExternalURLLinksAttribute, > + [NSNumber numberWithBool:YES], QTSecurityPolicyNoCrossSiteAttribute, > + [NSNumber numberWithBool:NO], QTMovieAskUnresolvedDataRefsAttribute, > + [NSNumber numberWithBool:NO], QTMovieLoopsAttribute, > + [NSNumber numberWithBool:YES], @"QTMovieOpenForPlaybackAttribute", > +#ifndef BUILDING_ON_TIGER > + QTMovieApertureModeClean, QTMovieApertureModeAttribute, > +#endif > + nil]; > + I hate having code duplicated in multiple functions, can you put this into a function that you call from MediaPlayerPrivateQTKit::createQTMovie(const String&) and here? 372684 7 jer.noble 2011-03-23 22:56:44 -0700 (In reply to comment #6) > (From update of attachment 86709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86709&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:319 > > + NSMutableDictionary *movieAttributes = [NSMutableDictionary dictionaryWithObjectsAndKeys: > > + [NSNumber numberWithBool:m_player->preservesPitch()], QTMovieRateChangesPreservePitchAttribute, > > + [NSNumber numberWithBool:YES], QTMoviePreventExternalURLLinksAttribute, > > + [NSNumber numberWithBool:YES], QTSecurityPolicyNoCrossSiteAttribute, > > + [NSNumber numberWithBool:NO], QTMovieAskUnresolvedDataRefsAttribute, > > + [NSNumber numberWithBool:NO], QTMovieLoopsAttribute, > > + [NSNumber numberWithBool:YES], @"QTMovieOpenForPlaybackAttribute", > > +#ifndef BUILDING_ON_TIGER > > + QTMovieApertureModeClean, QTMovieApertureModeAttribute, > > +#endif > > + nil]; > > + > > I hate having code duplicated in multiple functions, can you put this into a function that you call from MediaPlayerPrivateQTKit::createQTMovie(const String&) and here? Sure, except for the QTMovieOpenForPlaybackAttribute, which is conditional in createQTMovie. 373805 8 jer.noble 2011-03-25 17:29:22 -0700 Committed r82009: <http://trac.webkit.org/changeset/82009> 373821 9 webkit.review.bot 2011-03-25 18:13:24 -0700 http://trac.webkit.org/changeset/82009 might have broken Leopard Intel Release (Tests) The following tests are not passing: plugins/embed-prefers-plugins-for-images.html 86709 2011-03-23 15:24:58 -0700 2011-03-23 22:38:11 -0700 Patch bug-53818-20110323152457.patch text/plain 6257 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODE4MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOTQwMDY3Y2EwNWIxNGEw M2M3MTYwZTczYjlmNTQ0NWNkNjYzMzkxLi5lZWE1ZDkyMzQ0ZjFlYWIzNWZhYmUwNTlmNmVjNGMw OTQ1NmIyMmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMDMgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQgc2hvdWxkIHVzZSB0 aGUgQXBwbGljYXRpb24gQ2FjaGUgZHVyaW5nIGxvYWQuICAgICAgICAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzODE4CisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLgorCisgICAgICAgIFdoZW4gbG9hZGluZyBhIFVSTCwgY2hlY2sgdG8gc2VlIGlmIHRo ZSBBcHBsaWNhdGlvbiBDYWNoZSBoYXMgYSB2ZXJzaW9uIG9mIHRoYXQgVVJMCisgICAgICAgIHN0 b3JlZDsgaWYgc28sIHVzZSB0aGF0IGRhdGEgaW5zdGVhZCBvZiB0aGUgcmVtb3RlIFVSTC4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtp dC5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpjcmVhdGVR VE1vdmllKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Ojpsb2Fk SW50ZXJuYWwpOgorCiAyMDExLTAzLTIzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0 LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2 YXRlUVRLaXQuaAppbmRleCA4MGJjOTRlODUyNGY4MDhhZjAwMTZjOWU0MjdlNTI5ZmQzYjRjMGU3 Li43MDFiOWE2NTY3ZmY1ZGUxY2ExOTYyNzhmYjc3ZGIzOWVhZGQ3ZDE4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRL aXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5 ZXJQcml2YXRlUVRLaXQuaApAQCAtNTQsNiArNTQsOCBAQCBjbGFzcyBXZWJDb3JlTW92aWVPYnNl cnZlcjsKICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CisgICAgCitjbGFzcyBBcHBsaWNh dGlvbkNhY2hlUmVzb3VyY2U7CiAKIGNsYXNzIE1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0IDogcHVi bGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CiBwdWJsaWM6CkBAIC0xMzksNiArMTQx LDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgY3JlYXRlUVRNb3ZpZShjb25zdCBTdHJpbmcmIHVy bCk7CiAgICAgdm9pZCBjcmVhdGVRVE1vdmllKE5TVVJMICosIE5TRGljdGlvbmFyeSAqbW92aWVB dHRyaWJ1dGVzKTsKKyAgICB2b2lkIGNyZWF0ZVFUTW92aWUoQXBwbGljYXRpb25DYWNoZVJlc291 cmNlKik7CiAKICAgICBlbnVtIE1lZGlhUmVuZGVyaW5nTW9kZSB7IE1lZGlhUmVuZGVyaW5nTm9u ZSwgTWVkaWFSZW5kZXJpbmdNb3ZpZVZpZXcsIE1lZGlhUmVuZGVyaW5nU29mdHdhcmVSZW5kZXJl ciwgTWVkaWFSZW5kZXJpbmdNb3ZpZUxheWVyIH07CiAgICAgTWVkaWFSZW5kZXJpbmdNb2RlIGN1 cnJlbnRSZW5kZXJpbmdNb2RlKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0K aW5kZXggZWNiN2Q5ZmFkMThjNjdkYzAzYTVkYzkwZGNkYTMwZTQ1ODA4ZTBjZi4uYWYxNjVlZDJi Y2RjNjVkNjlkMmU4ZWUyYjY4MTZjNzZmNjkxYmJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVR VEtpdC5tbQpAQCAtMjksMTEgKzI5LDE4IEBACiAKICNpbXBvcnQgIk1lZGlhUGxheWVyUHJpdmF0 ZVFUS2l0LmgiCiAKKyNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQorI2luY2x1 ZGUgIkFwcGxpY2F0aW9uQ2FjaGVIb3N0LmgiCisjaW5jbHVkZSAiQXBwbGljYXRpb25DYWNoZVJl c291cmNlLmgiCisjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIuaCIKKyNlbmRpZgorCiAjaWZkZWYg QlVJTERJTkdfT05fVElHRVIKICNpbXBvcnQgIkF1dG9kcmFpbmVkUG9vbC5oIgogI2VuZGlmCiAK ICNpbXBvcnQgIkJsb2NrRXhjZXB0aW9ucy5oIgorI2ltcG9ydCAiRG9jdW1lbnRMb2FkZXIuaCIK ICNpbXBvcnQgIkZyYW1lVmlldy5oIgogI2ltcG9ydCAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW1w b3J0ICJLVVJMLmgiCkBAIC04Myw2ICs5MCw3IEBAIFNPRlRfTElOS19QT0lOVEVSKFFUS2l0LCBR VE1lZGlhVHlwZVRleHQsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktfUE9JTlRFUihRVEtpdCwgUVRN ZWRpYVR5cGVWaWRlbywgTlNTdHJpbmcgKikKIFNPRlRfTElOS19QT0lOVEVSKFFUS2l0LCBRVE1v dmllQXNrVW5yZXNvbHZlZERhdGFSZWZzQXR0cmlidXRlLCBOU1N0cmluZyAqKQogU09GVF9MSU5L X1BPSU5URVIoUVRLaXQsIFFUTW92aWVMb29wc0F0dHJpYnV0ZSwgTlNTdHJpbmcgKikKK1NPRlRf TElOS19QT0lOVEVSKFFUS2l0LCBRVE1vdmllRGF0YUF0dHJpYnV0ZSwgTlNTdHJpbmcgKikKIFNP RlRfTElOS19QT0lOVEVSKFFUS2l0LCBRVE1vdmllRGF0YVNpemVBdHRyaWJ1dGUsIE5TU3RyaW5n ICopCiBTT0ZUX0xJTktfUE9JTlRFUihRVEtpdCwgUVRNb3ZpZURpZEVuZE5vdGlmaWNhdGlvbiwg TlNTdHJpbmcgKikKIFNPRlRfTElOS19QT0lOVEVSKFFUS2l0LCBRVE1vdmllSGFzVmlkZW9BdHRy aWJ1dGUsIE5TU3RyaW5nICopCkBAIC0xMjAsNiArMTI4LDcgQEAgU09GVF9MSU5LX1BPSU5URVIo UVRLaXQsIFFUTW92aWVBcGVydHVyZU1vZGVBdHRyaWJ1dGUsIE5TU3RyaW5nICopCiAjZGVmaW5l IFFUTWVkaWFUeXBlVmlkZW8gZ2V0UVRNZWRpYVR5cGVWaWRlbygpCiAjZGVmaW5lIFFUTW92aWVB c2tVbnJlc29sdmVkRGF0YVJlZnNBdHRyaWJ1dGUgZ2V0UVRNb3ZpZUFza1VucmVzb2x2ZWREYXRh UmVmc0F0dHJpYnV0ZSgpCiAjZGVmaW5lIFFUTW92aWVMb29wc0F0dHJpYnV0ZSBnZXRRVE1vdmll TG9vcHNBdHRyaWJ1dGUoKQorI2RlZmluZSBRVE1vdmllRGF0YUF0dHJpYnV0ZSBnZXRRVE1vdmll RGF0YUF0dHJpYnV0ZSgpCiAjZGVmaW5lIFFUTW92aWVEYXRhU2l6ZUF0dHJpYnV0ZSBnZXRRVE1v dmllRGF0YVNpemVBdHRyaWJ1dGUoKQogI2RlZmluZSBRVE1vdmllRGlkRW5kTm90aWZpY2F0aW9u IGdldFFUTW92aWVEaWRFbmROb3RpZmljYXRpb24oKQogI2RlZmluZSBRVE1vdmllSGFzVmlkZW9B dHRyaWJ1dGUgZ2V0UVRNb3ZpZUhhc1ZpZGVvQXR0cmlidXRlKCkKQEAgLTI5MSw2ICszMDAsNDIg QEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6Y3JlYXRlUVRNb3ZpZShjb25zdCBTdHJp bmcmIHVybCkKICAgICBjcmVhdGVRVE1vdmllKGNvY29hVVJMLCBtb3ZpZUF0dHJpYnV0ZXMpOwog fQogCit2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpjcmVhdGVRVE1vdmllKEFwcGxpY2F0 aW9uQ2FjaGVSZXNvdXJjZSogcmVzb3VyY2UpCit7CisjaWYgRU5BQkxFKE9GRkxJTkVfV0VCX0FQ UExJQ0FUSU9OUykKKyAgICBBU1NFUlQocmVzb3VyY2UpOworCisgICAgTlNNdXRhYmxlRGljdGlv bmFyeSAqbW92aWVBdHRyaWJ1dGVzID0gW05TTXV0YWJsZURpY3Rpb25hcnkgZGljdGlvbmFyeVdp dGhPYmplY3RzQW5kS2V5czoKKyAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOm1fcGxh eWVyLT5wcmVzZXJ2ZXNQaXRjaCgpXSwgUVRNb3ZpZVJhdGVDaGFuZ2VzUHJlc2VydmVQaXRjaEF0 dHJpYnV0ZSwKKyAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOllFU10sIFFUTW92aWVQ cmV2ZW50RXh0ZXJuYWxVUkxMaW5rc0F0dHJpYnV0ZSwKKyAgICAgICAgW05TTnVtYmVyIG51bWJl cldpdGhCb29sOllFU10sIFFUU2VjdXJpdHlQb2xpY3lOb0Nyb3NzU2l0ZUF0dHJpYnV0ZSwKKyAg ICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOk5PXSwgUVRNb3ZpZUFza1VucmVzb2x2ZWRE YXRhUmVmc0F0dHJpYnV0ZSwKKyAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOk5PXSwg UVRNb3ZpZUxvb3BzQXR0cmlidXRlLAorICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6 WUVTXSwgQCJRVE1vdmllT3BlbkZvclBsYXliYWNrQXR0cmlidXRlIiwKKyNpZm5kZWYgQlVJTERJ TkdfT05fVElHRVIKKyAgICAgICAgUVRNb3ZpZUFwZXJ0dXJlTW9kZUNsZWFuLCBRVE1vdmllQXBl cnR1cmVNb2RlQXR0cmlidXRlLAorI2VuZGlmCisgICAgICAgIG5pbF07CisgICAgCisgICAgLy8g QXBwbGljYXRpb25DYWNoZVJlc291cmNlcyBjYW4gc3VwcGx5IGVpdGhlciBhIGRhdGEgcG9pbnRl ciwgb3IgYSBwYXRoIHRvIGEgbG9jYWxseSBjYWNoZWQgCisgICAgLy8gZmxhdCBmaWxlLiAgV2Ug d291bGQgcHJlZmVyIHRoZSBwYXRoIG92ZXIgdGhlIGRhdGEsIGJ1dCBRVEtpdCBjYW4gaGFuZGxl IGVpdGhlcjoKKyAgICBTdHJpbmcgbG9jYWxQYXRoID0gcmVzb3VyY2UtPnBhdGgoKTsKKyAgICBO U1VSTCogY29jb2FVUkwgPSAhbG9jYWxQYXRoLmlzRW1wdHkoKSA/IFtOU1VSTCBmaWxlVVJMV2l0 aFBhdGg6bG9jYWxQYXRoIGlzRGlyZWN0b3J5Ok5PXSA6IG5pbDsKKyAgICBpZiAoY29jb2FVUkwp CisgICAgICAgIFttb3ZpZUF0dHJpYnV0ZXMgc2V0VmFsdWU6Y29jb2FVUkwgZm9yS2V5OlFUTW92 aWVVUkxBdHRyaWJ1dGVdOworICAgIGVsc2UgeworICAgICAgICBOU0RhdGEqIG1vdmllRGF0YSA9 IHJlc291cmNlLT5kYXRhKCktPmNyZWF0ZU5TRGF0YSgpOworICAgICAgICBbbW92aWVBdHRyaWJ1 dGVzIHNldFZhbHVlOm1vdmllRGF0YSBmb3JLZXk6UVRNb3ZpZURhdGFBdHRyaWJ1dGVdOworICAg ICAgICBbbW92aWVEYXRhIHJlbGVhc2VdOworICAgIH0KKyAgICAKKyAgICBjcmVhdGVRVE1vdmll KGNvY29hVVJMLCBtb3ZpZUF0dHJpYnV0ZXMpOworICAgIAorI2Vsc2UKKyAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyNlbmRpZgorfQorCiBzdGF0aWMgdm9pZCBkaXNhYmxlQ29tcG9uZW50c09u Y2UoKQogewogICAgIHN0YXRpYyBib29sIHNDb21wb25lbnRzRGlzYWJsZWQgPSBmYWxzZTsKQEAg LTY1OCw2ICs3MDMsMTQgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6bG9hZEludGVy bmFsKGNvbnN0IFN0cmluZyYgdXJsKQogICAgIAogICAgIFttX29iamNPYnNlcnZlci5nZXQoKSBz ZXREZWxheUNhbGxiYWNrczpZRVNdOwogCisjaWYgRU5BQkxFKE9GRkxJTkVfV0VCX0FQUExJQ0FU SU9OUykKKyAgICBGcmFtZSogZnJhbWUgPSBtX3BsYXllci0+ZnJhbWVWaWV3KCkgPyBtX3BsYXll ci0+ZnJhbWVWaWV3KCktPmZyYW1lKCkgOiBOVUxMOworICAgIEFwcGxpY2F0aW9uQ2FjaGVIb3N0 KiBjYWNoZUhvc3QgPSBmcmFtZSA/IGZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+ YXBwbGljYXRpb25DYWNoZUhvc3QoKSA6IE5VTEw7CisgICAgQXBwbGljYXRpb25DYWNoZVJlc291 cmNlKiByZXNvdXJjZSA9IE5VTEw7CisgICAgaWYgKGNhY2hlSG9zdCAmJiBjYWNoZUhvc3QtPnNo b3VsZExvYWRSZXNvdXJjZUZyb21BcHBsaWNhdGlvbkNhY2hlKFJlc291cmNlUmVxdWVzdCh1cmwp LCByZXNvdXJjZSkgJiYgcmVzb3VyY2UpCisgICAgICAgIGNyZWF0ZVFUTW92aWUocmVzb3VyY2Up OworICAgIGVsc2UKKyNlbmRpZiAgICAKICAgICBjcmVhdGVRVE1vdmllKHVybCk7CiAKICAgICBb bV9vYmpjT2JzZXJ2ZXIuZ2V0KCkgbG9hZFN0YXRlQ2hhbmdlZDpuaWxdOwo=