53815 2011-02-04 14:54:31 -0800 NotificationCenter shouldn't keep its own ScriptExecutionContext* 2011-02-05 02:37:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth commit-queue eric oldest_to_newest 345820 0 japhet 2011-02-04 14:54:31 -0800 ....it should use the one it inherits from ActiveDOMObject. No need to duplicate, especially since only ActiveDOMObject's gets cleared when the ScriptExecutionContext goes away. 345833 1 81298 japhet 2011-02-04 15:07:04 -0800 Created attachment 81298 patch 346095 2 commit-queue 2011-02-05 02:35:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 81298: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 346096 3 81298 commit-queue 2011-02-05 02:37:30 -0800 Comment on attachment 81298 patch Clearing flags on attachment: 81298 Committed r77738: <http://trac.webkit.org/changeset/77738> 346097 4 commit-queue 2011-02-05 02:37:34 -0800 All reviewed patches have been landed. Closing bug. 81298 2011-02-04 15:07:04 -0800 2011-02-05 02:37:30 -0800 patch n.txt text/plain 5971 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjgyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDItMDQgIE5hdGUgQ2hh cGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZWZhY3RvcjogTm90aWZpY2F0aW9uQ2VudGVyIHNob3VsZG4n dCBob2xkIGl0cyBvd24gY29weSBvZiB0aGUgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCoKKyAgICAg ICAgd2hlbiBpdCBpbmhlcml0cyBvbmUgZnJvbSBBY3RpdmVET01PYmplY3QuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzgxNQorCisgICAgICAgICog YmluZGluZ3MvanMvSlNEZXNrdG9wTm90aWZpY2F0aW9uc0N1c3RvbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpKU05vdGlmaWNhdGlvbkNlbnRlcjo6cmVxdWVzdFBlcm1pc3Npb24pOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vdGlmaWNhdGlvbkNlbnRlckN1c3RvbS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpWOE5vdGlmaWNhdGlvbkNlbnRlcjo6cmVxdWVzdFBlcm1pc3Npb25D YWxsYmFjayk6CisgICAgICAgICogbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Tm90aWZpY2F0aW9uQ2VudGVyOjpOb3RpZmljYXRpb25DZW50 ZXIpOgorICAgICAgICAoV2ViQ29yZTo6Tm90aWZpY2F0aW9uQ2VudGVyOjpjaGVja1Blcm1pc3Np b24pOgorICAgICAgICAoV2ViQ29yZTo6Tm90aWZpY2F0aW9uQ2VudGVyOjpyZXF1ZXN0UGVybWlz c2lvbik6CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb25DZW50ZXI6OmRpc2Nvbm5lY3RG cmFtZSk6CisgICAgICAgICogbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaDoKKyAg ICAgICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvbkNlbnRlcjo6Y3JlYXRlSFRNTE5vdGlmaWNhdGlv bik6CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb25DZW50ZXI6OmNyZWF0ZU5vdGlmaWNh dGlvbik6CisKIDIwMTEtMDItMDQgIE1hcnRpbiBHYWxwaW4gIDxtYXJ0aW5ANjZsYXBzLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTRGVza3RvcE5vdGlmaWNhdGlvbnNDdXN0b20uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGVza3RvcE5vdGlmaWNhdGlvbnNDdXN0 b20uY3BwCShyZXZpc2lvbiA3NzY0NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RGVza3RvcE5vdGlmaWNhdGlvbnNDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0 Nyw3IEBACiAKIEpTVmFsdWUgSlNOb3RpZmljYXRpb25DZW50ZXI6OnJlcXVlc3RQZXJtaXNzaW9u KEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 ID0gaW1wbCgpLT5jb250ZXh0KCk7CisgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4 dCA9IGltcGwoKS0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpOwogCiAgICAgLy8gTWFrZSBzdXJl IHRoYXQgc2NyaXB0IGV4ZWN1dGlvbiBjb250ZXh0IGlzIHZhbGlkLgogICAgIGlmICghY29udGV4 dCkgewpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm90aWZpY2F0 aW9uQ2VudGVyQ3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhOb3RpZmljYXRpb25DZW50ZXJDdXN0b20uY3BwCShyZXZpc2lvbiA3NzY0 NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vdGlmaWNhdGlvbkNl bnRlckN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxLDcgKzgxLDcgQEAKIHsKICAgICBJ TkNfU1RBVFMoTCJET00uTm90aWZpY2F0aW9uQ2VudGVyLlJlcXVlc3RQZXJtaXNzaW9uKCkiKTsK ICAgICBOb3RpZmljYXRpb25DZW50ZXIqIG5vdGlmaWNhdGlvbkNlbnRlciA9IFY4Tm90aWZpY2F0 aW9uQ2VudGVyOjp0b05hdGl2ZShhcmdzLkhvbGRlcigpKTsKLSAgICBTY3JpcHRFeGVjdXRpb25D b250ZXh0KiBjb250ZXh0ID0gbm90aWZpY2F0aW9uQ2VudGVyLT5jb250ZXh0KCk7CisgICAgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IG5vdGlmaWNhdGlvbkNlbnRlci0+c2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpOwogCiAgICAgLy8gTWFrZSBzdXJlIHRoYXQgc2NyaXB0IGV4ZWN1 dGlvbiBjb250ZXh0IGlzIHZhbGlkLgogICAgIGlmICghY29udGV4dCkKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5jcHAJKHJl dmlzaW9uIDc3NjQ1KQorKysgU291cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRp b25DZW50ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MiwyMSArNDIsMjAgQEAKIAogTm90aWZp Y2F0aW9uQ2VudGVyOjpOb3RpZmljYXRpb25DZW50ZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCog Y29udGV4dCwgTm90aWZpY2F0aW9uUHJlc2VudGVyKiBwcmVzZW50ZXIpCiAgICAgOiBBY3RpdmVE T01PYmplY3QoY29udGV4dCwgdGhpcykKLSAgICAsIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dChj b250ZXh0KQogICAgICwgbV9ub3RpZmljYXRpb25QcmVzZW50ZXIocHJlc2VudGVyKSB7fQogCiBp bnQgTm90aWZpY2F0aW9uQ2VudGVyOjpjaGVja1Blcm1pc3Npb24oKQogewotICAgIGlmICghcHJl c2VudGVyKCkpCisgICAgaWYgKCFwcmVzZW50ZXIoKSB8fCAhc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCgpKQogICAgICAgICByZXR1cm4gTm90aWZpY2F0aW9uUHJlc2VudGVyOjpQZXJtaXNzaW9uRGVu aWVkOwotICAgIHJldHVybiBtX25vdGlmaWNhdGlvblByZXNlbnRlci0+Y2hlY2tQZXJtaXNzaW9u KG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCk7CisgICAgcmV0dXJuIG1fbm90aWZpY2F0aW9uUHJl c2VudGVyLT5jaGVja1Blcm1pc3Npb24oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKIH0KIAog dm9pZCBOb3RpZmljYXRpb25DZW50ZXI6OnJlcXVlc3RQZXJtaXNzaW9uKFBhc3NSZWZQdHI8Vm9p ZENhbGxiYWNrPiBjYWxsYmFjaykKIHsKLSAgICBpZiAoIXByZXNlbnRlcigpKQorICAgIGlmICgh cHJlc2VudGVyKCkgfHwgIXNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKICAgICAgICAgcmV0dXJu OwotICAgIG1fbm90aWZpY2F0aW9uUHJlc2VudGVyLT5yZXF1ZXN0UGVybWlzc2lvbihtX3Njcmlw dEV4ZWN1dGlvbkNvbnRleHQsIGNhbGxiYWNrKTsKKyAgICBtX25vdGlmaWNhdGlvblByZXNlbnRl ci0+cmVxdWVzdFBlcm1pc3Npb24oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCBjYWxsYmFjayk7 CiB9CiAKIHZvaWQgTm90aWZpY2F0aW9uQ2VudGVyOjpkaXNjb25uZWN0RnJhbWUoKQpAQCAtNjYs OSArNjUsOCBAQAogICAgIEFTU0VSVChtX25vdGlmaWNhdGlvblByZXNlbnRlcik7CiAgICAgaWYg KCFtX25vdGlmaWNhdGlvblByZXNlbnRlcikKICAgICAgICAgcmV0dXJuOwotICAgIG1fbm90aWZp Y2F0aW9uUHJlc2VudGVyLT5jYW5jZWxSZXF1ZXN0c0ZvclBlcm1pc3Npb24obV9zY3JpcHRFeGVj dXRpb25Db250ZXh0KTsKKyAgICBtX25vdGlmaWNhdGlvblByZXNlbnRlci0+Y2FuY2VsUmVxdWVz dHNGb3JQZXJtaXNzaW9uKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSk7CiAgICAgbV9ub3RpZmlj YXRpb25QcmVzZW50ZXIgPSAwOwotICAgIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCA9IDA7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL25vdGlmaWNh dGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv bm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaAkocmV2aXNpb24gNzc2NDUpCisrKyBT b3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5oCSh3b3JraW5n IGNvcHkpCkBAIC01OCw3ICs1OCw3IEBACiAgICAgICAgICAgICAgICAgZWMgPSBTWU5UQVhfRVJS OwogICAgICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICAgICAgfQotICAgICAgICAgICAg cmV0dXJuIE5vdGlmaWNhdGlvbjo6Y3JlYXRlKG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+Y29t cGxldGVVUkwoVVJJKSwgY29udGV4dCgpLCBlYywgdGhpcyk7CisgICAgICAgICAgICByZXR1cm4g Tm90aWZpY2F0aW9uOjpjcmVhdGUoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5jb21wbGV0ZVVS TChVUkkpLCBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCksIGVjLCB0aGlzKTsKICAgICAgICAgfQog CiAgICAgICAgIFBhc3NSZWZQdHI8Tm90aWZpY2F0aW9uPiBjcmVhdGVOb3RpZmljYXRpb24oY29u c3QgU3RyaW5nJiBpY29uVVJJLCBjb25zdCBTdHJpbmcmIHRpdGxlLCBjb25zdCBTdHJpbmcmIGJv ZHksIEV4Y2VwdGlvbkNvZGUmIGVjKQpAQCAtNjcsMTEgKzY3LDEwIEBACiAgICAgICAgICAgICAg ICAgZWMgPSBJTlZBTElEX1NUQVRFX0VSUjsKICAgICAgICAgICAgICAgICByZXR1cm4gMDsKICAg ICAgICAgICAgIH0KLSAgICAgICAgICAgIE5vdGlmaWNhdGlvbkNvbnRlbnRzIGNvbnRlbnRzKGlj b25VUkkuaXNFbXB0eSgpID8gS1VSTCgpIDogbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5jb21w bGV0ZVVSTChpY29uVVJJKSwgdGl0bGUsIGJvZHkpOwotICAgICAgICAgICAgcmV0dXJuIE5vdGlm aWNhdGlvbjo6Y3JlYXRlKGNvbnRlbnRzLCBjb250ZXh0KCksIGVjLCB0aGlzKTsKKyAgICAgICAg ICAgIE5vdGlmaWNhdGlvbkNvbnRlbnRzIGNvbnRlbnRzKGljb25VUkkuaXNFbXB0eSgpID8gS1VS TCgpIDogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5jb21wbGV0ZVVSTChpY29uVVJJKSwgdGl0 bGUsIGJvZHkpOworICAgICAgICAgICAgcmV0dXJuIE5vdGlmaWNhdGlvbjo6Y3JlYXRlKGNvbnRl bnRzLCBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCksIGVjLCB0aGlzKTsKICAgICAgICAgfQogCi0g ICAgICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQoKSBjb25zdCB7IHJldHVybiBt X3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQ7IH0KICAgICAgICAgTm90aWZpY2F0aW9uUHJlc2VudGVy KiBwcmVzZW50ZXIoKSBjb25zdCB7IHJldHVybiBtX25vdGlmaWNhdGlvblByZXNlbnRlcjsgfQog CiAgICAgICAgIGludCBjaGVja1Blcm1pc3Npb24oKTsKQEAgLTgyLDcgKzgxLDYgQEAKICAgICBw cml2YXRlOgogICAgICAgICBOb3RpZmljYXRpb25DZW50ZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCosIE5vdGlmaWNhdGlvblByZXNlbnRlciopOwogCi0gICAgICAgIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQqIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dDsKICAgICAgICAgTm90aWZpY2F0aW9uUHJl c2VudGVyKiBtX25vdGlmaWNhdGlvblByZXNlbnRlcjsKICAgICB9OwogCg==