53811 2011-02-04 14:03:54 -0800 Null deref in DOMURL 2011-02-07 23:45:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 cdn webkit-unassigned commit-queue jianli oldest_to_newest 345781 0 cdn 2011-02-04 14:03:54 -0800 Just fixing a null deref in DOMURL when the script execution context doesn't exist at the time of creation. I'll post a patch in a minute. 345849 1 81304 cdn 2011-02-04 15:26:41 -0800 Created attachment 81304 Patch 346901 2 81304 jianli 2011-02-07 15:42:46 -0800 Comment on attachment 81304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81304&action=review > Source/WebCore/ChangeLog:5 > + fix null deref in DOMURL Please capitalize the 1st character. > LayoutTests/ChangeLog:9 > + * fast/dom/domurl-script-execution-context-crash.html: Added. Since DOMURL is only used for blob URL, I think we'd better put this new test under fast/files. > LayoutTests/fast/dom/domurl-script-execution-context-crash.html:6 > + e.apply(w,['webkitURL']); Please add a space after comma. > LayoutTests/fast/dom/domurl-script-execution-context-crash.html:16 > + setTimeout(crash,30); ditto. > LayoutTests/fast/dom/domurl-script-execution-context-crash.html:26 > +e=(w=open()).eval; Please add space before and after 2 "=" operators. 346916 3 81547 cdn 2011-02-07 16:05:12 -0800 Created attachment 81547 Patch 347178 4 commit-queue 2011-02-07 23:43:36 -0800 The commit-queue encountered the following flaky tests while processing attachment 81547: inspector/debugger-scripts.html bug 53982 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch. 347181 5 81547 commit-queue 2011-02-07 23:45:01 -0800 Comment on attachment 81547 Patch Clearing flags on attachment: 81547 Committed r77914: <http://trac.webkit.org/changeset/77914> 347182 6 commit-queue 2011-02-07 23:45:06 -0800 All reviewed patches have been landed. Closing bug. 81304 2011-02-04 15:26:41 -0800 2011-02-07 16:05:10 -0800 Patch bug-53811-20110204152640.patch text/plain 3176 cdn SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDQgIENyaXMgTmVj a2FyICA8Y2RuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBmaXggbnVsbCBkZXJlZiBpbiBET01VUkwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzODExCisKKyAgICAgICAgVGVzdDog ZmFzdC9kb20vZG9tdXJsLXNjcmlwdC1leGVjdXRpb24tY29udGV4dC1jcmFzaC5odG1sCisKKyAg ICAgICAgKiBodG1sL0RPTVVSTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01VUkw6OkRPTVVS TCk6CisKIDIwMTEtMDItMDQgIE1hcnRpbiBHYWxwaW4gIDxtYXJ0aW5ANjZsYXBzLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0 bWwvRE9NVVJMLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0RPTVVSTC5j cHAJKHJldmlzaW9uIDc3Mzk2KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9ET01VUkwuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zNyw3ICszNyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIERPTVVS TDo6RE9NVVJMKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQp CiAgICAgOiBtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkK IHsKLSAgICBtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPmNyZWF0ZWREb21VcmwodGhpcyk7Cisg ICAgaWYgKG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKKyAgICAgICAgbV9zY3JpcHRFeGVjdXRp b25Db250ZXh0LT5jcmVhdGVkRG9tVXJsKHRoaXMpOwogfQogCiBET01VUkw6On5ET01VUkwoKQpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gNzc2ODMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMi0wNCAgQ3JpcyBOZWNrYXIgIDxjZG5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlc3QgZm9yIG51bGwgZGVyZWYgaW4gRE9NVVJMCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzgxMQorCisgICAgICAgICogZmFzdC9kb20v ZG9tdXJsLXNjcmlwdC1leGVjdXRpb24tY29udGV4dC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZG9tL2RvbXVybC1zY3JpcHQtZXhlY3V0aW9uLWNvbnRleHQtY3Jh c2guaHRtbDogQWRkZWQuCisKIDIwMTEtMDItMDQgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUgTGVvcGFyZCBiYXNlbGluZXMgZm9yIGZh c3QvYmxvY2tmbG93LCB0aGlzIHRpbWUgY29ycmVjdGx5LgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vZG9tdXJsLXNjcmlwdC1leGVjdXRpb24tY29udGV4dC1jcmFzaC1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9tdXJsLXNjcmlwdC1leGVjdXRp b24tY29udGV4dC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2RvbS9kb211cmwtc2NyaXB0LWV4ZWN1dGlvbi1jb250ZXh0LWNyYXNoLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorUEFTUzogbnVsbCBzZWN1cml0eSBjb250 ZXh0IGZvciBET01VUkwgZGlkIG5vdCBjcmFzaApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20v ZG9tdXJsLXNjcmlwdC1leGVjdXRpb24tY29udGV4dC1jcmFzaC5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvZG9tL2RvbXVybC1zY3JpcHQtZXhlY3V0aW9uLWNvbnRleHQtY3Jh c2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2RvbXVybC1zY3Jp cHQtZXhlY3V0aW9uLWNvbnRleHQtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwz MCBAQAorPGh0bWw+Cis8c2NyaXB0PgorZnVuY3Rpb24gY3Jhc2goKQoreworICAgIHRyeSB7Cisg ICAgICAgIGUuYXBwbHkodyxbJ3dlYmtpdFVSTCddKTsKKyAgICB9IGNhdGNoIChleCkgeyB9Cisg ICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiUEFTUzogbnVsbCBzZWN1cml0eSBjb250ZXh0 IGZvciBET01VUkwgZGlkIG5vdCBjcmFzaCI7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQor CitmdW5jdGlvbiBsb2FkKCkKK3sKKyAgICB3LmNsb3NlKCk7CisgICAgc2V0VGltZW91dChjcmFz aCwzMCk7Cit9CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu c2V0Q2FuT3BlbldpbmRvd3MoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRDbG9zZVJl bWFpbmluZ1dpbmRvd3NXaGVuQ29tcGxldGUodHJ1ZSk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOworfQorCitlPSh3PW9wZW4oKSkuZXZhbDsKKzwvc2NyaXB0Pgor PGJvZHkgb25sb2FkPSJsb2FkKCkiPgorPC9ib2R5PgorPC9odG1sPgo= 81547 2011-02-07 16:05:12 -0800 2011-02-07 23:45:01 -0800 Patch bug-53811-20110207160511.patch text/plain 3200 cdn SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDQgIENyaXMgTmVj a2FyICA8Y2RuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggbnVsbCBkZXJlZiBpbiBET01VUkwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzODExCisKKyAgICAgICAgVGVzdDog ZmFzdC9maWxlcy9kb211cmwtc2NyaXB0LWV4ZWN1dGlvbi1jb250ZXh0LWNyYXNoLmh0bWwKKwor ICAgICAgICAqIGh0bWwvRE9NVVJMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVVSTDo6RE9N VVJMKToKKwogMjAxMS0wMi0wNCAgTWFydGluIEdhbHBpbiAgPG1hcnRpbkA2NmxhcHMuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogU291cmNlL1dlYkNvcmUv aHRtbC9ET01VUkwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvRE9NVVJM LmNwcAkocmV2aXNpb24gNzczOTYpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0RPTVVSTC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogRE9N VVJMOjpET01VUkwoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCkKICAgICA6IG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dChzY3JpcHRFeGVjdXRpb25Db250ZXh0 KQogewotICAgIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+Y3JlYXRlZERvbVVybCh0aGlzKTsK KyAgICBpZiAobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KQorICAgICAgICBtX3NjcmlwdEV4ZWN1 dGlvbkNvbnRleHQtPmNyZWF0ZWREb21VcmwodGhpcyk7CiB9CiAKIERPTVVSTDo6fkRPTVVSTCgp CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiA3NzY4MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTAyLTA0ICBDcmlzIE5lY2thciAgPGNk bkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdCBmb3IgbnVsbCBkZXJlZiBpbiBET01VUkwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzODExCisKKyAgICAgICAgKiBmYXN0L2Zp bGVzL2RvbXVybC1zY3JpcHQtZXhlY3V0aW9uLWNvbnRleHQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2ZpbGVzL2RvbXVybC1zY3JpcHQtZXhlY3V0aW9uLWNvbnRl eHQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTEtMDItMDQgIERpbWl0cmkgR2xhemtvdiAgPGRn bGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUgTGVvcGFyZCBiYXNlbGluZXMg Zm9yIGZhc3QvYmxvY2tmbG93LCB0aGlzIHRpbWUgY29ycmVjdGx5LgpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9maWxlcy9kb211cmwtc2NyaXB0LWV4ZWN1dGlvbi1jb250ZXh0LWNyYXNoLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2RvbXVybC1zY3Jp cHQtZXhlY3V0aW9uLWNvbnRleHQtY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9maWxlcy9kb211cmwtc2NyaXB0LWV4ZWN1dGlvbi1jb250ZXh0LWNy YXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorUEFTUzogbnVsbCBz ZWN1cml0eSBjb250ZXh0IGZvciBET01VUkwgZGlkIG5vdCBjcmFzaApJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9maWxlcy9kb211cmwtc2NyaXB0LWV4ZWN1dGlvbi1jb250ZXh0LWNyYXNoLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9kb211cmwtc2NyaXB0LWV4ZWN1 dGlvbi1jb250ZXh0LWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2ZpbGVzL2RvbXVybC1zY3JpcHQtZXhlY3V0aW9uLWNvbnRleHQtY3Jhc2guaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwzMCBAQAorPGh0bWw+Cis8c2NyaXB0PgorZnVuY3Rpb24gY3Jhc2go KQoreworICAgIHRyeSB7CisgICAgICAgIGUuYXBwbHkodywgWyd3ZWJraXRVUkwnXSk7CisgICAg fSBjYXRjaCAoZXgpIHsgfQorICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gIlBBU1M6IG51 bGwgc2VjdXJpdHkgY29udGV4dCBmb3IgRE9NVVJMIGRpZCBub3QgY3Jhc2giOworICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKK30KKworZnVuY3Rpb24gbG9hZCgpCit7CisgICAgdy5jbG9zZSgpOwor ICAgIHNldFRpbWVvdXQoY3Jhc2gsIDMwKTsKK30KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5zZXRDYW5PcGVuV2luZG93cygpOworICAgIGxheW91dFRlc3RD b250cm9sbGVyLnNldENsb3NlUmVtYWluaW5nV2luZG93c1doZW5Db21wbGV0ZSh0cnVlKTsKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CisKK2UgPSAodyA9IG9w ZW4oKSkuZXZhbDsKKzwvc2NyaXB0PgorPGJvZHkgb25sb2FkPSJsb2FkKCkiPgorPC9ib2R5Pgor PC9odG1sPgo=