53810 2011-02-04 14:02:38 -0800 WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit 2011-02-04 14:56:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken buildbot webkit.review.bot oldest_to_newest 345780 0 sfalken 2011-02-04 14:02:38 -0800 WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit 345782 1 81284 sfalken 2011-02-04 14:07:38 -0800 Created attachment 81284 Patch 345786 2 webkit.review.bot 2011-02-04 14:09:03 -0800 Attachment 81284 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/win/MainWin.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 345790 3 81284 aroben 2011-02-04 14:18:51 -0800 Comment on attachment 81284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81284&action=review > Source/WebKit2/win/MainWin.cpp:50 > + ::GetModuleFileNameW(0, webKitPath, ARRAYSIZE(webKitPath)); You could also use _countof or WTF_ARRAY_LENGTH. Maybe the latter is best, since it can be used in cross-platform code, too? > Source/WebKit2/win/MainWin.cpp:57 > + // set to 0. We want both the WebKit client app DLL path and the WebKit directory DLL path in > + // the DLL search order, and we want the current directory set to the WebKit client app path. > + ::SetDllDirectoryW(webKitPath); How does this guarantee that the "client app DLL path" is in the DLL search order, or that the current directory is set to the WebKit client app path? 345800 4 sfalken 2011-02-04 14:36:11 -0800 Since we're using ARRAYSIZE directly within a Win32 call, it seems ok to keep. The file doesn't use any WTF headers now, so this would be the only dependency. The client app path will be in the search order, since the default use of CreateProcess sets the working directory to the same directory as the launching app. The current directory will be set to that path in the client app by Windows Explorer when it launches that app. 345801 5 sfalken 2011-02-04 14:37:29 -0800 Committed r77678: <http://trac.webkit.org/changeset/77678> 345823 6 buildbot 2011-02-04 14:56:28 -0800 Attachment 81284 did not build on win: Build output: http://queues.webkit.org/results/7698620 81284 2011-02-04 14:07:38 -0800 2011-02-04 14:18:51 -0800 Patch bug-53810-20110204140706.patch text/plain 3658 sfalken SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjY4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMDQgIFN0ZXZlIEZh bGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQyIGNsaWVudHMgZmFpbCB0byBsYXVuY2ggb24g V2luZG93cyBpZiBjbGllbnQgZXhlIGlzIGluIGEgZGlmZmVyZW50IGRpcmVjdG9yeSBmcm9tIFdl YktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM4 MTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg5NDYwODU+CisgICAgICAgIAorICAgICAgICBJ ZiBXZWJLaXQyV2ViUHJvY2Vzcy5leGUgaXMgaW4gYSBkaWZmZXJlbnQgZGlyZWN0b3J5IGZyb20g dGhlIGNsaWVudCBwcm9jZXNzLCBhbmQgdGhhdAorICAgICAgICBjbGllbnQgcHJvY2VzcyB1c2Vz IENyZWF0ZVByb2Nlc3MgdG8gbGF1bmNoIFdlYktpdDJXZWJQcm9jZXNzLCB0aGUgRExMIHNlYXJj aCBwYXRoIG1heQorICAgICAgICBlbmQgdXAgZXhjbHVkaW5nIHRoZSBkaXJlY3RvcnkgY29udGFp bmluZyBXZWJLaXQuIFRvIGFkZHJlc3MgdGhpcywgd2UgdXNlIFNldERsbERpcmVjdG9yeQorICAg ICAgICB0byBleHBsaWNpdGx5IGluY2x1ZGUgdGhlIFdlYktpdCBkaXJlY3RvcnkgaW4gdGhlIERM TCBzZWFyY2ggcGF0aC4KKworICAgICAgICAqIHdpbi9NYWluV2luLmNwcDoKKyAgICAgICAgKHdX aW5NYWluKTogVXNlIFNldERsbERpcmVjdG9yeSBhbmQgTG9hZExpYnJhcnkgdG8gbG9hZCBXZWJL aXQuZGxsIGZyb20gV2ViS2l0MldlYlByb2Nlc3MuZXhlCisgICAgICAgICogd2luL1dlYktpdDJX ZWJQcm9jZXNzQ29tbW9uLnZzcHJvcHM6IERvbid0IGxpbmsgZGlyZWN0bHkgdG8gV2ViS2l0LiBM aW5rIGFnYWluc3Qgc2hsd2FwaS4KKwogMjAxMS0wMi0wNCAgQnJpYW4gV2VpbnN0ZWluICA8Yndl aW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4K SW5kZXg6IFNvdXJjZS9XZWJLaXQyL3dpbi9NYWluV2luLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi93aW4vTWFpbldpbi5jcHAJKHJldmlzaW9uIDc3NjM1KQorKysgU291cmNlL1dl YktpdDIvd2luL01haW5XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw2ICsyMyw3IEBACiAg KiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAorI2luY2x1ZGUgPHNobHdh cGkuaD4KICNpbmNsdWRlIDx3aW5kb3dzLmg+CiAKICNpZiBkZWZpbmVkIF9NX0lYODYKQEAgLTM3 LDkgKzM4LDMwIEBACiAKICNwcmFnbWEgY29tbWVudChsaW5rZXIsICIvbWFuaWZlc3RkZXBlbmRl bmN5OlwidHlwZT0nd2luMzInIG5hbWU9J01pY3Jvc29mdC5XaW5kb3dzLkNvbW1vbi1Db250cm9s cycgdmVyc2lvbj0nNi4wLjAuMCcgcHJvY2Vzc29yQXJjaGl0ZWN0dXJlPSciIFBST0NFU1NPUkFS Q0hJVEVDVFVSRSAiJyBwdWJsaWNLZXlUb2tlbj0nNjU5NWI2NDE0NGNjZjFkZicgbGFuZ3VhZ2U9 JyonXCIiKQogCi1leHRlcm4gIkMiIF9fZGVjbHNwZWMoZGxsaW1wb3J0KSBpbnQgV2ViS2l0TWFp bihISU5TVEFOQ0UgaEluc3RhbmNlLCBISU5TVEFOQ0UgaFByZXZJbnN0YW5jZSwgTFBUU1RSIGxw c3RyQ21kTGluZSwgaW50IG5DbWRTaG93KTsKLQogaW50IFdJTkFQSSB3V2luTWFpbihISU5TVEFO Q0UgaEluc3RhbmNlLCBISU5TVEFOQ0UgaFByZXZJbnN0YW5jZSwgTFBUU1RSIGxwc3RyQ21kTGlu ZSwgaW50IG5DbWRTaG93KQogewotICAgIHJldHVybiBXZWJLaXRNYWluKGhJbnN0YW5jZSwgaFBy ZXZJbnN0YW5jZSwgbHBzdHJDbWRMaW5lLCBuQ21kU2hvdyk7CisjaWZuZGVmIERFQlVHX0FMTAor ICAgIExQQ1dTVFIgd2ViS2l0RExMTmFtZSA9IEwiV2ViS2l0LmRsbCI7CisjZWxzZQorICAgIExQ Q1RTVFIgd2ViS2l0RExMTmFtZSA9IEwiV2ViS2l0X2RlYnVnLmRsbCIpOworI2VuZGlmCisKKyAg ICBXQ0hBUiB3ZWJLaXRQYXRoW01BWF9QQVRIXTsKKyAgICA6OkdldE1vZHVsZUZpbGVOYW1lVygw LCB3ZWJLaXRQYXRoLCBBUlJBWVNJWkUod2ViS2l0UGF0aCkpOworICAgIDo6UGF0aFJlbW92ZUZp bGVTcGVjVyh3ZWJLaXRQYXRoKTsKKworICAgIC8vIExvb2sgZm9yIERMTHMgaW4gdGhlIHNhbWUg ZGlyZWN0b3J5IGFzIFdlYktpdDJXZWJQcm9jZXNzLmV4ZS4gVGhpcyBpcyBub3QgaW4gdGhlIHNl YXJjaAorICAgIC8vIHBhdGggYWxyZWFkeSwgc2luY2Ugd2UgbGF1bmNoIFdlYktpdDJXZWJQcm9j ZXNzLmV4ZSB2aWEgQ3JlYXRlUHJvY2VzcyB3aXRoIGxwQ3VycmVudERpcmVjdG9yeQorICAgIC8v IHNldCB0byAwLiBXZSB3YW50IGJvdGggdGhlIFdlYktpdCBjbGllbnQgYXBwIERMTCBwYXRoIGFu ZCB0aGUgV2ViS2l0IGRpcmVjdG9yeSBETEwgcGF0aCBpbgorICAgIC8vIHRoZSBETEwgc2VhcmNo IG9yZGVyLCBhbmQgd2Ugd2FudCB0aGUgY3VycmVudCBkaXJlY3Rvcnkgc2V0IHRvIHRoZSBXZWJL aXQgY2xpZW50IGFwcCBwYXRoLgorICAgIDo6U2V0RGxsRGlyZWN0b3J5Vyh3ZWJLaXRQYXRoKTsK KworICAgIDo6UGF0aEFwcGVuZFcod2ViS2l0UGF0aCwgd2ViS2l0RExMTmFtZSk7CisgICAgSE1P RFVMRSBtb2R1bGUgPSA6OkxvYWRMaWJyYXJ5Vyh3ZWJLaXRQYXRoKTsKKyAgICB0eXBlZGVmIGlu dCAoV0lOQVBJKiBXZWJLaXRNYWluUHJvY1B0cikoSElOU1RBTkNFLCBISU5TVEFOQ0UsIExQVFNU UiwgaW50KTsKKyAgICBXZWJLaXRNYWluUHJvY1B0ciBtYWluUHJvYyA9IHJlaW50ZXJwcmV0X2Nh c3Q8V2ViS2l0TWFpblByb2NQdHI+KEdldFByb2NBZGRyZXNzKG1vZHVsZSwgIldlYktpdE1haW4i KSk7CisgICAgaWYgKCFtYWluUHJvYykKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICByZXR1cm4g bWFpblByb2MoaEluc3RhbmNlLCBoUHJldkluc3RhbmNlLCBscHN0ckNtZExpbmUsIG5DbWRTaG93 KTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL3dpbi9XZWJLaXQyV2ViUHJvY2Vzc0NvbW1vbi52 c3Byb3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL3dpbi9XZWJLaXQyV2ViUHJvY2Vz c0NvbW1vbi52c3Byb3BzCShyZXZpc2lvbiA3NzYzNSkKKysrIFNvdXJjZS9XZWJLaXQyL3dpbi9X ZWJLaXQyV2ViUHJvY2Vzc0NvbW1vbi52c3Byb3BzCSh3b3JraW5nIGNvcHkpCkBAIC0xMCw2ICsx MCw2IEBACiAJLz4KIAk8VG9vbAogCQlOYW1lPSJWQ0xpbmtlclRvb2wiCi0JCUFkZGl0aW9uYWxE ZXBlbmRlbmNpZXM9IldlYktpdCQoV2ViS2l0RExMQ29uZmlnU3VmZml4KS5saWIiCisJCUFkZGl0 aW9uYWxEZXBlbmRlbmNpZXM9IlNobHdhcGkubGliIgogCS8+CiA8L1Zpc3VhbFN0dWRpb1Byb3Bl cnR5U2hlZXQ+Cg==