<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>53808</bug_id>
          
          <creation_ts>2011-02-04 13:46:53 -0800</creation_ts>
          <short_desc>GCC compiler on ARM compile fix has issues.</short_desc>
          <delta_ts>2011-04-15 11:56:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>53620</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Levin">levin</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          <cc>abarth</cc>
    
    <cc>darin</cc>
    
    <cc>eric</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>345760</commentid>
    <comment_count>0</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-02-04 13:46:53 -0800</bug_when>
    <thetext>1. The define isn&apos;t specific enough.
2. The code is stuck forever. How will we know when it can be removed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345772</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-02-04 13:57:01 -0800</bug_when>
    <thetext>You&apos;re a good man, señior levin.  But I wouldn&apos;t kill yourself over this fix.

I look forward to the review!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357143</commentid>
    <comment_count>2</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-02-24 10:28:12 -0800</bug_when>
    <thetext>(In reply to comment #0)
&gt; 1. The define isn&apos;t specific enough.

I can tighten up the define using GCC_VERSION_AT_LEAST.

&gt; 2. The code is stuck forever. How will we know when it can be removed?

I scoured gcc.gnu.org/bugzilla. Nothing sticks out. It also appears our cross-compiler on the ARM bot is quite old, so we should update it and see if it&apos;s gone away.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385915</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-14 11:43:45 -0700</bug_when>
    <thetext>I think the gcc arm compiler has been upgraded (during abarth&apos;s stint as gardener) and likely gotten rid of this issue.

Perhaps it is time to remove the code added in 53620.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386795</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-15 11:56:19 -0700</bug_when>
    <thetext>This compiler fix appears to have been removed as part of http://trac.webkit.org/changeset/80463 so the issue is fixed now.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>