53798 2011-02-04 12:22:31 -0800 Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup window, or when running regression tests 2011-02-04 12:33:38 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 bweinstein bweinstein aroben oldest_to_newest 345681 0 bweinstein 2011-02-04 12:22:31 -0800 Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup window, or when running regression tests. > WebKit.dll!WebKit::WebInspectorProxy::platformClose() Line 174 + 0x25 bytes C++ WebKit.dll!WebKit::WebInspectorProxy::invalidate() Line 74 C++ WebKit.dll!WebKit::WebPageProxy::close() Line 240 C++ WebKit.dll!WKPageClose(const OpaqueWKPage * pageRef=0x061f0f58) Line 103 C++ ASSERT(m_inspectorWindow) is the failing assertion. <rdar://problem/8814364> 345687 1 81264 bweinstein 2011-02-04 12:26:51 -0800 Created attachment 81264 [PATCH] Fix 345691 2 81264 aroben 2011-02-04 12:28:36 -0800 Comment on attachment 81264 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178 > + if (m_isVisible) { > + ASSERT(m_inspectorWindow); > + ASSERT(m_inspectorView); > + } To get rid of the if in Release builds, you could do: ASSERT(!m_isVisible || m_inspectorWindow); ASSERT(!m_isVisible || m_inspectorView); > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181 > + ASSERT(::IsWindow(m_inspectorWindow)); Have you verified that this is true even when the inspector is docked? 345694 3 bweinstein 2011-02-04 12:31:52 -0800 (In reply to comment #2) > (From update of attachment 81264 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review > > > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178 > > + if (m_isVisible) { > > + ASSERT(m_inspectorWindow); > > + ASSERT(m_inspectorView); > > + } > > To get rid of the if in Release builds, you could do: > > ASSERT(!m_isVisible || m_inspectorWindow); > ASSERT(!m_isVisible || m_inspectorView); Fixed. > > > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181 > > + ASSERT(::IsWindow(m_inspectorWindow)); > > Have you verified that this is true even when the inspector is docked? We don't support a docked inspector in WebKit2 yet, but I will make sure to check this when we do. Thanks! 345695 4 bweinstein 2011-02-04 12:33:38 -0800 Landed in r77655. 81264 2011-02-04 12:26:51 -0800 2011-02-04 12:28:36 -0800 [PATCH] Fix inspector_assert.patch text/plain 1722 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjUyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMDQgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIFdlYkluc3BlY3Rv clByb3h5OjpwbGF0Zm9ybUNsb3NlIGNsb3NpbmcgbWFpbiB3aW5kb3cgd2hlbiBpbnNwZWN0aW5n IGEgcG9wdXAgCisgICAgICAgIHdpbmRvdywgb3Igd2hlbiBydW5uaW5nIHJlZ3Jlc3Npb24gdGVz dHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc5 OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODgxNDM2ND4KKyAgICAgICAgCisgICAgICAgIE9u bHkgYXNzZXJ0IGFib3V0IHRoZSBzdGF0ZSBvZiBtX2luc3BlY3RvcldpbmRvdyBhbmQgbV9pbnNw ZWN0b3JWaWV3IGlmIHRoZSBpbnNwZWN0b3IgaXMgdmlzaWJsZS4KKyAgICAgICAgQWxzbywgb25s eSBjYWxsIDo6RGVzdHJveVdpbmRvdyBpZiB0aGUgSFdORCBpcyBub24tbnVsbCwganVzdCB0byBi ZSBzYWZlLgorCisgICAgICAgICogVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNsb3NlKToK KwogMjAxMS0wMi0wNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3Mvd2luL1dlYkluc3BlY3RvclByb3h5V2luLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYkluc3BlY3RvclByb3h5V2luLmNwcAkocmV2aXNp b24gNzc1MjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYkluc3BlY3RvclBy b3h5V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTcyLDEwICsxNzIsMTUgQEAgdm9pZCBXZWJJ bnNwZWN0b3JQcm94eTo6cGxhdGZvcm1PcGVuKCkKIAogdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6 cGxhdGZvcm1DbG9zZSgpCiB7Ci0gICAgQVNTRVJUKG1faW5zcGVjdG9yV2luZG93KTsKLSAgICBB U1NFUlQobV9pbnNwZWN0b3JWaWV3KTsKKyAgICBpZiAobV9pc1Zpc2libGUpIHsKKyAgICAgICAg QVNTRVJUKG1faW5zcGVjdG9yV2luZG93KTsKKyAgICAgICAgQVNTRVJUKG1faW5zcGVjdG9yVmll dyk7CisgICAgfQogCi0gICAgOjpEZXN0cm95V2luZG93KG1faW5zcGVjdG9yV2luZG93KTsKKyAg ICBpZiAobV9pbnNwZWN0b3JXaW5kb3cpIHsKKyAgICAgICAgQVNTRVJUKDo6SXNXaW5kb3cobV9p bnNwZWN0b3JXaW5kb3cpKTsKKyAgICAgICAgOjpEZXN0cm95V2luZG93KG1faW5zcGVjdG9yV2lu ZG93KTsKKyAgICB9CiAKICAgICBtX2luc3BlY3RvcldpbmRvdyA9IDA7CiAgICAgbV9pbnNwZWN0 b3JWaWV3ID0gMDsK