53797 2011-02-04 12:20:14 -0800 [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name 2011-02-04 18:14:00 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned gustavo mihaip oldest_to_newest 345679 0 mrobinson 2011-02-04 12:20:14 -0800 If you call webkit_web_frame_get_name more than once with the same WebKitWebFrame*, it can return a stale frame name if the name changes between the calls. This can be observed by the failure of fast/history/history-subframe-with-name.html. 345683 1 mrobinson 2011-02-04 12:23:11 -0800 Sorry, the failing test should be: fast/events/pageshow-pagehide-on-back-uncached.html. The previously mentioned test is failing for some other reason and that failure is tracked in 44784. 345690 2 81265 mrobinson 2011-02-04 12:28:05 -0800 Created attachment 81265 Patch for this issue 345692 3 mrobinson 2011-02-04 12:28:51 -0800 I have attached a patch fixing this issue. 345935 4 81265 mrobinson 2011-02-04 17:14:37 -0800 Comment on attachment 81265 Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=81265&action=review > LayoutTests/platform/gtk/Skipped:4728 > -fast/events/pagehide-timeout.html > \ No newline at end of file > +fast/events/pagehide-timeout.html This change is an accent from my editing, I think. I'll omit it when landing. 345941 5 81265 xan.lopez 2011-02-04 17:27:16 -0800 Comment on attachment 81265 Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=81265&action=review > Source/WebKit/gtk/webkit/webkitwebframe.cpp:487 > I guess we should return "" here to not break the API subtly. It does not make much sense, though... 345975 6 mrobinson 2011-02-04 18:13:17 -0800 Committed r77714: <http://trac.webkit.org/changeset/77714> 345976 7 81265 mrobinson 2011-02-04 18:14:00 -0800 Comment on attachment 81265 Patch for this issue Landed with Xan's suggestions. 81265 2011-02-04 12:28:05 -0800 2011-02-04 18:14:00 -0800 Patch for this issue bug-53797-20110204122804.patch text/plain 4077 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NmM0ZGMyYzQ0MjY5MmI1YzFjNjYwMTFmNjQ0MWZkNjg2MWQxZmI0Li5iODFjZGVm M2RiOGFlZTBjOTEwY2U5N2U3MDIzNmRhZTZiNGJlYTNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDItMDQgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdlYktp dFdlYkZyYW1lIGNhbiByZXR1cm4gYSBzdGFsZSBmcmFtZSBuYW1lIHdoZW4gY2FsbGluZyB3ZWJr aXRfd2ViX2ZyYW1lX2dldF9uYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01Mzc5NworCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFVu c2tpcCBhIHRlc3Qgd2hpY2ggaXMgbm93IHBhc3NpbmcuCisKIDIwMTEtMDItMDQgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luZG93cyA3IFJlbGVhc2Ug VGVzdHNdIHRyYW5zaXRpb25zL3RyYW5zaXRpb24tZW5kLWV2ZW50LW11bHRpcGxlLTA0Lmh0bWwg Zmxha2V5IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCA3ZjZhZTExYmQzMGI5Y2Y4MmE5 MTRmMTAyZTEwZTMzZjRkNmExYmUzLi43ZjljOWI4MGJiMDRmN2M2OWFjNjJhMDg2MDcwYzg3MWU4 ZmRiODY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtMzc2Myw3ICszNzYzLDYgQEAg ZmFzdC9jc3Mvb3BhY2l0eS1mbG9hdC5odG1sCiAKICMgTmV3IGV2ZW50cyBmYWlsaW5nOyBzZWUg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4ODIzCiBmYXN0L2V2ZW50 cy9wYWdlc2hvdy1wYWdlaGlkZS1vbi1iYWNrLWNhY2hlZC5odG1sCi1mYXN0L2V2ZW50cy9wYWdl c2hvdy1wYWdlaGlkZS1vbi1iYWNrLXVuY2FjaGVkLmh0bWwKIGZhc3QvZXZlbnRzL3BhZ2VzaG93 LXBhZ2VoaWRlLmh0bWwKIAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzA3MjQKQEAgLTQ3MjUsNCArNDcyNCw0IEBAIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2Nyb3NzLW9yaWdpbi5odG1sCiAKICMgUHJvYmFibHkgY2F1c2VkIGJ5IGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzczMwogIyBUZXN0IHdhcyBhZGRlZCBpbiBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC83NzU1OQotZmFzdC9ldmVudHMvcGFnZWhpZGUt dGltZW91dC5odG1sClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorZmFzdC9ldmVudHMvcGFn ZWhpZGUtdGltZW91dC5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggYTU5MWJlNDg0MjUwMTg4YTky YWQ2Y2VkMzg1NzNiZTY3MzE3OGRjZS4uZDdkYjU5ODJlOGE2YjM5YTAxYTFhMjNiYTNjMTcwMjYx ZjBmNGI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTAyLTA0ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBXZWJLaXRXZWJGcmFtZSBjYW4g cmV0dXJuIGEgc3RhbGUgZnJhbWUgbmFtZSB3aGVuIGNhbGxpbmcgd2Via2l0X3dlYl9mcmFtZV9n ZXRfbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTM3OTcKKworICAgICAgICBXaGVuIHRoZSBmcmFtZSBuYW1lIGNoYW5nZXMgYmV0d2VlbiBkaWZm ZXJlbnQgY2FsbHMgdG8gd2Via2l0X3dlYl9mcmFtZV9nZXRfbmFtZQorICAgICAgICBvbiB0aGUg c2FtZSBmcmFtZSwgcmV0dXJuIHRoZSBuZXcgZnJhbWUgbmFtZSBpbnN0ZWFkIG9mIHRoZSBvbmUg dmFsaWQgZHVyaW5nIHRoZQorICAgICAgICBwcmV2aW91cyBjYWxsLgorCisgICAgICAgICogd2Vi a2l0L3dlYmtpdHdlYmZyYW1lLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfZnJhbWVfaW5pdCk6 IEluaXRpYWxpemUgdGhlIGZyYW1lIG5hbWUgdG8gMC4KKyAgICAgICAgKHdlYmtpdF93ZWJfZnJh bWVfZ2V0X25hbWUpOiBDaGVjayB0aGUgY3VycmVudCBmcmFtZSBuYW1lIGZpcnN0IGJlZm9yZQor ICAgICAgICByZXR1cm5pbmcgdGhlIGNhY2hlZCB2YWx1ZS4KKwogMjAxMS0wMi0wMyAgWXVyeSBT ZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYmZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5j cHAKaW5kZXggNWFiMjY1NDEyZjQzMmQ4NWI5NzZmZGZkNjRkODFhZDRiMzljZWE0NC4uY2M2YjQx ZGJkNjUzYjhlZGFkODYyZjhjMmViZmRhOTkxNjlkNTg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCkBAIC0zODUsNiArMzg1LDcgQEAgc3RhdGljIHZv aWQgd2Via2l0X3dlYl9mcmFtZV9pbml0KFdlYktpdFdlYkZyYW1lKiBmcmFtZSkKIAogICAgIC8v IFRPRE86IE1vdmUgY29uc3RydWN0b3IgY29kZSBoZXJlLgogICAgIGZyYW1lLT5wcml2ID0gcHJp djsKKyAgICBmcmFtZS0+cHJpdi0+bmFtZSA9IDA7CiB9CiAKIApAQCAtNDc0LDIzICs0NzUsMjMg QEAgV2ViS2l0V2ViVmlldyogd2Via2l0X3dlYl9mcmFtZV9nZXRfd2ViX3ZpZXcoV2ViS2l0V2Vi RnJhbWUqIGZyYW1lKQogICoKICAqIFJldHVybnMgdGhlIEBmcmFtZSdzIG5hbWUKICAqCi0gKiBS ZXR1cm4gdmFsdWU6IHRoZSBuYW1lIG9mIEBmcmFtZQorICogUmV0dXJuIHZhbHVlOiB0aGUgbmFt ZSBvZiBAZnJhbWUgb3IgTlVMTCBpZiB0aGlzICNXZWJLaXRXZWJGcmFtZQorICogaXMgaW52YWxp ZCBvciBpcyBub3QgYmFja2VkIGJ5IGEgbGl2ZSBXZWJDb3JlIGZyYW1lLgogICovCiBHX0NPTlNU X1JFVFVSTiBnY2hhciogd2Via2l0X3dlYl9mcmFtZV9nZXRfbmFtZShXZWJLaXRXZWJGcmFtZSog ZnJhbWUpCiB7CiAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9GUkFNRShm cmFtZSksIDApOworICAgIEZyYW1lKiBjb3JlRnJhbWUgPSBjb3JlKGZyYW1lKTsKKyAgICBpZiAo IWNvcmVGcmFtZSkKKyAgICAgICAgcmV0dXJuIDA7CiAKICAgICBXZWJLaXRXZWJGcmFtZVByaXZh dGUqIHByaXYgPSBmcmFtZS0+cHJpdjsKLQotICAgIGlmIChwcml2LT5uYW1lKQorICAgIENTdHJp bmcgZnJhbWVOYW1lID0gY29yZUZyYW1lLT50cmVlKCktPnVuaXF1ZU5hbWUoKS5zdHJpbmcoKS51 dGY4KCk7CisgICAgaWYgKCFnX3N0cmNtcDAoZnJhbWVOYW1lLmRhdGEoKSwgcHJpdi0+bmFtZSkp CiAgICAgICAgIHJldHVybiBwcml2LT5uYW1lOwogCi0gICAgRnJhbWUqIGNvcmVGcmFtZSA9IGNv cmUoZnJhbWUpOwotICAgIGlmICghY29yZUZyYW1lKQotICAgICAgICByZXR1cm4gIiI7Ci0KLSAg ICBTdHJpbmcgc3RyaW5nID0gY29yZUZyYW1lLT50cmVlKCktPnVuaXF1ZU5hbWUoKTsKLSAgICBw cml2LT5uYW1lID0gZ19zdHJkdXAoc3RyaW5nLnV0ZjgoKS5kYXRhKCkpOworICAgIGdfZnJlZShw cml2LT5uYW1lKTsKKyAgICBwcml2LT5uYW1lID0gZ19zdHJkdXAoZnJhbWVOYW1lLmRhdGEoKSk7 CiAgICAgcmV0dXJuIHByaXYtPm5hbWU7CiB9CiAK