53787 2011-02-04 10:20:00 -0800 REGRESSION: Caret is rendered at wrong location when editable region ends with a non-editable region 2014-05-09 00:54:03 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All NEW P2 Normal --- 1 rniwa webkit-unassigned enrica garryb jparent kalman leviw pkoszulinski oldest_to_newest 345586 0 rniwa 2011-02-04 10:20:00 -0800 In the following markup, <div contenteditable>text text<span contenteditable="false">foo</span></div> Clicking a position right after foo results in the caret rendered at the right upper corner instead of at the end of foo. 345588 1 rniwa 2011-02-04 10:20:12 -0800 http://crbug.com/71598 345659 2 leviw 2011-02-04 11:54:03 -0800 This unfortunate bug is non-trivial to solve. Editing creates canonical positions that are eventually sent to Render____::localCaretRect to have the rect determined. In certain cases like this, the canonical position editing would *normally* create, ["foo", 3], doesn't work (in this case because it's in non-editable content). There are 2 problems with this: 1) RenderBlock uses RenderBox to determine the caret rect, but for RenderBox, any offset > 0 equates to drawing the caret after the content, even if it's an offset between children. 2) A RenderBlock and offset isn't enough information to determine the correct position for the caret. [DIV, 2] in this case could be interpreted to the position after "foo" or the position after the DIV! I think localCaretRect needs to take a type (offset into children, or position before/after renderer e.g. Position::AnchorType). 349196 3 82009 garryb 2011-02-10 11:03:09 -0800 Created attachment 82009 This demonstrates the issue and a couple other cursoring bugs in this use case, but only one of them is a regression (the one tracked on this bug). 349197 4 garryb 2011-02-10 11:04:08 -0800 Also wanted to emphasize that this issue didn't exist earlier, it was a regression from Chrome 8 to Chrome 9. Maybe there were some hacks in earlier versions that fixed this. 351738 5 leviw 2011-02-15 16:56:39 -0800 The bug where a line break is inserted when backspacing the whitespace following a button is similarly related to legacy positions. DeleteSelectionCommand uses mergeParagraph to handle selections that span paragraph boundaries, and because it upstreams the resulting position after the deletion into [button, 1], the code falsely believes the position to be inside the inline-block element and inserts a placeholder. The "right" fix for this would be to make Position::upstream() return a position at [button, PositionIsAfterAnchor] and have DeleteSelectionCommand then correctly handle positions after Inline-Block flow elements (where positions before/after treat them like inline nodes and positions inside them like blocks). 1007922 6 pkoszulinski 2014-05-09 00:54:03 -0700 The issue was also reported on CKEditor's bug tracker: http://dev.ckeditor.com/ticket/11923 82009 2011-02-10 11:03:09 -0800 2011-02-10 11:03:09 -0800 This demonstrates the issue and a couple other cursoring bugs in this use case, but only one of them is a regression (the one tracked on this bug). webkitbug.html text/html 2553 garryb PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICA8dGl0bGU+RWRpdGFibGUgVGVzdDwvdGl0 bGU+CiAgPHN0eWxlPgogICAgYm9keSB7CiAgICAgIGZvbnQ6IDEzcHggQXJpYWwsIHNhbnMtc2Vy aWY7CiAgICB9CiAgICAuZWRpdGJveCB7CiAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwog ICAgICBwYWRkaW5nOiAxMHB4OwogICAgICB3aWR0aDogNDAwcHg7CiAgICB9CiAgICAucGlsbDIg ewogICAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CgogICAgICBiYWNrZ3JvdW5kOiAjMDA5Owog ICAgICBib3JkZXI6IG5vbmU7CiAgICAgIGJvcmRlci1yYWRpdXM6IDNweDsKICAgICAgLW1vei1i b3JkZXItcmFkaXVzOiAzcHg7CiAgICAgIC13ZWJraXQtYm9yZGVyLXJhZGl1czogM3B4OwogICAg ICBjb2xvcjogI2ZmZjsKICAgICAgZm9udDogbm9ybWFsIDEzcHggQXJpYWwsIHNhbnMtc2VyaWY7 CiAgICAgIG1hcmdpbjogMCAycHg7CiAgICAgIHBhZGRpbmc6IDFweCAycHg7CiAgICB9CiAgPC9z dHlsZT4KPC9oZWFkPgo8Ym9keT4KICA8cD5CYWNrZ3JvdW5kOiBJIGp1c3Qgd2FudCBhbiBlbGVt ZW50IHRoYXQgY2FuIGNvbnRhaW4gdGV4dCBhbmQgYmVoYXZlcyBhdG9taWNhbGx5IChsaWtlIGFu IGltYWdlKS48L3A+CiAgPGgzPkNocm9tZSA5IHJlZ3Jlc3Npb248L2gyPgogIDxkaXYgY2xhc3M9 ImVkaXRib3giPgogICAgPGRpdiBjb250ZW50RWRpdGFibGU9InRydWUiPgogICAgICBDbGljayBy aWdodCBhZnRlciB0aGUgYnV0dG9uLiAgVGhlIGN1cnNvciBpcyBmaW5lIGluIENocm9tZSA4IGJ1 dCBpcyBkaXNwbGF5ZWQgYXQgdGhlIHVwcGVyIHJpZ2h0IGNvcm5lciBvZiB0aGUgY29udGVudEVk aXRhYmxlIGluIENocm9tZSA5LiA8YnV0dG9uIGNsYXNzPSJwaWxsMiIgdGFiSW5kZXg9Ii0xIiBj b250ZW50RWRpdGFibGU9ImZhbHNlIj5idXR0b24gbm9uLWVkaXRhYmxlPC9idXR0b24+PC9kaXY+ CiAgPC9kaXY+CiAgPGgzPkRvZXNuJ3QgaGFwcGVuIHdoZW4gdGhlIGVsZW1lbnQgaXMgZWRpdGFi bGU8L2gzPgogIDxkaXYgY2xhc3M9ImVkaXRib3giPgogICAgPGRpdiBjb250ZW50RWRpdGFibGU9 InRydWUiPgogICAgICBUaGlzIGJ1dHRvbiBkb2VzIG5vdCBoYXZlIGNvbnRlbnRFZGl0YWJsZT1m YWxzZSwgYW5kIGRvZXMgbm90IGhhdmUgdGhlIGlzc3VlLiA8YnV0dG9uIGNsYXNzPSJwaWxsMiIg dGFiSW5kZXg9Ii0xIj5idXR0b24gZWRpdGFibGU8L2J1dHRvbj4KICAgIDwvZGl2PgogIDwvZGl2 PgogIDxoMz5JdCdzIG5vdCBqdXN0ICZsdDtidXR0b24mZ3Q7czwvaDM+CiAgPGRpdiBjbGFzcz0i ZWRpdGJveCI+CiAgICA8ZGl2IGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSI+CiAgICAgIFRoaXMgaXMg YSBzcGFuLiA8c3BhbiBjbGFzcz0icGlsbDIiIHRhYkluZGV4PSItMSIgY29udGVudEVkaXRhYmxl PSJmYWxzZSI+c3BhbiBub24tZWRpdGFibGU8L3NwYW4+CiAgICA8L2Rpdj4KICA8L2Rpdj4KCiAg PGhyIHN0eWxlPSJtYXJnaW4tdG9wOiA1ZW0iPgogIDxoMj5TZXBhcmF0ZSBidWcgdGhhdCBtaWdo dCBiZSByZWxhdGVkIC0gcmVwcm9lcyBvbiBDaHJvbWUgOCAoYW5kIHByb2JhYmx5IGVhcmxpZXIp IDwvaDI+CiAgPGRpdiBjbGFzcz0iZWRpdGJveCI+CiAgICA8ZGl2IGNvbnRlbnRFZGl0YWJsZT0i dHJ1ZSI+CiAgICAgIERlbGV0ZSB0aGUgc3BhY2UgYWZ0ZXIgdGhpcyBidXR0b246IDxidXR0b24g Y2xhc3M9InBpbGwyIiB0YWJJbmRleD0iLTEiPmJ1dHRvbiBlZGl0YWJsZTwvYnV0dG9uPiAmbHQ7 LS0gZGVsZXRlIHRoZSBzcGFjZSwgYW5kIGEgbmV3bGluZSBpcyBhZGRlZC4KICAgIDwvZGl2Pgog IDwvZGl2PgogIDxoMz5TZXR0aW5nIGNvbnRlbnRFZGl0YWJsZT1mYWxzZSBhdm9pZHMgdGhhdCBp c3N1ZTwvaDM+CiAgPGRpdiBjbGFzcz0iZWRpdGJveCI+CiAgICA8ZGl2IGNvbnRlbnRFZGl0YWJs ZT0idHJ1ZSI+CiAgICAgIE5vdyBpdCB3b3Jrcy4gPGJ1dHRvbiBjbGFzcz0icGlsbDIiIHRhYklu ZGV4PSItMSIgY29udGVudEVkaXRhYmxlPSJmYWxzZSI+YnV0dG9uIG5vbi1lZGl0YWJsZTwvYnV0 dG9uPiAmbHQ7LS0gZGVsZXRlIHRoZSBzcGFjZSwgYW5kIE5PIG5ld2xpbmUgaXMgYWRkZWQuCiAg ICA8L2Rpdj4KICA8L2Rpdj4KCiAgPGhyIHN0eWxlPSJtYXJnaW4tdG9wOiA1ZW0iPgogIDxoMj5D YW5ub3QgY3Vyc29yIHRvIG5vbi1lZGl0YWJsZSBlbGVtZW50IGF0IHRoZSBiZWdpbm5pbmcgb2Yg YSBsaW5lPC9oMj4KICA8ZGl2IGNsYXNzPSJlZGl0Ym94Ij4KICAgIDxkaXYgY29udGVudEVkaXRh YmxlPSJ0cnVlIj4KICAgICAgVHJ5IGN1cnNvcmluZyB0byB0aGUgYmVnaW5uaW5nIG9mIHRoZSBm b2xsb3dpbmcgYnV0dG9uCiAgICAgIDxicj48YnV0dG9uIGNsYXNzPSJwaWxsMiIgdGFiSW5kZXg9 Ii0xIiBjb250ZW50RWRpdGFibGU9ImZhbHNlIj5idXR0b24gbm9uLWVkaXRhYmxlPC9idXR0b24+ ICZsdDstLSBjdXJzb3IgdG8gdGhlIGxlZnQgYW5kIHlvdSBjYW4ndCBjdXJzb3IgYmVmb3JlIHRo ZSBidXR0b24uCiAgICA8L2Rpdj4KICA8L2Rpdj4KPC9ib2R5Pgo8aHRtbD4K