53786 2011-02-04 10:17:54 -0800 check-webkit-style: The error message about NULL should be more clear for comments. 2011-02-09 11:54:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin commit-queue eric hamaji oldest_to_newest 345582 0 levin 2011-02-04 10:17:54 -0800 There have been at least three bugs filed about this and probably other times people thought it was in error and didn't file a bug. https://bugs.webkit.org/show_bug.cgi?id=31215 https://bugs.webkit.org/show_bug.cgi?id=34605 https://bugs.webkit.org/show_bug.cgi?id=53755 This is my attempt to help clarify the issue. 345590 1 81243 levin 2011-02-04 10:22:13 -0800 Created attachment 81243 Patch 345739 2 81243 eric 2011-02-04 13:25:01 -0800 Comment on attachment 81243 Patch What's "null"? 345740 3 eric 2011-02-04 13:25:23 -0800 I support the "comments" thing, I'm not sure I understand the "null" bit. 345747 4 levin 2011-02-04 13:33:46 -0800 (In reply to comment #3) > I support the "comments" thing, I'm not sure I understand the "null" bit. I don't know if I get it either, but I going with what I've seen other say. For example, https://bugs.webkit.org/show_bug.cgi?id=34605#c2 And it appears in https://bugs.webkit.org/show_bug.cgi?id=53749 the patch author took the "null" route. 345750 5 eric 2011-02-04 13:39:16 -0800 I see. Using "null" in comments. But "null" isn't a language primitive, or is it? I can never remember. 345756 6 levin 2011-02-04 13:43:28 -0800 (In reply to comment #5) > I see. Using "null" in comments. But "null" isn't a language primitive, or is it? I can never remember. No. This particular line should only be printed for comments actually. The style checker has special logic to catch NULL in comments and people think it is a bug so I changed the text on this instance of the message to make it more clear. 345773 7 81243 eric 2011-02-04 13:59:10 -0800 Comment on attachment 81243 Patch Oh. OK. it wasn't clear to me that tis' a comment-only message. 348426 8 81243 commit-queue 2011-02-09 11:54:40 -0800 Comment on attachment 81243 Patch Clearing flags on attachment: 81243 Committed r78100: <http://trac.webkit.org/changeset/78100> 348427 9 commit-queue 2011-02-09 11:54:44 -0800 All reviewed patches have been landed. Closing bug. 81243 2011-02-04 10:22:13 -0800 2011-02-09 11:54:40 -0800 Patch bug-53786-20110204102212.patch text/plain 2608 levin ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMmRj YTM4ZjQ0OTU5YzA1MzRhNjJjMWQ1ODg4MzE4MDdiY2FhZTczLi5hYzdjYWVmOGQzM2FhNDc4MjRl YWU5YjcxZGZhZDY4MzI4NDMwNzBiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMDQgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZTogVGhlIGVycm9yIG1lc3NhZ2UgYWJv dXQgTlVMTCBzaG91bGQgYmUgbW9yZSBjbGVhciBmb3IgY29tbWVudHMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc4NgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IENsYXJpZmllZCB0aGUgZXJyb3Ig bWVzc2FnZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weTogRml4ZWQgdGhlIGNvcnJlc3BvbmRpbmcgdGVzdC4KKwogMjAxMS0wMi0wMyAg SmFtZXMgS296aWFuc2tpICA8a296QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5CmluZGV4IDI1MGI5ZWU2MDdlMzQxNzhiZTJlYTJiMDhmODg5OGNhOGQwZGVkMjUu LmViODRjZmJlZjg2NGM1MTNhMzEyYTRjYWNlMThkZTc1ZjRiZTdjOTEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yMzE1LDcgKzIzMTUsNyBA QCBkZWYgY2hlY2tfZm9yX251bGwoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRl LCBlcnJvcik6CiAgICAgIyBtYXRjaGVzLCB0aGVuIGRvIHRoZSBjaGVjayB3aXRoIHN0cmluZ3Mg Y29sbGFwc2VkIHRvIGF2b2lkIGdpdmluZyBlcnJvcnMgZm9yCiAgICAgIyBOVUxMcyBvY2N1cnJp bmcgaW4gc3RyaW5ncy4KICAgICBpZiBzZWFyY2gocidcYk5VTExcYicsIGxpbmUpIGFuZCBzZWFy Y2gocidcYk5VTExcYicsIENsZWFuc2VkTGluZXMuY29sbGFwc2Vfc3RyaW5ncyhsaW5lKSk6Ci0g ICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbnVsbCcsIDQsICdVc2UgMCBp bnN0ZWFkIG9mIE5VTEwuJykKKyAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0 eS9udWxsJywgNCwgJ1VzZSAwIG9yIG51bGwgaW5zdGVhZCBvZiBOVUxMIChldmVuIGluICpjb21t ZW50cyopLicpCiAKIGRlZiBnZXRfbGluZV93aWR0aChsaW5lKToKICAgICAiIiJEZXRlcm1pbmVz IHRoZSB3aWR0aCBvZiB0aGUgbGluZSBpbiBjb2x1bW4gcG9zaXRpb25zLgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRl eCA4NjhkM2Y2MDRmZjI4NDkzMTNlMDBiYmE1OGU4ZjM1MTAzZTliNjJiLi42ZDI4N2I4OTQ5YzFh NzRkMmViM2Q4MWM0OWZhMjQxYmE4YjJlYjhiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMzkwMSwxMiArMzkw MSwxMiBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAg ICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAi Ly8gRG9uJ3QgdXNlIE5VTEwgaW4gY29tbWVudHMgc2luY2UgaXQgaXNuJ3QgaW4gY29kZS4iLAot ICAgICAgICAgICAgJ1VzZSAwIGluc3RlYWQgb2YgTlVMTC4nCisgICAgICAgICAgICAnVXNlIDAg b3IgbnVsbCBpbnN0ZWFkIG9mIE5VTEwgKGV2ZW4gaW4gKmNvbW1lbnRzKikuJwogICAgICAgICAg ICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs0XScsCiAgICAgICAgICAgICAnZm9vLmNwcCcpCiAg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAnIkEgc3RyaW5nIHdpdGggTlVM TCIgLy8gYW5kIGEgY29tbWVudCB3aXRoIE5VTEwgaXMgdHJpY2t5IHRvIGZsYWcgY29ycmVjdGx5 IGluIGNwcF9zdHlsZS4nLAotICAgICAgICAgICAgJ1VzZSAwIGluc3RlYWQgb2YgTlVMTC4nCisg ICAgICAgICAgICAnVXNlIDAgb3IgbnVsbCBpbnN0ZWFkIG9mIE5VTEwgKGV2ZW4gaW4gKmNvbW1l bnRzKikuJwogICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs0XScsCiAgICAgICAg ICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCg==