53783 2011-02-04 10:00:44 -0800 Dynamic changes to the lang attribute not seen by e.g. div:lang() selector 2012-08-17 00:13:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 94092 76364 0 jag-webkit webkit-unassigned ap esprehn falken oldest_to_newest 345565 0 81239 jag-webkit 2011-02-04 10:00:44 -0800 Created attachment 81239 Simple test case, courtesy of Boris Zbarsky Dynamically setting the lang attribute doesn't trigger a style update for selectors that (now / no longer) match. 695047 1 ap 2012-08-14 09:34:42 -0700 I think that this has need fixed already. Bug 76364 tracks adding tests. 695871 2 falken 2012-08-15 02:51:14 -0700 Yes, this was fixed in the patch that added lang to -webkit-locale mapping, which also added a style recalc for when lang is set (http://trac.webkit.org/changeset/103608). In the current code, the style recalc occurs because lang is one of the attributes in HTMLElement::isPresentationAttribute. Some tests for dynamic changes have landed as part of bug 76364, but technically they only test the mapping to -webkit-locale, and not the CSS :lang selector. I think it'd be good to add a new test specifically for the :lang selector. I'll upload a patch. 697958 3 falken 2012-08-17 00:13:15 -0700 Closing bug as the test in bug 94092 landed. 81239 2011-02-04 10:00:44 -0800 2011-02-04 10:00:44 -0800 Simple test case, courtesy of Boris Zbarsky bug631352.html text/html 245 jag-webkit PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHN0eWxlPgogICAgICBkaXY6bm90 KDpsYW5nKGZvbykpIHsgZGlzcGxheTogbm9uZTsgfQogICAgPC9zdHlsZT4KICA8L2hlYWQ+CiAg PGJvZHkgb25sb2FkPSJkb2N1bWVudC5ib2R5Lm9mZnNldFdpZHRoOyBkb2N1bWVudC5ib2R5Lmxh bmcgPSAnZm9vJyI+CiAgICA8ZGl2PlRoaXMgdGV4dCBzaG91bGQgYmUgdmlzaWJsZTwvZGl2Pgog IDwvYm9keT4KPC9odG1sPgo=