53781 2011-02-04 09:48:15 -0800 Web Inspector: check-inspector-strings doesn't process Unicode literals in .js sources 2011-02-04 10:40:41 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 345550 0 mnaganov 2011-02-04 09:48:15 -0800 In localizedStrings.js all characters are represented as themselves, while in .js sources Unicode chars can be represented as \u escape sequences. check-inspector-strings doesn't convert \u sequences into corresponding characters, and thus doesn't match such strings correctly. 345554 1 81237 mnaganov 2011-02-04 09:50:27 -0800 Created attachment 81237 patch 345561 2 81237 joepeck 2011-02-04 09:54:47 -0800 Comment on attachment 81237 patch I think you can give "convert_string" a better name. The comment inside it is more descriptive, how about, "decode_unicode_escapes", "decode_unicode", etc? Just a thought. With this improvement are there any changes to the localizedStrings.js file? 345570 3 mnaganov 2011-02-04 10:07:49 -0800 (In reply to comment #2) > (From update of attachment 81237 [details]) > I think you can give "convert_string" a better name. The comment inside it is more descriptive, > how about, "decode_unicode_escapes", "decode_unicode", etc? Just a thought. > decode_unicode_escapes is a good one. It eliminates the need for the comment. > With this improvement are there any changes to the localizedStrings.js file? No. This code allows to match, e.g. ellipsis character from localizedStrings.js to its \u2026 counterpart from .js source. BTW, why localizedStrings.js uses UTF-16 -- this makes resolving conflicts painful. Can we convert it to UTF-8 or do you have any restrictions from your l10n process? 345571 4 81240 mnaganov 2011-02-04 10:09:16 -0800 Created attachment 81240 renamed function 345599 5 mnaganov 2011-02-04 10:28:59 -0800 Manually committed http://trac.webkit.org/changeset/77641 345606 6 joepeck 2011-02-04 10:40:41 -0800 (In reply to comment #3) > BTW, why localizedStrings.js uses UTF-16 -- this makes resolving > conflicts painful. Can we convert it to UTF-8 or do you have any > restrictions from your l10n process? Pavel has had the same question. Googling, I see a novel idea: http://fi.am/entry/keeping-your-localizablestrings-in-utf-8/ Let me ask internally now! I personally have no idea, other then comments on the web and vague comments in the documentation that say UTF-16 is preferred. 81237 2011-02-04 09:50:27 -0800 2011-02-04 10:09:16 -0800 patch patch-53781 text/plain 1612 mnaganov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmM1 YzQ2Li4xZGYzNjBhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMDQgIE1pa2hhaWwgTmFnYW5vdiAgPG1u YWdhbm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXggcHJvY2Vzc2luZyBVbmljb2RlIGxpdGVy YWxzIGZyb20gLmpzIHNvdXJjZXMgaW4gY2hlY2staW5zcGVjdG9yLXN0cmluZ3MuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc4MQorCisgICAgICAg ICogU2NyaXB0cy9jaGVjay1pbnNwZWN0b3Itc3RyaW5nczoKKwogMjAxMS0wMi0wNCAgQWRhbSBS b2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTGluayB0byBNYWMgY3Jhc2ggbG9n cyBmcm9tIHJlc3VsdHMuaHRtbApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9jaGVjay1pbnNw ZWN0b3Itc3RyaW5ncyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2staW5zcGVjdG9yLXN0cmluZ3MKaW5k ZXggYzk1YWZjYi4uODdhMmVlNyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9jaGVjay1pbnNw ZWN0b3Itc3RyaW5ncworKysgYi9Ub29scy9TY3JpcHRzL2NoZWNrLWluc3BlY3Rvci1zdHJpbmdz CkBAIC01NCw2ICs1NCwxMCBAQCBjbGFzcyBTdHJpbmdzRXh0cmFjdG9yKFByb2Nlc3NvckJhc2Up OgogICAgIGRlZiBzaG91bGRfcHJvY2VzcyhzZWxmLCBmaWxlX3BhdGgpOgogICAgICAgICByZXR1 cm4gZmlsZV9wYXRoLmVuZHN3aXRoKCIuanMiKSBhbmQgKG5vdCBmaWxlX3BhdGguZW5kc3dpdGgo IkluamVjdGVkU2NyaXB0LmpzIikpCiAKKyAgICBkZWYgY29udmVydF9zdHJpbmcoc2VsZiwgcyk6 CisgICAgICAgICMgQ29udmVydHMgZXNjYXBlZCBVbmljb2RlIGNoYXJhY3RlcnMgaW50byB0aGVp ciB2YWx1ZXMKKyAgICAgICAgcmV0dXJuIGV2YWwoInVyXCIiICsgcyArICJcIiIpCisKICAgICBk ZWYgcHJvY2VzcyhzZWxmLCBsaW5lcywgZmlsZV9wYXRoLCBsaW5lX251bWJlcnM9Tm9uZSk6CiAg ICAgICAgIGZvciBsaW5lIGluIGxpbmVzOgogICAgICAgICAgICAgY29tbWVudF9zdGFydCA9IGxp bmUuZmluZCgiLy8iKQpAQCAtNjMsNyArNjcsNyBAQCBjbGFzcyBTdHJpbmdzRXh0cmFjdG9yKFBy b2Nlc3NvckJhc2UpOgogICAgICAgICAgICAgZm9yIHBhdHRlcm4gaW4gc2VsZi5fcGF0dGVybnM6 CiAgICAgICAgICAgICAgICAgbGluZV9zdHJpbmdzID0gcmUuZmluZGFsbChwYXR0ZXJuLCBsaW5l KQogICAgICAgICAgICAgICAgIGZvciBzdHJpbmcgaW4gbGluZV9zdHJpbmdzOgotICAgICAgICAg ICAgICAgICAgICBzZWxmLnN0cmluZ3NbaW5kZXhdLmFwcGVuZChzdHJpbmcpCisgICAgICAgICAg ICAgICAgICAgIHNlbGYuc3RyaW5nc1tpbmRleF0uYXBwZW5kKHNlbGYuY29udmVydF9zdHJpbmco c3RyaW5nKSkKICAgICAgICAgICAgICAgICBpbmRleCArPSAxCiAKIGNsYXNzIExvY2FsaXplZFN0 cmluZ3NFeHRyYWN0b3I6Cg== 81240 2011-02-04 10:09:16 -0800 2011-02-04 10:23:50 -0800 renamed function patch-53781 text/plain 1562 mnaganov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmM1 YzQ2Li4xZGYzNjBhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMDQgIE1pa2hhaWwgTmFnYW5vdiAgPG1u YWdhbm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXggcHJvY2Vzc2luZyBVbmljb2RlIGxpdGVy YWxzIGZyb20gLmpzIHNvdXJjZXMgaW4gY2hlY2staW5zcGVjdG9yLXN0cmluZ3MuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc4MQorCisgICAgICAg ICogU2NyaXB0cy9jaGVjay1pbnNwZWN0b3Itc3RyaW5nczoKKwogMjAxMS0wMi0wNCAgQWRhbSBS b2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTGluayB0byBNYWMgY3Jhc2ggbG9n cyBmcm9tIHJlc3VsdHMuaHRtbApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9jaGVjay1pbnNw ZWN0b3Itc3RyaW5ncyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2staW5zcGVjdG9yLXN0cmluZ3MKaW5k ZXggYzk1YWZjYi4uMDM1MGFjYSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9jaGVjay1pbnNw ZWN0b3Itc3RyaW5ncworKysgYi9Ub29scy9TY3JpcHRzL2NoZWNrLWluc3BlY3Rvci1zdHJpbmdz CkBAIC01NCw2ICs1NCw5IEBAIGNsYXNzIFN0cmluZ3NFeHRyYWN0b3IoUHJvY2Vzc29yQmFzZSk6 CiAgICAgZGVmIHNob3VsZF9wcm9jZXNzKHNlbGYsIGZpbGVfcGF0aCk6CiAgICAgICAgIHJldHVy biBmaWxlX3BhdGguZW5kc3dpdGgoIi5qcyIpIGFuZCAobm90IGZpbGVfcGF0aC5lbmRzd2l0aCgi SW5qZWN0ZWRTY3JpcHQuanMiKSkKIAorICAgIGRlZiBkZWNvZGVfdW5pY29kZV9lc2NhcGVzKHNl bGYsIHMpOgorICAgICAgICByZXR1cm4gZXZhbCgidXJcIiIgKyBzICsgIlwiIikKKwogICAgIGRl ZiBwcm9jZXNzKHNlbGYsIGxpbmVzLCBmaWxlX3BhdGgsIGxpbmVfbnVtYmVycz1Ob25lKToKICAg ICAgICAgZm9yIGxpbmUgaW4gbGluZXM6CiAgICAgICAgICAgICBjb21tZW50X3N0YXJ0ID0gbGlu ZS5maW5kKCIvLyIpCkBAIC02Myw3ICs2Niw3IEBAIGNsYXNzIFN0cmluZ3NFeHRyYWN0b3IoUHJv Y2Vzc29yQmFzZSk6CiAgICAgICAgICAgICBmb3IgcGF0dGVybiBpbiBzZWxmLl9wYXR0ZXJuczoK ICAgICAgICAgICAgICAgICBsaW5lX3N0cmluZ3MgPSByZS5maW5kYWxsKHBhdHRlcm4sIGxpbmUp CiAgICAgICAgICAgICAgICAgZm9yIHN0cmluZyBpbiBsaW5lX3N0cmluZ3M6Ci0gICAgICAgICAg ICAgICAgICAgIHNlbGYuc3RyaW5nc1tpbmRleF0uYXBwZW5kKHN0cmluZykKKyAgICAgICAgICAg ICAgICAgICAgc2VsZi5zdHJpbmdzW2luZGV4XS5hcHBlbmQoc2VsZi5kZWNvZGVfdW5pY29kZV9l c2NhcGVzKHN0cmluZykpCiAgICAgICAgICAgICAgICAgaW5kZXggKz0gMQogCiBjbGFzcyBMb2Nh bGl6ZWRTdHJpbmdzRXh0cmFjdG9yOgo=