53766 2011-02-04 07:06:20 -0800 [Qt] Compilation error on OpenBSD 2011-02-10 21:09:55 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Other RESOLVED FIXED Qt, QtTriaged P5 Normal --- 1 ogoffart webkit-unassigned abarth benjamin commit-queue eric kling paroga webkit.review.bot oldest_to_newest 345471 0 ogoffart 2011-02-04 07:06:20 -0800 src/3rdparty/webkit/WebCore/websockets/WebSocketHandshake.cpp:289: error: 'strnstr' was not declared in this scope That function is apparently not protbale. According to the man page: "Since the strnstr() function is a FreeBSD specific API, it should only be used when portability is not a concern." 347801 1 paroga 2011-02-08 16:35:46 -0800 Please add a OS(OPENBSD) (or whatever) at http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/StringExtras.h?rev=74855#L103 348132 2 benjamin 2011-02-09 03:42:58 -0800 (In reply to comment #1) > Please add a OS(OPENBSD) (or whatever) at http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/StringExtras.h?rev=74855#L103 I would be happy to but I can't make a patch I do not test. Patrick, could you make the patch for OpenBSD and test the build? Here is some info about making patches: https://trac.webkit.org/wiki/QtWebKitContrib Ping me on IRC if you have any question. 348134 3 paroga 2011-02-09 03:52:43 -0800 (In reply to comment #2) > I would be happy to but I can't make a patch I do not test. I have the same "problem" of no OpenBSD installation. > Patrick, could you make the patch for OpenBSD and test the build? I'm be willing to create a patch, but Oliver needs to test it first. Mabye my last comment should be read as: "Oliver, can you try to add OS(OPENBSD) to StringExtras.h and tell us if that fixes the problem" Sorry for the unclear comment. 348874 4 ogoffart 2011-02-10 01:10:52 -0800 I confirm that adding || OS(OPENBSD) in StringExtras.h works. Then webkit compile and i am able to run the Qt demo browser. 349251 5 82021 paroga 2011-02-10 11:59:31 -0800 Created attachment 82021 Patch 349296 6 82021 benjamin 2011-02-10 12:55:27 -0800 Comment on attachment 82021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82021&action=review > Source/JavaScriptCore/wtf/Platform.h:729 > +#if !defined(HAVE_STRNSTR) > +#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(WINDOWS) && !OS(LINUX) && !OS(SOLARIS) && !OS(OPENBSD) Shouldn't that be the other way around: #if OS(MAC) || OS(FREEBSD) ? 349317 7 82034 paroga 2011-02-10 13:21:19 -0800 Created attachment 82034 Alternative Patch (with positiv listing) View in context: https://bugs.webkit.org/attachment.cgi?id=82021&action=review >> Source/JavaScriptCore/wtf/Platform.h:729 >> +#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(WINDOWS) && !OS(LINUX) && !OS(SOLARIS) && !OS(OPENBSD) > > Shouldn't that be the other way around: > #if OS(MAC) || OS(FREEBSD) > ? Maybe yes, maybe no. ;-) I don't know if it's defined at AIX, HAIKU, NETBSD, QNX, but changing this to positiv listing is clearly better. It seams that at least HAIKU needs this change too, so it's ok to take the risk of breaking the build on some "uncommon" platforms IMHO. 349321 8 82034 kling 2011-02-10 13:27:21 -0800 Comment on attachment 82034 Alternative Patch (with positiv listing) r=me 349325 9 kling 2011-02-10 13:31:29 -0800 (In reply to comment #7) > It seams that at least HAIKU needs this change too, so it's ok to take the risk of breaking the build on some "uncommon" platforms IMHO. Judging by the qt-haiku port (I had it handy..), Haiku doesn't have strnstr(). http://gitorious.org/webkit/qt-haiku-webkit/commit/b964b5fb44144d48a8bce266db856d3317d12a0f?diffmode=sidebyside 349434 10 82034 commit-queue 2011-02-10 15:26:51 -0800 Comment on attachment 82034 Alternative Patch (with positiv listing) Clearing flags on attachment: 82034 Committed r78278: <http://trac.webkit.org/changeset/78278> 349435 11 commit-queue 2011-02-10 15:26:56 -0800 All reviewed patches have been landed. Closing bug. 349616 12 webkit.review.bot 2011-02-10 21:09:55 -0800 http://trac.webkit.org/changeset/78278 might have broken GTK Linux 32-bit Release The following tests are not passing: http/tests/misc/acid2-pixel.html http/tests/misc/acid2.html 82021 2011-02-10 11:59:31 -0800 2011-02-10 13:25:46 -0800 Patch bug-53766.patch text/plain 1728 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdmYjQwNDUuLmMyMWQzNzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAyLTEwICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBlcnJvciBvbiBPcGVuQlNECisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc2NgorCisgICAg ICAgIEFkZCBhIEhBVkVfU1RSTlNUUiBpbiBQbGF0Zm9ybS5oLCBkb24ndCBkZWZpbmUgaXQgb24g T3BlbkJTRC4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorICAgICAgICAqIHd0Zi9TdHJp bmdFeHRyYXMuaDogVXNlIEhBVkUoU1RSTlNUUikgbm93LgorCiAyMDExLTAxLTI1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5kZXggMzRiNmNkZS4uZTk3OGVlMiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtNzI1LDYgKzcyNSwxMiBAQAogI2RlZmlu ZSBIQVZFX1NJR05BTF9IIDEKICNlbmRpZgogCisjaWYgIWRlZmluZWQoSEFWRV9TVFJOU1RSKQor I2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09NUElMRVIoUlZDVCkgJiYgIU9TKFdJTkRPV1MpICYm ICFPUyhMSU5VWCkgJiYgIU9TKFNPTEFSSVMpICYmICFPUyhPUEVOQlNEKQorI2RlZmluZSBIQVZF X1NUUk5TVFIgMQorI2VuZGlmCisjZW5kaWYKKwogI2lmICFPUyhXSU5ET1dTKSAmJiAhT1MoU09M QVJJUykgJiYgIU9TKFFOWCkgXAogICAgICYmICFPUyhTWU1CSUFOKSAmJiAhT1MoSEFJS1UpICYm ICFPUyhSVkNUKSBcCiAgICAgJiYgIU9TKEFORFJPSUQpICYmICFQTEFURk9STShCUkVXTVApCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJhcy5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdFeHRyYXMuaAppbmRleCA0NzNiYjIyLi4zNzFl MzNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJhcy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmgKQEAgLTEwMCw4 ICsxMDAsNyBAQCBpbmxpbmUgaW50IHN0cmNhc2VjbXAoY29uc3QgY2hhciogczEsIGNvbnN0IGNo YXIqIHMyKQogCiAjZW5kaWYKIAotI2lmIENPTVBJTEVSKE1TVkMpIHx8IENPTVBJTEVSKFJWQ1Qp IHx8IE9TKFdJTkRPV1MpIHx8IE9TKExJTlVYKSB8fCBPUyhTT0xBUklTKQotLy8gRklYTUU6IHNo b3VsZCBjaGVjayBIQVZFX1NUUk5TVFIKKyNpZiAhSEFWRShTVFJOU1RSKQogCiBpbmxpbmUgY2hh ciogc3RybnN0cihjb25zdCBjaGFyKiBidWZmZXIsIGNvbnN0IGNoYXIqIHRhcmdldCwgc2l6ZV90 IGJ1ZmZlckxlbmd0aCkKIHsK 82034 2011-02-10 13:21:19 -0800 2011-02-10 15:26:51 -0800 Alternative Patch (with positiv listing) bug-53766.patch text/plain 1670 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdmYjQwNDUuLmMyMWQzNzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAyLTEwICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBlcnJvciBvbiBPcGVuQlNECisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc2NgorCisgICAg ICAgIEFkZCBhIEhBVkVfU1RSTlNUUiBpbiBQbGF0Zm9ybS5oIGFuZCBkZWZpbmUgaXQgb25seSBv biBEYXJ3aW4gYW5kIEZyZWVCU0QuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKyAgICAg ICAgKiB3dGYvU3RyaW5nRXh0cmFzLmg6IFVzZSBIQVZFKFNUUk5TVFIpIG5vdy4KKwogMjAxMS0w MS0yNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTm90IHJl dmlld2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDM0YjZjZGUuLmU5 NzhlZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTcyNSw2ICs3MjUs MTIgQEAKICNkZWZpbmUgSEFWRV9TSUdOQUxfSCAxCiAjZW5kaWYKIAorI2lmICFkZWZpbmVkKEhB VkVfU1RSTlNUUikKKyNpZiBPUyhEQVJXSU4pIHx8IE9TKEZSRUVCU0QpCisjZGVmaW5lIEhBVkVf U1RSTlNUUiAxCisjZW5kaWYKKyNlbmRpZgorCiAjaWYgIU9TKFdJTkRPV1MpICYmICFPUyhTT0xB UklTKSAmJiAhT1MoUU5YKSBcCiAgICAgJiYgIU9TKFNZTUJJQU4pICYmICFPUyhIQUlLVSkgJiYg IU9TKFJWQ1QpIFwKICAgICAmJiAhT1MoQU5EUk9JRCkgJiYgIVBMQVRGT1JNKEJSRVdNUCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJhcy5oCmluZGV4IDQ3M2JiMjIuLjM3MWUz M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdFeHRyYXMuaApAQCAtMTAwLDgg KzEwMCw3IEBAIGlubGluZSBpbnQgc3RyY2FzZWNtcChjb25zdCBjaGFyKiBzMSwgY29uc3QgY2hh ciogczIpCiAKICNlbmRpZgogCi0jaWYgQ09NUElMRVIoTVNWQykgfHwgQ09NUElMRVIoUlZDVCkg fHwgT1MoV0lORE9XUykgfHwgT1MoTElOVVgpIHx8IE9TKFNPTEFSSVMpCi0vLyBGSVhNRTogc2hv dWxkIGNoZWNrIEhBVkVfU1RSTlNUUgorI2lmICFIQVZFKFNUUk5TVFIpCiAKIGlubGluZSBjaGFy KiBzdHJuc3RyKGNvbnN0IGNoYXIqIGJ1ZmZlciwgY29uc3QgY2hhciogdGFyZ2V0LCBzaXplX3Qg YnVmZmVyTGVuZ3RoKQogewo=