53764 2011-02-04 06:07:23 -0800 Web Inspector: Network panel filtering is broken 2011-02-04 06:22:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 345451 0 pfeldman 2011-02-04 06:07:23 -0800 Patch to follow. 345452 1 pfeldman 2011-02-04 06:07:46 -0800 What steps will reproduce the problem? 1. Open DevTools window on a page and switch to Network panel 2. Reload page to refresh network view 3. Try limiting the view to Scripts/Images etc using the filter buttons What is the expected output? What do you see instead? Only the grid updates (lines with alternating background colors) - there's no text. 345454 2 81209 pfeldman 2011-02-04 06:14:56 -0800 Created attachment 81209 [PATCH] Proposed change. 345457 3 pfeldman 2011-02-04 06:22:29 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/NetworkPanel.js Committed r77623 81209 2011-02-04 06:14:56 -0800 2011-02-04 06:19:48 -0800 [PATCH] Proposed change. network_filter text/plain 4969 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNzVhNWRmLi41YzliYjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDItMDQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogTmV0d29yayBwYW5lbCBmaWx0ZXJpbmcgaXMgYnJva2VuLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM3NjQKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5l dHdvcmtQYW5lbC5wcm90b3R5cGUuX3NvcnRJdGVtcyk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu TmV0d29ya1BhbmVsLnByb3RvdHlwZS5fc29ydEJ5VGltZWxpbmUpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLk5ldHdvcmtQYW5lbC5wcm90b3R5cGUuX2ZpbHRlcik6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZS5fdXBkYXRlT2Zmc2NyZWVuUm93cyk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5cGUuaXNGaWx0ZXJl ZE91dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5 cGUuZ2V0IHNlbGVjdGFibGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtUb3RhbEdy aWROb2RlLnByb3RvdHlwZS5pc0ZpbHRlcmVkT3V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5O ZXR3b3JrVG90YWxHcmlkTm9kZS5wcm90b3R5cGUuZ2V0IHNlbGVjdGFibGUpOgorCiAyMDExLTAy LTAzICBBbnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvTmV0d29ya1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9OZXR3b3JrUGFuZWwuanMKaW5kZXggNDg1ODU2ZS4uYjRhZTkxMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKQEAgLTMx NCw2ICszMTQsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZSA9IHsKIAog ICAgICAgICB0aGlzLl9kYXRhR3JpZC5zb3J0Tm9kZXMoc29ydGluZ0Z1bmN0aW9uLCB0aGlzLl9k YXRhR3JpZC5zb3J0T3JkZXIgPT09ICJkZXNjZW5kaW5nIik7CiAgICAgICAgIHRoaXMuX3RpbWVs aW5lU29ydFNlbGVjdG9yLnNlbGVjdGVkSW5kZXggPSAwOworICAgICAgICB0aGlzLl91cGRhdGVP ZmZzY3JlZW5Sb3dzKCk7CiAgICAgfSwKIAogICAgIF9zb3J0QnlUaW1lbGluZTogZnVuY3Rpb24o KQpAQCAtMzMyLDYgKzMzMyw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrUGFuZWwucHJvdG90eXBl ID0gewogICAgICAgICBlbHNlCiAgICAgICAgICAgICB0aGlzLl90aW1lbGluZUdyaWQuc2hvd0V2 ZW50RGl2aWRlcnMoKTsKICAgICAgICAgdGhpcy5fZGF0YUdyaWQubWFya0NvbHVtbkFzU29ydGVk QnkoInRpbWVsaW5lIiwgImFzY2VuZGluZyIpOworICAgICAgICB0aGlzLl91cGRhdGVPZmZzY3Jl ZW5Sb3dzKCk7CiAgICAgfSwKIAogICAgIF9jcmVhdGVGaWx0ZXJTdGF0dXNCYXJJdGVtczogZnVu Y3Rpb24oKQpAQCAtNDkwLDYgKzQ5Miw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrUGFuZWwucHJv dG90eXBlID0gewogICAgICAgICAgICAgdGFyZ2V0LmFkZFN0eWxlQ2xhc3MoInNlbGVjdGVkIik7 CiAgICAgICAgICAgICB0aGlzLl9zaG93Q2F0ZWdvcnkodGFyZ2V0LmNhdGVnb3J5KTsKICAgICAg ICAgfQorICAgICAgICB0aGlzLl91cGRhdGVPZmZzY3JlZW5Sb3dzKCk7CiAgICAgfSwKIAogICAg IF9zY2hlZHVsZVJlZnJlc2g6IGZ1bmN0aW9uKCkKQEAgLTEwNDAsMTUgKzEwNDMsMjYgQEAgV2Vi SW5zcGVjdG9yLk5ldHdvcmtQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciB2aXNpYmxl VG9wID0gdGhpcy5fZGF0YUdyaWQuc2Nyb2xsQ29udGFpbmVyLnNjcm9sbFRvcDsKICAgICAgICAg dmFyIHZpc2libGVCb3R0b20gPSB2aXNpYmxlVG9wICsgdGhpcy5fZGF0YUdyaWQuc2Nyb2xsQ29u dGFpbmVyLm9mZnNldEhlaWdodDsKIAotICAgICAgICB2YXIgcm93SGVpZ2h0ID0gcm93c1swXS5v ZmZzZXRIZWlnaHQ7CisgICAgICAgIHZhciByb3dIZWlnaHQgPSAwOwogCiAgICAgICAgIC8vIEZp bGxlciBpcyBhdCByZWNvcmRzQ291bnQgLSAxLgorICAgICAgICB2YXIgdW5maWx0ZXJlZFJvd0lu ZGV4ID0gMDsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByZWNvcmRzQ291bnQgLSAxOyAr K2kpIHsKICAgICAgICAgICAgIHZhciByb3cgPSByb3dzW2ldOwogICAgICAgICAgICAgLy8gRG9u J3QgdG91Y2ggc3VtbWF0eSAtIHF1aXQgaW5zdGVhZC4KLSAgICAgICAgICAgIGlmIChyb3cgPT09 IHRoaXMuX3N1bW1hcnlCYXJSb3dOb2RlKQorICAgICAgICAgICAgaWYgKHRoaXMuX3N1bW1hcnlC YXJSb3dOb2RlICYmIHJvdyA9PT0gdGhpcy5fc3VtbWFyeUJhclJvd05vZGUuZWxlbWVudCkKICAg ICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIHZhciByb3dJc1Zpc2libGUgPSBpICog cm93SGVpZ2h0IDwgdmlzaWJsZUJvdHRvbSAmJiAoaSArIDEpICogcm93SGVpZ2h0ID4gdmlzaWJs ZVRvcDsKKworICAgICAgICAgICAgdmFyIGRhdGFHcmlkTm9kZSA9IHRoaXMuX2RhdGFHcmlkLmRh dGFHcmlkTm9kZUZyb21Ob2RlKHJvdyk7CisgICAgICAgICAgICBpZiAoZGF0YUdyaWROb2RlLmlz RmlsdGVyZWRPdXQoKSkgeworICAgICAgICAgICAgICAgIHJvdy5yZW1vdmVTdHlsZUNsYXNzKCJv ZmZzY3JlZW4iKTsKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0KKwor ICAgICAgICAgICAgaWYgKCFyb3dIZWlnaHQpCisgICAgICAgICAgICAgICAgcm93SGVpZ2h0ID0g cm93Lm9mZnNldEhlaWdodDsKKworICAgICAgICAgICAgdmFyIHJvd0lzVmlzaWJsZSA9IHVuZmls dGVyZWRSb3dJbmRleCAqIHJvd0hlaWdodCA8IHZpc2libGVCb3R0b20gJiYgKHVuZmlsdGVyZWRS b3dJbmRleCArIDEpICogcm93SGVpZ2h0ID4gdmlzaWJsZVRvcDsKICAgICAgICAgICAgIGlmIChy b3dJc1Zpc2libGUgIT09IHJvdy5yb3dJc1Zpc2libGUpIHsKICAgICAgICAgICAgICAgICBpZiAo cm93SXNWaXNpYmxlKQogICAgICAgICAgICAgICAgICAgICByb3cucmVtb3ZlU3R5bGVDbGFzcygi b2Zmc2NyZWVuIik7CkBAIC0xMDU2LDYgKzEwNzAsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1Bh bmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgcm93LmFkZFN0eWxlQ2xhc3Mo Im9mZnNjcmVlbiIpOwogICAgICAgICAgICAgICAgIHJvdy5yb3dJc1Zpc2libGUgPSByb3dJc1Zp c2libGU7CiAgICAgICAgICAgICB9CisgICAgICAgICAgICB1bmZpbHRlcmVkUm93SW5kZXgrKzsK ICAgICAgICAgfQogICAgIH0KIH0KQEAgLTEzNjQsNiArMTM3OSwxMyBAQCBXZWJJbnNwZWN0b3Iu TmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX25hbWVDZWxs LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5zZWxlY3QuYmluZCh0aGlzKSwgZmFsc2Up OwogICAgIH0sCiAKKyAgICBpc0ZpbHRlcmVkT3V0OiBmdW5jdGlvbigpCisgICAgeworICAgICAg ICBpZiAoIXRoaXMuX3BhbmVsLl9oaWRkZW5DYXRlZ29yaWVzLmFsbCkKKyAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgcmV0dXJuIHRoaXMuX3Jlc291cmNlLmNhdGVnb3J5Lm5hbWUg aW4gdGhpcy5fcGFuZWwuX2hpZGRlbkNhdGVnb3JpZXM7CisgICAgfSwKKwogICAgIHNlbGVjdDog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5fcGFuZWwuX3Nob3dSZXNvdXJjZSh0aGlz Ll9yZXNvdXJjZSk7CkBAIC0xMzc0LDExICsxMzk2LDcgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtE YXRhR3JpZE5vZGUucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgaWYgKCF0aGlzLl9wYW5l bC5fdmlld2luZ1Jlc291cmNlTW9kZSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAg ICAgaWYgKCF0aGlzLl9wYW5lbC5faGlkZGVuQ2F0ZWdvcmllcy5hbGwpCi0gICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKLSAgICAgICAgaWYgKHRoaXMuX3BhbmVsLl9oaWRkZW5DYXRlZ29yaWVzW3Ro aXMuX3Jlc291cmNlLmNhdGVnb3J5Lm5hbWVdKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgcmV0dXJuICF0aGlzLmlzRmlsdGVyZWRPdXQo KTsKICAgICB9LAogCiAgICAgX2NyZWF0ZURpdkluVEQ6IGZ1bmN0aW9uKGNvbHVtbklkZW50aWZp ZXIpCkBAIC0xNjk1LDYgKzE3MTMsMTYgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtUb3RhbEdyaWRO b2RlID0gZnVuY3Rpb24oZWxlbWVudCkKIH0KIAogV2ViSW5zcGVjdG9yLk5ldHdvcmtUb3RhbEdy aWROb2RlLnByb3RvdHlwZSA9IHsKKyAgICBpc0ZpbHRlcmVkT3V0OiBmdW5jdGlvbigpCisgICAg eworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfSwKKworICAgIGdldCBzZWxlY3RhYmxlKCkK KyAgICB7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9LAorCiAgICAgY3JlYXRlQ2VsbHM6 IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHZhciB0ZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoInRkIik7Cg==